From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB549D15DB6 for ; Mon, 21 Oct 2024 16:04:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B6036B0083; Mon, 21 Oct 2024 12:04:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43E576B0088; Mon, 21 Oct 2024 12:04:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 306726B0089; Mon, 21 Oct 2024 12:04:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0ED756B0083 for ; Mon, 21 Oct 2024 12:04:26 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 50CA5AD07E for ; Mon, 21 Oct 2024 16:03:55 +0000 (UTC) X-FDA: 82698081270.23.C2CCB0B Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf18.hostedemail.com (Postfix) with ESMTP id 4B3521C0027 for ; Mon, 21 Oct 2024 16:04:17 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=qiOtmcFi; dmarc=none; spf=pass (imf18.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.171 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729526627; a=rsa-sha256; cv=none; b=AePcZ4YDFI2BhhYMzj6kF7oNurqO1cOT2I4rwzbthL2Z6+Oc2ynaqTDN8QyTVS3VXAUNr6 sSwJMmP758EDfcLpZpB93OwT5VCTx1unNiagzLCG7GVCMJ1Ei65xf84v8ieVNsXaclXuBI uG1zw9aIq+kydsJ9nLNFE/uBzTdsZJs= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=qiOtmcFi; dmarc=none; spf=pass (imf18.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.171 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729526627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l84e0UnSnb5/wXRcsEl1eXO6u1LE4VmYmgz6RFMIs3w=; b=XJxgiE8tCkig7YlCplnOBA4/idZPVFSLSCW95AzODc1upbBIy3FCSaO2umu7F5UPN+vZyF sZcOlQoICJBefaFSvbfrFO6dnK39JPFQYLJwHzcLPylRqupx/n01jr3nDC46S4yhNDvM+S Un0SLf3yDHvI30tWrwHpZZ11H3mPDZY= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-4609d8874b1so35542321cf.3 for ; Mon, 21 Oct 2024 09:04:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1729526663; x=1730131463; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=l84e0UnSnb5/wXRcsEl1eXO6u1LE4VmYmgz6RFMIs3w=; b=qiOtmcFi1x29X7O7p0+HGrZmRf5Z5g0vvC7+Je1vB64z1tkC88j3EVCYaDUQYJKIZ7 +RbZYYJHaKJtuSrDw6rpLtnrC1e4t4tpzbYkG8eqORgtDSZnWHORjVyCMktknplKZYND 09te2QKSfwbU4ADZ39ebA3kiJgbWMZqKVJdyt6iFWNS3gO4HDjScreAdMdCDk3v0a/pz V+UTC19uD/ooPXXCm/ocL3pkn11HyBbGdxZaxJQAXL9sM8JjMX9XKDWtfxu8aHamTyjL yQRZ12tTsiIkeIBAzEGU+nQAP2ItFHcXIyM76cPOXE/c9USqacAP6Bt2F0mqpszrO1Fy obZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729526663; x=1730131463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l84e0UnSnb5/wXRcsEl1eXO6u1LE4VmYmgz6RFMIs3w=; b=aGXr3BsDqgYzcat9lFmQttusan6XwDnSDXJwg0nUd0oNyVBPG0yTtN+dOTl5HE6bQp SrKMRAO6SNn7TAyqR3N2UtvCO7193EHeJ1XbH649LHMllnScWef8LkqBmxhlTeuQBw7p L1hcZadD+H1FTbHmpA8/LX23d3HN8DzsGgoh1waZvpAJ9nL4Ku4eXq1QQphMGImaFBp9 ZwtnaKcLsD8sI4fCiFSZe3yg2Mp9dHw8ibTmQukKSSMLEehOY5eFtKO5ftvb+xctggCd zM9AsGHK46MZriG/4gER7gA41awmA6Aocs5NbEQ/3vFas60y4bnjZTwtPJDCL4oSrj+D oR2w== X-Forwarded-Encrypted: i=1; AJvYcCUyoKsoY5vNzbUtCpUSUZSTDIfJykKvL6Kx6Kbjv6saIt8mCUo2UF5lAdKsd0g4RMSDECngbYpCsQ==@kvack.org X-Gm-Message-State: AOJu0Yxi2l/kw3ETS7w0uh9h6yic1+QBxjzB98nfIFNFZB2cJPDd7kAv BBmn84jj/Wk+byT/9zGlbrCroxiS1Dosqrp3Sap8q1Fy8xa1yXiEjvhrL5Lwnsc= X-Google-Smtp-Source: AGHT+IF6+iVm5LbiJbyoiX1o00pqae4N2gKWe1rpx48Z3dEJTuR25irME1treebcR3ivdgDlUf6STg== X-Received: by 2002:a05:622a:47ca:b0:458:4e4c:b692 with SMTP id d75a77b69052e-460aed8cb72mr174768891cf.36.1729526662589; Mon, 21 Oct 2024 09:04:22 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-460d3d71664sm19231821cf.71.2024.10.21.09.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 09:04:21 -0700 (PDT) Date: Mon, 21 Oct 2024 12:04:23 -0400 From: Gregory Price To: David Hildenbrand Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, dan.j.williams@intel.com, ira.weiny@intel.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, rppt@kernel.org, akpm@linux-foundation.org, alison.schofield@intel.com, Jonathan.Cameron@huawei.com, rrichter@amd.com, ytcoode@gmail.com, haibo1.xu@intel.com, dave.jiang@intel.com Subject: Re: [PATCH v2 2/3] x86: probe memblock size advisement value during mm init Message-ID: References: <20241016192445.3118-1-gourry@gourry.net> <20241016192445.3118-3-gourry@gourry.net> <7b877356-f5c5-4996-904b-6c3b71389255@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: 4e36jmwus9hqrnjpu8mszmr64ryg3644 X-Rspamd-Queue-Id: 4B3521C0027 X-Rspamd-Server: rspam02 X-HE-Tag: 1729526657-969863 X-HE-Meta: U2FsdGVkX19QaYOlNmNB0wiIWL0K/yUXto9xk0KYwDQy8BsSNXm/4b36/+tRco4B3zzlf71cCBxXqi6CJRNpEtLgLYLdPMaC/aXx87t5gXKasEXbPNQoOarkWNhEi83+DHWRr18f1y9Q7dngL7m6nhfnuNUakJQ6YHnRY/ZlMY7yrpA/fvd0aF+BNABPrCEZ/q0Z2mQm3xlNY2GsZrdnuGvhRHfL3kE3nH/Hb9SjHhkD21nEkxCoXxwPDcu5oi/cqObwXoQLoptYwKpF7BrN7NuCOtWb6fVbwFPw8s5gohrNkBTo5RW14VZ4QZrziCbBALMKMHzqN1DOzdW/2xwHP2nVXQld3AXdCrxErILQrBEq7+xUjBxKWUFZUQDGwcylWu/8BTrdoMmXGNzpSwLXvqprQj5gPhYR1RIoB0r2FISr8JjRZlDDeY/yc0skJezHeuFtf0eaPKYwsIpnrPRTaMqNRbWiLSbIoCmxzAN2SNm4L4mjL6zqU3uuI9XiSLRBW0wZ0/E8nG001IinbspZQUf5FETwPHQMCEy6b72JgEeqInc1NZwtm6JHioUC9AEny4r5wCsjNsfUV4RDsNgv75DycChL66zuiHA30EemdFqTZe7jzjPap3nXvqLQ02gdWqdlFr1qbXkg2SpWGRDhVVl6cIkMDTO2Mf03wGY23lHVH8DsOvMm4U827GTc1BYCagOsj0jvhTCZl5wDfGeQWEzXMuWshSIHqZgXG3RMxOv/RtB/rLOVZIf7qZPrd15x6A5ggA+2e+7jxrKqhxRQnzzo1IZdC5hN1C85evYqdEPuBRFUafK/JmglcR+Q1Aytx0A1vPN4OxW0P7Rodtz4ZGv1kAgGBZj1XQNhWZcCWQ0/OjOdjFf3blaClp9NgDyVYuaNHSeWcUyoGpxXMoCskD3trzS0INTrotTGqT8FSZIqYmz3xmTrCOSaX5buw41Ysf5zBg512jbQbs5u/Ok TdFV28Au II9fGmT5lhnDEyOuZoSCE/joa8i8dyDGe1wfqhMVtEImJ+oZQqvl/rCD17JqwlkWSiM1XAoyKOcbYXOb+tmx4AEGTMS7ADc5hyWEezXR1kp+tlALvLPaj4We8tbwtnKg+U4TVE/syZepR//swFhp8wWIvfTb6huZ1x6YgauOzDZ08FhZXYYdgqk89zCie5CdYXoekBGHfoJg66vwqUHinsTwAkifYoI+Smj/jjaD71GY2cyWIGJ5rdFs82XJo6SHoLUe1s0jZMvMYznoAFn8Pb6Nup6zws/2a8xCK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 21, 2024 at 10:46:38AM -0400, Gregory Price wrote: > On Mon, Oct 21, 2024 at 01:12:26PM +0200, David Hildenbrand wrote: > > > > > + /* Consider hotplug advisement value (if set) */ > > > + order = memblock_probe_size_order(); > > > > "size_order" is a very weird name. Just return a size? > > > > memory_block_advised_max_size() > > > > or sth like that? > > > > There isn't technically an overall "max block size", nor any alignment > requirements - so order was a nice way of enforcing 2-order alignment > while also having the ability to get a -1/-EBUSY/whatever out. > > I can change it if it's a big sticking point - but that's my reasoning. > maybe change to memory_block_advise_max_size memory_block_probe_max_size but still take in / return an order? ~Gregory