From: Gregory Price <gourry@gourry.net>
To: David Hildenbrand <david@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-mm@kvack.org,
dan.j.williams@intel.com, ira.weiny@intel.com,
dave.hansen@linux.intel.com, luto@kernel.org,
peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org,
rppt@kernel.org, akpm@linux-foundation.org,
alison.schofield@intel.com, Jonathan.Cameron@huawei.com,
rrichter@amd.com, ytcoode@gmail.com, haibo1.xu@intel.com,
dave.jiang@intel.com
Subject: Re: [PATCH v2 2/3] x86: probe memblock size advisement value during mm init
Date: Mon, 21 Oct 2024 12:04:23 -0400 [thread overview]
Message-ID: <ZxZ7h335O9hgB20l@PC2K9PVX.TheFacebook.com> (raw)
In-Reply-To: <ZxZpTlnhYPqg-tGh@PC2K9PVX.TheFacebook.com>
On Mon, Oct 21, 2024 at 10:46:38AM -0400, Gregory Price wrote:
> On Mon, Oct 21, 2024 at 01:12:26PM +0200, David Hildenbrand wrote:
> >
> > > + /* Consider hotplug advisement value (if set) */
> > > + order = memblock_probe_size_order();
> >
> > "size_order" is a very weird name. Just return a size?
> >
> > memory_block_advised_max_size()
> >
> > or sth like that?
> >
>
> There isn't technically an overall "max block size", nor any alignment
> requirements - so order was a nice way of enforcing 2-order alignment
> while also having the ability to get a -1/-EBUSY/whatever out.
>
> I can change it if it's a big sticking point - but that's my reasoning.
>
maybe change to
memory_block_advise_max_size
memory_block_probe_max_size
but still take in / return an order?
~Gregory
next prev parent reply other threads:[~2024-10-21 16:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 19:24 [PATCH v2 0/3] mm/memblock,x86,acpi: hotplug memory alignment advisement Gregory Price
2024-10-16 19:24 ` [PATCH v2 1/3] mm/memblock: implement memblock_advise_size_order and probe functions Gregory Price
2024-10-20 8:57 ` Mike Rapoport
2024-10-21 14:39 ` Gregory Price
2024-10-16 19:24 ` [PATCH v2 2/3] x86: probe memblock size advisement value during mm init Gregory Price
2024-10-21 11:12 ` David Hildenbrand
2024-10-21 14:46 ` Gregory Price
2024-10-21 15:57 ` David Hildenbrand
2024-10-21 16:17 ` Gregory Price
2024-10-21 16:04 ` Gregory Price [this message]
2024-10-16 19:24 ` [PATCH v2 3/3] acpi,srat: reduce memory block size if CFMWS has a smaller alignment Gregory Price
2024-10-21 9:51 ` [PATCH v2 0/3] mm/memblock,x86,acpi: hotplug memory alignment advisement David Hildenbrand
2024-10-21 14:51 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxZ7h335O9hgB20l@PC2K9PVX.TheFacebook.com \
--to=gourry@gourry.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=haibo1.xu@intel.com \
--cc=hpa@zytor.com \
--cc=ira.weiny@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=rrichter@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=ytcoode@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox