From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F155D15DB6 for ; Mon, 21 Oct 2024 15:57:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8C4E6B0082; Mon, 21 Oct 2024 11:57:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3BD56B0083; Mon, 21 Oct 2024 11:57:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A047D6B0085; Mon, 21 Oct 2024 11:57:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 829976B0082 for ; Mon, 21 Oct 2024 11:57:17 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 306981219BC for ; Mon, 21 Oct 2024 15:57:03 +0000 (UTC) X-FDA: 82698063042.08.5FD0E58 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf02.hostedemail.com (Postfix) with ESMTP id 97A2780006 for ; Mon, 21 Oct 2024 15:56:46 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=cpnGcrGK; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf02.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729526113; a=rsa-sha256; cv=none; b=Hdtk9uLxUzjMfKBaBGr9qZ/dlUMxhPHhKasz65P+KJAXuSEIL6Ja0R9r1CMFrdUBaBiC5O 7M81iUigUVWICcLYFzfoiXRAcohoiMit6rlmgL34lPIiZz067cZzodi+dKXbRH0dROa5Yo lI9GK3UCIH7fjr0Fzx0GKKLMfQc3Bos= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=cpnGcrGK; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf02.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729526113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dDw/eqUUNfsBtWyAEhbHkP16UO4fYbMtXP5eNWAHVM4=; b=mNToBB2f3HTTHiVisa8z4TJgNfVLdlKkq3gxo7mKdEw26zqrGKX0B0Mdd055y+Xk6IONiP wjIidVmL9CT0dNTesXEcj89IGhfUdGU6LmocgUwFil9WaK6vWLHfHseHcEfpVeaAsdquc9 Rm482j9XRiAi1bDX++IvH1rfA37s14A= Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5c957d8bce2so2159790a12.2 for ; Mon, 21 Oct 2024 08:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1729526233; x=1730131033; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=dDw/eqUUNfsBtWyAEhbHkP16UO4fYbMtXP5eNWAHVM4=; b=cpnGcrGKmgj7/ICtEHaajSpCqPQ63bFtiygVHUi7eGkudUSsIO7oG+kpME9vZwOwXa zgTg/R5xT8OgdQ4EureF0Ar2q5ZUlko8c/XZ8AwK3uvluD7oAn3wBIKlWjZNBUpePhIZ BybsbhZwp5YkdRELYgEcRLEsI8HukVsJjjrS6tJjX+chNlIjSqVaRXS3MXZrdQ4praGx Cs8KMjFt+PkDB3vM8sYXZLr64SUk0UwwPrMfJvib/UdYM+t6/F603S9ad+mEqyHFsqA6 nrLZZQAwpVehWCKTAFoo+WRbUoQEHy1acgXtU0T2/7l9XoFcgWJxcY2TUmDwdTVyA8zY Pa6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729526233; x=1730131033; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dDw/eqUUNfsBtWyAEhbHkP16UO4fYbMtXP5eNWAHVM4=; b=hHrqs40Yd2oQ+K/gBcEEjMcjX7FmiSD3+PnRMwl70tPE/ybYk0wWcj85wqmA4GcCqs AsBf6aFRjdAYkLwwzu7VDvIuy70/Lt/4m+h69PqePJzhEz6KazJ/YFHaVFevuNCpTh5Z T023sXSiuLiEsbyljiyLBOHSL7rrJQjWGflqK2fTETm+cv8/wKfZItI5JrGfg2PPjak7 OP+WJDBUG56Zd2ymA3+7qQgCkBlkMx0XWKIHzAci5ZoFGB1ndH0l7BExnjG1JwCfKqHN 4UIfqCMU6j54j1T41FlTGToFGs4dt4Zikg76vl98XPFE1/OcwHVj2hEbCXQ7lXChRgAi cAYg== X-Forwarded-Encrypted: i=1; AJvYcCVs8oC9Sg3nuZf2mEnN2m3T3SsUM9RUlhNTaQnOgLBaRrZBZq7N8zHklnlG2uWGhMaG9PupaX1oIQ==@kvack.org X-Gm-Message-State: AOJu0YyOQJwfYeTdB+EmhXeWBztacyFVZA+zy8I5BaYLyVyLzPsLKx/P aaVAEFTgTGhAa3E9aG1xfQ9020XxEaMi26rwR0L/9llg6KtmaqBgkMbefSE6TME= X-Google-Smtp-Source: AGHT+IH8rj3/sUlYj4idAmDktH+SYwN0X+O5bSIWGTSplCx3Kpe3omxzwpgCZW0mKkaRkknG0Ii7EA== X-Received: by 2002:a05:6402:42d6:b0:5c9:137b:b81b with SMTP id 4fb4d7f45d1cf-5ca0ae81126mr14584037a12.25.1729526233247; Mon, 21 Oct 2024 08:57:13 -0700 (PDT) Received: from localhost (109-81-89-238.rct.o2.cz. [109.81.89.238]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cb66a654cfsm2065438a12.29.2024.10.21.08.57.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 08:57:12 -0700 (PDT) Date: Mon, 21 Oct 2024 17:57:12 +0200 From: Michal Hocko To: Suren Baghdasaryan Cc: David Hildenbrand , John Hubbard , Yosry Ahmed , akpm@linux-foundation.org, kent.overstreet@linux.dev, corbet@lwn.net, arnd@arndb.de, mcgrof@kernel.org, rppt@kernel.org, paulmck@kernel.org, thuth@redhat.com, tglx@linutronix.de, bp@alien8.de, xiongwei.song@windriver.com, ardb@kernel.org, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, dennis@kernel.org, yuzhao@google.com, vvvvvv@google.com, rostedt@goodmis.org, iamjoonsoo.kim@lge.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags Message-ID: References: <62a7eb3f-fb27-43f4-8365-0fa0456c2f01@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 97A2780006 X-Stat-Signature: isr4d14d5dobx7buz4t5af7hciddof7i X-Rspam-User: X-HE-Tag: 1729526206-999248 X-HE-Meta: U2FsdGVkX18jCEx9TRr5PMQNfZxh73bEtOCMm1vgrX6x+ywGuZv7JZAoBbSxJk+Hffrzi1byUYuUSXySzuqK+I0kW4ERdru3L85G24QMmFCjU6pEwDmfTH78vcxOgNjOhSkirq550h1PKpqvodhQjhUXVKureAp/xY+UUy1pdpc5b8SEcpnPioPubUr2qbBolFtF4+jWWSq3KeY0Ww/tKLB5BULdVHIkW6PAceGXUntsqpyU37K7lTo5n9jKQF8YMji8RHTVCMmuGX8dTRQxpoSUrIHNEOvBliDJTr9ZYC2fVf//yJ8XSDIfW8U4nyqp0Kvh5x1nyKsE8j334ipL1UezckjigYFWi9JX0uZV3m4BI/XEo/closWMPMWvxvsBu+cD9UVThNVelG15ixmlBUa+liCcPtcENaZ0dgpedyTJSd5yUbMfIxsYjTjM2fji1x/h+9LxVqwIDLW0w0d1NEEl21hZDtysI1Y793nz4zUP3jaG2uN3/Ez5PkCAgwBI0wJUx/ZuUAZ3x5hiX7HGQGB2zXBU7V3woeb8NX7+sQSm1GIuDZDRvEwiEontGJN+2PL2qrOB9FvdxKIYKNpotm61CWBFP1MuZvaH0MpdAaHG3vG029CwXCbwpN2I+JHfn6V0SLMVDedkpi84bwLnY9ZhKSyyvLVqvQh4tyj1eGvqgiVJnGZBz45ezSz2BpPdmxena/ISaND53n2VDMTmh21dV5YfWA5ihm9GFlZCgJNc+6e1ro18UPv8SpXuF5LsUBb2eoH4SYHM55x+KJN/hCFnImTZOo3j2yW5M4Ria5HXoZTcXbBTNr66kxeGkOcCRKjMV9kFNs/cgMBojXrb4KtUrkMoxnYOLfWu68jzG7qj8xDAq2TwQNNfEjkxSA8FzbWFSkiHh8zCpTJNw8c7SV0vM0RMmWjBqepfF+hNih6DVPw6pEJJauTjKpJNObloiLJDOVvR78OLcsjyOJ1 Uy0SptY8 aCR03iqLvehTkOkfWNgink9bqB6t+Or0o+tkiTgDtm36gHD/DTQ1eGaxRFRx3VGX/VmvKfoHUS1VHACTbD3Lc6L1B60xyMzE5Q9Jf8m4N2N23nlvAhUAxgP6Pe7uPeGeUb1U53sHVMJx7Nt6DH6m+DMvqOIweucaJm3O+kojXFqOqv2DbwagYf6v22SBEhO3e60riueDRmqM5XXa40aL1Y3ytCgw6uPjr9nuw1mYJelsvQldK/HqezTAJOiLelQBFy/tekqEy2wTXFnDU1Bfz6ZfAi7ZKj7MOpg8Y34dgZnPbRbpxdFjhZJL9mhzdyVwB1resioUbWqdbXKOZA7g1CMoo1mU5ewj4SySNqi49KTS/exRBy6eT0+yfKX/vrvRl97C/xYlsGQVwj8RGZS4iDhrzG9dmszDypKSqH+VIivXsBCWRIRMRlNvscPscg34qpz6z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 21-10-24 08:41:00, Suren Baghdasaryan wrote: > On Mon, Oct 21, 2024 at 8:34 AM Michal Hocko wrote: > > > > On Mon 21-10-24 08:05:16, Suren Baghdasaryan wrote: > > [...] > > > Yeah, I thought about adding new values to "mem_profiling" but it's a > > > bit complicated. Today it's a tristate: > > > > > > mem_profiling=0|1|never > > > > > > 0/1 means we disable/enable memory profiling by default but the user > > > can enable it at runtime using a sysctl. This means that we enable > > > page_ext at boot even when it's set to 0. > > > "never" means we do not enable page_ext, memory profiling is disabled > > > and sysctl to enable it will not be exposed. Used when a distribution > > > has CONFIG_MEM_ALLOC_PROFILING=y but the user does not use it and does > > > not want to waste memory on enabling page_ext. > > > > > > I can add another option like "pgflags" but then it also needs to > > > specify whether we should enable or disable profiling by default > > > (similar to 0|1 for page_ext mode). IOW we will need to encode also > > > the default state we want. Something like this: > > > > > > mem_profiling=0|1|never|pgflags_on|pgflags_off > > > > > > Would this be acceptable? > > > > Isn't this overcomplicating it? Why cannot you simply go with > > mem_profiling={0|never|1}[,$YOUR_OPTIONS] > > > > While $YOUR_OPTIONS could be compress,fallback,ponies and it would apply > > or just be ignored if that is not applicable. > > Oh, you mean having 2 parts in the parameter with supported options being: > > mem_profiling=never > mem_profiling=0 > mem_profiling=1 > mem_profiling=0,pgflags > mem_profiling=1,pgflags > > Did I understand correctly? If so then yes, this should work. yes. I would just not call it pgflags because that just doesn't really tell what the option is to anybody but kernel developers. You could also have an option to override the default (disable profiling) failure strategy. -- Michal Hocko SUSE Labs