From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BCABD15DB1 for ; Mon, 21 Oct 2024 15:34:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B03176B0089; Mon, 21 Oct 2024 11:34:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB3876B008A; Mon, 21 Oct 2024 11:34:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97B906B008C; Mon, 21 Oct 2024 11:34:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 74B5B6B0089 for ; Mon, 21 Oct 2024 11:34:36 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4AEEBACF5D for ; Mon, 21 Oct 2024 15:34:05 +0000 (UTC) X-FDA: 82698006342.02.261CB0E Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf08.hostedemail.com (Postfix) with ESMTP id 99C64160005 for ; Mon, 21 Oct 2024 15:34:23 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=BbUf5Rzm; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729524763; a=rsa-sha256; cv=none; b=N2CRBFFsvYBQV+S1TEh2IGc1SAd7JPtPbEXEbG7vkNgnN8/pp2ZzydG15bZObK8R8OA81t VS9yrnphyO7EuFq/Feg+lJ6BfLhu6doWWj61sGJQf3+jYka82b68X5nKFqCxXZOOVvJn7H IpHCenit/K5ymk8Xw8aGWbNwsWc8SUg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=BbUf5Rzm; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729524763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kpi3GmQz/NfclizXKPSgfHHhy5JjbE963jj4j4rTyiU=; b=akcyzTL2bh+TDhglDHQKXj2W3nKIrvUIbxaElXjTFoPcHlnhtQpKgssJYTZ48HfZ0C2mA3 7kUkOUYnbVjr2D0ecFzMVltQ85qOOmcnsOQfGneAHzjeJqLGql/GUW2td3cAWcHK4/LTjs qLKipc2Wat+e+Geav/bGY3vJELesRcU= Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-539fb49c64aso6433648e87.0 for ; Mon, 21 Oct 2024 08:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1729524872; x=1730129672; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Kpi3GmQz/NfclizXKPSgfHHhy5JjbE963jj4j4rTyiU=; b=BbUf5RzmC7unZ8MvbDdgXqumA4mHyvDzdGFZ8gPNBUix+jx9Y1aIl7/dyu0SkqbxSN im1wBM3AlJcdVgK2EVwjx6cGZUlxhJpn2kbw+oApoRcYGohOYoEgk9NuBJYPNR1c9ubd 47ILX8ENrdVuR7eZuKtHtR87PuUbPjICd8x9P2e+A3FjWbIftuEECOTIC9+CLeVI42bk syM8naFOSDuqIDzu4V+788vTlI+pX1gYyfYycMOyt0MH5MY+BXuC+g2KA2gmn2M5I6us Tf8GEVRUv4dY5jK0BxYsDq2F15znpoXsUG/1/qSMuLjad7i2MVLkgQ/Y4iU+CXGKdH3K eacg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729524872; x=1730129672; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Kpi3GmQz/NfclizXKPSgfHHhy5JjbE963jj4j4rTyiU=; b=qD53sP0CPzC5vsarjrXp9cWA7DWHxzLdkkhxh95/mTLqQQaSY6cPxFejhZAJY1UVpe T5dNTSCyrqGroJYCXZVuzGf7CUIFtAmPj9BzxmB3vTxjYFRehdvW2hTxcJwGDRjmEB9L Bhal3Oq0UHjSQLMGVyFlN5pH6xMQoXjqkZZqNlDAX52l3wqCo7jg0DAsDlmNR1igj8km pNtUPZGXB1plK5U3HAiNmehY/dZy6yPCYpyKuLkCY2RSQb7pO1XS5bCENsROw6AeYXMr j05BQw9UNeOUMdKYkXk6a5/FSK5/RVotxj5n5n4VxRdo+vdPL1tzE8Mu2IMkdGROEvgH rTlA== X-Forwarded-Encrypted: i=1; AJvYcCXGZVZeoRkNfWAlsrEQH92XI7eDy9PGQsXkgNRoVPdzeOL6nURZSAb4Zddxvd/0wrRU8gwCDejyYA==@kvack.org X-Gm-Message-State: AOJu0YxMFg1FtsclDDIwzv4ZEj2M9LCfE98/FzHV8+0l9BdKQ7wRFC8H +Arin7puNMTWtfNKg/tBJPfJsaXWTYtwUAP3DDd1c9nb6wGbIWab9u3dLKdI5T8= X-Google-Smtp-Source: AGHT+IGzzU1TQCW20G0COaHzT8p401xKbkZuwocfdc2Wv/QwRAiKkBR0510ioS+3h4L6HROkPO+JAg== X-Received: by 2002:a05:6512:1244:b0:536:a7a4:c3d4 with SMTP id 2adb3069b0e04-53a154c9f17mr10043316e87.39.1729524859798; Mon, 21 Oct 2024 08:34:19 -0700 (PDT) Received: from localhost (109-81-89-238.rct.o2.cz. [109.81.89.238]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a91370631sm215121766b.104.2024.10.21.08.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 08:34:19 -0700 (PDT) Date: Mon, 21 Oct 2024 17:34:18 +0200 From: Michal Hocko To: Suren Baghdasaryan Cc: David Hildenbrand , John Hubbard , Yosry Ahmed , akpm@linux-foundation.org, kent.overstreet@linux.dev, corbet@lwn.net, arnd@arndb.de, mcgrof@kernel.org, rppt@kernel.org, paulmck@kernel.org, thuth@redhat.com, tglx@linutronix.de, bp@alien8.de, xiongwei.song@windriver.com, ardb@kernel.org, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, dennis@kernel.org, yuzhao@google.com, vvvvvv@google.com, rostedt@goodmis.org, iamjoonsoo.kim@lge.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags Message-ID: References: <9c81a8bb-18e5-4851-9925-769bf8535e46@redhat.com> <62a7eb3f-fb27-43f4-8365-0fa0456c2f01@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 99C64160005 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 3mbub4ngp7p5mszeoumhcdx1ggsrfmph X-HE-Tag: 1729524863-882534 X-HE-Meta: U2FsdGVkX1/scveR8XQO8lBb75AwDrnSf7P2r60NtsQ3qsKBKW5TYppfVjmQMI4EEWK6paOnscHT+WzPTFO9mWVGsYqfRJWEOuck4PW+rOv8/7c7zlvgACzokym1quYOfCYqMrxvKvOAcWcf12UjE3bNU/LUvDTBs4EXhAOzYDF+dvzC202PxAtAOuvPRU2dxa625a8OU8FHj+rcAOaQYylOMGy8xwVQsqWNDlrnQjTRbOFEQtf8MSrWJGuxsGm2a4IYRzbS9yiP80p9WsjffNBcnf+kxlcVtJCMVvVOWk/4nfvV7ZEGgXGU3YWsjGtwuPL/lH/uiBEWzEX6LqmeI9vABJ7SGvluoL2MXhKMsT0uTNS5XH+/HH2iqwdhUyhRAQ/7hYD04T7dhjl8iWU0ZOupqeiyto+PuvNUFZdPAZtNu3yYfrSW16JX+CH8doKW0Fd2nAHarkFwEzAlDmrIYabSIdhitT310LWYciUsjsTUD6YQPwXUwQg8EowaUba6JJZTxroHUTjIFhy4VqPVZQ5evrmXQQCgnMb0aYTLjL3B4tcd9R2QXdaWtts3trkxn241PSFRpgZlaoB+6s7UN4KS1jmVZ42CXjDus49zheriqQAvG3YHag76cWfFew9k+iAdCSD8UhJAD2Lk5qAFmdVm1PVxR30EMGklBoLma2JkYNJiQ5pTwWEkPF9Tpa6Yww3Ue2YShLrV1JW00aeCgPDG0EkWZCR/oxTPaEDJ94fl4leEcOyOMIhANR9fBINprGxRWWKcFk6QBjaGCy/ky0qescrRi/wpSHSn86sm0zj0aMsbcxlPpimUM4RCpjZF6oRqRMd4F488+4VtHHyweN4UumGSCDg3EfLLpoXsMSJ5VaCtux6E2JasjxGw5ZOVp1IvRfNmstt1/nI7+tDnk1jbqldrnuRfZ5N3R05HNScSXqm8isrUCjcSNO9OrA2k92ELcXHsus4Ah4VvsJr poNTq83N TYEIKNv7u/LT6u41epzZJcZjdtO1J/lI9GT5ovVcbuwGle3cehmE+qLZQ37kWNrO5DUVjHEP1iUOEbPqQJIcjRMF8VsgOt0S2ZJ6YgM13a7Az8Ubmrmygqi1GxertJ9YtmBDAMQvgXBrSB2eRiegY3wD7TdkbXV5h9QDfM3phMjmVvWXWtXQe1tQoARFLArBVNE/uUapHo8Jwhqvr+ip3dN8aTxvcU03Mlie6eDMxvMSWq0fAg3pm+gVpndzlxYax7naMPu9V8k+8oo4qu4T6UuKG24+61+AoH50AO5yzxgT3KL5lqSgAOXBAw/OIwxaJjD5XoaxkoJFc+iyl2lvR96R21IU9ldO+6m4Mr4nAJIWg7C0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000059, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 21-10-24 08:05:16, Suren Baghdasaryan wrote: [...] > Yeah, I thought about adding new values to "mem_profiling" but it's a > bit complicated. Today it's a tristate: > > mem_profiling=0|1|never > > 0/1 means we disable/enable memory profiling by default but the user > can enable it at runtime using a sysctl. This means that we enable > page_ext at boot even when it's set to 0. > "never" means we do not enable page_ext, memory profiling is disabled > and sysctl to enable it will not be exposed. Used when a distribution > has CONFIG_MEM_ALLOC_PROFILING=y but the user does not use it and does > not want to waste memory on enabling page_ext. > > I can add another option like "pgflags" but then it also needs to > specify whether we should enable or disable profiling by default > (similar to 0|1 for page_ext mode). IOW we will need to encode also > the default state we want. Something like this: > > mem_profiling=0|1|never|pgflags_on|pgflags_off > > Would this be acceptable? Isn't this overcomplicating it? Why cannot you simply go with mem_profiling={0|never|1}[,$YOUR_OPTIONS] While $YOUR_OPTIONS could be compress,fallback,ponies and it would apply or just be ignored if that is not applicable. -- Michal Hocko SUSE Labs