From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB964D15DB7 for ; Mon, 21 Oct 2024 16:17:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AEF56B0089; Mon, 21 Oct 2024 12:17:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35F4B6B008A; Mon, 21 Oct 2024 12:17:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24E036B008C; Mon, 21 Oct 2024 12:17:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 082126B0089 for ; Mon, 21 Oct 2024 12:17:10 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AA8A412197F for ; Mon, 21 Oct 2024 16:16:55 +0000 (UTC) X-FDA: 82698113064.07.4BE82DC Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf10.hostedemail.com (Postfix) with ESMTP id 2434BC001A for ; Mon, 21 Oct 2024 16:17:00 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=GlkgMNNj; dmarc=none; spf=pass (imf10.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.171 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729527377; a=rsa-sha256; cv=none; b=Rp0B85y+JsKTIaTlA7U3K9Qp0X7WvdVihfI1n/GrCC+HxixuvyPgcSPwuspmF7a6s0Yd32 Lac9VeMf2txGzUimZy6g0qR0+rFmykPKhqzE95y0TMe6r2gf6AhHJBMLm/e31QywwjxM5M R0oIDTytmdAijYm1mO9B208rYIxkzMk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=GlkgMNNj; dmarc=none; spf=pass (imf10.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.171 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729527377; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gEfONzhDqFGNtDvGcVV2OjNwgNeswu1gnCdcntMBt+E=; b=NkQqfq3POuRNY+Hj1QZRSyCkHCcNrXmfqaZyqDjw0asc+/k66GI4s1mCauX0YsKwVJMq6/ zd1PxMgR3rXEGEn4HoB4nvEfucSOTwGTuNGELceL9mT1b1pORtQ8ZdGgzCkot3QnjyCQ53 gLmlUZpR1DhLIlSIv23chVUEZ4QBUJM= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-4609c96b2e5so27570241cf.0 for ; Mon, 21 Oct 2024 09:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1729527427; x=1730132227; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gEfONzhDqFGNtDvGcVV2OjNwgNeswu1gnCdcntMBt+E=; b=GlkgMNNjHqipoVsTGq58HQVGj0MIYzec/Piz6OM4ZXqyrDG/7kE4VZKP8urPdiotPF 0vL3ExgiOciH9Idobz/TlxAudUbVnXcvp/8I8XHUGTAxGEcsrH5lElOpW2nJuCrukAIR 6Dtvh2mvXGPIHwKYVVSeFCblfCufHsApyATCCu9e8zrDeSZQqBjnkilwuSCvEngj6Izm k4jMaJmNCfEHzz1VxfJaC2iJlivR6yKinHKYX22fXLjbj4YA/NI4oj1w6IeQ2cUDZNfR F1o6FVI036FNgUatDqvRMSEscYoqjH10U+wht3ZQ3wzHJ0uLPh02v3tWO1atUA+cRTLR /aEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729527427; x=1730132227; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gEfONzhDqFGNtDvGcVV2OjNwgNeswu1gnCdcntMBt+E=; b=QZ8aQUiz4hKdtSbwjnVUUTn0ydkAEpHCvEiaRGjUZCkyjEyBKPuvc8ecf55DmpZQ8x 5h2m19kOwWp2IPdvsNS8aY8mfzQ/pLkHYq0lMP7RmeppXZ5+Dka2/J40TqdBjGw7dreT 5oq6+pxVA0NRFcEaYObmzAEhzLznl2QExFLNXFTGvxnv6lCGUlrpm4n8N/nhtolkLChV guTu1Qm3isI7i729FsZVee8Kj90wPqbslyH+eE3wnD0DfuL6YDeJ37tBB2DDtuGkaT/r hyqRfjyLi4abLm+DuWo2Uw96pbYDge/ZMoqVtz30ZiXwRLzApgHTLAvJsm3PNSmwBmGB x2iA== X-Forwarded-Encrypted: i=1; AJvYcCWhtWewQFjkxNRwOzGVUvxc225vxeUAOY+CUPqwCQ86mMzhXn9jVo0AJxmv28OkepPQGhGVqcpKlw==@kvack.org X-Gm-Message-State: AOJu0Yz6AHzu9vI6ba3ee3mhBzI/RI1WlD4udmpLU8S5A0ehd+I2widm gfz+7IoLtPRZlyTTfquJzx69QOxUNqXO/q9VmOWdiUX3kTgK5hhvimN+T5+IURE= X-Google-Smtp-Source: AGHT+IFlwa+hY7tlLp1VVOtE4ZB+LHnzpcwpYzAHWBfO5e5xtdUCSHXs+mU0bRAc7fVRuYNN4H/eYw== X-Received: by 2002:a05:622a:1992:b0:45f:8ee:1859 with SMTP id d75a77b69052e-460aeba0e48mr203414481cf.0.1729527426826; Mon, 21 Oct 2024 09:17:06 -0700 (PDT) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-460d3cbb3c3sm19515151cf.52.2024.10.21.09.17.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 09:17:06 -0700 (PDT) Date: Mon, 21 Oct 2024 12:17:08 -0400 From: Gregory Price To: David Hildenbrand Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, dan.j.williams@intel.com, ira.weiny@intel.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, rppt@kernel.org, akpm@linux-foundation.org, alison.schofield@intel.com, Jonathan.Cameron@huawei.com, rrichter@amd.com, ytcoode@gmail.com, haibo1.xu@intel.com, dave.jiang@intel.com Subject: Re: [PATCH v2 2/3] x86: probe memblock size advisement value during mm init Message-ID: References: <20241016192445.3118-1-gourry@gourry.net> <20241016192445.3118-3-gourry@gourry.net> <7b877356-f5c5-4996-904b-6c3b71389255@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 2434BC001A X-Rspamd-Server: rspam01 X-Stat-Signature: ndoy93am3ru5wrgmfnyqh4ktrjx4fwf4 X-HE-Tag: 1729527420-80503 X-HE-Meta: U2FsdGVkX18tdJHiAQMFwIIG1g/DQOesOyqi6uqhpz1seArMi+CBD/10L70rr3W03drZ5ldKPZNICAvibU5zQ88j62oE4hsSmZgYMDcsKe4CsWBGmnpccz4uMTTnyuRIYEp5Z9xffiNsA32THK5p/BMliFrPLcNZvJDkp6RcEG3Wqa9/LMgScrbwQL8BPqaektk3epqico+dtnUALPgZQ1SCqDTH5B0aYWXmgxcAKuTeHDfAsMWwDJKKja8HU8f/Hjjkz4L3ANdzO9k76BQJNFiHIikud/D8YpkCynqmaelu5FgWnyOkMh4JB1sedGzA2TSJ27WRDChDEoo61md5HeHonO5eo6fyCN1EM/gx77se388T6Rhz1R+tX4y6VBodiVqTJsqSzzUSx5lJFG7l4sVhyOC7doiyocU5SIEjv2cefbdMu6F3fMpdU0LshJY1G43uaaDsMEN6t8JHYqLV09BSsCgc++1+XD3AqphG5ofv1ZJwGEtIcls1Ji/Ui/C2Hk9OnBs4eZkpJROHhPYNA2hVlK28A37A5uFhn1vk7POqPFfx3n6zQv9PGhXvnb+hlWwpwVZf3zzQUauQ0NhMLQFvQ6datuE4OnqwUCI7kVJi1dTf6YSqOId+ELaBw73B9aMdg6tmYe5FAMIcarRID9ZfVWtUls8G/ixmCL1sv4Sx2vaC6P1iE2DPhZNP4zVf46kV7yKbuJk0lupj0Tcd0b+FSFqmbyWe+/72IqdhdjirWPHzdmeuTDw2vmOLvatpEHeZ9zNnKKiUVXqwHeGEjzub6fh7yecRkwXz4NfuEGdnrs+j4DbzIHdtQvkYhABWDttQda3F6ll21xyHd5EJwpRMu7GtujjQaKvnBkOst4o3XAhmnR29yH3IFH90HUFStMtpJGur6vlH0MDmvryExYItf2S990H2R30n7n6DLjTPUI94w45uIDPMQxvvw4MG2Joj55WkHwG4y+dBISg 7VZ6xcEQ tF3oWU/FsZLv4EfR2K/qfnzJfIxJl986MLx7FAM1CbTXizZjmZ4fZ5QNKW66GIvWNtDJdCUt8xY1F5UdKJ6YB4wYSCtXccTj/NSIC/8mlzmmTS7iBDggEbFE1EQsI/a/9Xi/M2Zwq6Y2j+OmkpWsFy4Tm9VMMGA8+PPkJCRdvI/vO6pjBrjiq+89aiOarAY9t78suXFHdBTClKKHZEZiddApbRmTVRTkxGpdPS7W8gDS+JDLE3dn6WtMcDWbFnlUxuoQexTiVjUuG/OdfNIbyBasnqNK7adUiHsAL3bOhE7kILDhknlq7knkJecSHpDZeZMiVY9LbxJcJ23lQE+RIwrcla2m6Dp6yz53Gc2rntRcCITXDoQZeeE/IIA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 21, 2024 at 05:57:28PM +0200, David Hildenbrand wrote: > On 21.10.24 16:46, Gregory Price wrote: > > On Mon, Oct 21, 2024 at 01:12:26PM +0200, David Hildenbrand wrote: > > > > > > > > > Am 16.10.24 um 21:24 schrieb Gregory Price: > > > > Systems with hotplug may provide an advisement value on what the > > > > memblock size should be. Probe this value when the rest of the > > > > configuration values are considered. > > > > > > > > The new heuristic is as follows > > > > > > > > 1) set_memory_block_size_order value if already set (cmdline param) > > > > 2) minimum block size if memory is less than large block limit > > > > 3) [new] hotplug advise: lesser of advise value or memory alignment > > > > 4) Max block size if system is bare-metal > > > > 5) Largest size that aligns to end of memory. > > > > > > > > Suggested-by: David Hildenbrand > > > > Signed-off-by: Gregory Price > > > > --- > > > > arch/x86/mm/init_64.c | 16 ++++++++++++++++ > > > > 1 file changed, 16 insertions(+) > > > > > > > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > > > > index ff253648706f..b72923b12d99 100644 > > > > --- a/arch/x86/mm/init_64.c > > > > +++ b/arch/x86/mm/init_64.c > > > > @@ -1439,6 +1439,7 @@ static unsigned long probe_memory_block_size(void) > > > > { > > > > unsigned long boot_mem_end = max_pfn << PAGE_SHIFT; > > > > unsigned long bz; > > > > + int order; > > > > /* If memory block size has been set, then use it */ > > > > bz = set_memory_block_size; > > > > @@ -1451,6 +1452,21 @@ static unsigned long probe_memory_block_size(void) > > > > goto done; > > > > } > > > > + /* Consider hotplug advisement value (if set) */ > > > > + order = memblock_probe_size_order(); > > > > > > "size_order" is a very weird name. Just return a size? > > > > > > memory_block_advised_max_size() > > > > > > or sth like that? > > > > > > > There isn't technically an overall "max block size", nor any alignment > > requirements - so order was a nice way of enforcing 2-order alignment > > while also having the ability to get a -1/-EBUSY/whatever out. > > I see. But we (MM) just call it "order" then, like pageblock_order, > max_order, compound_order ... but here we use "size everywhere" so I prefer > to just sticking to that. > > > > > I can change it if it's a big sticking point - but that's my reasoning. > > Simply enforce it when setting the size. We call it "memory_block_size" > everywhere and it's also a power-of-2 etc and sanity-check that in > memory_dev_init(). > > Disregard my other email. Didn't see this one come through. I'll switch to a size and check alignment. Probably i need to play with the locking mechanism to avoid changing after it's probe the first time, but i'll poke at it. So probably i change to an ssize_t for the arg and return value. ~Gregory