From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4503D0E6C7 for ; Mon, 21 Oct 2024 08:13:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F5076B0093; Mon, 21 Oct 2024 04:13:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 47DDA6B0095; Mon, 21 Oct 2024 04:13:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31E176B0096; Mon, 21 Oct 2024 04:13:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1038D6B0093 for ; Mon, 21 Oct 2024 04:13:41 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B4CE11C4E4A for ; Mon, 21 Oct 2024 08:13:23 +0000 (UTC) X-FDA: 82696894854.27.D1B6824 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf11.hostedemail.com (Postfix) with ESMTP id 83C394000E for ; Mon, 21 Oct 2024 08:13:21 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=JzGrf0xl; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729498369; a=rsa-sha256; cv=none; b=cap6q7IcCTkIEDBa0xem31c+kO+mpHUPVh71JMnIBYvmRsN1jAAkblDMFTBRjobLZ1WNXs eaJkkhKTsa94760/0V2CWpgcmoL2Pge7JxvdqyJrCwtkRLuaycPFzXtcf1sp5f/+JjiFx8 we+iFfBm0VeqeZ9SaluXOgEccmZgJcE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=JzGrf0xl; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf11.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729498369; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yZWxmndYcOZZ85jYs10Ky2hzEF5qsbgDei3uuETVLRo=; b=7B0f4SsL1ObmSavcD6GZlDalCdJbMOqEzfkg7hw3DqdIUaGGD/SvTe8djpalfDmBPh3byb +BvYRYmu2g0zJI24iXiR7XSPLp45Rlv7uAatwLTPwo7ugTzGldTqg4EqmlFAGDNuBbwonj +d/28spMEcpIhT0KSQq+6KTLUHJimLk= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5c9428152c0so5630014a12.1 for ; Mon, 21 Oct 2024 01:13:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1729498417; x=1730103217; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yZWxmndYcOZZ85jYs10Ky2hzEF5qsbgDei3uuETVLRo=; b=JzGrf0xlv+uBFnrUAVAnlBOIwwwVZ9AXUSOxP6cgb4I7h5nGVxfboWursy3YeevQyY OZ9Su+0OUqlbzJbtBZzGJksFBjChFq3Yuf4E8Qmy0nwWBZryR2oFK922OAHqmD/QUxsX Azm+jwwb3x6BoXLNHj2UY3Y0ie7Lklh7g/iBbsi8WreCRr5BsVwqCaUTT8oH5Urg9nMi YOhA2Eao2N/V2qhyOhqskLgdYZE3eHlCRKX75Rr32xvm0vKD/HXLOi5SGc9MsV+8C0SJ N0vWV6AG2Wgdm3gPod1Bf7B1qeDYjLewPuLV/CEefJLzusKVlJBMZ3KZHZtaJpic3396 zBcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729498417; x=1730103217; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yZWxmndYcOZZ85jYs10Ky2hzEF5qsbgDei3uuETVLRo=; b=ZFSkwpFYyUUnwpZXjEgvy1f5MnwQPloJkjIBl/kvxLyOGfu8YWIoBy7RVviESif+Bx f/DXN3zPMUZj8i5sjhBizwDhRfYLPPe3eIniU/SFuraa95q/PuX5thByC2l3njAFP2lw 8hKwEaw8ixmDUxKtm0yxylS6SiwYznaGk3K6jgCbVTIgOB9LoVhTeRbNawTqqfO0DGKv 0vkuxOD4Kb+ym9589a1uSA81/ObkRYCPxvlV0SaqrrS3USLO2w+BWKr0zmT45o2GPaPi 61q2izh0VRhAXiaMghkrpafw69P361a4HRuucf+dft9F3ZZG4s0OVkeM7hMhEYjzPynP z0Xg== X-Forwarded-Encrypted: i=1; AJvYcCUrA22g99TT8Zxp9M+3ZwYYo+K6JNa//+HOMhbE3gts5w/WLN1nFolRS2EP699MeeRAQTkGWpIC9A==@kvack.org X-Gm-Message-State: AOJu0Yx9STv7/fUvL4qr1BYQaX2Jt/LVm3sVd1RyL4LluCSKYFgSDggF u0LlhCLKGtLlmi3jQ/+peq4kBID4ce/C9TS6lRCvPyUpYeHSL2EYrBETPIvjb7k= X-Google-Smtp-Source: AGHT+IH6OUZvSau7zYJilrQ3BnOA5Jyne3edpM2fJujY3GAy9NDR+atmzAursD7ReEtWUYn2DtdlHg== X-Received: by 2002:a17:907:1c24:b0:a9a:6d7:9c4 with SMTP id a640c23a62f3a-a9a69a63af8mr1163073366b.12.1729498414640; Mon, 21 Oct 2024 01:13:34 -0700 (PDT) Received: from localhost (109-81-89-238.rct.o2.cz. [109.81.89.238]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a91370631sm173355166b.104.2024.10.21.01.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2024 01:13:34 -0700 (PDT) Date: Mon, 21 Oct 2024 10:13:33 +0200 From: Michal Hocko To: Yu Zhao Cc: Andrew Morton , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Link Lin Subject: Re: [PATCH mm-unstable v1] mm/page_alloc: try not to overestimate free highatomic Message-ID: References: <20241020051315.356103-1-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241020051315.356103-1-yuzhao@google.com> X-Rspam-User: X-Rspamd-Queue-Id: 83C394000E X-Rspamd-Server: rspam01 X-Stat-Signature: 4ka4ogp4muct78i157sqb1dupmwyztur X-HE-Tag: 1729498401-559841 X-HE-Meta: U2FsdGVkX18cHCOom3+sb01tfw/wbu+oZCRlAPUNA1kdPTURh620mKdK5xj419ZVpxO0DmZw0tUkTgj2krl7DpvtSPD/P8oqoUfctd5Nxb82GC1Q5yQdkQpfMwADp2Dh6V+wcwd9XP+hqHXiR9s7SuJSxyn3nlWJ37lsHbyuUV4y7lAjPQMbRX8eBVxkJL5SbFwByUC/C13nKt6EXQyP4bQeBq5XzMMZFkU1Se0/1vOQz4apPciyfDtOgTK+S5hKSHJvNgxlrJCvXd9lTQNMuO0cNhyLLWkNape1EWSIpU7KvUd0SHytfq78yTRTcJsoWJd7+iK+wIcFypSA5HcbSobgUA1Ohls5WItrAZfz4h+rDIy6GyROdn0vL7/9fE2hVvkz4lGDkKydOFZLsDxLDv7vuvnv/ALNYHASdLOgrRdURlP1hJd3PnAzFx7EyXGSdIVUSEhZ8tdYpX/hMXDLj562EMuYBDNWqhGjXAQUdh1R8afXa7nvE/fRdRRF8lYC13Gd9N7dweY44js2dyfrHir6vdv1zHq4uEWL+n4PSVLF6vLdq+zzpCpsqeXYQMDOtA0aMJQKj8z98H3HET7H8VW0x5Rzz+a+4lT9UxLXLy+lXC2J2A+xYdJH5zqmMxkSG081Fey/w4iOkwPNB3psOB+3XJZg/qB9wfmSahF0Ne+Wc0ANPAEQ07AbklP+rOyhVy0ohbxsoTp7Pl8Gmfv2gGXpNuqArU3pHz0DS2WKNzLYLkKKmSlZ6uGT1jl4Z1i63v2iS3921pfehprmNTxqPkAkhkMsQth0+RGYUoLUcZF5iowuSK34s8xcuCOEc2Gmmjn2RIsJC2Zpqa0Ri2QoqO0pTJLQU0lTpvJOtPRfQwmL3z2fnlRmEyTrIZ3x9hBM3qK2maWghD0H/CgyeugNgbkhZNSddl5OMh4ehdyD+Br+ekn1ZcRnxPQDCIb7YHNhcR21O+UtqOgm4C/DER/ fkWVf637 sUjiNbuHADOm3Z0wvRcQiWnLxlfde0JnDKWJ+yX6ClKLkwLGft7gNn+6ZJcAQdce91ylZ9C2nZXjOq2+X7EidH7161WGZxWpNFEqOpa3P+poUQXVyyKOQ3IEyNDXINjxqFmGQgoZOByFiMKiItm8RQcC2/KPJi0Dq1TILWBiU9P6lLLjDzfU1Yxxq49r145uqluez3LZd+xHEalf/IJRIG7KDEaUU1bRpEHFZ2A6Cxeq8n83GNEAMMHZYo8n0196qdHZbHQUCIoAVLTd+8K7KQ45dEhliI+A/347waEdtVO2WMeFQUBeMB2SaJCTht44VLvJBRcQg5Q/WRyxLJf05J7A7RSW8p/NlXUc5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat 19-10-24 23:13:15, Yu Zhao wrote: > OOM kills due to vastly overestimated free highatomic reserves were > observed: > > ... invoked oom-killer: gfp_mask=0x100cca(GFP_HIGHUSER_MOVABLE), order=0 ... > Node 0 Normal free:1482936kB boost:0kB min:410416kB low:739404kB high:1068392kB reserved_highatomic:1073152KB ... > Node 0 Normal: 1292*4kB (ME) 1920*8kB (E) 383*16kB (UE) 220*32kB (ME) 340*64kB (E) 2155*128kB (UE) 3243*256kB (UE) 615*512kB (U) 1*1024kB (M) 0*2048kB 0*4096kB = 1477408kB > > The second line above shows that the OOM kill was due to the following > condition: > > free (1482936kB) - reserved_highatomic (1073152kB) = 409784KB < min (410416kB) > > And the third line shows there were no free pages in any > MIGRATE_HIGHATOMIC pageblocks, which otherwise would show up as type > 'H'. Therefore __zone_watermark_unusable_free() overestimated free > highatomic reserves. IOW, it underestimated the usable free memory by > over 1GB, which resulted in the unnecessary OOM kill. Why doesn't unreserve_highatomic_pageblock deal with this situation? -- Michal Hocko SUSE Labs