From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7FD2D3C927 for ; Sun, 20 Oct 2024 07:15:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A3216B007B; Sun, 20 Oct 2024 03:15:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3521C6B0082; Sun, 20 Oct 2024 03:15:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 240386B0083; Sun, 20 Oct 2024 03:15:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0D1066B007B for ; Sun, 20 Oct 2024 03:15:28 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C4833160F54 for ; Sun, 20 Oct 2024 07:15:11 +0000 (UTC) X-FDA: 82693119264.07.BF0519F Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf02.hostedemail.com (Postfix) with ESMTP id 9D09480006 for ; Sun, 20 Oct 2024 07:15:00 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HyUqYdJ3; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729408376; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KXnI353GCKgAtuilwYNuyiGGeifEMlwLXDuGE68LnI8=; b=pnm8SY+LFIC4wQ/8N2vhJSBGnYr+Sh7Z2WOmr1orMOxe/sODq0CHjfc2e/sqhFKqCW7lvc Nf2q1x96pk31hSQSDo/XreEC5pmd9mdMxivROc/zW0ILLPn3qHuSK8zWtYkCBKD9jFnGyg AqRELebvJzya36NbD89PFNbFOJUVc/s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729408376; a=rsa-sha256; cv=none; b=HPoh+p5Fn1PeJvMRko5pzkuw3vkkA33FamVPi1bWzqjJSVfRepY1rAthGIIT77SH8MUJUc U2Q+H8Vzy6pfQeYNnyxSAd3O+xVG8RkUFCePLmPgZuclDaKQJLAnK/jwmFQq/YzfDy4vLy bAssQ46qXPWcgtyo9jMuQrP4mpGVpeA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HyUqYdJ3; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id ED872A4015E; Sun, 20 Oct 2024 07:15:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F18AC4CEC6; Sun, 20 Oct 2024 07:15:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729408524; bh=yeNo6luy1/4z52AiDhi7fFi1PCeauLclbjN9yAVUCOc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HyUqYdJ31Vf7pF8us/AsUILyQRvw6YB8oGqiGXqNND0GPVWIjtHO9/4xQRjJ8EYqm 95MbjoVIq1jR729Ye+UwW9kjI6MviJHCH/seoV0N3SxBootuOeSG2MFDEHTLw6AllU K/j1F2kaVAp1Q89vhSGHHUzwd09xi97ai7MN0R+nDZO7dQQY+x+dqS/P5rIbaQrNw1 5b2iOEsukQL2LJ2n4GC3xcRz5+eO/HcENl6TLWwEmQhbdOIdgZBELu7v6L6OA+7h2I P/X1ZxP2A2GHRV55xGC6FEpk4AkUY5KkkPUXhHFaMLJZPYnylhvwWzwzn/6JZc0fPJ 5hbpGfV/S6u0Q== Date: Sun, 20 Oct 2024 10:11:38 +0300 From: Mike Rapoport To: suhua Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, suhua Subject: Re: [PATCH] memblock: Uniform initialization all reserved pages to MIGRATE_MOVABLE Message-ID: References: <20241017064449.5235-1-suhua1@kingsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241017064449.5235-1-suhua1@kingsoft.com> X-Stat-Signature: o7re6uxff53sianj41dpreb1jxwdaeeu X-Rspamd-Queue-Id: 9D09480006 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729408500-784673 X-HE-Meta: U2FsdGVkX1+DeZyY2FicMk1IM2+N63s5KQPQ7eTurcPNuhS/aaotyn8Ytgoo+3FGqWwDPjPuXETnK0RzXj4tidBEMVYp7biVTsnsiTy1ZDkCNUTNntc7ydIQ9MEmT697VyEYYNtttnu2izmZZXr/zbPwqq6iujNfeZXwJnHIpenER8W1IF42cFFgH3CiFhlKIdHjhWB3e7uM/iI7F5bMN3NG1LqOlNbFXEAhIK7zdI96s9wO/lN81kGVVZx1zR5Wog/PJ3ahNlRTRDsG0CbnMfrj0vYiTf7gljVMH7OCzqVRCn+DWO7AiglZ0qYqXzs95e83VqVbkXvxytPJzcyoAYSj9PfiZyGxMLZZnBQMyu8kdVXNBtZEvNZltiVB22BaLD//GSF++TeTRSUY7ow4EWCO59/EUD6qw00dCD2GxCjJleoBebtD/SV+LIHdmCAU087ocxGcorqWoqq/+io7t9VQa8Bf84hHnuMEA1aG3KB5R999uGrcmUi/U9YOD6WX8vC5oVe47djr+ZcKyXyfx++dU8PfNyUrTA238oevgGj8/xVIeq0RRgFAucQrSodbhBlowuwMq/ry8eDmxwHDj1JrW8B0jNd42GwC5cgfRHVIWy5AfoaLzMrmsPpvOOJFvjrqehv8R9CPDw4fjE60GZ9fmZhugFfbZ7i+X1778oAmIXaOe+HlNlmjtzLq5aNCSVaFRZfARd9LalORtFNO5it40oCSjkWmMZYbvnhx9kBV6g/Qm234l/KM0KcYw0YK/ZwvHpPEHGFO2FBZ0HqpKUJsFGROxDn0YdZ3Dp+ZFFXj4daFDMMkpcfVkcieWy6j1FPrDYy+9a/WxqsxXG5mUx26hkXWQ+wFbuG7W3GIHJGVWhTYdDMBPUstX4q76PIkIt7v0JpmbuVNWsRDd95zPeV5rnZ3QXqQ0mHhDFTZTdxdbCFmvKU75NZ8UlLIPaoDs9NDHMlWGduBHZsM2+r 2QTLxsaR 4hYcriIiJU6COTKVyvOYeGkNJMHmtnf1yncIcG7E1sOdukU2S5wi2OYj1nUILs2Oq/Ww3ZJcvupNq/1XDMzFqGcVb4bQskMX4s4O2mRJUZX2Pf9X4HZQtKPqvP568KDn1QCvJudDH+ktMH/DQeKrBfDSOYbu0z7brCNHNcmkv1GVQrlLFmTJ21qAZBocGzoa8RSRQP+uL+uI40jfyRMAbo9XZA1qNKwWa0vcT364oXfV1muLAPU/2CFrc17CCMofB0JpNNDB3wQc7mn8Wi8F8W7y96p2zlDdFQpK2c3MxCS2RhDdrByXuuMCOxOfJrjn21peoUja0EhzMZSbv2oQu7ewiNBtpYjGSy9tPRxtzHTDpqN0gEpwlxWLH8s8QMlQr4NzWcpS97b54pn2a80o9QkObEDJODHDBughS+3wlDHIpVfK8qQsddAeLSuJCD+jF3WDKj9IVsreY9elE0C6RQQTZJ4tfWqs5eMbm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 17, 2024 at 02:44:49PM +0800, suhua wrote: > Subject: memblock: Uniform initialization all reserved pages to MIGRATE_MOVABLE I'd suggest: memblock: uniformly initialize all reserved pages to MIGRATE_MOVABLE > Currently when CONFIG_DEFERRED_STRUCT_PAGE_INIT is not set, the reserved > pages are initialized to MIGRATE_MOVABLE by default in memmap_init. > > Reserved memory mainly stores the metadata of struct page. When > HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON=Y and hugepages are allocated, > the memory occupied by the struct page metadata will be freed. The struct page metadata is not freed with HVO, it is rather pages used for vmemmap. > Before this patch: > when CONFIG_DEFERRED_STRUCT_PAGE_INIT is not set, the freed memory was > placed on the Movable list; > When CONFIG_DEFERRED_STRUCT_PAGE_INIT=Y, the freed memory was placed on > the Unmovable list. > > After this patch, the freed memory is placed on the Movable list > regardless of whether CONFIG_DEFERRED_STRUCT_PAGE_INIT is set. > > Eg: Please add back the description of the hardware used for this test and how much huge pages were allocated at boot. > echo 500000 > /proc/sys/vm/nr_hugepages > cat /proc/pagetypeinfo > > before： > Free pages count per migrate type at order 0 1 2 3 4 5 6 7 8 9 10 > … > Node 0, zone Normal, type Unmovable 51 2 1 28 53 35 35 43 40 69 3852 > Node 0, zone Normal, type Movable 6485 4610 666 202 200 185 208 87 54 2 240 > Node 0, zone Normal, type Reclaimable 2 2 1 23 13 1 2 1 0 1 0 > Node 0, zone Normal, type HighAtomic 0 0 0 0 0 0 0 0 0 0 0 > Node 0, zone Normal, type Isolate 0 0 0 0 0 0 0 0 0 0 0 > Unmovable ≈ 15GB > > after： > Free pages count per migrate type at order 0 1 2 3 4 5 6 7 8 9 10 > … > Node 0, zone Normal, type Unmovable 0 1 1 0 0 0 0 1 1 1 0 > Node 0, zone Normal, type Movable 1563 4107 1119 189 256 368 286 132 109 4 3841 > Node 0, zone Normal, type Reclaimable 2 2 1 23 13 1 2 1 0 1 0 > Node 0, zone Normal, type HighAtomic 0 0 0 0 0 0 0 0 0 0 0 > Node 0, zone Normal, type Isolate 0 0 0 0 0 0 0 0 0 0 0 > > Signed-off-by: suhua checkpatch.pl gives this warning: WARNING: From:/Signed-off-by: email address mismatch: 'From: suhua ' != 'Signed-off-by: suhua ' Please update the commit authorship or signed-off to match. Also, Signed-off-by should use a known identity, i.e. Name Lastname. > --- > mm/mm_init.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 4ba5607aaf19..6dbf2df23eee 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -722,6 +722,10 @@ static void __meminit init_reserved_page(unsigned long pfn, int nid) > if (zone_spans_pfn(zone, pfn)) > break; > } > + > + if (pageblock_aligned(pfn)) > + set_pageblock_migratetype(pfn_to_page(pfn), MIGRATE_MOVABLE); > + > __init_single_page(pfn_to_page(pfn), pfn, zid, nid); > } > #else > -- > 2.34.1 > -- Sincerely yours, Mike.