From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95E7DD3C92E for ; Sat, 19 Oct 2024 22:19:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03C866B0085; Sat, 19 Oct 2024 18:19:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F07FF6B0088; Sat, 19 Oct 2024 18:19:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D59D46B0089; Sat, 19 Oct 2024 18:19:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B38036B0085 for ; Sat, 19 Oct 2024 18:19:32 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E5895120DCB for ; Sat, 19 Oct 2024 22:19:19 +0000 (UTC) X-FDA: 82691768754.07.6AB283E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 91E4D40004 for ; Sat, 19 Oct 2024 22:19:20 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=vNM1wyZQ; spf=pass (imf17.hostedemail.com: domain of mcgrof@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729376174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RJpTD/Xv5f2pqBFSuqkTCCHmm0Mp3BKcMjnZ1BWJcfQ=; b=LpjE2SPuB1aUji3odfMfhfQ0g7cg8J5w3J1gAWGlFGva/dqUfzd2dOW8X1cqVAYiZ81X2H P/lcaIYgK4wbEVNk/nOAav0Vz9UnofHwh/8S28MlPMFLiF8h/bFgKG9b7yeWW1RNLmvpU6 9RB8xqmJMdSj0+BXmdYFF+iDrko/3XQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=vNM1wyZQ; spf=pass (imf17.hostedemail.com: domain of mcgrof@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729376174; a=rsa-sha256; cv=none; b=rZkYKFzLJNkVF+wCO5wNKiPoWtAyONhnrgd14WDMGW4kOjlVNUEUjafQxeMfQ8CcYaEx5k gTDn2h+60JO87EauDaXSEebWY0amTH65u1w1iTahSLBKzwjEyH2P6WmlFgPs0b94qNhoc+ dusW1tNV9uiSBgixBkIqhEquQ9qz9yk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B22E35C5419; Sat, 19 Oct 2024 22:19:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B925C4CEC5; Sat, 19 Oct 2024 22:19:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729376368; bh=daUc5xecu7xI5c+UkC320lN7WO6Pv9zdDCfjUjy8L1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vNM1wyZQW4Fo3UYmtYtZPgjiHgu/H4XI/+27SeHDRGuyHhrsjIEj389botXDz7xzU oRoliDromsIEdrwgMdf3d6+NrBy7bXYMTE2T/8I1/d4kB9gjHsLS/MIoIKs8EASeaT aBxIiobIWyjFiwv9/poZDmy2HqvjFhixH+91U8zwdcdRhqXgTkEFbn2iL08Ol1J7ou HP420DfIrrmCeqEBftQC/r/u9iEdCqnooHwASpRmuOZ6oVBWARW5PE0Gis4BiiIMsJ 95hjSW/bv4/gU/7p/7MsytMe7tkh0nWplVzjhpV678uD6QoJdFyqaGyiUG8CRghoje 30qArBjHZQnlg== Date: Sat, 19 Oct 2024 15:19:25 -0700 From: Luis Chamberlain To: Mike Rapoport Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Suren Baghdasaryan , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org, Christoph Hellwig Subject: Re: [PATCH v6 2/8] mm: vmalloc: don't account for number of nodes for HUGE_VMAP allocations Message-ID: References: <20241016122424.1655560-1-rppt@kernel.org> <20241016122424.1655560-3-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241016122424.1655560-3-rppt@kernel.org> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 91E4D40004 X-Stat-Signature: xqkeda9u6mdxikic7g89qjotaygtjrb3 X-Rspam-User: X-HE-Tag: 1729376360-737844 X-HE-Meta: U2FsdGVkX1/rFblvFof2uFQocJjJJ+4ijpmsvz/i8qF678r+N9w2M5wm4ifjn1hbOFTWsqlowIL4FSFssAhrvYHwnTzyoIc/UEAO3kmVqMe00LJgP9P5oLuib1qVD8pt6JK2YxjhKC3K4ZXQB82OArDV00YUotckUYjbq7ws6kXt+g3axcOLYlRHeYlHVlB2g3QGoiKgEELjOCDwV0U+zBgjcctyefqFC0kXNmYdm5LqVW7y7tR10H7PzL9Rum+QHYz6EBykdrgxxXJHO7Zx1Rn62ld0dU/pZ5SdRdhLb1K/CLZu7L/eH32w6+ARxQCfE+AfWZFLexcV/8gLkOybNia4gzr2mqm3XquepdupfqQY3T5BSTe/bMRSpA94+HzJlu4u0K8qqocRN9vj/hSFmylKBnNxbYgD8NzpMa6dq9rRbk6C4jCa8Tmbifucydkxz5ibCfSVmPlVCaLd2d2s2POQZXPnCTqFKwzcIzkQ96/UrTLNoZlfx9ToI6N8OvmE86xRhAe0hucBUxR/O/xZJS30ASh0ZH/oUhydQ5OgUdyepxxd3wQVlHoHByiYHbeda70EU6icB0+C1ZyeLords3BNdxbkEdq49oZq5ehMEv+BDgcf7XeiVDNkmndJmjw6StBSUN0mtNGeu2WejyngUOpmAZeB1UMcA+Tyxc/ZlIK417MhboLGbmdyIXCD4yKGXZ1VcQ0pH2BNPKLLP9YNYN15VpNKspGT8ISP36mOKoSmVvGmOuTtAAhFuLvYRwuJFYYARodvr4YjGH+8Y910H/yNNvaJC4a7V5UG4uCZA/WVfNIvdFHxKrB3pDQOSADGJdEW9wdynWy1s65l5IyH/cHvdE6oGQz5y1HJu1cdw9AyeTLl3lqikZC71fo85aoVxKN+fUg0c+RvimN7T3arpxhY6K0RnQX7ebTPGwGrK7ZtPpXTWdNfFvGPHQtMQ3l5Ge9lVePnUlhldxrPQLr RgKcBsXW Whwi4HbkOfcYWcv3ldRhWkS3e7GEAPp4KbLgYBgFI/ctcvZFUyelJGgjMZlAqAzSnJb8kerKDWcAauXfwiqJet6z9/GHBs7kz/kD5F2DNJ+H1AR4ewIRvAGOOKOHsbfQzml/OeRzQcHZNPnIcnB4QZ45g7aYg1OOYTsqR/n1u58wmZVBbBE9LnbkNrzTSQxgWijeQn1l4Nuq6dmbwTp98+6uzs85Ju7lIQ/SMEw5u6hPFbUksTnLPYMDEhe1EKxFAVNsWgJhcilsNUvzde92cAJXvv4IMvcam8e2gdSB6947BcOHo0/JVfQJfM56CWFgKPTgWpLyn+CAcZ5vvcH9/CXK1kw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 16, 2024 at 03:24:18PM +0300, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > vmalloc allocations with VM_ALLOW_HUGE_VMAP that do not explicitly > specify node ID will use huge pages only if size_per_node is larger than > a huge page. > Still the actual allocated memory is not distributed between nodes and > there is no advantage in such approach. > On the contrary, BPF allocates SZ_2M * num_possible_nodes() for each > new bpf_prog_pack, while it could do with a single huge page per pack. > > Don't account for number of nodes for VM_ALLOW_HUGE_VMAP with > NUMA_NO_NODE and use huge pages whenever the requested allocation size > is larger than a huge page. > > Signed-off-by: Mike Rapoport (Microsoft) > Reviewed-by: Christoph Hellwig Reviewed-by: Luis Chamberlain Luis