From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A087D3E194 for ; Sat, 19 Oct 2024 00:20:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B30E16B00A8; Fri, 18 Oct 2024 20:20:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE09F6B00AA; Fri, 18 Oct 2024 20:20:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A8D66B00AC; Fri, 18 Oct 2024 20:20:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 79EA56B00A8 for ; Fri, 18 Oct 2024 20:20:10 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 01C3E1C515A for ; Sat, 19 Oct 2024 00:19:55 +0000 (UTC) X-FDA: 82688444076.08.D0A1530 Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf24.hostedemail.com (Postfix) with ESMTP id 3D24F180011 for ; Sat, 19 Oct 2024 00:20:04 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=PYB9fJvZ; spf=pass (imf24.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729297060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zdDTvBQFkrAbA5UYsiAGy1L58PcaCZM1pS4G5GVb73Q=; b=wcPGg8tqEHddV8PM/anmaA0KQtnr8ZCIPdzMJle6vFQuYkAsKQIBPnErSqEGbs1V/7vrDl P2qVadEh+Ai12Ei32h7M++LntWUAmKjiXGZty3HuZjYJ0KYcIcuGP656P4I14GW/3Dudgi 7R8QvoW1J5HqYDeeQRNW1YBeTKjOjFU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729297060; a=rsa-sha256; cv=none; b=D88BdE79hQNkdiQcS5m5Vcn17mybJ6Wyn/Pni4gWXXwoF4nhcK6CIlMX+e+9uvrdoGkKoQ NTzvYRfC/aV1l6ToarvIjnaThRkr8104xqsl8yBW54yn8slbyZldZ6IP5xHzflmaGqkwjb 81EElbIxktYPZLlaSWD4LTxl+eKI1LM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=PYB9fJvZ; spf=pass (imf24.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au; dmarc=pass (policy=quarantine) header.from=apana.org.au DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zdDTvBQFkrAbA5UYsiAGy1L58PcaCZM1pS4G5GVb73Q=; b=PYB9fJvZq646VxX9D/D6jU4RSV WLOvBXYenBE+50AuDfcfPeNRirfZqz7oH+8dk3oc/5Zaj6H6/Ju+R5yGCtbu8SgfBB2CFvOCKic9M pPX0eFVYzLLZuXXaTDRt7lA7b3jkW7eZc4E2tLDSzOPs5aMaGN4JDs1ITCn/y9qu16L738mPm5xDH BwYPpZp0yUC8/9oBrPkxcL0/8g4YqpayJbJRA5lV1j1mjGaRfMghyHt47R5aNsgcgxN7vygZeK/jR i40azgCN3t7PtUAHwpoBIQ9/bB43LwqBZZdeaHo7qQUkuZMEwOInEbU2oRRTcBWZlhdUzJXC+l8UP nUsoHnzQ==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1t1xCD-00AVu7-2K; Sat, 19 Oct 2024 08:19:54 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Sat, 19 Oct 2024 08:19:53 +0800 Date: Sat, 19 Oct 2024 08:19:53 +0800 From: Herbert Xu To: "Sridhar, Kanchana P" Cc: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "yosryahmed@google.com" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "Huang, Ying" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "zanussi@kernel.org" , "viro@zeniv.linux.org.uk" , "brauner@kernel.org" , "jack@suse.cz" , "mcgrof@kernel.org" , "kees@kernel.org" , "joel.granados@kernel.org" , "bfoster@redhat.com" , "willy@infradead.org" , "linux-fsdevel@vger.kernel.org" , "Feghali, Wajdi K" , "Gopal, Vinodh" Subject: Re: [RFC PATCH v1 01/13] crypto: acomp - Add a poll() operation to acomp_alg and acomp_req Message-ID: References: <20241018064101.336232-1-kanchana.p.sridhar@intel.com> <20241018064101.336232-2-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: csh83hc15z6uwuux3hm5e7fomen8xep4 X-Rspamd-Queue-Id: 3D24F180011 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729297204-434282 X-HE-Meta: U2FsdGVkX18G7tYLQuGfbgvUJHOjHkVe4bs0H0yuAip0gxG8lCZctI4nK+1D+TBrGuPE00qpN9mNghNog9bhK/Zq1u+mAH7k/52DdWvcjMapytMLkP3vjyvaZcesMBFugOamkFW80upSIrnO0azHilFaI9oYQrL9WuCjq5QEIs9TGBB8grLH8K0GnVhLPWCZ/jsxrg5ViumzjLfYqXrvyljzect4dRlZ8ZjmXE1dDSSStDO2beEwF7vJAkCTeAoXB7PbjeTpM1THKXWxgVijFyOhLuwbNpkDGi7BWJk+dsgS/AqYzAXBsc5BCfVfntZuBM0cEaGc6DXObJwwotEN85dGPRrR8cX5hbSvzcbjy2WjQGRSBqFRHmaCsS3TqeVr/CRnp9bFFWQaJllx2WE29mYWFQdWhBmFQkn4LJbJ8mOvWj997isQwhrGipPRsy02OsLmNSaB/8vtLKH2IFMsoKarmGF11h0zu/TYHVidiblb6wGv5zxaoiHoVrJH3BZ1mZYBghCj4Y3pDgl3XWIYrEgLCuoDQWaiRn0lJrjHWDwukqABODyxSQf7P7VSi/gxdFlNV5cuKAotNQIhKnFMe5k5F34Uti/yhRaFSJI4u09shfpuGpiZVD4T6Tf3AkLClIcIycJm7Hlf+F4wsnJ+fwBnhlSfqndYpFE9hjS1psaFwzC/KmGUGoUbuaXKFXXETnVCxMl54KU480dhmWsJ8w7oEi48itbv3b2ABPRTOPRMT4T+9+QJY56HmvLa6L7mrSJgi7zgOWVrGN9iBENCh08No96dfeFdxjY6SSsbSwxolx4WNclP+rxvW8tO7i6IFYs2RO2uWKujmVNqE7uN5lxzC+yhYk4XIU1npQqFKbTcN5lfSCCnkjUa745b6F/B2dflUriBNSoOx6UU/w3lvrU+EcrF14JAB4cwuJ51li8BX39vbkGZT0jQoZct8+ku07CjuyundmQ/kTbm9pS /54+cr6n b++867MXgaGFonGqEm3kXNcF4EUbFWmz2sjTwhHhipO8E9glwns13uDUbq6K0A7LHwDD/OAQ2NXIRlKl4rGjQuyJydIJ1FvIzMf/MnjcT3EmYRY5xZ8lmfdNdaaqIZ/xKMVCU+ic3x/4cOSsOOiDwEPoecGgbqaTwnVBgXj1fBdmdCEY2NS9MRdfAFc0vT9ncFEQwNxWSX9vcIgcUoTj8k7qBzl0PSpK2ngS1LwY63NdIN35551m/1vZTj+ArJ1pTWPqW1ub1Qp0DUtsJ/49S4xEcw4I1CYxbumI12nTfqZHw6/kzDSW+WDmYDS1LbCVR9qlCuVxPD7w6TOM6QL1ck1bqnLRjOPfrbPwz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 18, 2024 at 11:01:10PM +0000, Sridhar, Kanchana P wrote: > > Thanks for your code review comments. Are you referring to how the > async/poll interface is enabled at the level of say zswap (by setting a > flag in the acomp_req), followed by the iaa_crypto driver testing for > the flag and submitting the request and returning -EINPROGRESS. > Wouldn't we still need a separate API to do the polling? Correct me if I'm wrong, but I think what you want to do is this: crypto_acomp_compress(req) crypto_acomp_poll(req) So instead of adding this interface, where the poll essentially turns the request synchronous, just move this logic into the driver, based on a flag bit in req. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt