From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 385C0D2A53A for ; Fri, 18 Oct 2024 08:21:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CEC06B0089; Fri, 18 Oct 2024 04:21:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87D786B0093; Fri, 18 Oct 2024 04:21:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71DD26B009F; Fri, 18 Oct 2024 04:21:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 552096B0089 for ; Fri, 18 Oct 2024 04:21:08 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8CF358060C for ; Fri, 18 Oct 2024 08:20:57 +0000 (UTC) X-FDA: 82686027312.08.DC3557A Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) by imf22.hostedemail.com (Postfix) with ESMTP id F1F1EC0012 for ; Fri, 18 Oct 2024 08:20:51 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=iRhySdG0; dmarc=pass (policy=quarantine) header.from=apana.org.au; spf=pass (imf22.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729239547; a=rsa-sha256; cv=none; b=Fkd+aeBFPbn8H7oGg3f0H3ryRIs00wCtKKLVP9xA5XsHsz7gjYrG2gInEfWnZHcCV5OaPP tHbQzVw4bThDSoD4HXDSjdOr3AaGvTsRHey887Y8AVaPdMI23lFVNSDiAxYXSHoAmV9CbG O5LPPSncU/A2S8VUW37qGpoTYoXH7X0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=hmeau.com header.s=formenos header.b=iRhySdG0; dmarc=pass (policy=quarantine) header.from=apana.org.au; spf=pass (imf22.hostedemail.com: domain of herbert@gondor.apana.org.au designates 144.6.53.87 as permitted sender) smtp.mailfrom=herbert@gondor.apana.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729239547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mL32Eki6sjCzVmgt0MNugO7Uxg6dlD8cyllaWHsT1OE=; b=A1R1CK8oxJJYEOyah2bI4WMYFyw5fhVaZqK5dP9E+ifugpFGz+/iq5LWSWaCUigYbqWFoV 9Y5nNXEK5FPz8t79/UReq/YAiK6W2U0NxAf4RLLGGKq7c8/W87G5M8GU3gFjpgREoL9zoP 5/PhRIAwvEN0UnBaAzCdn1/shqnYrpo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hmeau.com; s=formenos; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mL32Eki6sjCzVmgt0MNugO7Uxg6dlD8cyllaWHsT1OE=; b=iRhySdG0+HzFT33nV2Qe97Xwxn 8bFkloSEdrywPJbXjvcdyyB+kUVHdbRid7SJT47MfNNGK9oywgBvQ28dsu7T5zd5+XugG8Sm3auvg vz+yFwwk1MAHSlJ+VN4HYkmIImOnOvm3EqQjEqFzkdmZVkI6SJbg4D3SZ47E5cBwXt2elOq4DTbLZ wzQPzUPC9Ndb9KxrwpzJEuYmLMNzdb+Ism3vYQueaP9Pvc3BccOmLdYRy9QGH66kesJq2iDJm3WF8 3Tg5/WS+QqT3avdo3ftalz3kDGqqMjZlyf/rt/09eHPAr/EBk7fZBw0vcTig2oUy6KF4Mi16oNrVf 2xncK+0A==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1t1hpF-00AJtu-1v; Fri, 18 Oct 2024 15:55:10 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 18 Oct 2024 15:55:09 +0800 Date: Fri, 18 Oct 2024 15:55:09 +0800 From: Herbert Xu To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, linux-crypto@vger.kernel.org, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, zanussi@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, mcgrof@kernel.org, kees@kernel.org, joel.granados@kernel.org, bfoster@redhat.com, willy@infradead.org, linux-fsdevel@vger.kernel.org, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Subject: Re: [RFC PATCH v1 01/13] crypto: acomp - Add a poll() operation to acomp_alg and acomp_req Message-ID: References: <20241018064101.336232-1-kanchana.p.sridhar@intel.com> <20241018064101.336232-2-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241018064101.336232-2-kanchana.p.sridhar@intel.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F1F1EC0012 X-Stat-Signature: h4jccakcu8931nrs6yczr3ssjqu7mx6j X-Rspam-User: X-HE-Tag: 1729239651-842554 X-HE-Meta: U2FsdGVkX18AKdzaYq63rDtxDSC4IeiPY2n0QS9zHHSKeu2i+lvG469ImRq2gM9IFUtRDiVm+CnzcX1Uyx75teFM/R+WZCWlsDoMVvhtIXhONAFMiVSyVylL1EosNX33LZmZavh+chrUrITnWNNgy68jWi6SsmUzh2F+CKIg6xuNz4EkUzdef/BpJa9c2RlmoSAB2zAykeLIio9qA6Y3HX1XGs2JrOlv+wUjgg04p36llvr6NDk4yVaBVrPeTHbnNbcFQ0UH0hHyxe+APBFO6hOzYa2g023H4Xow9mJAUSCH4SHpCD0NoRM/E9vqltwEEtHWPgiSQrJoeYWspLc2zcUe+tEUboAZM0TQg5jd9gJavf/CsU9PSRs0yqgZHKA+ComXJvO17Thyz4yJAzWPqwh76tdqlK9lt2QduM7vtqL8yo3uPHbUMTwURip4fzC0o4tClKhhdR+cBGasveBh32rgZ4Om0r2hN5XELBpt5OkH45o3J8yyxAytOOItt+6J574XPFIemszWYk7k1tYdkGFUvYmwQVn+Mu30hvMGx1UdLSeQ+4K+gTsZnF/zMgXqQ5nWer9RG3gQXQ0AimDRzIbDkhASphzLK+kg7Mpa7TiMvVrQplFiCaWG1Ie+hsts9IhUipKFsHaIZAsSzLqV03jGLd3XmfDRokTFe1eY7t/F1ngiCkXDwdubc9atj9ADc9tZeCHxCMyRq9p7kjP4sJscos8wT8rICN0xH8XaVL5YdQt8+4NSEPuTWW4L7tqgeCvtecsjrtOsveFtF+Fdtos91ySlzenWNieor8x06Rzt/2RWENjQOKOAN8gjhQhDeFKteD0hZm4aUu+H0NiGXTL9/pJcm1NnO6D2ab9XPa5PkRKzKj0zY4chDuTiuPzu4QqFZAl5L3wCD4SlWiOvSXGVbq0pYSl4rgQUdkw4mYjGJ7GZi5g2OIuY7k3zV1yl0JfHjCAEwJEC3OFB9oB Ucw2VXJB 5wdz9eTLID63UX0krK57SKT76pIMr/ZYpk8tMH02xJjeqmaPADs+n+aw2c0CCdugef3iQddCWLLUacD92r4C3qxdEa1QbHlRnYwVZCxLd+yBXuithvB0fV/NZFzYxC1i0dDBndIoQkNlRgNOKIqr5rMAikv2xZCmiUIXkiP4mScKsO5tMFzzZAPYZcXBnXIhSMO2bYB5BmrcfjeRVk9XK9Mqdr8tfxOIDTmgFJEpTs4LeLPXXy4q4RsAQtHUtjQRar92bZ1JQvsE43QYtUyFB7VdjYaHQiN4Cme3IV0hZrJptfuYKfl9MjxtEEMG57s3ASYwesNQyJd0+1aHoQAjHjdxRvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 17, 2024 at 11:40:49PM -0700, Kanchana P Sridhar wrote: > For async compress/decompress, provide a way for the caller to poll > for compress/decompress completion, rather than wait for an interrupt > to signal completion. > > Callers can submit a compress/decompress using crypto_acomp_compress > and decompress and rather than wait on a completion, call > crypto_acomp_poll() to check for completion. > > This is useful for hardware accelerators where the overhead of > interrupts and waiting for completions is too expensive. Typically > the compress/decompress hw operations complete very quickly and in the > vast majority of cases, adding the overhead of interrupt handling and > waiting for completions simply adds unnecessary delays and cancels the > gains of using the hw acceleration. > > Signed-off-by: Tom Zanussi > Signed-off-by: Kanchana P Sridhar > --- > crypto/acompress.c | 1 + > include/crypto/acompress.h | 18 ++++++++++++++++++ > include/crypto/internal/acompress.h | 1 + > 3 files changed, 20 insertions(+) How about just adding a request flag that tells the driver to make the request synchronous if possible? Something like #define CRYPTO_ACOMP_REQ_POLL 0x00000001 Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt