From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9EB6D2FFE0 for ; Fri, 18 Oct 2024 10:12:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44ADD6B008A; Fri, 18 Oct 2024 06:12:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FA846B008C; Fri, 18 Oct 2024 06:12:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E9AF6B0092; Fri, 18 Oct 2024 06:12:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0FD766B008A for ; Fri, 18 Oct 2024 06:12:05 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8779880588 for ; Fri, 18 Oct 2024 10:11:54 +0000 (UTC) X-FDA: 82686307284.28.D623027 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf08.hostedemail.com (Postfix) with ESMTP id 70C2816000A for ; Fri, 18 Oct 2024 10:11:55 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=G4u7PNPD; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729246177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nP+JOMY4iaykICx5qO8ZsaBsQsowDERbnUHntcs+XbI=; b=eBZ12xACAyoTlH99aegQw3bYQK+w9fWA8gNyUkhcmWPTZsqFMI+WFmBScyrHFuXA32llRU XhFYZ+9y16Not6nN8m3JXD/jD9i8/vsLNBUb0HtX65/liH+p3awJSci+ZneNZz9OWRhqvf NtXVmHBNoR1JHebABlWWiqyheO3+6yE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729246177; a=rsa-sha256; cv=none; b=UGFsR3v2Ywuv8htesMXokvrxFyc7krrAP+VpwP76X4D12AjVys61oDZqt54shlS/yhj2tx T6hH55XegpUWIAgkjH0EyVPq+sCERx+naCk6qs0K4ypkxNmFnII6/XzxK0TjXKOEDXBr78 MmNO7tYw6ARXZ2RAjxvLw7l0aKGyyEk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=G4u7PNPD; spf=pass (imf08.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a99ebb390a5so570247666b.1 for ; Fri, 18 Oct 2024 03:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1729246321; x=1729851121; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nP+JOMY4iaykICx5qO8ZsaBsQsowDERbnUHntcs+XbI=; b=G4u7PNPDJU3GssVvVIe3/i8SHARWmAA1aohDi/VyMbmvQWBqir1UBRBlSldvd/TzIY ijRgLWTMGuUZHw8AWXOPekshTq7Mk1v8XCXIgbf5GRVezG/s1wUNDPk+fpQoOmv5Por5 ZooJpxNfJxWxQFcbwdEjoPBG4WH4lQhM8yKHrZp9sHJDN2NF+4M1z54iXHViAtl8fzXV EUlidLlCsP7VvyQc2P1md5mzIk6kGKzYfE8xeKl+9DL87XhdpvV0PRX1pUv/PG+0ngct DWPwH24jzmRXnSZCqgriOtIM0w8yH5N840xshXiCh4TjFPxIPcZhFepLIC1XJUgMHR0e PTuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729246321; x=1729851121; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nP+JOMY4iaykICx5qO8ZsaBsQsowDERbnUHntcs+XbI=; b=M2Qa8FtDZwOMWYCN+G+jZVX1CrxY1qwWG01KP33eQ5Txx46feAn7oxJh+Q0X+Tw/ms Fg6ioyr+IKpByd0JrTTwQYe3OreEHwW28xQkJ3uwOgWxk7/4MQpPYQcdQRbmY33V0F70 NiQBrhzyjhA+d1I0hqoroVwtMzl43mVsftxN+CJjjzfa9LBwpZCfyZqIv2PkznOrdCdk eUK+gkKke8GGZGcEwWXZPHyp51ZF+vX70YnfNK8uF9QDbOqk+zRODG14GhHZTqU2twLr B0eG2sMQtQHSmeMO3DnDMc17TmuMCntXqX0rg8cFORbfhaqRQMAfG8wpM4QqyiHuEBeR iCUQ== X-Forwarded-Encrypted: i=1; AJvYcCWgnfh+9JWCPe3yuwSy7S5Otch2MDclgKl3mcH2m9aobFuy/EGnO33cMBj7hFTRDnTHIYwx/HkCnw==@kvack.org X-Gm-Message-State: AOJu0Yx0XbOI02rJ8/EouuTEZn5g0lz9qmuH8ktSH5rGC01rjLA0B3CE +anMRIwEZVmOiqt0X36BqJK7L+ZBeHiQXDy4kCQnKHeQygHGFAjgxbAoU/Xltak= X-Google-Smtp-Source: AGHT+IFpi0II1Hmaw1IuAkx+cm14EFxpoJJ2Qv/1Lw4miCPbqkHcvomv5vAStTR5DLHU/UpSIoybaQ== X-Received: by 2002:a17:907:6e87:b0:a99:eef5:d360 with SMTP id a640c23a62f3a-a9a4c311578mr608526566b.19.1729246321295; Fri, 18 Oct 2024 03:12:01 -0700 (PDT) Received: from localhost (109-81-89-238.rct.o2.cz. [109.81.89.238]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9a68bf4157sm73467066b.154.2024.10.18.03.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 03:12:00 -0700 (PDT) Date: Fri, 18 Oct 2024 12:12:00 +0200 From: Michal Hocko To: Joshua Hahn Cc: hannes@cmpxchg.org, nphamcs@gmail.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, lnyng@meta.com Subject: Re: [PATCH 0/1] memcg/hugetlb: Adding hugeTLB counters to memory controller Message-ID: References: <20241017160438.3893293-1-joshua.hahnjy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241017160438.3893293-1-joshua.hahnjy@gmail.com> X-Rspamd-Queue-Id: 70C2816000A X-Stat-Signature: 57bsug6pbro4rjzbwwkuqcnjzrishrmf X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729246315-801893 X-HE-Meta: U2FsdGVkX1/hEzrvTr1DPw0xSw85CakJOFZbxbx7BnzEhM8Jz2LjXPTP/JldfRkNnCDv/k09KJ9INM6l2iHTByPReR3lNzNegRuerxlO34xZlWr6SBRf8PMJdiDDhch7YvQw80bqj3aDAbk6eXZ2dPmGg/UK3SziOhQyZbUeKnWz2kI8gojjvEi2ipnlYe3JB2/GVO8BF/HGD4fKYjE0XxX+KE44eCJqhngaKIY/7KqR5VJTU7nVrsjDX2HM/C9sXT/zN7rghKAr/zDkyU30Ts/HfdutizjLGhfrQK0CBf/wRjWS5iG8ER5ySzwog6lY+mclwbPn9Q/TGfmxHnKpC9LjcmFJwhjzFrR2g+PHZmQDCaI1TZOkUTMwRlYBc1c0PaCFvj24ryUn2duEEzZpYUHnGiCD/8wlikqo/bE8wRqWRs4GWPSpKkaF3eaiSLvXU/dfTsPhg2xL2oY1sTDER3Ctq0rA13iftd2kbSSh5PM8e69HDF1z4GcGI7jQfeF5DSpUfeFYQOK3VCtZW6mjUs/in2UAFTH4wostMCX0dkJnl2yReN+qbzTnGKDD7nz9gFyXFOUoPwj7IdpBDA15q70aVL03y/MwiwutIYYixSmT4BVfrVPkJjVLbk8Ho8Wdaa+XffYX2sEV/1TKuZq/3aUwdzLeVgCRU/BRdNQ1bq/EBNVFJCveqnP2uWmBWGBJcsaJcf2nTuv2Ik1zSsdZ3h5Fv4VZN+OZMh3NtsNjUiWEAxzQZOOA5ua4abIyzFPgrIvISXcZIJTvOo69ghj+B21aYDd09Z1kOHPN6yHzoZU/mNcum2e9wuU6QIS20HSHA8tWrgMdE3rdte8qxna+K/NYn4OaPAa8q9faP5I44dHHAavkpq5lbCdRctGh6LtEJom7qE+PO5Gg4Dd8MpHcjFOdI9fae6oKhANueFLu2qSNnXSMc/zWzNPZOEH3ZLwMx2BDI2opNwmSy2eyu1U YzlWhLXz 0BocJm83ehu0gyws1HAxluP5qg9mTPqbLBpnmrctxIxwB4JJ6vskxcP1EPSsOLnobADw1e6H1oVcNLszizK35/HARQtvSkFl3LN+X+o/O2X4XJWLATm6ZpfRng03jkviUylfofD2mRk0bO02EuZXo272UZvukMH0rQhoAFwqu5MA5aA41RbxufMsH/X5qMD1BsIpt0HjlvkuoAv3jFfggUO5dzin5Tj1nBeM2tm2RhSGuXOeXuTmIFKxxDCxDG8TatwC9dD1lAR0/ntgCkPmSqizy+QMaGvKltADyymNuRdHfbWB8J89uS5EVU3FBThOtW3L7JDGLR503g4Il/oKadWkIRWM46F3HqJCb2NdMPeUG4u7tKhA7aHDvVyA0G2XSBAT1T5I6PX6Qq+NMyexfZj/Gzw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 17-10-24 09:04:37, Joshua Hahn wrote: > HugeTLB usage is a metric that can provide utility for monitors hoping > to get more insight into the memory usage patterns in cgroups. It also > helps identify if large folios are being distributed efficiently across > workloads, so that tasks that can take most advantage of reduced TLB > misses are prioritized. > > While cgroupv2's hugeTLB controller does report this value, some users > who wish to track hugeTLB usage might not want to take on the additional > overhead or the features of the controller just to use the metric. > This patch introduces hugeTLB usage in the memcg stats, mirroring the > value in the hugeTLB controller and offering a more fine-grained > cgroup-level breakdown of the value in /proc/meminfo. This seems really confusing because memcg controller is not responsible for the hugetlb memory. Could you be more specific why enabling hugetlb controller is not really desirable when the actual per-group tracking is needed? > Signed-off-by: Joshua Hahn > > Joshua Hahn (1): > Adding hugeTLB counters to memory controller > > include/linux/memcontrol.h | 3 +++ > mm/hugetlb.c | 5 +++++ > mm/memcontrol.c | 6 ++++++ > 3 files changed, 14 insertions(+) > > -- > 2.43.5 -- Michal Hocko SUSE Labs