From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 707F0D37487 for ; Thu, 17 Oct 2024 12:51:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCED36B007B; Thu, 17 Oct 2024 08:51:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7EEB6B0082; Thu, 17 Oct 2024 08:51:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C463E6B0083; Thu, 17 Oct 2024 08:51:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A61956B007B for ; Thu, 17 Oct 2024 08:51:30 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 25D91A12FD for ; Thu, 17 Oct 2024 12:51:10 +0000 (UTC) X-FDA: 82683080046.30.E0C8F5F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 75D1C20019 for ; Thu, 17 Oct 2024 12:51:18 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LC8oarjH; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of cassel@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cassel@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729169381; a=rsa-sha256; cv=none; b=M14agjnOJue1RVKrr0Ek4345vagMGV2J0dx66OxTMQL8ViiBRoqOZo4Ryb1rAUngCemXhI z2FwiqZ9E+DkwEIFYAnJY1M33/UOLGkfBmKn4hCAPS4zGGGuxxTIw4z8famVVGjmGpYY52 eYaLYXhxPZf/q00BSsVLWmxfP6kFdc8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LC8oarjH; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of cassel@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cassel@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729169381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uxZ8zRDQJT8AwJwuhReUV3OmU+i9cuOOJMkmttbiBF0=; b=xzxj6kIx+BFso9lCIhBhQj9AdKXm/Q5yQLTdrJl7RMegcYhZjSnRnsgTHfu0wURKYvSrNx v0cKHWzzVs5X0Hjg524pEdvmrP6beSIBC68ZGyRrIkqT/nr9VTfmrBToeQbNujhB97s5Gy OPbdX0ICt8UHw7AwlYclsY54Y2EFA2w= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 29CF45C41A4; Thu, 17 Oct 2024 12:51:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED8B7C4CEC3; Thu, 17 Oct 2024 12:51:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729169487; bh=5j15eT918xydVxHdlScuM8Z8O1RXoSCieKuyjdyfJhU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LC8oarjHlSAF5pidioTEz8bPBwH15OVtGZKJXtxJ95e3svqFYRi99yxVF/A8zkL5y DjEEcdVyKfl501O+clX8U8go8BtRfxD4WhFIm8g3NU/ABRdzFi6+21IMEnB5IlfDtQ oi+vSqPM/cMFPcCpe1DUy3UqoxALq7pcnaFNEHSkXqFnKjgId5RmGd05Wv3ZlkmMbH Qc6Kh3a0wHqlQNa2iCJ+tvD9IC/z+WR4bbOUmghaHKP+jACoq6Yt33nW4b3wGU192q ZC4FBPEDnkLi0rTQhAVKBdKtKuhMyrcvSXgCeQxKHL+rO/PotoV6iJ7FvWFvVqlCIe M+uqlEKscUoVg== Date: Thu, 17 Oct 2024 14:51:20 +0200 From: Niklas Cassel To: Ryan Roberts Cc: Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Damien Le Moal , David Hildenbrand , Greg Marsden , Ivan Ivanov , Kalesh Singh , Marc Zyngier , Mark Rutland , Matthias Brugger , Miroslav Benes , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Kees Cook , "Gustavo A. R. Silva" Subject: Re: [RFC PATCH v1 34/57] sata_sil24: Remove PAGE_SIZE compile-time constant assumption Message-ID: References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> <20241014105912.3207374-34-ryan.roberts@arm.com> <7aa84080-6845-496a-a394-30d334632298@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7aa84080-6845-496a-a394-30d334632298@arm.com> X-Rspamd-Queue-Id: 75D1C20019 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: pbh85h84x3ap19kscek5a5xisrg1f9m1 X-HE-Tag: 1729169478-993985 X-HE-Meta: U2FsdGVkX1+yDtDTjfVQE7XPZFMV774DBBRp8CE8Y+OwyscLCXKQ4han2FVYi+R0Ut4ZwRSKLT/cg8VZi94CtfP1AUzBh9CvZVfI5cQb1b1KhwLyZZ1z6k5Vf+u9dWWkUM7INHNv6DFlwSp6JcDy8cQ4Kkr6VkwSbIIFK7m4zLOAQYRst8W4OGCYiOR/1wgtO1UM14vcJ6u6BtoZOJLAnBENVJkf09yzBSYta++uvLKHwp9k1jNH0ozc31rFxsSozbpy1Kx2G3nWztxIJ6dMI3KG98pOP4GjSzxGcHoj8OBQCZCGxw+CA5NkZxze4wtEMuOp9L6pj70M/P4J+BXCpEitvZD2QO5ECmjU94ZAsCY1lEdZo/rbfKvG8ceZkf3Yc72MflP3Ch2bNyEGMP8cY/tAC+n1OlxSJlz04GPZdpsBddJaakM+7FE0p/kMStuKYd0kpeVBQgqFsLTPE612tB3zJOqdsaNHGWaqk6B3gPsKOJAt7wyYaHKj28pIv2jP0cOP2jGBTVhqfZaHbSpTUTwV6b92MqMUT02B2iNYEMX8sfnWQopOfe7/9ykMqkbR5cylaeKJBbJ3L+SXwWq4MFklW86X8rbR5tg2+C9CylRCFYGj8VqGuWDZk8Nx+imrrRbTeBp1cp3flsxPw7QObSrh+gyyvML4Dp/F55M8k/s+uUm2yA0GQ6koUG5MPh29jbKsNeTM5rE2xC+MepOeXTYUJWoV4wF6JzrJhHQAlHTpdJ0XYnaB67giJKHsCj1sZgJlPHcJaCKHRgpxOOXQPXQRr7xJ4VvhWVOlgtskODBr+YMGeUWtVOFlWoCbzzCl+J92OYH62oVqYZFian3MHoDh25iASycW3OGH+1aLMO1Gbl8ayikkqAmy9bOj2mvV0fJJesYSbp+vRA04Ac/39Bv15ohu8PG7tRLzNNfvuL6HFKF1pjVYTBshmzlYTT9J/pWG3hm2Dt9utWrhfqr FhexfSLr zLdTPdHqrd/ehFn62FaWPdfU52bjjkM/D6zoqiacFHKbwDsuqJE25YeswhVEE93sM3TbtO2RQvr9BVFEi60RNw8PmMKVR+1LBGLSXNLDFXUbA53FvvxdyWcvTllS4B4BiLFiiLgDHVBIgqJe3pkpWVC2hZBp+FI69gCc5cQowCp8oWJx6YCiZDdETNy/IaHuxN3I3fsmEw/Ua3zZn6mSSnlWytfdMsm+M28Oe7GCobM7GipttzCKOtox66p37LDwh1Uc4KKrBAxxoLVc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 17, 2024 at 01:42:22PM +0100, Ryan Roberts wrote: > On 17/10/2024 10:09, Niklas Cassel wrote: (snip) > > As you might know, there is an effort to annotate all flexible array > > members with their run-time size information, see commit: > > dd06e72e68bc ("Compiler Attributes: Add __counted_by macro") > > I'm vaguely aware of it. But as I understand it, __counted_by() nominates > another member in the struct which keeps the count? In this case, there is no > such member, it's size is implicit based on the value of PAGE_SIZE. So I'm not > sure if it's practical to use it here? Neither am I :) Perhaps some of the flexible array member experts like Kees Cook or Gustavo A. R. Silva could help us out here. Would it make sense to add another struct member and simply initialize it to PAGE_SIZE, in order to be able to use the __counted_by macro? > > > > > I haven't looked at the DEFINE_GLOBAL_PAGE_SIZE_VAR_CONST macro, but since > > DEFINE_GLOBAL_PAGE_SIZE_VAR_CONST(), when doing a boot-time page size build, > defers the initialization of the global variable to kernel init time, when > PAGE_SIZE is known. Because SIL24_MAX_SGE is defined in terms of PAGE_SIZE, this > deferral is required. > > > sge[] now becomes a flexible array member, I think it would be nice if it > > would be possible to somehow use the __counted_by macro. > >