From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C353D21262 for ; Thu, 17 Oct 2024 09:40:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1C6F6B0089; Thu, 17 Oct 2024 05:40:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACD356B008A; Thu, 17 Oct 2024 05:40:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BBCE6B008C; Thu, 17 Oct 2024 05:40:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7DA066B0089 for ; Thu, 17 Oct 2024 05:40:24 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5EF64A110E for ; Thu, 17 Oct 2024 09:40:04 +0000 (UTC) X-FDA: 82682598516.05.A93FEE3 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf25.hostedemail.com (Postfix) with ESMTP id C506CA000A for ; Thu, 17 Oct 2024 09:40:15 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729157974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r+baKPjRqEHbZsRnb5n0k6pdM9xZdZOA941RFIOxeqM=; b=y/ZiCIzWaApr9UKQfC4NeT04v8YS462n1yV0+LPByVGgSqB+O/fEtKv2v8hEZouTS/Pns9 afQvbdtLrBY7iJY5J0XOIO3c0sQUKQJEmJYUcqGBWtCNwQUsoVVfWJO34LLP7e6vrvEG45 SAxDzWLNnVMkCleBQN0PxGLjUj7vUxs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729157974; a=rsa-sha256; cv=none; b=JRTARAUAD3ic8ZxU6H6yI/uR98QX2VzsqGy4roAJJavkgvo2xlUbQwEuq59IWTFBaGi+ye Bvkw6Kil0nG2LiwmOMI+yVfhk1xFmtJpxxWo+08JiTAnaUO6IS6KgnWclfvwUBCeN9x8nY 0ntHd8AgJolqNcuSx8CzBVQycIXAU3I= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 9CFC8A43982; Thu, 17 Oct 2024 09:40:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25A3BC4CEC5; Thu, 17 Oct 2024 09:40:19 +0000 (UTC) Date: Thu, 17 Oct 2024 10:40:17 +0100 From: Catalin Marinas To: Pintu Kumar Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, pintu.ping@gmail.com Subject: Re: [PATCH] mm/kmemleak: fix errors/warnings for coding style Message-ID: References: <20241014183918.30123-1-quic_pintu@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241014183918.30123-1-quic_pintu@quicinc.com> X-Rspam-User: X-Stat-Signature: 1uk51cun34aysccegyxewejyi5j7dtmz X-Rspamd-Queue-Id: C506CA000A X-Rspamd-Server: rspam11 X-HE-Tag: 1729158015-671877 X-HE-Meta: U2FsdGVkX1/14pQ2EFGFhJ4trvZfw0cg9oBwxoLLgUgilydGOy6qusfCAStB/zucOrvl+0arO6ONw9/JtNnHECyl87B//A1yYmLjzC3tn6i2ENZjO5b7u5q1nXuCmhYn8rOBYrz1YzNS+kqpWkZ+rlxH3JU/j6OODt4+M1dLRN1zpwK2pug/pa9L6KkEiXSRT64oFbVykRuwSeQSDUSBHV9qzCkX745qhyXr6NyjgJhhQTwalzshmSYlKirgQ/hoM2MWxqZpA82t7Qm1qUwnshqBiZQ/x1iVZZ3HHIytKuRhMtLZBAndPwX+zeBTDuCgrXw3OxS5J2xZf00y+CIZ/n14V+LHA83q1VY7g3ion4FU1eEpBMBJXI3yIyJQOO6G+GDkor+k+JNj/XGqA5Q632nQlOTm2af4vGweJgvj/lSusToW2BZehj8xvLuYuHjgHiloS9sQsmTASMy9oF3ukCj/8x9Sz2TymSqc2bAsMNB4+r/Wn1ieNLXkJJu2R764/RO+HdZ91OqXW72VFr44Y8HJowV2NByMbSC/6C4d+BV4DnAgfpODAAqDST9CpG60DKLucuWxTRYgu6Q3TISAC1aTGpmsNx7illRspMpk+yRdXG8xGhq59X1aozDFXcRl45D69y3fjc94PkIJUL9ByCMZMRHGHNaihYYhvPVpiTRt3OPh4I7RjNaubPkRnMBZSwoTdv0w80rLmoWeW6DNopwyBpeP9mWJhCZvIWDKlUfjhnkM0G1ckf5h4I+re53SLvXbu1hE0vtiHZWcbFHX3lGPYOaYCl81Zx50rf85/yQ9xZmSQJUPvjaJZUDpUv4sS9pNskvWRleCSgcwEeKolJC2X/xqcWoi9so4nF8Y6O0U7zVeNzpFqt+zprzQ5I7f3JpQxhQfYsnlAUxUnNk7ChJxhWXkVo4CyeXOsP0UfTByqd5dLFiVF7I18C01KrYuP5AvTnFex3sifSn/L5B bwOzaMaf EDSmJZXVgjGXkwlMdPz8XtqOPIUx26MmD+Apr4lkjlW5aMBwMuPcZlQ9VYerp84jPaUgahZAG/Z1zR7VvHlLB2xERo/wc/wyOcvwXzUMVu0oGDlKPYdWJoY/QM5KzJ0XUyF1rfrwFaYkQZLlB7rkqL7b6k2rEqymFDh2cLUQ/aBR129+NNBlh71RL3hi/277/5oetD1deaC5VxLqd4WrUE5hNAFiexv+2mNNg9A3NgDL4dYfltzcF12StqLin3NydgokboVH1OiM9jZaCJGP/Mvpj1zd3TkfvlNBxpYkQ/p3ZrVOg5Rn7lY0a04S7kkGBa9UD5Zcs+ClT/rGkt58mKHYKDzHJLwHrIIovr60vsEPUPbHBFTCdokBC3Sw5HATu0WEoefrvsQA7agpYFRT5iyEJbUpRSA8bqOxu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 15, 2024 at 12:09:18AM +0530, Pintu Kumar wrote: > There are several errors/warnings reported by checkpatch. > Fix all of the positive once as below: > - Use #include instead of > - Missing a blank lines after declarations > - Prefer 'unsigned int' to bare use of 'unsigned' > - else should follow close brace '}' I wouldn't bother fixing up the style in existing code, it just makes backporting fixes harder. > @@ -2179,8 +2180,7 @@ static int __init kmemleak_boot_config(char *str) > else if (strcmp(str, "on") == 0) { > kmemleak_skip_disable = 1; > stack_depot_request_early_init(); > - } > - else > + } else > return -EINVAL; > return 0; According to the coding style doc, the 'else' branch also needs braces here. -- Catalin