From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7779CD2F7FA for ; Thu, 17 Oct 2024 07:37:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED69C6B007B; Thu, 17 Oct 2024 03:37:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E86786B0082; Thu, 17 Oct 2024 03:37:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D27026B0083; Thu, 17 Oct 2024 03:37:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B53C66B007B for ; Thu, 17 Oct 2024 03:37:11 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9DAAB41117 for ; Thu, 17 Oct 2024 07:37:04 +0000 (UTC) X-FDA: 82682287926.06.237E64B Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf14.hostedemail.com (Postfix) with ESMTP id BEF24100004 for ; Thu, 17 Oct 2024 07:36:57 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=UjTR6QP5; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf14.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729150510; a=rsa-sha256; cv=none; b=U+HlLhIXY+JDuV5NhK2yov6+AA1EnNeegJ7Q/0fLNq6kX/iuFfADrrEE0HQwEs9tjXkUr3 6LBLniIuHLdrmFGb58UnQDy6uvltwybdOO/PdjapyiYoMmf+oIy7iLGK2ORCAnZ6/Dah9Z 0ymEBCZKpO1CAkmwwpxrAq8zeIsagR8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=UjTR6QP5; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf14.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729150510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CCockiiMIdzXFF10k9ecjz3T/PBTZFsqm9mtgI58+4o=; b=Kvj/thMZt+c3hr8GmXxVKD15C+nvS3QIPExupERMhH14fg0pG/luq3zP4Y/4vN6q2O2k/b KrTu1oO4FmhM5dDlh68LLzV1YWvnvUDkBALoLRUhUMZraWreE6SHBzid0VO/BbV11F9ODy l9qTJvtWeyw6oa6Mysoq6ZNXlQqWogY= Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49H1tltB028414; Thu, 17 Oct 2024 07:37:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=CCockiiMIdzXFF10k9ecjz3T/PBTZF sqm9mtgI58+4o=; b=UjTR6QP5gdttKteJTjOOPX61PMn5doVH66+queNczgz/vK YOZb36GRkMUBNOrjzE8wt4kakW4grWrRi+8NFe9UwJFqGe8OzbS1y48PNu/uDu4Y FFf8XFchFn+bJ8MS5AgeqG4KS8K252VShEjBHc/sZobnNM+zRTIS6xioyVJWXHME gQPjwAun2y2bU2wABSIrWHGWktprvkSvDA2bDTid20KRK32jXYULZ8rcQ6eqtKum 9toCtOb2X30ovGnILNh3+uuf+WM2y/VgQ9XH+IXXqJkdDkcpGtJo/wfGXrl5ZqJv Egqgvz/Rd3G+zEpZudT/lsspmRxWWycaWbHctrrw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42asbd16cf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Oct 2024 07:37:07 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 49H7b6Bg020668; Thu, 17 Oct 2024 07:37:06 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42asbd16c9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Oct 2024 07:37:06 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 49H6AHRq006401; Thu, 17 Oct 2024 07:37:04 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4284xkde73-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Oct 2024 07:37:04 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 49H7b06D18809164 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Oct 2024 07:37:00 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 870CD2004B; Thu, 17 Oct 2024 07:37:00 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 804AE20040; Thu, 17 Oct 2024 07:36:59 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.179.26.155]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 17 Oct 2024 07:36:59 +0000 (GMT) Date: Thu, 17 Oct 2024 09:36:58 +0200 From: Alexander Gordeev To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Morton , Jonathan Corbet , Mario Casquero Subject: Re: [PATCH v2 4/7] s390/physmem_info: query diag500(STORAGE LIMIT) to support QEMU/KVM memory devices Message-ID: References: <20241014144622.876731-1-david@redhat.com> <20241014144622.876731-5-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241014144622.876731-5-david@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: I8XjFklzuWznK3cD6E4X0sa9LCHD5Rtg X-Proofpoint-GUID: bnb60nF_oPjDqifw1vM7LX54XpsdFO6s X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 phishscore=0 mlxscore=0 clxscore=1011 adultscore=0 priorityscore=1501 mlxlogscore=535 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410170048 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BEF24100004 X-Stat-Signature: m5ijft8w119j4os19a8f9echerze4ej9 X-Rspam-User: X-HE-Tag: 1729150617-145188 X-HE-Meta: U2FsdGVkX18f3k3hdqSo3LWQbi+pjuxeQchhMYnrPPjDPjTKeCWg/UIPaU4bSw+QuJj9SJMwUPNE78ggtuZt1JUsxVLCqtIARGS4mX18KqR9Nd6MPGTPiSXYl97ho5Fvd7JA9X+XiQEeNDm81jrRBd9z4EsVVUChoO/5BhYK6mia6EzaZ06XLKeoK/g5VMk24KAToAVAT4ZIcCGJ2m6MG72G0IDKRxKJ+prA60zTP8bJMtMX0EXbRQe6IQ/iiuZd5vk76+7S2oCrUBAJc80Wt5/vP/WfCMQq2RCpU9V5I+sFZVAry+SNQ9cb2R/940f4a821KBMS8aWDTtB0bMppogSscNvAIDIyAwy+jAmeiImprBS5Dj/ObaZTG/USs3ylDKqV21l2wpD0LEAAhkEh6ti9Eh9hhaH3vo4mOn0nMbmR0vsLpeHG0cTBywlR9BsQLbHFWGszRUW65I1AebpZTvQS/7nPlNruzPOsui1KeqhDu4dH1Wk+90fmGLA9yuGhTY8kDU5X0if7KKenjPY84bLv8EhL0kyh1D7f67AdfMXAT355DFO7kzF5k3yIZNxthbL99jzaw7+qg6ZdahU+c04fol/0RoVh9XYG8C4dNT8rAkTN0uL/HP1V+rUBeunz8gO5YuXp4FfcKfO2BLWDSnUEzAucx1EStBLsqoueKs7fX/OItjgEV5kCUQ/albJ2sCjh9QDgTFNljy3yGwu2/8kxFH1y8dKBxmxcQVsx5Zc9TyrOZqe6MYpPJtHsa1KHJdJUTU0PmVxbxZt1ltHu0wqALP8h0517L7d7Hw5nWyws7lKnMWE8wxnItaVBefWoXk9dM5iAq3VQ9cCv2Y3oN/1nkpMg/aEHBGdkippI6dJD2oQ+MKHxPBGpwkdMcqxHqCDxeic+cK9KdgQKc+EBJN72TgtJLFrFzgMQqhRSz3PWpaecNgoQxx/CEuVmRC7DRFdXfZOss1CzwEQKNKb jumuedF+ L954ugFclakzbdlErZbhWDfqYbRT0Vj5va0nK0Du4g5gZbgvIfEXviYVlGVO531U71P8PfZhPnNmSeABV2Q7MZP7HnzZlXxiZP7Gpg8rYzGkdx7/azO8c3KTPg9OnRa8T1xGXjT+1HKW8PfDGCIV3S6HmMrkrMzS5fSgaAsbjIZqjTnafJo+BSiG300zQ/TIQFm1jC5BfPfm5QfrYLEkveYXG/Mz1/FOQOa8mjn7QkW3GvzKAw90nXWYXeL3GA9CeeO5jEHCs6W8eUamidVihIIPBXQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 04:46:16PM +0200, David Hildenbrand wrote: Hi David! > @@ -157,7 +189,9 @@ unsigned long detect_max_physmem_end(void) > { > unsigned long max_physmem_end = 0; > > - if (!sclp_early_get_memsize(&max_physmem_end)) { > + if (!diag500_storage_limit(&max_physmem_end)) { > + physmem_info.info_source = MEM_DETECT_DIAG500_STOR_LIMIT; > + } else if (!sclp_early_get_memsize(&max_physmem_end)) { > physmem_info.info_source = MEM_DETECT_SCLP_READ_INFO; > } else { > max_physmem_end = search_mem_end(); > @@ -170,11 +204,17 @@ void detect_physmem_online_ranges(unsigned long max_physmem_end) > { > if (!sclp_early_read_storage_info()) { > physmem_info.info_source = MEM_DETECT_SCLP_STOR_INFO; > + return; > } else if (!diag260()) { > physmem_info.info_source = MEM_DETECT_DIAG260; > - } else if (max_physmem_end) { > - add_physmem_online_range(0, max_physmem_end); > + return; > + } else if (physmem_info.info_source == MEM_DETECT_DIAG500_STOR_LIMIT) { > + max_physmem_end = 0; > + if (!sclp_early_get_memsize(&max_physmem_end)) > + physmem_info.info_source = MEM_DETECT_SCLP_READ_INFO; Why search_mem_end() is not tried in case sclp_early_get_memsize() failed? > } > + if (max_physmem_end) > + add_physmem_online_range(0, max_physmem_end); > } > > void physmem_set_usable_limit(unsigned long limit) > diff --git a/arch/s390/include/asm/physmem_info.h b/arch/s390/include/asm/physmem_info.h > index f45cfc8bc233..51b68a43e195 100644 > --- a/arch/s390/include/asm/physmem_info.h > +++ b/arch/s390/include/asm/physmem_info.h > @@ -9,6 +9,7 @@ enum physmem_info_source { > MEM_DETECT_NONE = 0, > MEM_DETECT_SCLP_STOR_INFO, > MEM_DETECT_DIAG260, > + MEM_DETECT_DIAG500_STOR_LIMIT, > MEM_DETECT_SCLP_READ_INFO, > MEM_DETECT_BIN_SEARCH > }; > @@ -107,6 +108,8 @@ static inline const char *get_physmem_info_source(void) > return "sclp storage info"; > case MEM_DETECT_DIAG260: > return "diag260"; > + case MEM_DETECT_DIAG500_STOR_LIMIT: > + return "diag500 storage limit"; AFAIU you want to always override MEM_DETECT_DIAG500_STOR_LIMIT method with an online memory detection method. In that case this code is dead. > case MEM_DETECT_SCLP_READ_INFO: > return "sclp read info"; > case MEM_DETECT_BIN_SEARCH: Thanks!