From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21CA8D13588 for ; Mon, 28 Oct 2024 05:30:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A2CF6B0085; Mon, 28 Oct 2024 01:30:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 953746B0088; Mon, 28 Oct 2024 01:30:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 824606B0089; Mon, 28 Oct 2024 01:30:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 665496B0085 for ; Mon, 28 Oct 2024 01:30:34 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D9CD94070C for ; Mon, 28 Oct 2024 05:30:21 +0000 (UTC) X-FDA: 82721885106.06.102D084 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf10.hostedemail.com (Postfix) with ESMTP id B41FAC0002 for ; Mon, 28 Oct 2024 05:30:21 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=bpaF29GH; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf10.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730093316; a=rsa-sha256; cv=none; b=lCj+1Vq90N1/3+u6I6ouyCiMV/TAM6mtykw/BCNDwEPWsh3BaoSIHttxjXSFXiDakhuimv LwXerABKicEPuLjhJkN9xLAohc4mn3N/d37ZC5T+5Jy8iYDtQn8kT4rRRGdZ51Gu8binj9 k/EVT9kucG3kQ3zKLpouMbq+C8m9Db0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=bpaF29GH; dmarc=pass (policy=quarantine) header.from=fromorbit.com; spf=pass (imf10.hostedemail.com: domain of david@fromorbit.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730093316; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V1YSOeVXzEwF1sm652ZwAqo5z9JPJsNseJdyz5eSkEs=; b=UNpD3t7UTU9ztFiccA2BN8jG+qZ2grbXuM026+f4uC4rHrHSpzBCBjGjyx9G6Aj/By7/Tt jeRfbwCr/buy2Qxz0MbZB9BCBVQFlpaqmz3ongwhs43w5NXo4ENkm/l/p9oslu7HiQ6V5n Kw021Qnjjn8JGEAoQc18zRSGMryQdiQ= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-20c714cd9c8so37245165ad.0 for ; Sun, 27 Oct 2024 22:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1730093431; x=1730698231; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=V1YSOeVXzEwF1sm652ZwAqo5z9JPJsNseJdyz5eSkEs=; b=bpaF29GH/JWhKQ7g7Lx3I90gQf7yMH6bcOYjjAO8Pc0ZKHgP+x4sDfuf9C8Hfm2Rsm VY/xbcHdgZus3IM23mneHjmLf/jlk3TyIqoXBBKR/I+ENJpZiUvnJIoBoIl04l5ye2+m 6KS6CXl5fIKksa0ANyCX4rjyeb+I6wS2OoP9OUGLRX4We71lp79aUqLK9trmLHFLMnKx Ihm7VY2fWfyBllZUuTlPYzN4Q8lfOoDUi+MmpzWCqzAVj99CU8m+oHs2prb7Kw6GePU6 43clxrH/uUnr6xDUiWzEwwCSLM67gLyH+SEJHFi3cR7YBJViH/WU0KMoqq7xZ9zbEdAT jGEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730093431; x=1730698231; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V1YSOeVXzEwF1sm652ZwAqo5z9JPJsNseJdyz5eSkEs=; b=p6JYVCni8v9cWRdvIc8759bS/qlL9SfBA8lqTYsAKjFlI/0zl5QCkknvMxnwlIiQEG BXdkKla20LxKefVwjd/n1mSQ+WDPwNSYMO8EfLJDy3hX0ft8/2WLfR/kACchgQ7VKwsP iFtjM5G+zyVkc3PugH010naMRl/8JvljVoU+y6gb9kTADfAETc+sEo+Z0y6hmSUEad+r 8vvRXiiWHEggGdo2n4BmNx0Y9WSk4aIFsjyP/iXzKqZXytew6d6ufWTimy7jJ4lIK4kc F+NqXlyQXmG97vx+8fNNe8UlhEaPtR9dObGKmvpzR/zi+qvlWiP+MYZk15G3R9h6hmhv Aktw== X-Forwarded-Encrypted: i=1; AJvYcCUu7S1bG6O4pkTOGNAs3PDWvAabxlq8LfKSR91cX526VNYARbnIDMlx3bedFaCeZ9mr2yAuTDyCYQ==@kvack.org X-Gm-Message-State: AOJu0YyXJu7NwjloBopSygGKhvGS53fYYB56V0pS6WocEPC1wzI35WMK NZ8TxIytODCIEEQ7oMaex11YAfM8eNuMw/4hNyApT90fJoTV3ktpWR9XSIWHKpk= X-Google-Smtp-Source: AGHT+IE/Q+7tT9+yHYQZQbf65R5+ohgNP16VI/zt5o1urAhuVw7IbOnCCkLes/ksFMkDVDZUTrEcgA== X-Received: by 2002:a17:903:32c4:b0:20c:a1a3:5373 with SMTP id d9443c01a7336-210c6c90e6cmr92968105ad.55.1730093430690; Sun, 27 Oct 2024 22:30:30 -0700 (PDT) Received: from dread.disaster.area (pa49-186-86-168.pa.vic.optusnet.com.au. [49.186.86.168]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bc0133cdsm43303065ad.154.2024.10.27.22.30.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 22:30:30 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1t5IKh-006mqT-2E; Mon, 28 Oct 2024 16:30:27 +1100 Date: Mon, 28 Oct 2024 16:30:27 +1100 From: Dave Chinner To: Chen Ridong Cc: akpm@linux-foundation.org, zhengqi.arch@bytedance.com, roman.gushchin@linux.dev, muchun.song@linux.dev, anshuman.khandual@arm.com, vbabka@suse.cz, kirill@shutemov.name, linux-mm@kvack.org, linux-kernel@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Subject: Re: [PATCH v3] mm: shrinker: avoid memleak in alloc_shrinker_info Message-ID: References: <20241025060942.1049263-1-chenridong@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241025060942.1049263-1-chenridong@huaweicloud.com> X-Rspamd-Queue-Id: B41FAC0002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: eg7c7j65rq8wqz1jwne4haosw6n9jhoz X-HE-Tag: 1730093421-79051 X-HE-Meta: U2FsdGVkX19+T43AGVrFnb7B3iN4Jne2qBMQ8i64OYm1IEK014+7/V++U59885yzbIX944M1oWbNEviyertRTcPArY1s8YFafwUyGgwzEk9OAz2L/0LUMAuCVUbeNc4EazAK5HRUR5pajyGZw267p2NlGro16HGpAV+OrMuz37qva+5pGy1UhqBPFJ5HE1e71SdaYrNWz5UFcQWkVUS2jTqZ5twMIIQzKQo8cMPjj/wWzqWH0hfeQ7zSGpI1PWRTYzSMKAC4lVko340bBAH9qacTfnpGdeN4gcwz3mmBgkZpcO0C6CTtiMdHIifuE/LXig2DTe5ErC57QfIvDgdaJI18uuly6Lq8mdYD3/VqlKZYvsE6YAftNBZdJZ75Lbs4TVOYDMnj7JHnjkrA/Ubowof3i7oFzT3BaQA0E7wvBbaWbVwcEe6CCy1eeWeiIaYxLscItIluSS+cFn9NkHZRyB0NL25QKvGIRDrHMeX5257Yyr9jlEJkAKSTDO0RJ0+rxEUsmfjKFptF6iR0HIexx/NaxpPnYV4jxZJ/Akg7JtaJtFtQ3+xu2KJj7uCTNRv6DbdCFUryFKFGj7VoiBfPjrx6yKHjPLqUp7xofNeU0z3+JAAtw272KJIoeoQzNnLC0t8O40JnHzO9WjahEHUtnQ77SaZB03BTpvQjb8qAjXM8zv1/yzMB2mpErANJvqBtUKklPQgjF1NUeqSF1aVlDmDH6lDnaap9IFlEMdi3U/6r/x4p5tWIlsrnp8JW1oIGnq2jrugBvqCOj9sb2TYDJeMdGhFgDdKVXJcubNml1VAtM4HNFx5aKg8woHJyGWg42pbGLljHCss6EpdS7ULzBipfqTlRysVmypL8/Sn0FKynKP5Lg95B1C7CWMkOy1d2ok3B/t4rQgvfg8BcPwbqyL5WJTzA3YkgfUCd8niRm+OoBPsT30mIAH8NjlXT6xDWn/VWRtny/DfKvAg1Yf0 0u+v+n44 syRWGhp91wQVRkxXKPhIv21bmwac/o3xgoy2xNWEKJPuofJwrqo5bKCtpZV3lfMv2zgBRHokOcCsTDvGQ2Zyyn3fopxz4apagVn1ydiFC621gbjI9FnlhLyOEi11I0Qty2Z0cEe+JaHbmH29UWRn7NxaGp82vI7iFwCJXKZ+OSo3uH9MIXdYet76UJV/wAvbKsdOOuDubdUkQ/dTI8qTXw7oDfi+kj7RNRMP2zYKN1+0iyGPV3hn4Nc4tZ5IoQjCbgFpog1Z32nJ8BFnt4FSrW2+aqHixWZBLEB1nBg5WsysJJwK0bTIR0AliE9NNXm6cpMozcexgm8zBi1gjW60vjUXZcRQ5imzE5so6hkykvW4/oV6dbsD+/InPpiRVmrW6uqD5+nqQKMlQV/eRiI4xua2RJp/sbbvNoXFNrDfXGYqg6pgjtmpvZ5XLJ2JFbb1CGKTwrlOpgYxHZfaoYeEbEfqfx2GOl2/mhLY6YjcdvK325e0tbYinzFQz2BMCbHG0CS2R/EWyg+RVQnCQbjDeK2tnmA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 25, 2024 at 06:09:42AM +0000, Chen Ridong wrote: > From: Chen Ridong > > A memleak was found as bellow: > > unreferenced object 0xffff8881010d2a80 (size 32): > comm "mkdir", pid 1559, jiffies 4294932666 > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 40 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 @............... > backtrace (crc 2e7ef6fa): > [] __kmalloc_node_noprof+0x394/0x470 > [] alloc_shrinker_info+0x7b/0x1a0 > [] mem_cgroup_css_online+0x11a/0x3b0 > [] online_css+0x29/0xa0 > [] cgroup_apply_control_enable+0x20d/0x360 > [] cgroup_mkdir+0x168/0x5f0 > [] kernfs_iop_mkdir+0x5e/0x90 > [] vfs_mkdir+0x144/0x220 > [] do_mkdirat+0x87/0x130 > [] __x64_sys_mkdir+0x49/0x70 > [] do_syscall_64+0x68/0x140 > [] entry_SYSCALL_64_after_hwframe+0x76/0x7e > > In the alloc_shrinker_info function, when shrinker_unit_alloc return > err, the info won't be freed. Just fix it. > > Fixes: 307bececcd12 ("mm: shrinker: add a secondary array for shrinker_info::{map, nr_deferred}") > Signed-off-by: Chen Ridong > Acked-by: Qi Zheng > Acked-by: Roman Gushchin > Acked-by: Vlastimil Babka > --- Looks fine. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com