From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0523ED33990 for ; Mon, 28 Oct 2024 14:43:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CE436B0089; Mon, 28 Oct 2024 10:43:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87F4E6B0092; Mon, 28 Oct 2024 10:43:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 745B06B0093; Mon, 28 Oct 2024 10:43:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 584A86B0089 for ; Mon, 28 Oct 2024 10:43:28 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 192A41C2568 for ; Mon, 28 Oct 2024 14:43:28 +0000 (UTC) X-FDA: 82723277700.20.C11217B Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf15.hostedemail.com (Postfix) with ESMTP id A7DF2A0029 for ; Mon, 28 Oct 2024 14:43:02 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ukWBd9Ny; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730126448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JecW0NEIDa5IBhwNTUvDvDfFMkbe/JopkKPj1lEcGNs=; b=IsXMh9vm+MYI6rYoKBxaLzVuTNNDc9J94ZI8SvV8bwtU12QeJAsY17ZjJPu2UcHEif+keD V8omlACZpo5WQ7xwLdSgR03qH8BGIl33M74IO9xlvIdcNV9pW/vQXXCd449+LHMSDAJ8Om MGG6tMjRbMAJSlKC6e7OGSHZoS8PDVw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730126448; a=rsa-sha256; cv=none; b=bwTwywjsjFeonLX5kucB1Nf48G1uE5aG9ZBEmr/E+DaH0DlqoI0G6Fpym0YxVYwPL0OafL VtMJU066iS6oKEsjXokm6is4hLukOIA2mqVuUaZUgZ9wiCodmwyznOgA7+VNiwF68mfgw7 h6WwJsWIbmFzaZcYyA/o3hc0Irig6OI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ukWBd9Ny; spf=pass (imf15.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D9FE5A42548; Mon, 28 Oct 2024 14:41:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59972C4CECD; Mon, 28 Oct 2024 14:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730126605; bh=LLw6rtm3xObAOtcw0EBxdlEoBK22y7ghA8CXAj+UVoc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ukWBd9NyZSQpUKXgbPo/Idj6rFOjB6/8MTKn26QV2sWtwBkY/+mLLVJJcwrEIXKXt U1ux0Qr5DKLGh0Ew8vBHPfsXhbZqP9Cb7VI4oQhh/E+UKqNDwBmpH2nJoMvlaFBclk AJeP4dAUUQojKV5AnzEkXPK4uhRTqI3QE+DtF0B5OpEN1sVeISMZUR/7qapA7aIITX DQt6WCbBpx9CLebHbENvpyMIFvnGY/urFx/Wlr6kAehwsbM7Vnx9tpKh1dlWHPjxse 3vT+CERepl6G9RSDkjTQao+6EyfcJX7ydewCpQktnry8K+mQuFXIpdeCyTTIfKdb5s OleP0oryI2Edg== Date: Mon, 28 Oct 2024 16:39:33 +0200 From: Mike Rapoport To: Arnd Bergmann Cc: Andrew Morton , Suren Baghdasaryan , Pasha Tatashin , Arnd Bergmann , Luis Chamberlain , Song Liu , "Masami Hiramatsu (Google)" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] alloc_tag: hide execmem_vmap() on !MMU Message-ID: References: <20241028141818.622917-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241028141818.622917-1-arnd@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A7DF2A0029 X-Stat-Signature: i64wc7whpeo61cqnnabk6z4pd78dat46 X-HE-Tag: 1730126582-636286 X-HE-Meta: U2FsdGVkX1+MFNA2NZaxQ/VTxTh9YHVLqFXoJEi9VkbgtmrCNr6Ho2N+p3uKxKsas4D63lBf1fVDg/W4M4h8kL37udtI+f1w7e/b4lrKMV9eSTBNBUxBh+4rAO7e+cXqsc6ppHg/h5LCtR7t9UCjXAMjNF5a1vTv2WTdJyVyIMjNXMuKkcfRECcJ+yr04V/AHUG7cgOvksk6o4BG/XaD98ese7nQMo0Gy22PN02dneDLZu9hnuEnG+dH6h38imKAvjgCvAGpmHHAFG9Vlev3yxsf5lAR/t14Jl8A4J/pP5bCU8NL3eDllBENR4UI3EViDfC/cD3N/OJMA/u02HO8uhcphwHivg11ptC4e38Ima4lrHTFwtXz5UsB7knXGwHbDJ24dBpquuRE4An3DT8lygdOUlKusfcrhPIN2OmIKgPq56NkzNdVDk7oKYk+qnzM+G9SFnKqwWn5blDZrU9tb+6oIAW0/e7xPvreV/39w4L1/VVk9O5+jYOtkUX406QoBTSXZgNkCnlTRFyj/ytWi76HBl2kQ4hfL+oid8V8q4QqTJ+xED8eyKJfZLg2fOXTyoILfymqNNtr6pN/ZzzlC5RNRgWNgX+fkBtukVorGkCpMZwLZQ8+3DPgXdOVQ29r/+O1OKZUMfMtFeBbdiSd3tgudGuOzIu1VvPwyykGN0kb9JwWy1XEg6czn81zeLZoRqm2dwPE7hJLU9N73i88zIsBMQUNE9wpEH8ulZS7ygYigggSJ1BFYg9gjNt9ptCJEYGjlscDnVBkYUk5OMqInXGMC/jrQdful07tzjJ9rzGSffcmcEYh1jL7vhH1vMSY9WgGMYzTiiPZrcqHCt+HR8VFQINaEGgjm62eMvao1lk5Oj1/K/e+I/tE99dNfv3SjYdMOV/nuSh0urSY6p5TbxiRqlI6IomuMhCPhyIuDwcBpSc84bfqmPS/kV939ljkF+kNmXV0KemNP9R6mJL thJeUkIo TDTBJbf6bMdncmNWDX+KMyK+jHI9tuZFDQnJoXQjdJB2EL07+eYkB1MO3fe/tOywrLmBAAwz2sYmHd4nDsjtQPp3YuU6i3nUHfLYF2zFXdWfKMBlev22gjXxON2Q2AfpdNgzyozMNp1HD6B0/WeQfudbWFVMDLTwBpVnLij2+DHlZgrYaxPUUwB08GRRlcX8gS77Y+NPfZ/C8iqWBz2SyJGpS8HD2HQMVKxcGpcL2ovGjnkkqWTtzVqcmMZK25sVyWJVQVrRe6BxpPjuaNSs5AaEKolxefdo4ihJSkUo1MQ6vmp8blC4qCqNsrnZoOhPSCIw5Mw6QIOsI3ufDouXVI4z7Lhgjs9J+dU3w8cDMA5Vf5SY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 28, 2024 at 02:18:09PM +0000, Arnd Bergmann wrote: > From: Arnd Bergmann > > The newly added function fails to link on nommu kernels, but is also > not needed there: > > ld.lld-20: error: undefined symbol: __get_vm_area_node > >>> referenced by execmem.c > >>> mm/execmem.o:(execmem_vmap) in archive vmlinux.a > >>> referenced by execmem.c > >>> mm/execmem.o:(execmem_vmap) in archive vmlinux.a > > Fixes: 57bc3834fb6f ("alloc_tag: populate memory for module tags as needed") > Signed-off-by: Arnd Bergmann > --- > mm/execmem.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/execmem.c b/mm/execmem.c > index 5c0f9f2d6f83..b04cfece7356 100644 > --- a/mm/execmem.c > +++ b/mm/execmem.c > @@ -368,6 +368,7 @@ void execmem_free(void *ptr) > vfree(ptr); > } > > +#ifdef CONFIG_MMU > struct vm_struct *execmem_vmap(size_t size) > { > struct execmem_range *range = &execmem_info->ranges[EXECMEM_MODULE_DATA]; > @@ -383,6 +384,7 @@ struct vm_struct *execmem_vmap(size_t size) > > return area; > } > +#endif Nit: there is already #ifdef CONFIG_MMU block in execmem.c, better to move execmem_vmap() there Other than that Acked-by: Mike Rapoport (Microsoft) > void *execmem_update_copy(void *dst, const void *src, size_t size) > { > -- > 2.39.5 > -- Sincerely yours, Mike.