From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 224F0CF259D for ; Mon, 14 Oct 2024 05:56:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 203AB6B0082; Mon, 14 Oct 2024 01:56:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B3E56B0083; Mon, 14 Oct 2024 01:56:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 053D36B0085; Mon, 14 Oct 2024 01:56:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DA8C46B0082 for ; Mon, 14 Oct 2024 01:56:08 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D56CC80B7F for ; Mon, 14 Oct 2024 05:56:01 +0000 (UTC) X-FDA: 82671147090.11.C9DBBA1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id 4A4A640010 for ; Mon, 14 Oct 2024 05:56:02 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=UPElqyPB; spf=none (imf12.hostedemail.com: domain of BATV+f913630adc52fe272e7a+7722+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f913630adc52fe272e7a+7722+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728885224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Go+Bj6RO5KoE/9AfXdF5E8AJBwbpjnqmhBNe3btI6Rc=; b=BnKCvC6v98npM/NpeilN7gMIWdBGmKucoFrKr9ljdiUXvRTPPPIz85QbeEY2dRNPlW9O5Q MROLPbEBNo0qhWOdz0054MbocMq6nlVZ66BySvKfWJx+GrzNWeykpctGp5ruBR1+Qo7cEO wfCw+w5Ti2JQ76k+b/B4MsDkAXb0x9k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728885224; a=rsa-sha256; cv=none; b=Z9qrbJiQ3/+RmVpREBgWv8mJMJQciCMCb08dYMqldUuwrdp5Yc/6Oqze6NGhuz777oLHLJ y1iI6V0c3xeSg/xCpNNvhlepByoSdAKdxIJzHfZwvBQ+Jl/ODEdSKjcasqQ6E7e63hpN9r pLlGsElsqasZhf62lW/naqQmy5hB+ps= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=UPElqyPB; spf=none (imf12.hostedemail.com: domain of BATV+f913630adc52fe272e7a+7722+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f913630adc52fe272e7a+7722+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Go+Bj6RO5KoE/9AfXdF5E8AJBwbpjnqmhBNe3btI6Rc=; b=UPElqyPBVcONi79QDgqannuJ8k ekzP13+lCLTRhjd0RsBuUuriQn6L1+7+jerZ1u5Al3QyEt2FMS6WglOqiIYRCPC95h6PrTwqF1ts1 PWmrnzZCq2mL/K2dLXqaDd0RIfbpc0hidVHfW0hcI22NMksrAuiLCJAmBG9DiAs7alHiLyDNNsuur 7HBzQHoIIH7RZPA4xv39sBtQ8TSlScwbjH674t/7hgNk4DsM7Le91HXSmKrDHUWLH9r8jJFF0mMPK mItE7VNi3UiGgVL10orTJc1Q65Ko0/nDG04GKlm2B+fPRKXh4xsGm9A5xgah8WKUspiWy5w5SGuhw kNW8vO1A==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t0E3B-00000003o4s-2PYe; Mon, 14 Oct 2024 05:55:25 +0000 Date: Sun, 13 Oct 2024 22:55:25 -0700 From: Christoph Hellwig To: Mike Rapoport Cc: Christoph Hellwig , Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages Message-ID: References: <20241009180816.83591-1-rppt@kernel.org> <20241009180816.83591-8-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: 9dpm33o3533zjj1eddpuy5e8gy5c6ndi X-Rspamd-Queue-Id: 4A4A640010 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1728885362-936840 X-HE-Meta: U2FsdGVkX186eI6r4845cfw9lPW7+tDFh7SS/wsgW8yexkWi91bEysrbgGb8JnaUm544a4oYQflNFER7smYk2dBYK2arMymQdqFL+QLvhAe3Szc+XWZG3waoe7Ktb0wnSb0UQ+aKTmXtt/SOJCt69anl0aWwhKq+Rogh9xmX5msy/GmBHl+ZH5hTDaBehchoXqWd+YMd5n5Rq8sbES6ldoP4agY0Vo+yPhhN85n4enWAyQDfEF7hHZCkrIga0ZCIJgxROffYIH0Bq1FX7+CS97YimLuAVhlQbrOro9IhKB+u3dn38L8zZqce80RwzTYKfDNjR5QLXlq1S4c14IZ000IUzcI7MjpGMCAUlVdKo1N0BYSGNiN5nLxP9dZKmY5vflehWzCm4g+j5QzEpwihR3B1h+QHDoNvO3af1b7OaE4iSub6cs46jYXQY6Th54a0p82P49i5qY90OXZpd/aoyl1ss1TnNFsanTNcjiy+YWQlP7rg1rSp7UhYHKxqW75nC+/EOutgIJOkR8oT8p9J1RW8c72divcmTuE9HDf8OaBkjbAOvQBhRkIFqnZd/opwqTaF9Iq9K6qMFRDH76q1uQO+/Y3gdEODeivaFl+ZYfBwgb5Y8JBav9rTReRZHH9v2wolA0csa1wJhMJm8WVNaJNeb88S1nCjxiygibXKda3Uw5kIfjfvLO0m4DGAi3AdgmzT0T/9OPRaY9Yd96TXcsrKUHvcP2fHj9ZXgmG9PdrQKxF9kRHdiOULDUDg+j/ohBKXn+ZwyFOv7ESLg03AoPVBz+EFr+FSmRBin99Ybzi1Q5Wo20o8zH22XImEY6b2GiLbfQd4ShcZv+Cq0PuFqYfi3H+MJ8rVBY3qUQtBvg2U1HpHq4slvAIS60tnocMxgds6Htu3w25ua5dt4OD+dPyz3ZEAzrEzOTLIgbMKv94XIpcij9oQagAu3HPAU62QSQk48+b7vr24YmrQ8CZ a9a3rJbi 1JIx/emmzHAsJnawv9kAPeu83CKuX6tibXAVTIcZGosDq/MefE5zDwVUxJyIx+83vlT6w0mPOjnIS7tIlquwGMIUJJSMg/FoTigcJnGFoKB4aqQFLfLfzhuPNfmNedwx+k45y/6yxMz3LwU0D7Cqmez7rbZ9IAJTsJVwejFg4WYUVQhBl9QmJg9jFCkC9d9+aT9sNMB00dEf8/rCYxfobH7FU4bISoDOLwNRoO8ggYqP246b7trIZFyMmH/HVxwZTZSdQkRL44MoHGfMzv8RuDep701xL/XhZ+00wRAzd7lLojCXIJplPzRDZOdcNhUjGCqJgq3bxkif9PSOqHnzMLo7ci1GIsUZXtVgPYWCOnupjblYxIS/BMmoaGFpuCSXbDUQZxpUkyQOm2bOzjPCNnehiUbYg6qkrbkHZWwFf74LPQ5XT2+yvRVq6BxvlqpdSHScHQ8RyPjibFNs7nyN8Y0dhWA93+LSGPnCqHTXvLHo5hUHWxkhnOqPUbnOu3fq2cj0N X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Oct 13, 2024 at 11:43:41AM +0300, Mike Rapoport wrote: > > But why? That's pretty different from our normal style of arch hooks, > > and introduces an indirect call in a security sensitive area. > > Will change to __weak hook. Isn't the callback required when using the large ROX page? I.e. shouldn't it be an unconditional callback and not a weak override?