From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E15C0CF2576 for ; Sun, 13 Oct 2024 08:47:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30A886B0082; Sun, 13 Oct 2024 04:47:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BB8D6B0083; Sun, 13 Oct 2024 04:47:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 182BF6B0085; Sun, 13 Oct 2024 04:47:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F011A6B0082 for ; Sun, 13 Oct 2024 04:47:36 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 580C51C4D92 for ; Sun, 13 Oct 2024 08:47:29 +0000 (UTC) X-FDA: 82667950428.18.826BE3B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 2E272140018 for ; Sun, 13 Oct 2024 08:47:30 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=E8OMxiME; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728809115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IdHkHhUjAfxO8/rqMjtBzvsaF8+JprszM0WexjyZHos=; b=5hDjuJ1CNf/l82BE9natdeC6T2qNWiAyr3uvke5E1Lm59ol2eFI7foPZ3UF/hiuJ2Do237 AZDMooi7kbeS+5dMYDGXYE4pQWCm/3vGVNS4Rsl/ZWqNrLUYeRS+VDcVCY+KNFj0maAcI9 2TPQPVRnG8g8KkTHE3u/MYs3M5MNwiA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728809115; a=rsa-sha256; cv=none; b=OXBKN/VdtXH+pL8SMWWXGwVcfc3XEK1In2x/qJUh3A9/mpGWnIQTIGjNo2hMBy+Jgxbxv1 aKSfj84xbfFarBl6GIORNOAmGQE2EYhsMvDig9RloZca3vnaITn6jnDM8LfhqvO3/s7gLj Wuxrn9Z0V2T62ynCuzzda0R4r1Hhr4w= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=E8OMxiME; spf=pass (imf09.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DDA245C4CBB; Sun, 13 Oct 2024 08:47:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00D61C4CECD; Sun, 13 Oct 2024 08:47:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728809253; bh=oCkJ2115ozRiZPDG4YoFw9nArbpLGJybX01Iv//69uE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E8OMxiMEktF+GQmyT4EDIYDJPag5y6VDyo/Ga7wsRXJJ99cwzji7jLF1sUHlppQrC kfjLbesywWMnxfXjdxF/ttfJW0S6OCnAeNyYzQJk2u4D3I/IHI9w4eKpfc6/PVtfuE WndRqsL5ofKVGyFE9G/gSdQ0nGfWKHlQ3BhJP58mfPjvLaZMFmHfTrH7D6YY90Mj1Y Bf6s6/XciGtUwI6Emh7Lkdsn+ce052geMCuH5U+Tb+yPiRy+C2Qz+9+N2Qx0N42A/1 /daXS+24OOYM/5Gk5f/vkwwYyUK7ykCQAd22G6E+/Xf2yKVuhiVY41QpTSBy6H62Ks p+MyUT+rRu6SQ== Date: Sun, 13 Oct 2024 11:43:41 +0300 From: Mike Rapoport To: Christoph Hellwig Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages Message-ID: References: <20241009180816.83591-1-rppt@kernel.org> <20241009180816.83591-8-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 2E272140018 X-Stat-Signature: k9tnz4jd1ayfem9ps38g5k9j87m3yda9 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728809250-85826 X-HE-Meta: U2FsdGVkX1/dhFubWAo4vy5u3bWx5Bwd29pWocTCCCv/uoGAUpOJYH6zjLjIjxD15Vum8saxXRchLD+dT3+Bxdi8OADU8lMKs56LYtFg0Gs/TJEq14QZGD+bORukIScaUnVewqT0OD8B0RrQIo1FN+0lw/7+/IK7EDfKYtN4jehc0xznYgvhjQpQtlekDdTy9li4AKG2kht7eWqPDBrMFKVAh/7wtM3Sn1VsgHwcXyufrtHgZDAYdsJZRoY/Q4Ygxa4J5bCOqAF2a6b4lETksQb3Zs5evtWxv2DIyu1KbBiePu+Ce4Mi6TfCd/1KEAxzLKkesW9HH2rHXue6Pl9LUHo5THKvoqdF71PuLlMfqgz98tYvhpRkKDpEXV2uKqMazpxyRKMmlcos9mnHgNy7fCzcFazfOCR6XXWlqwNt5sxOCIqUqn+1cllURDpcHNC0z3RSm0YVNoLi9/VJvce7glJ/mTBOQsVZbkMTbs1db6nmhpL8fuavSzzld5zCUAXlTOduE79eo93AWTNMbE5rwr/ePkSzmUYTcP1tRwqyT3VMtX8EyGCQmRp4ZcIEwoHYd1hhodlwBxnbVd63RxdZfV6DbVtmqpNVGo8Wt1Mf6OxskzjbXv8wcg0dA9Pr3pkMurIuHGSL33lrxh+QsfNz+mYTaikzuFT70jhSSwqEPgCIxY/xaqkjJznEDUWRkLQlkB83twshDWRnCtCHTuXLxI5GRECNwDVZCMkY7HuQEVZhzl89+cG/v5lBO+qBtYSWkB9b0iqADaNK5Sn1CT7z+0KZE6fBuO+znaYmJvG2aFmL54PXwe2wfwWPCZfQmQEBE5jrITR605kTlJhHtVDr/g2A3pkQ0xEge2+pWSL34b41PeN6A+sUL6cqqgA+AGmmOxjQT+YudCXO19WKQbLkzQLqz0URRQiaLxyaIg4NBkhlEIkJPMpwUXdn/+FdIFB0Kr/F4Yme/Lzw5G9idy8 mhlaR/rD Qo2C2ayTaPLzd16O+YlcRzF8ni7Y2s+6lq1Pqq7gNXojMu4aMyYGLNhytty95QisTYUP0np06Wk1Ria7r83bPXiTgk5vNM2K3XVUwO2tzmCVvzxCmTCfelQHiS0X8kvBXtuAFOqjcqeg+Zo7k6HjfnMVNG90FHq8yDXVZuSaYD19vqTOcX9iIr+mqWj/u6sI/wGWg3OIIIGo5KRS20X45riYTJRbg9dcg50fNAfql6rk/dHvJWQttOn8dYXtEsEVA2U7R X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 11, 2024 at 12:46:23AM -0700, Christoph Hellwig wrote: > On Thu, Oct 10, 2024 at 03:57:33PM +0300, Mike Rapoport wrote: > > On Wed, Oct 09, 2024 at 11:58:33PM -0700, Christoph Hellwig wrote: > > > On Wed, Oct 09, 2024 at 09:08:15PM +0300, Mike Rapoport wrote: > > > > /** > > > > * struct execmem_info - architecture parameters for code allocations > > > > + * @fill_trapping_insns: set memory to contain instructions that will trap > > > > * @ranges: array of parameter sets defining architecture specific > > > > * parameters for executable memory allocations. The ranges that are not > > > > * explicitly initialized by an architecture use parameters defined for > > > > * @EXECMEM_DEFAULT. > > > > */ > > > > struct execmem_info { > > > > + void (*fill_trapping_insns)(void *ptr, size_t size, bool writable); > > > > struct execmem_range ranges[EXECMEM_TYPE_MAX]; > > > > > > Why is the filler an indirect function call and not an architecture > > > hook? > > > > The idea is to keep everything together and have execmem_info describe all > > that architecture needs. > > But why? That's pretty different from our normal style of arch hooks, > and introduces an indirect call in a security sensitive area. Will change to __weak hook. -- Sincerely yours, Mike.