From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 353EECF2579 for ; Sun, 13 Oct 2024 08:21:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 913386B0082; Sun, 13 Oct 2024 04:21:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C3266B0083; Sun, 13 Oct 2024 04:21:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78A6D6B0085; Sun, 13 Oct 2024 04:21:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 582656B0082 for ; Sun, 13 Oct 2024 04:21:39 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D01EB1C4D3F for ; Sun, 13 Oct 2024 08:21:31 +0000 (UTC) X-FDA: 82667885034.28.F708806 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf06.hostedemail.com (Postfix) with ESMTP id D012818000D for ; Sun, 13 Oct 2024 08:21:33 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tULugrmy; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728807593; a=rsa-sha256; cv=none; b=We1MtNfzVVFe6A/hLUOGu4LRHKUd4kb/JmLk9veP+t2hZn4/n12y/FvpL1vwMsdINgUz7u gC77bVO88HQ1o5vujbtgTZyYzdOfwvlFFPle5f5hi82PvvPio02De4PjH/N45VsglrOEGd VpiZKylLZYAIonhapnmSJiW38PsnowM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tULugrmy; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728807593; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hOcDuJHakptIkVTJUnlrbTI5JoigZlMs4hFR2itAh2I=; b=bFBFi+gEVX3hnSA3KSmQEFyvGKQarGazt6iWVkTvXylpfD0mjaUtYVb+71nvN+Jd6afIc+ R88NZ2tMWlusB3LAnx60OnMhz93Svaf83kgcmLPYLBH6qyKDJHR3SDnAKIc8myXqtAGaYC 2+BtibDshRhTAtr7h8qMadeW0JTKfro= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id E4744A40188; Sun, 13 Oct 2024 08:21:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F7DDC4CEC5; Sun, 13 Oct 2024 08:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728807695; bh=axLE1xiN/UJraVdsbL227+KygpaRBx8zh/1+7kBzHtI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tULugrmyy2c91yQJWjaBjHXqphYG/JvCX5o6kz6uVZ9/fCV6HwEPz8SuQgJzDUq5n kxV0HdtXAKAFfmvUvZdgQZMP0unvXMRCEnlyS1H3JQDZ5ossIIaf2Eh/Nt9pL4A4fs UgxKSMuMKcaccm8geMjYnMSohGCn8RKZBpgaQDbot9RbMkW0GDRRTO33pSpl/x1ym0 dQuemnzjAiXPC/0mLG1oT+1A/aZ61lYeZndqRDYWKybQ8BBsLJUN0uOrlEeKnU9yp5 FWC9VLWLI9drpamlPLmTprJP5YlRHBN3xN5RHu8q3+QwHPmEl5AZGNADKSg4N+YSpq BHkDzwCRuBmaA== Date: Sun, 13 Oct 2024 11:17:48 +0300 From: Mike Rapoport To: Dave Hansen Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Christoph Hellwig , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , linux-kernel@vger.kernel.org Subject: Re: [linux-next:master] [x86/module] 6661cae1aa: WARNING:at_arch/x86/mm/pat/set_memory.c:#__cpa_process_fault Message-ID: References: <202410111408.8fe6f604-lkp@intel.com> <73d5a6ed-da3c-448e-8cf8-6abb59cb2c36@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D012818000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: c7qnrfia9un3unn1wfp5shzwkx89ermw X-HE-Tag: 1728807693-764885 X-HE-Meta: U2FsdGVkX1/GlWuhUOBZT/MVbKGiwiKRve6OiKZo+PSLRQFCaeMwXtHQ3RFW/ZMsmvnpuwDlNxZPCDRP274HtmFBHM+bH1eTs+HOGKzl5x9tufY+6gbOF23z5HOvXSRCNJNaJfBLdvjG6wST2FwVlut4pQBYuPiPDe3GaawjRAIFW7o5yrssaso+PNy+BvYJ4xGgYBG94H/KSOi1QwsgEy/At0fd4dd1mHXwsgWnIzwjXrewdnmsiYyRtQ7+3uQ7B6sOPB7tfBV6jYPouH4UyVp6qeLtzzflK5/AIlK0F9osvjnlv/ig/w8LkWZTAxShi3/pOxohb6Y6yMXxCsZr8VPDkRTLwdTjXo4T7PNShOCxNZzgUpV3HiMTB5HS81pxQbX3lEFXv2llt6OFxvfyuHF7ip8IfLJrFiRTIIVKNk8uKfrmfYCTgUXyFlFOP2XQvWL0GAg3W5NdjxWg3rmitKbtrMtDns1eN3wurAUYwhwhPiLV19d7eDkJVzE3QJZr1zCKZr6DqQkyV6+8aLzca9mBf/+KSLfY7YxWxbZSlIJL3L4a7lMDS8NkbpMZ8PnvtpGfCYJtzDecxjAGcAZxh2u/2IMv9j0i63ONxZ1XxJCrev0ru29/AnpgwPHYo8L3LO/BCFjLXujwwwCTNOajT7cdZGoGs0F578b03tq21sW6iD/+CCgDf0uZNmcgQcI3dBWcYZi5Wi0OupGHFgruAxIXoLwucDJUr+jkl2d7w5Yw+zkVfdUE0sLxJKPhs84mMJlFcqUm4xawE85+UJI2vJD91UsxCLMPf9npfIkpNdaUCz73P8uCZFoVur7u1SPDDXWXqb1gdvrjVSvMHHT3fhFrlSEh/IY9fprqo89L3O+fH1gX+m97UBrqSatAjhevMYwDnbqQnvmMuFrJJZAT4NNkqd2kU2rX5QPHN3vN56o8+w5j1ZfwMeWoUQ6puhA85cmInyliT3qIQEbGoLf dxgvS/Yj +MctfkHb6fbfPOdwPgqBlxuHk2//pN1YswYgbfRD5+sq3MFWWLY8Nk3GxUFsS0tv2g8qAQvquC5BqZg8Wk0BEBo9pit4RxOd+HqfT7ZJHJ4t4/HtBI7YmQ7HfGOUUH0IS9K0kOBwcrSdAKGNf+uIydjAFNwmoysOo1jlVHibLATwtj+gcPoLm01jlj5gSqy3FEbHD2TeQkHFkQ/tDFMVY777Xy9oQzTN21c3ZviU5YDb+8wHuvAF+fJZTp0yFAQ19sA6hp5zHCVfUQsNIBdqmua6X4g9xza1/j4CO9o+w0QHmGLs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 11, 2024 at 09:30:33AM -0700, Dave Hansen wrote: > On 10/11/24 08:40, Mike Rapoport wrote: > > On Fri, Oct 11, 2024 at 07:00:01AM -0700, Dave Hansen wrote: > >> On 10/11/24 06:08, Mike Rapoport wrote: > >>> This patch disables ROX caches on 32-bit, it should fix the issue. > >> While I'm not going to shed a tear for 32-bit, what's the actual > >> compatibility issue with 32-bit? > > From the stack trace it looks like execmem tries to update the direct map > > for highmem memory, and cpa is not happy about it. > > First of all, if it's a highmem problem, shouldn't the check be for > CONFIG_HIGHMEM and not on 32-bit vs. 64-bit? We do have non-highmem > 32-bit configs. 32 bit also does not have ARCH_HUGE_VMALLOC and execmem cache will be anyway populated with 4k pages, so I don't see why it would be useful on 32 bit all. > Also, where did the highmem come from? All of the execmem allocations > look like they're some variant of PAGE_KERNEL, but no __GFP_HIGHMEM. Despite that execmem allocations are PAGE_KERNEL, __vmalloc_area_node() implicitly adds __GFP_HIGHMEM for !DMA allocations. cpa->vaddr = 0 here: [ 8.161035][ T98] CPA: called for zero pte. vaddr = 0 cpa->vaddr = 0 means that page_address() returned NULL which can happen only for highmem pages. set_direct_map_valid_noflush() __set_pages_np() unsigned long tempaddr = (unsigned long) page_address(page); struct cpa_data cpa = { .vaddr = &tempaddr, ... __change_page_attr_set_clr(&cpa, 1); -- Sincerely yours, Mike.