From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 950B8D0EE12 for ; Fri, 11 Oct 2024 17:08:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28C736B00B7; Fri, 11 Oct 2024 13:08:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2463C6B00B8; Fri, 11 Oct 2024 13:08:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DCE66B00B9; Fri, 11 Oct 2024 13:08:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E581C6B00B7 for ; Fri, 11 Oct 2024 13:08:26 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 73C381A12F6 for ; Fri, 11 Oct 2024 17:08:18 +0000 (UTC) X-FDA: 82661954970.02.EE8EC1A Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf24.hostedemail.com (Postfix) with ESMTP id 85C3C18001F for ; Fri, 11 Oct 2024 17:08:23 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=F4a3sJLx; dmarc=none; spf=pass (imf24.hostedemail.com: domain of debug@rivosinc.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728666402; a=rsa-sha256; cv=none; b=BqyH/7cbh1wqnDwkJWuNtqwZYLaK3yB526/ncZD7F5Tq+851LrczlOYo6PsjIgQQpU9U/0 JDZ7xv/8HIrksFYi3SXCk7aLQktOE/yUVViqIfUzdUTboShW/AUMmqgnZ0Vs/G1lz3uIhn wUoJ0ZEnBTho5eSRAiK6cFJrRsgUPfc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=F4a3sJLx; dmarc=none; spf=pass (imf24.hostedemail.com: domain of debug@rivosinc.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728666402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r+xPK7LKwEh54/ZZC8QG6tkevrImBxSFBvQwNAw+xEw=; b=f6Ko74c7RRfDgNFB3uFlIqis4393ox3MDm1jR7K4HxG3Oey9TzBe2V0IV4FG3HSC5VpXMJ MGfgLOa/wSyobZ9v2jtBtr5ArfYz2/3gwk61Hh7eGqa1zgYENZpW11wMsDkqry9+gS3JMN a4Ww5/52Cupr/2/9wCHfhqKrcCSG6g0= Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-71df2de4ed4so1551813b3a.0 for ; Fri, 11 Oct 2024 10:08:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1728666503; x=1729271303; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=r+xPK7LKwEh54/ZZC8QG6tkevrImBxSFBvQwNAw+xEw=; b=F4a3sJLxhmxJYrYEc5sedKW6A3jNF2qnxQ9LiM6BctrsxsWJNX1tDbnV3g6nD352A9 CAhqyuErTsX5hNBh3keOpF6A4QahkcF8X1vhNLgwwsOsryXZpF8Oq8eqv9weypesKFhu Xe3Y6WQgGmKDZNclWAwzE48j/9RlSaYSPHq+7dkgv4i7JZjwpjsVII9Cq0BaWJUqlLsl T4zfCQQOybCo4x0rJaR+mwm0hLvG+VhLehK8SmAG5e6e0BdlUghIxRKyI5Sv4kVR8z77 5zthELsfByyw+IgctyI5b/ENLtGN/sG6p9hPQmOxpyRaKDOTvRg0RfPEqChGEPgL83hC Dzvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728666503; x=1729271303; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r+xPK7LKwEh54/ZZC8QG6tkevrImBxSFBvQwNAw+xEw=; b=pIVAP9DQW0o+ruwdDFlErmJ/sJnetGw89Tj9W5HoU5k9DzXuNretnj67Ha1UOpMIHC wKx1cUc2k1VR3Mz/YXOCWejsYPT5zjetv/Kr8WrTx33aiOIjNcGvoyskyu+zI0jfiiqH yS3cIOn90Y5YHWWiVUvrG9ApTYQovlPsJHmtXdCgKt45rvmqe8169C+fZeQKJxDGmMbU 2aY+aHiGiARjQaeunjPTusNIPU/YVbqS3cbFH6/++H7lIWXA4SZywO8Nmw1PNz/FqLYo MGZvwM6gPavoJD/UA0hpeiGtl7YAbmCuCMKdFmEVSJ0Uc27+FfQoUQQtEUefj/zWlUWx cdsQ== X-Forwarded-Encrypted: i=1; AJvYcCUw+nPa6bA12OeWWRaxqV0nVY9nk2K7nLJRjhyzE4UZx13ZL00sg+Y7rMmAMs2Fk5Wt2V2H6ecHKw==@kvack.org X-Gm-Message-State: AOJu0YyD8zPTAp/6GBQLiB1dkcAdMTuXls9EdtNG8lNWpUpYy2qdQWMD 4Bt1fA2+9/yRNWPmrXanNOFL8MorqMH+JXYiy6Wd5v9CjqdJT++aSX1/dTQ67P0= X-Google-Smtp-Source: AGHT+IEHmhZfyYl8DJMsul1UkXEVT9lzG0SPe4pnS2qGoqHY42Il/aljbU9nux3eahAquBNN31tnFA== X-Received: by 2002:a05:6a00:2d0e:b0:71e:d8e:7676 with SMTP id d2e1a72fcca58-71e37987c15mr5444761b3a.12.1728666503198; Fri, 11 Oct 2024 10:08:23 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71e2aaba5acsm2890345b3a.177.2024.10.11.10.08.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 10:08:22 -0700 (PDT) Date: Fri, 11 Oct 2024 10:08:20 -0700 From: Deepak Gupta To: Mark Brown Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, Rick Edgecombe Subject: Re: [PATCH RFC/RFT 2/3] mm: helper `is_shadow_stack_vma` to check shadow stack vma Message-ID: References: <20241010-shstk_converge-v1-0-631beca676e7@rivosinc.com> <20241010-shstk_converge-v1-2-631beca676e7@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 85C3C18001F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: fet7cwqwfh7sg36q8w4dggbbxaos4mm6 X-HE-Tag: 1728666503-68076 X-HE-Meta: U2FsdGVkX1+/eqfvqjNNfACNXKSLHcp2t+27nZ8Cs5cWGrgwf/B4tQXuutFCj2filx3tkiCRrE5HRUSU2Xf5eeNd4U7i7vy/wPlJHfn7kS5CTqgSjACJmEQtNeKBq37dSNWXrsoB7MVQ6WxVwznu/4BEybgfcOQciG8ss5nV0qQZCfFknAEyBk9DK0DGn8koRNgTtVrIdyDGYz/XbzyPXZnjgIWRDVq4ftMz6rujdcNld/8j0HbHoc/qlcm07RGwTvOPUvNlgE5FYAyyZ6CMkKLVc6fNWVWdKkaOjyLRDxlIJlHOhSw3lj8VbfkV5xVUg9yPFsxGuDLqC35K7tIDVFozPNlXPR/FyebnuWU0BOG+RiB64aF0JDNQ0tKNwXQE3HKZzId74t19vBNKQFlkPZTX4GdJqtKvGk/hoX90PYfxu0QZWGVUqqGunHNGcXNxiJV3ch7PqvGoC0iYEL4KPDPv4NyLb4asKEindWUlhBfbeta9LV9tYsoc/oR0rh6MIZAoHJWkLvw1YMcGMlVttW2jUsrHMvBHkWTqJkXjM2uPRbkJ913HAfVt8M4CfFMOz08HX8dShkjEtbQ4YFYJP3KI1Yc2njcUtblFI4z+VEdsWuJvL3xFDpm/T5QkmNZY32WZYv63MgrWzhitpay9wXtHpImlXdfgbqMrP2yKY8kQlkIQwr0vgkuO+HTQNAX4Muqhg3i83HffZV8fL2cZr1ibcxzmvgcTpQGSHu2HdVqG53lH1xAENDqa9/Bx77qb854HwOV5AeGqeEWze23UCabqh49keZMUg0leeXP39BlKeZZCu1WFgFPDCxrOXC+H+PvGOG3tvG5UtFo32f4xRS0KUpT9uJZ8DK2+2Na9mdjzxUWTyXQZTuM60PV7uPqcKLBMgNE9/w4/xAF9kjO1dIY5gL4brhu5F70X18oqFVhdoeW/sbUmgapy0hI9CEKLymXmwcWjoX4v/jjlngP 28ti5jHM W1Bh/P2nwqQknCcdrKUeglyArLKvi98FIUiiAoCbTDxKt8y3nSx5YB9l2TohpFS/DjvTDfcRYDkJqqgPmGt5Zf/3UGs2vBO6IXvEJKFtYmZw/YdBfRhtRcKvFKIiSWAFc1byNrM5U9TngMAok68mKnnJLarpHo5Wd7Z+8cjawJLMqzEAV1hTx+LAKs9rwRN4aqD5RKu3m+2cuFapJfvzMliEpBAnupgUgk9ofXSRwtQ2e1cVnkCf3ORpkV8UX0HMD5LEp2f5jTmc7E+EqbS1DwoqlBibm8HLTkj9g58HNc2nlJL2Z8Esg1ARu2e/8yfAkbVqTTN7VzzwRPoyuFdSPsG2IJ1XCUhYNVjW3N6/pW528+H0Km48bywV7AMIY6sdrKF7W9f+gR9rUHRstY5smeSwWEODRV5hweYSvbcmBdzzrrPtV3fcxhjyxgg3gK4ARq+A3IhLlnz0Q5qJvvgF8cxC8ag== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 11, 2024 at 11:38:51AM +0100, Mark Brown wrote: >On Thu, Oct 10, 2024 at 05:32:04PM -0700, Deepak Gupta wrote: >> VM_SHADOW_STACK (alias to VM_HIGH_ARCH_5) is used to encode shadow stack >> VMA on three architectures (x86 shadow stack, arm GCS and RISC-V shadow >> stack). In case architecture doesn't implement shadow stack, it's VM_NONE >> Introducing a helper `is_shadow_stack_vma` to determine shadow stack vma >> or not. >> >> Signed-off-by: Deepak Gupta >> --- >> mm/gup.c | 2 +- >> mm/vma.h | 10 +++++++--- >> 2 files changed, 8 insertions(+), 4 deletions(-) > >As I noted in reply to the version of this patch in the RISC-V series >there's another test for VM_SHADOW_STACK in mm/mmap.c. Yeah will make sure to consolidate comments from both patch series in next version. Thanks.