From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37D51D0EE24 for ; Fri, 11 Oct 2024 19:13:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CAFB6B00AE; Fri, 11 Oct 2024 15:13:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 754486B00B0; Fri, 11 Oct 2024 15:13:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F4BC6B00B1; Fri, 11 Oct 2024 15:13:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3BE9C6B00AE for ; Fri, 11 Oct 2024 15:13:41 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8D4291A162B for ; Fri, 11 Oct 2024 19:13:32 +0000 (UTC) X-FDA: 82662270558.13.FE939A2 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf19.hostedemail.com (Postfix) with ESMTP id C83551A0012 for ; Fri, 11 Oct 2024 19:13:35 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GEEMux9W; spf=pass (imf19.hostedemail.com: domain of namhyung@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=namhyung@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728673974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pvRwV6025PsyQy84OirMqXBvGIltOUm0t5egW4RL/s8=; b=MAUoNnxwAWm3eAUQE7waDmT21skmIGCiPumj6Fk0gPJu0EVyvnH8GqZljkib0L8EzYm0i7 GtlZswh9aLw/LMO9KXaYVelH0sYfchx0z/AwcFz8iYGLg3bmEPP79WVYezUlPqzOUMj7Fy I53gsCiib+ldiisjwxuefLkycCs0xRU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GEEMux9W; spf=pass (imf19.hostedemail.com: domain of namhyung@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=namhyung@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728673974; a=rsa-sha256; cv=none; b=1lkBeolo3RGWAx+Rbkp2g7qSF0QXb62QEe8nuG/rUxPjjA3Jxxvl8SnD/fi2opxbBXwPgq WLcWrb2jzzqYOEQQMWGIBnGTZ24dHtsRiD2Xs3RCQKkGzGtVg5WHBwGLu7jYKyC4/rozoD PT3cQ5eXdUPFPrSb/rg278EakcAYN5o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 47CB6A44BEF; Fri, 11 Oct 2024 19:13:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE469C4CEC3; Fri, 11 Oct 2024 19:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728674017; bh=dW3DEue8pH156XSw6e8kr83B3PJXGaUHI7/vg7NPJBA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GEEMux9WepdfRoOXDG39ZOmXkE9K4ZfVsvVC8csGPD8XMe606As/d0JF2yFfpjLQR Q+i+kKOWP53SFAfFCRUq7TnFgaWiAcQH1xu8n7LnXM1t+j/6vJzQ7ohXJN1ns0NrUo tRha77uyt4wycWAId6sYtOiILyFFgqM+Xoy1hoT/aBwAEjnSnuAfXIzYw8/oUU/TuL hPu39O15kzhhO5A3Ak2KC9lquP/3PaHpm2D6bi0Ulv9XQBWN2SY9iaODz7nPr+JMWt Gq3sSB2OgKebqvwqjuSPpjfTcOASnh3fMJSLBRp8OmmM/jt4bFED7SI/sKNuA7zWHM 61l6iPpMhyHnw== Date: Fri, 11 Oct 2024 12:13:34 -0700 From: Namhyung Kim To: Alexei Starovoitov Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , LKML , bpf , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm , Arnaldo Carvalho de Melo , Kees Cook , "Paul E. McKenney" Subject: Re: [PATCH v5 bpf-next 1/3] bpf: Add kmem_cache iterator Message-ID: References: <20241010232505.1339892-1-namhyung@kernel.org> <20241010232505.1339892-2-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Stat-Signature: ao4koegqmzjsejegqj7abjxc1t6gzx3p X-Rspamd-Queue-Id: C83551A0012 X-Rspamd-Server: rspam11 X-HE-Tag: 1728674015-802369 X-HE-Meta: U2FsdGVkX18tTJjN/evHMrtFtD3WgZIyDa15IWriSN+e4FqRbcWFrTCYEau5hpvEF+xG19vBJV8rlXCt5gE/gZOH8/9vhZUn9BovwQAuVQgpFxvSfH5Qsacu592XkbXXVCe6RU6Wow6jaMUC0vfvxpacY0oMXsQWwcEnP3oImQYV5eFI6bAaKmqsWztLdvwtG0cgYj4Q6CLadjfGeU3oQoA8f2FjSw7J7iN70nbdR6Vgi1iTxjVd3u2aBAQi3fXeUD3XY1bzaPTA/SbUzCIpiO4jQPLRHETdQrfFkyJBsyhAN9WwEhpHc3EDab7oQ++USQ13Z1d5Z4RnwEprjStGor67uI6LqwvNKYjgvWn0q35sHt1OO/5ti3ZOJmFAAICkAzSuyYdpMfv/9vHrQHU0vIVqId6c8qqq17RSmOOANrK4fIhuGOc2uwoanPPWOTWpv2o0X9kHZDMaNSbjxZKVWIxOnv9Ke5/5hmqP2OT0gy6fA8qwL8U5cq77iMCCJuuVszBycaFMFiR2cz5eVqrBeI8KAOwXVYzqdIqkZIgjpz8b/Bc6ue6MRdvynqaXYql0rZkw3LStQJMi3RgFTji7E/RMZdKLse36ZVLiGlzxGQjDfGFh1OxeqPwPIlPPZcMiz8f8+E3+FI11B5QxrIQV1RoXEFFdI6LlIuobg8RImBKTCy/ylkNHtyv6xBebb2xMzRFtZKYWZL+Yvkuy4UK5UA+xlm342xtfS4mmr2WSrnJ5dfIk3V+5CoRLsvpUYJNcGOhiDMm62cMd35s5juKa2zd4/Hy3FkM57KaW+9ezBg4Q42iEhX4hpyCIWG8yiUGS0zm2/IBdZRLKUWkGI1uqGDj5If+8heNftiRUvDlfe0hsYH9Suy5o7Kk3M8SI41t/qUX9EI41mcLpwCnDnRmD1wpj97+gyx1JuIPcKW6+jqvNf4fLp5ruHs56G24OiGFWAFJyxyi5LqtaTROuozh UeRkUkHV MzXEVJrovRCEvh3NbmVKq5R7Ng6sM0yl5uu+pxzMSX5VFrjeSArckhH2YWs7fxpjMuE0w8ZLd4HUET5BdbxkL0Rs6I+tGCtyQMGI/DFUA2Hx1sfeVzIHu+y87q5JGIiAeOYBZjjoAoh7KKnr2L251ZC46TxLydwwZwlaNZSitREACu1zUVc5QwZialA3UNuH/0UMmw52oYfjDaABfW6QUq2mEgSsBcupexsfHsfseZe2x+t237LMdgaWysPOXIXP3vV9TVSvem7jC7dMqD6vhLeG/VCtAlxxFmmHyN1CCbd3Kw1OBhiVsq+gqTg6peq7O668YRvfUspi3YvGLHLY6dGhQcWjTViHyPaQIUdi4ogpSv6APs172Tu8FFdHWm2OVC7FwLW3IEDfJPLnDsIo6wVm2JvmlM40E8lEk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Alexei, On Fri, Oct 11, 2024 at 11:33:31AM -0700, Alexei Starovoitov wrote: > On Thu, Oct 10, 2024 at 4:25 PM Namhyung Kim wrote: > > > > The new "kmem_cache" iterator will traverse the list of slab caches > > and call attached BPF programs for each entry. It should check the > > argument (ctx.s) if it's NULL before using it. > > > > Now the iteration grabs the slab_mutex only if it traverse the list and > > traverses > > > releases the mutex when it runs the BPF program. The kmem_cache entry > > is protected by a refcount during the execution. > > > > It includes the internal "mm/slab.h" header to access kmem_cache, > > slab_caches and slab_mutex. Hope it's ok to mm folks. > > What was the reason you dropped Vlastimil's and Roman's acks > from this patch while keeping them in patch 2 ? I wanted to make sure the slab maintainers agree with the refcounting and the locking logic changes. But I forgot to add back Vlastimil's Acked for the v4 which is the same in this regard. > > Folks pls Ack again if it looks ok. > > I'm ready to apply, but would like the acks first. > > Also I'd like to remove the above paragraph > from mm/slab.h from the commit log. > It was good to ask during v1, but looks odd at v5. Sure, feel free to make any changes. Thanks, Namhyung