From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9980CFC60F for ; Fri, 11 Oct 2024 07:47:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2325A8D0002; Fri, 11 Oct 2024 03:47:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E25D8D0001; Fri, 11 Oct 2024 03:47:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AA2D8D0002; Fri, 11 Oct 2024 03:47:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E21DD8D0001 for ; Fri, 11 Oct 2024 03:46:59 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E193880E60 for ; Fri, 11 Oct 2024 07:46:55 +0000 (UTC) X-FDA: 82660540158.18.F008389 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id 109A040003 for ; Fri, 11 Oct 2024 07:46:54 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RNzRRI+j; spf=none (imf12.hostedemail.com: domain of BATV+0c28974be301e84ba5dc+7719+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0c28974be301e84ba5dc+7719+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728632678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HlhUCBO2cgAocJ0jal2+odmhS3fEGMT9ApCG3YBalmk=; b=Ev1hHfCxL1kcvSc7t0T0KUsZmaRVNp72hCN6GMa5kvEzslj7rVhD66ZzlqNuDjir2Dgkj/ fMjEWhE06ajvDltEtg3LZ7bAH0GqUjALRz09bWADzEQL6KceBfew1LuT3zvfmdhCzeLymc EWvXhJmmbk2MCgEvDTxYEWW71OifrBc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728632678; a=rsa-sha256; cv=none; b=lgzztbinJO3q8v+mZlAgVDHSeoBUtp5Ed3E/wZtR+KpBZP3PvkZRT1h6j/qrtvqFmmKTun vLuj7pEmxyeTdL0v33d08bYkjrdbCis1CBfU/LeFRtbJbouDSbLd9E1U+98VgWljZLw8+V 9aj1Wr3MBO3L1zbuDFbozp79p3rVayc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=RNzRRI+j; spf=none (imf12.hostedemail.com: domain of BATV+0c28974be301e84ba5dc+7719+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+0c28974be301e84ba5dc+7719+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HlhUCBO2cgAocJ0jal2+odmhS3fEGMT9ApCG3YBalmk=; b=RNzRRI+jS+E41pEvv2tM/PBMQr SQs+GEy9wRlJQS7LgwXIlsLPiOEfZ0lcfVl/LZAzCmJERr/wrGQx/6Jkm+z665nLQ1YxAvvKLbZgJ K836flQdGWfRcahrgPWsGgbE2Kv46RlU2j9210RhGvDmBYmeahOdJixtpW4jFIpXAj2/1kuIqVUzm 9UeGFlwfEh13tOOBCEhTCdOmFs+NkVHulOmWBcYiyIrEdETWz96sC8sQ5hitRuikUOylqpHtAubjX bIdwQSiSdX8D+zYfq6nK2YaptkNRLX5ebrdQ9hI/fijT9vdqmXxkPzbZ/e0uearFNRK9I5GNV8P5M +7qkIbyw==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1szALv-0000000Faln-258j; Fri, 11 Oct 2024 07:46:23 +0000 Date: Fri, 11 Oct 2024 00:46:23 -0700 From: Christoph Hellwig To: Mike Rapoport Cc: Christoph Hellwig , Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages Message-ID: References: <20241009180816.83591-1-rppt@kernel.org> <20241009180816.83591-8-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: mmwcmyet5dqitomn3nwbsb5cbtpys5r4 X-Rspamd-Queue-Id: 109A040003 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1728632814-213055 X-HE-Meta: U2FsdGVkX19LcwzGDb986/tSJn2NOksokev4SzoBArbN1IyZMtzMSzrLqGVgHF8eePRStGBAuXNVti1J8OoqS2tAwY94fhHHvzUyixjt7RmzY3ZFZhFKl9v7M6MgOCV90xQAGIfNV69WrjHEnIQo4b+ZPiBH0bb/juo7Z0F++zEGUzJYZc4BHiLZtys8ZySeE2VqqNre+eVHB8TgELNWpaToGjZwz2k6a4R6nwg5fTDfPK6zM5ykJ8NYaIlt5OVk413AFxL4wCiWCipeSG1QIIszv5HrudkA50ByUoDJJAtY4fBkUK0wZ73+hLYJRI5zTq5Z6ajQBOY+3KDAsb2U7QQUUl38+e8KXg1r6E16UHr3Ot5HFzZLfQvVHUGP2svf0J70toB3gJkDFqylDpzIvmyquIeWsjj/Kex2htJSQsGbyZCLHorp/whNPOKYoU6S5lqAbKITzpPy3Y4sRcsu9uafiDCUNCsX4XogC7IIaJY26gDVKM88WMwTUE3RX8EtqdC/juY2YYIui13B2fMtr2wXDOamU1vT+w/H4g2hAA2RkYqXFjEWJUWdTmEGQnZLJn6owI9a25LHQItcPrDrZnXzpfghnKpmf/vCv9IFPxU+dTFBfIUhKR5Im3FDM3anoUVUlogbK+hzZHo42iNe0VsHDisKdN65X8L+vw977sCsH2SXdm6PHJ12oFqRREHo8kdQM4WIcaHOhWSPINS3hQ9YJY051S2g6yzjQ3zu50ZOOXKm2vKg+OWf4C3OO3fiDHlBYkYQkhreLwG9dOsdUKTO92PwBE3nCClr67y5w0Ae+FQ+FcOORD/mrA8JX7p0L0+Z3lhT7uV5XIpcH2YwDkfQORFeR82CbdO7BTCE3p4aDmNBajRy9MsEPYfkVT7P6L+oDUnzrQoZhdSt4nOtmCmnzeYnHjMNSi6vozM55oIEWTPTY5pnTFEOX+FRCca+0vOEc/JejSQtqX2t1T5 kybM9n6K LmbTOvMyCqel6DoEUq0cp0FkqFXraixrGnbnzcUHBp8NdtT7SzZgrOVo/uIRAWhRPO9Wx/Jmez1DwyQgiCo1m3kEa4dloNLZLRP3qD11glixeKCAX16Sm4nTpGqgrRdTHV0Ji2vrZ6JrFNnuH5B359rxZM3HTQeB+uxMifbto1QFst9keoJLO7hi0/Gj9lfxhvIkZbz9tiGD05PW+9NazOTp1ASw9yS8mT8wtVb9izDBJ57aznNnyde+qPUxLgpS7rltSaQI/vT37Ct1ZAXKLIKXEWpPtKb73hP3hAxpensdQrS4F3yHlbNxEuHTVOqx4FsFo2U7txBRoZwuF5Y0MVpcSwGxj8xOQa8ZC6w75R2jXjR6VyIRhUSmATEuXyJ7AkFO6AcoX2HtmfEOn/BN28rF0aGISTkXmwnFX54iNwbX/spEOO0dh33eNZbjxX1FRBID6zu7mBWv7XoYLlSTCOw9HBDnijUhLKY0X X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 10, 2024 at 03:57:33PM +0300, Mike Rapoport wrote: > On Wed, Oct 09, 2024 at 11:58:33PM -0700, Christoph Hellwig wrote: > > On Wed, Oct 09, 2024 at 09:08:15PM +0300, Mike Rapoport wrote: > > > /** > > > * struct execmem_info - architecture parameters for code allocations > > > + * @fill_trapping_insns: set memory to contain instructions that will trap > > > * @ranges: array of parameter sets defining architecture specific > > > * parameters for executable memory allocations. The ranges that are not > > > * explicitly initialized by an architecture use parameters defined for > > > * @EXECMEM_DEFAULT. > > > */ > > > struct execmem_info { > > > + void (*fill_trapping_insns)(void *ptr, size_t size, bool writable); > > > struct execmem_range ranges[EXECMEM_TYPE_MAX]; > > > > Why is the filler an indirect function call and not an architecture > > hook? > > The idea is to keep everything together and have execmem_info describe all > that architecture needs. But why? That's pretty different from our normal style of arch hooks, and introduces an indirect call in a security sensitive area.