From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF48ACF11C6 for ; Thu, 10 Oct 2024 10:40:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 228B96B0082; Thu, 10 Oct 2024 06:40:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D8EE6B0083; Thu, 10 Oct 2024 06:40:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 079FB6B0085; Thu, 10 Oct 2024 06:40:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DC5406B0082 for ; Thu, 10 Oct 2024 06:40:33 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6BD9E140165 for ; Thu, 10 Oct 2024 10:40:30 +0000 (UTC) X-FDA: 82657348746.30.0421F67 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf26.hostedemail.com (Postfix) with ESMTP id E369C140004 for ; Thu, 10 Oct 2024 10:40:30 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=u9ENKwYH; spf=pass (imf26.hostedemail.com: domain of vvvvvv@google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=vvvvvv@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728556694; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EBHWiktfVYlgbYifeV/Ct3rZTbpPbZ7HKtEDGENAOyk=; b=LFnndo3f+Zt80tvFX0pcQh4hYtNnaT1ZITbM0ok5V+KFGSlPGwlRzK7RRwHjrLt5gH+Fgs M58mjuhae3a8+833dI2VE5fdImIJwFH56wNXj6JdJa8tl5pmYikYiq/8hcAEeTm215HLgi 7fmsnuVfaRUgf3wAdBDShuda/24pLQM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728556694; a=rsa-sha256; cv=none; b=47wmucNGb+IbAfNacrPxtV9aa5QgO0ZDWqggcL5mS4zeOYP21y35zQlynqlb4djU7UEPal EdJkSxUEVT42e0CmSvALjmFburxOqPEAi6FrH0tl+Ic76h1HieuWBClvhour1Cba2Jr+2r gkz0CxHIdXpnRpumX9z0FBQ1ik1FMg4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=u9ENKwYH; spf=pass (imf26.hostedemail.com: domain of vvvvvv@google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=vvvvvv@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-37d51055097so93638f8f.3 for ; Thu, 10 Oct 2024 03:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728556830; x=1729161630; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EBHWiktfVYlgbYifeV/Ct3rZTbpPbZ7HKtEDGENAOyk=; b=u9ENKwYHrmsE+RqSwDgh/PBKXjtCA/Opaulh3awz0N2ushQkGYoTN7o5LdoJeu9Qn9 J2pxtea9KZKc6myCSAIbJ+XVAZxeqPNhnQiZG2qzxbUlZOIJQv4i22bUmwEEQ8JjtJQt JkPELn7UmUxNOBBVj/wv8eOYfYTKfgWZMjP2WVC+TB1xToivgXR7hQ6Zvv1SGeUCqQY/ rioV9zzkTdF3/ib1BsqkFLckg5nsQZaYdXuLOSAEnhO5GfV4gn6jyEq/AvEC/nJsv/Jp CXNj+8cD196IBJbQvFs/IHz0HabZLxhjDYGcs05kuTNnlErQUFpSBRXEGe54NhvcXk42 niQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728556830; x=1729161630; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EBHWiktfVYlgbYifeV/Ct3rZTbpPbZ7HKtEDGENAOyk=; b=xVaf8cEvu9zUCpvmGJJK72c/2XCHqBaz3ztbh+xzqfTWHRccoVAxXjcfP0CwE8m0oH ye+hONkEf42DeRBZkHFaj+gn8+R3AF76fgnlIt8jV2P3DB7hplDtvgEHci5AuKtOwidh Y0+G3gAjJ1UvHgIw86brHCCY7n/ecqZiW6a+LRL079qUKCquOq6euRDNv+ILFMTPKVb2 4vbz8edQFA91eo24KSIOtvhHldVFRWDtadnBEkqnsDHG357C89a6awUWtho2ksXcJD8V fWpbFKs0lg0mgdt0gGJzRgmsVzKi9xC4rRCDHVoUOOUMwSj50Wl6BpateL6tNptCNaX9 IGCQ== X-Forwarded-Encrypted: i=1; AJvYcCXrFIMKtZCoDkwm4guYmDqOUjJaiF98gCHuVK7QreNjB4SZ17OkfudSoHIFfIUOnVrFOMBGXYjctg==@kvack.org X-Gm-Message-State: AOJu0YwiU77dcG7MrK+51iXJ0NLBpftqUnUoEcS8GDwFawvnJfosADPV 1dO/2Hv3xqMiQ+w277ic7sLxf5lqr1ypnyoH2OabBIrhK79B/BG1ISWMeW14Vw== X-Google-Smtp-Source: AGHT+IFO5jDd08ddK1X0YjR9dIy7JGWXcVcRqZfK2+MjUcvEOY5tKA5RJvpLtMudOT6lSTGNeMHZZQ== X-Received: by 2002:adf:ecca:0:b0:37d:4a68:61a1 with SMTP id ffacd0b85a97d-37d4a68621cmr1116060f8f.56.1728556829836; Thu, 10 Oct 2024 03:40:29 -0700 (PDT) Received: from localhost (65.0.187.35.bc.googleusercontent.com. [35.187.0.65]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b6a8269sm1183712f8f.1.2024.10.10.03.40.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2024 03:40:29 -0700 (PDT) Date: Thu, 10 Oct 2024 10:40:25 +0000 From: Aleksei Vetrov To: Nathan Chancellor , Arnd Bergmann Cc: Shivamurthy Shastri , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, vbabka@suse.cz, willy@infradead.org, hannes@cmpxchg.org, anna-maria@linutronix.de, tglx@linutronix.de, arnd@arndb.de, llvm@lists.linux.dev Subject: Re: [PATCH] mm/vmstat: Fix -Wenum-enum-conversion warning in vmstat.h Message-ID: References: <20240621111604.25330-1-shivamurthy.shastri@linutronix.de> <20241008005136.GA241099@thelio-3990X> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241008005136.GA241099@thelio-3990X> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E369C140004 X-Stat-Signature: t9tonqeckq4epk69ttq4fqgxizh1ppcc X-HE-Tag: 1728556830-170085 X-HE-Meta: U2FsdGVkX19KmlJE2n6xoYxSj0I/Xuo05iduSVarlAXuTZkGyKQoGiWAtVm0lDmo0uBeHaGPw4CAO4OhTscwUPYOgGk+mefsgeBUog3KnArgKSOOD4SWx2UWkfJfBc+hERo4YoVf6qXvkvJpOFD08bamgsv1p6x9iveMdqAWnn6DTsqzYKOLi90VfmNXQ1PyRbuld3B+K2c0OiFrB0aoyBMM5pqHYCXeutFOXLWvjc8/UQrnTEQkU4R+Cjmuk9N9Ktf0sFpRf/YolwA0NR8lxdIaCh+YpKrplbP+hRB73OKwEqCbI6SzHCwyMpgLkVGp/PVoTonH9JT0DsjhEFSeKRynrRFnRSzU/7H0H7AQvkkMug7oMJXhBJtg/1bX6JSafUGtbAjaSTs2C/j9mfDqrXn+BSfKTl+XGQhBcuQ4tICPPO8yPcZpYplEn8IuIqDqhZ68V8AgF4RjiKq/3q6nL2aTTCMfOMjfOHMX7YbzueW9fsuvom+XSVMnl/1qQsNF5HiraJgjbxh8BIpvgYRNv28RTiMwUpTCQ4qINAwIrGm2tWctNKfhJ1KGqbkNoyioKOcqtVdVLDh+mB0TYqsfUmw4p1HVIFkyE+YfoK6BG1A4XN6j2pexUL7EOIF/8am0Y4G8zJusj3KIXR6PbaUDXzY/ri0ZsERQEPtf4MfClTYSdwsKgIKFTJwjsrS6FwWwO995j8s6PF8SgbtCm1wLjlOC6o3lEugRMKJJcDrTPa15dCUMxMwe0y1wc71QKnww3/YARMZxniYT0el7WCLJKouAE+6huDs+5Ef/nS02uqDbLvpHRfL5n5Ui5xcnPA6WoUIq7eKxYy/AoHR5nUnI2vZ9aBrSRmXoujd+44zm6En5hAgqHTbyzpTrxsD3XhSRFHdTgWQyKoxEfwJYNMnDtkwx7i1G5auDVY1aiekTRJ60c3FvD92VxT6/ZPT+VmXYGw5KzoUzgetlNsQcv/y A8fyP4tq K9I6Hu5Z4durtcsuB7w8BKLZnmCMKOAfuCVdgLv+3Fxam5OMOhZbRvw0HwuHQx9tY3YbbbgRWTGYeEb65qisvbin7SeAZXdgNd/bRj2qPE1254npNrjkk258ns6hVNjrTZ3a5o1aPNwGLHF1Gd3QmohkHvpfq7qwf8vW1GZaYcVAMLkOXmdjE6sYqeFlsth4cAqUGhKLaam7hMC8wGZaVF6UkqbMTdw7S1Gh7l91mNX/2U6SqAx//YhyobM7gA1vRWuQ9eLuSAOomBJFaqetUGsTPREkSXgX2rDflQLNg9deX31y3u9lcSFYI+uc0Jid2exkBjsGJoOJGrQmn0IDRKhRLyBnwmrSMqKFB88K+OSkKTb0jX3+yrrj/aEUlYlJwv8w7ORNB2Qm8iqM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000070, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Nathan, On Mon, Oct 07, 2024 at 05:51:36PM -0700, Nathan Chancellor wrote: > For what it's worth, I never really saw Matthew's comment around what > value does this warning provide addressed. I was the one who originally > moved it into W=1 at the request of Arnd because he felt that instances > of this warning could be bugs and they should be audited. However, I > have not seen many instances of this warning pop up in new code through > 0day build reports and the ones that I have seen seem to be intentional, > as they are using enums like integral values, such as here. If that is > just going to result in a bunch of patches like this adding unnecessary > casts, I think it would just be better to consider disabling this > warning altogether or at the very least, moving it to W=2 (which is for > warnings that are noisy but might contain bugs), since more people are > using W=1 as their normal build configuration nowadays. If time has proven that this warning has never found an unintended enum conversion, then it is worth to disable it for everyone. As you said in the original thread ([PATCH] kbuild: Disable two Clang specific enumeration warnings), W=2 is not run by any CI, so I would prefer to disable it completely. Alternatives considered: * Enable -Wenum-enum-conversion only for 0day build reports through KCFLAGS. It will eliminate noise for regular users while keeping developers informed about new instances of this warning. * -Wno-error=enum-enum-conversion to keep warning but don't block compilation for CONFIG_WERROR users. Arnd Bergmann, what do you think? Have you found it useful after all?