From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03621CEDDBE for ; Thu, 10 Oct 2024 09:33:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EE826B008A; Thu, 10 Oct 2024 05:33:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 576DD6B008C; Thu, 10 Oct 2024 05:33:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 419176B0092; Thu, 10 Oct 2024 05:33:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 21E976B008A for ; Thu, 10 Oct 2024 05:33:31 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ACC3AA09FF for ; Thu, 10 Oct 2024 09:33:24 +0000 (UTC) X-FDA: 82657179780.19.245FFEF Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf07.hostedemail.com (Postfix) with ESMTP id 4F9BC4000B for ; Thu, 10 Oct 2024 09:33:27 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TOVNNKtr; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728552672; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GAyGpq2ToVprQTiU0GHlGT9QpKdbqvtvC7vVE+iJ9ss=; b=Xn2ZE0WILq2Q5W2ORuzcQZMfXPUg2BKJSLZrydydxGVVDykAwM6U7iY0Rpzm/3IfoP7KC9 KyrkShjHIFdB0eMlBTRH2AwwfJQ/p3ZjQemHCy+Mwe/PoD+u7AfqrIyXD+Nf1Eedd/MXgM hRNFlAHcSGnZKtwGYteQcC8cfBdOfz4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728552672; a=rsa-sha256; cv=none; b=e7aG+iOXv7HuZu5oS0srMh1kf8EJWKI/DLc2c+51WIZG/8I3q0uxZTiXZ/xKX4O1pnhO+f jdEaAwuvc2r0tV+qGn08hHmAaG7CRIChQPVp5p44wkMu6nge4BXxq4Xz/oa8eriMbXqdBZ KCns4H8dEpLkiMBKCRlU9ixr7vmNA4A= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=TOVNNKtr; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3129CA43782; Thu, 10 Oct 2024 09:33:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18111C4CEC5; Thu, 10 Oct 2024 09:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728552807; bh=IHjj8Pm1cvim8ImsaUaQl0ADY0QKS9kDKJZxcyI9510=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TOVNNKtrf8daQuuMacjY7pAlRlt/k4vb7wjQCQYF0aVuw/4MxtY1IEDmecYy869WA eL70bjSLCWzeSg87onzBIfUU+BSv9+MhwYkC/eIJ924jg8Lyc5Ubk1r7GreDoZptDJ teVpdajxre4MsBPJA9mql4sRA7irY3J0uloNZaSVW+zDmxt4CzZVh6D1UOnW7YD45l /XMlYCHBMS9YgkvBhtdnENr2FDWIvohUoNzgrqIpRpXIOWraQQuc8IrP9OJlfmnsWJ /Y7TcehyVVbI3ky02lFC2Bu9TlmKaTridXnO8cdxvFKPK24cuDB2/RZZ9PsqYrxZV2 Py4W9D9Jti/XA== Date: Thu, 10 Oct 2024 12:29:39 +0300 From: Mike Rapoport To: Andrew Morton Cc: Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages Message-ID: References: <20241009180816.83591-1-rppt@kernel.org> <20241009180816.83591-8-rppt@kernel.org> <20241009132427.5c94fb5942bae3832446bca5@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241009132427.5c94fb5942bae3832446bca5@linux-foundation.org> X-Rspamd-Queue-Id: 4F9BC4000B X-Stat-Signature: oqwkeyxd99mnm1zozy3dnbwggeq7ianp X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728552807-631259 X-HE-Meta: U2FsdGVkX1/lf1Oa3lpYSciPdZK1ZHfHVeD7nmK7INZJJareebL7EeTk1yZA9JuLDM4hNHe1dk06tpQZPJGZRV2Jt6W6tgDtf/ToIW8A8G8VOGund3l5wNOzx9eF4buRsKrXx4o8SI88MELTql9bIqMTtsE19mhlq+AQH9c3UZWv3juTHsCqqd98/or7ONwaL2eae1+yFAoe5hOj0WTiW4B3KSrPB7jAj/5F1qzzFok4Q+eNn0vjFSPWJsemMJAvgXUtCrhtLZ7FVvufuS24xwRaMWP6szlqvsIifbKplkGnIVsv06D/9Bl9ZYnLL6WQHD7ym6XaVmUyHv1PWifnrpnwA5sFhGWAFu3c2fNAarBg7ojOtuAu3p7OIhLgnGcv0Qv6Ht95KesnOHEbACQq9+TzaR4yiz9FxJxu+1Q2mCxIboV27GGe4JAQz7/ynlSMXr4Petdm61oGaeziYssYjQcCey2jx/bWuSQ/04MwwW2ZMGW0O3e/vXBkk7n3OTjdcHHMVtr585rWa+XYDHjA6raKyPClhzrEzYTe9NBcN6Og/pmBoVpUaKUbXyIpOC4PdlqQjzZ0IpvVzwfCuNScACqq13al9mwPkWgMplAFvrHSIyULdRcjTcEyXri+abCcpFkE7sBmDsgme2V1jJY0LiOgShRS/R8dpiaiW4K2Qz3hJEEYpHFTPrCpP87PU1CQaUmIhEFeXfOYDNDfLB0hoEVFUtGQoiqyhOzHf5RJ14p4Nt4UmlPNTkecUrTz4boNhcnqWxnYyr1wvbsHt3Se4/nZQq1n6WFPHfVBVpjVzldd8jaTp23laUllczlsMVJ9FGJHbctYIh/WTL1inm6tkeQ26SUFMtspCk63xVJH/JacqppTZ7LW421kJqJytIqh6K8DddBLujaSz/SFFjjcpl80siddZrLGltW5oO1NeKCWvoEh8uWV4NzjuOwfbas04wTDC2dfmbbfD3JMuAP I73q2+1h RiYT+LdADHeTTg69V1N89TzpSyPe7ycib6mXHVwNXvhX1RJ88nYAUQexeHE8LjGzre9LfG+Uju2MHwEUkjvlJY7JhDfmG46BdHWHiHfHirHNmnXH+ofwnqEakhODgE0QW3upD1tu0TdJadBN9+NqtCuLQBXRr9w0pLQBcHD9OZdSzqouPbEs83oRhpqn8kum7gJthN/Jl4SZdEf+0/7LiSgvS8KxDvTVibFA2ca/2usRVvfCKiM1ds8OfEhZRZbxzjrcHA5VJxl/yT9kfrrtNJyrIDw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 09, 2024 at 01:24:27PM -0700, Andrew Morton wrote: > On Wed, 9 Oct 2024 21:08:15 +0300 Mike Rapoport wrote: > > > Using large pages to map text areas reduces iTLB pressure and improves > > performance. > > Are there any measurable performance improvements? I don't have any numbers, I just followed the common sense of "less TLB entries is better" and relied on Thomas comments from previous discussions. > What are the effects of this series upon overall memory consumption? There will be some execmem cache fragmentation and an increase in memory consumption. It depends on the actual modules loaded and how large it the fragmentation. For a set of pretty randomly chosen modules where most come from net/netfilter I see an increase from 19M to 25M. > The lack of acks is a bit surprising for a v5 patch, but I'll add all > this to mm.git for some testing, thanks. > -- Sincerely yours, Mike.