From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA422CF07A8 for ; Thu, 10 Oct 2024 05:47:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 527BE6B0082; Thu, 10 Oct 2024 01:47:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AD476B0083; Thu, 10 Oct 2024 01:47:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 327456B0085; Thu, 10 Oct 2024 01:47:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0E2A96B0082 for ; Thu, 10 Oct 2024 01:47:48 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7693440CF6 for ; Thu, 10 Oct 2024 05:47:45 +0000 (UTC) X-FDA: 82656610974.26.25E4072 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 89ADD100003 for ; Thu, 10 Oct 2024 05:47:44 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=e1wK0sqC; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728539196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7pL9DjnUbhD4Jj4TUGmgK/B+QAzH921/eIKxZUNyPg0=; b=kzt32OHDW1CPZN0hfFzwDmOUyO9RXz4aUSr1FtWle1AQcms2O4aIjGGKIrnHkf66c7Ihkn Hp5pl9yprZlgHqEBoTlVTrxwqC7OkmCQ18/xwmB0bB6+gj6BQWEDKugB96lZ59OZHUpqVB MnH/npJAgvcoWuWX/WxmXICRSllv1Zw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=e1wK0sqC; spf=pass (imf05.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728539196; a=rsa-sha256; cv=none; b=tDHM4uiVNuItmynjyiWkwAa6bc33w6XDx8w+docj1H19Y+F+F7LocacQauIOR/XEjsYNcQ ubkwgj+neMYA5VtDK0ZaQOI4eACF8OOvO6BX8NcABFHPx7/QU2zdCvriy4zhj+SMhuJiTi A6KSVC+AJzxTy4iyT/VuBAM+3Zns3FU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 729BE5C5406; Thu, 10 Oct 2024 05:47:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 941A0C4CECC; Thu, 10 Oct 2024 05:47:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728539264; bh=OTuy4VqE5rZSLBEA0/Pnb2zLZJiAXIMvgimloV5JAr4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e1wK0sqCj1hFSMccCG8VnSk9aTxpzFJTrYzsRT9VXVEEoRS3hraEZu619qHthJzSx DynBiJLcPJQRbA9J0lLh6ATNk3FB4/xFOM4dXnLEGXWPkSrxd0XcoTxriiWODdioLD 1sWIJTn6uT4ZOaW12OrRLOdpildKc5e58UW0/bc2P0yDusD5bq7Iwbf8r4b7hIX5Iy XccbgL+BkzqR13hBcI+eIsGnGBFTEruC5c+E0zapz7RRHpVu6gMKoZHI6cwfi2IRZM bP+nlVliXD/Sq3TcOU7AO/E8ZEwKb501SlYT1dTNQaVEK/mrQ9FtlySueDuymdFkFN xybmhUi0XMlmg== Date: Thu, 10 Oct 2024 08:43:56 +0300 From: Mike Rapoport To: Song Liu Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v5 4/8] module: prepare to handle ROX allocations for text Message-ID: References: <20241009180816.83591-1-rppt@kernel.org> <20241009180816.83591-5-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 89ADD100003 X-Stat-Signature: 6fge8yncm6dc8fhkjdf3ywgpjn6ygq6y X-HE-Tag: 1728539264-1357 X-HE-Meta: U2FsdGVkX1/y7SFEn4hKALAMtidlLIaX/sQdwVlXk/RvTjleFaPkPNixG1c4YiBR54K69TgolC96ZLCFx7K+f6Tk0+Prc477/W73iAAz+5IlJvBMZmqp3GSpSG60LrOGK9W/kbKp8Zolm5/rAV3Pq/6YyFjAOHlWiM6X2Mh/XK9TzQHFpSf0IfT6c5xVMghzDn8hepdb0PSx6BJ0gIr53K9HKWClVwTODRrxhNpqajOO6geCSdHwLrsTIDhNJoLSCEiNY8t9HHC2vWdg9Ilsbt9eVbRCTS5d4xQn/k2F8kWvrgrs8+aWpmFgwPzFB14/XwANUcXkNzGDUmFQ2Teo/ADQSMJagkKGtHyGHQtOQRBwli2ebAouQnvdzTySuysitLWmigrIxMeZ4z3ubK+JEiSS489DjFUJDsyi6B+9Co8OhBkmMVsM8nT3wmR4pQfQfDQZU6jSVR9+HBxRljuqciNVEDO9NotyKHji9/DChCJVp8cg+YT39Jhj5J5xzyPQavu8xpXOxTjO+u08CXYMV9NSZGI+xtJ+f4yqsYcihRvGDrJuyYme8wYogdzeGf+tblpuceRXhdNskKgLHM7wUDIPGZClRjTT2K+ETf5xHzeV0ONnBFK5pGaC/Sp/g4KH0OGsrxMxgPYJBbO7h6or9+NxRZHkvAbdIH9UAzG52b3GrBEL0sEi+nsm8lAKO9Y/YMo+6kC7xaRpbpvlHJGeF770uuUE2V8/y5fM6FxeO60ambsFO6WM0gvVp4zpt6k/X2l7C7N5nXb/PvP9yl/1uirDfxiBKJ2QAD2PBohOx+Yc/KLeR+/NzAxb1tSRcu0xqoH/gl4Vm8+qeIIxWwUjmQt2sXyCWaafueen2IIJI4d3lM5Sx83r992Y3kixBYnqyoIOJIa80ilj2FoLau5ZyHcvV8sML4VAPo03HCktZyaLpro8OYua/iclMt1cOWLIaW96H+hkaYS2U2SMbU9 U+eItvz7 jA5mmDfBXMcEYhdFtK8j031I36yP8zvfL2V+yaCyVBiQeSdnY1NTUOSN2gfjVe8IIZ/QtfVpQf3DDtDLjdbPzRY5vn490rQiM25L2Ka577wmOWQ9YONckSzQXQ3xkM3CbRFcQjXa/Wcpckm8eYAWkAgZyhIfdPse3gZBZaZc/gomuQs6pWnOg4n0nD/0oqIqQCUZq/DRRbTHY0dh0m4VoHzJfz7qmth9wzfVc513YVtpOFE3mqcoLJj2uchQEo6Ta9YIGZCrKm03vQjzeVTGoSw0KwTigPnJo6U0CCyPisZpSGhUqBRMLa0CyU+mP1Keaar20J1hEuxkK9Q4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 09, 2024 at 03:23:40PM -0700, Song Liu wrote: > On Wed, Oct 9, 2024 at 11:10 AM Mike Rapoport wrote: > [...] > > diff --git a/include/linux/module.h b/include/linux/module.h > > index 88ecc5e9f523..7039f609c6ef 100644 > > --- a/include/linux/module.h > > +++ b/include/linux/module.h > > @@ -367,6 +367,8 @@ enum mod_mem_type { > > > > struct module_memory { > > void *base; > > + void *rw_copy; > > + bool is_rox; > > unsigned int size; > > Do we really need to hold the rw_copy all the time? We hold it only during module initialization, it's freed in post_relocation. > Thanks, > Song > > [...] -- Sincerely yours, Mike.