From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0B0DCF07B7 for ; Thu, 10 Oct 2024 06:57:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74FB76B0083; Thu, 10 Oct 2024 02:57:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 700346B0085; Thu, 10 Oct 2024 02:57:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A0A96B008A; Thu, 10 Oct 2024 02:57:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 39D826B0083 for ; Thu, 10 Oct 2024 02:57:18 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5B1A181B68 for ; Thu, 10 Oct 2024 06:57:15 +0000 (UTC) X-FDA: 82656786156.01.8F9AE77 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 669B4120005 for ; Thu, 10 Oct 2024 06:57:15 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="QWjL/ef7"; spf=none (imf29.hostedemail.com: domain of BATV+13eeef5fd6cafc46e7de+7718+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+13eeef5fd6cafc46e7de+7718+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728543254; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=053yPSqgX+xVLoacqjtpWuCBNx3Ew/0eqSAR54be0Yo=; b=yHkCLYNDlklW/sWYYxWsSxtJ+5o4XLcIo47bAaazEeLcEk5MmUGufLYmdqFiWoHCn3ISw4 iUDLsB+8fIq8TdBVlXMIAJGGS08mvZHH7tRNqXeDaOWX8/lAX7WlkRUSSy/rM48qVZ7gwu aReSQL0A5Q4Ladozo/ZC5vbk0xT9qaM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="QWjL/ef7"; spf=none (imf29.hostedemail.com: domain of BATV+13eeef5fd6cafc46e7de+7718+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+13eeef5fd6cafc46e7de+7718+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728543254; a=rsa-sha256; cv=none; b=LqKHeToNk1b+LuP/TKkTKtwD3O2xzRdGI+YPnx01GgIA5ecGj77Ujw9Jq2ClamIQHQ0FVB UVYrmsLbuuj9gfRzyZ2bDAH2jcmRmskqf12YcGnqs4Wf53QZeSVnT4SZFOabo463RdC+/p QjnY6Oq51m7NlMs/MjAjm7MTb6Yq9gs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=053yPSqgX+xVLoacqjtpWuCBNx3Ew/0eqSAR54be0Yo=; b=QWjL/ef7t4NfdHQ7+ikpJ84WE6 Tv3JStjrA26fGK50QoFCrOZKD8MPCk2cUy19aXnEhRSMGgdtvuO05QCRtCngoHhMQ33YSkxggcwcl /8eTdvS/gyJ8yjj4OHnjgnxJVDyZl/cUu24C1a7S1zejQqboASikt51Fh9Ntt0Smk3Slk9O/RzO4P HtOuCDb4Jbeh3HIGDy01x3nuah1xCKNQHjX2IUCo/yxp53VfhvoZC4lQtEWvsXnxm0vcujiphLfuA brUDkf5ycgRwkSBfRJX0/yVyYdmNgNWOH3sLEAXvaVdG+AQFXKlL23ma1MPX2I8m8b13OCjrlebZS vz4QzXyA==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1syn6b-0000000Bl2f-08gV; Thu, 10 Oct 2024 06:57:01 +0000 Date: Wed, 9 Oct 2024 23:57:00 -0700 From: Christoph Hellwig To: Mike Rapoport Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v5 6/8] x86/module: perpare module loading for ROX allocations of text Message-ID: References: <20241009180816.83591-1-rppt@kernel.org> <20241009180816.83591-7-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241009180816.83591-7-rppt@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 669B4120005 X-Stat-Signature: 4cimiwp6y1u5q1rucugcjyw1yboibqoa X-Rspam-User: X-HE-Tag: 1728543435-90275 X-HE-Meta: U2FsdGVkX18x4hYyCZd+wErS8ecvWUJAiG+rynlRBmqYdJgnYGGKkj5z0mq/8mcdDlrRYdJRLNRDj5bcUVakgBg5sz4nsRm53DHdPyjrsRwGKS/2xy/4mPYIqmDZK41J+L1D1oAPKEIxZAAC9C15Hna6T5FRnzBAn9A3SxNBgPOFuq9BShwVe7PI2Ziw2EfhtaPf/2sf0BSONGMIf4kCzQ+gPWDIe/DllPWW0RpqIqeL8CaRIe9VyIdEHCDR0UduKTVsOGTkirNCerTqORjDVxsHPNMkNC9ReUK9eZK+5edx2pPL8Vjq2lAdUbmu5K/KiGQ2obP8+s8NQcQLg5xOzpgo4xkOmISa1VNiobpUU0Xe2OyDwTlPK4H/isle91J8Kgn7Qb3MBt8Qg/95+Inb0LJrfRTthSFjVP6AbJARmr3kdMlEph7XcahlEvYVA2ZJUhrgcpm/EkpCtmz8UC3phnCTPyfTcEuB+rzD9YeP0NDE6rBPz2EhLGESI7wq1kzTIQrbEpybkWOdtipAhB5a7Q5q4VMDFW9O521uS5wEg1MwMIWNJlQcfVwiFItKFNdlgr3qaEPImj1jMMCbQ26AGBtcL+L240qzgxZkOx2htEHcWxDO3BJzq0dJZmIIVDSGxsiBvDwzFbmQsdKv/3jAp+QqLsF3soXr2es3M4ehfDzlrheXU6rYmcbZ0rgGwXL8z9Jo1hRLzFMx/o79nuPdkeX7ZdfTDL1zKkinxd1INgseO9KeTMOsNfoXLaGWVjviuUw2zoMdQng4wqGPQ0m53Tn8cVZSgdzCXmKsTiCtOWFCtJY1p/r4KicSYjllxTxBvcNlvuVFJX4U7iz0FU1hYM5WjqzyRRlpJ/CY0RdQo/umszu5hZ9wiMpvKuhhRSStrpz/S6QDMi9ECPFjddfeCTxSHJ/44v+OTTQ99vsSUGwffensIn5aU2SagTAyKlZThrWeo6Ks5BMfjBpGFP8 vCC1OyNI 8dYLRN/N59k8qtBCZhilO2rtorFP37b/czf3vMiXLu6od2d76VpUUQxa4G1t/ou5QDB3pwK8tR4tlr1pnfEv5XRNra8I6jpN3n/kj9t/p5mTCJEhrzxxFEoOca6MSdNXmoLNFAP7PqboW2W5SxtxK+ar9MEADaXs63R6EpK7Eih5uVcDEvwdQVMgGN+pocPegoo16Q6N/ozpb+iH6alVLILsLhuUFE7N8ALfyzCQBitMKNFq2eqaoum7Y5UN3iITmxqaXTjaAJ5zCzZlmScyltHvLyuRjfE3AytgVDntoarlytFVy37+Cf0PYOgm5rgE+Qu3CXW0cLQ3Yq/AsCY7ajqvm7tXTHEmqfqbK5y/wGnq6RwMHK8e37U5hukk5oSvf/z+WAZ3HlkAbc0OxaDiFztmQbdQYYJ0wzuf93GokPajto0lybAMOfC32Z6K83GgjZDiT9+VI1C1eVD2/9kchzWkw9RCSvre+qvW0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > +extern void apply_alternatives(struct alt_instr *start, struct alt_instr *end, > + struct module *mod); > +extern void apply_retpolines(s32 *start, s32 *end, struct module *mod); > +extern void apply_returns(s32 *start, s32 *end, struct module *mod); > +extern void apply_seal_endbr(s32 *start, s32 *end, struct module *mod); > extern void apply_fineibt(s32 *start_retpoline, s32 *end_retpoine, > - s32 *start_cfi, s32 *end_cfi); > - > -struct module; > + s32 *start_cfi, s32 *end_cfi, struct module *mod); Please drop all the pointless externs while you're at it. Otherwise looks good: Reviewed-by: Christoph Hellwig