From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23C01CF07B3 for ; Thu, 10 Oct 2024 06:54:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FAD86B0082; Thu, 10 Oct 2024 02:54:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 884596B0083; Thu, 10 Oct 2024 02:54:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FD336B0085; Thu, 10 Oct 2024 02:54:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4B7FC6B0082 for ; Thu, 10 Oct 2024 02:54:42 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BB7A7AD019 for ; Thu, 10 Oct 2024 06:54:35 +0000 (UTC) X-FDA: 82656779604.12.7842FA6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 97B7F20008 for ; Thu, 10 Oct 2024 06:54:38 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Pkikn0l9; spf=none (imf03.hostedemail.com: domain of BATV+13eeef5fd6cafc46e7de+7718+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+13eeef5fd6cafc46e7de+7718+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728543209; a=rsa-sha256; cv=none; b=NSxdOIr3/QY+2ycoduqLXC4rRZguikiJlOlux9A0tY8FlGPXRQCNCDqDhLHLuBBMidasbG E2OkPMQwsCWx48XnpDRkKbKmf60RfMA6YBrD+SLjG68SQKMgT9SshDKJj2dFxbeHTltoGM Cs8srK+tRlFCxKdvvRhB8Qn05+hFJDA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Pkikn0l9; spf=none (imf03.hostedemail.com: domain of BATV+13eeef5fd6cafc46e7de+7718+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+13eeef5fd6cafc46e7de+7718+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728543209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l9uqvIs7KaBM8jKZiiP+47rSYlM+HcdGDx8MG0uieP0=; b=cBkvkP/8smY0a3SpuqyhqPxZVwjd4/JtGs9CDudQfAtDG2alP13ZVHZSWc7d7IC6kw/Brg 5GSI4uLGGsXiiJT2dxdch+dHaVTUyV8mRKGo+AjZScXldsa8GulRRXxSnTZFU44Mb67t65 DFQPhkeq/X0nwo1V6+cOxsmso/XcIjo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=l9uqvIs7KaBM8jKZiiP+47rSYlM+HcdGDx8MG0uieP0=; b=Pkikn0l9YV6IbkwdMYYYCh7NS0 +bbHbF45MU5mE1Rb3r9FII7FXayka1iyxVG7DxF8G4bp4UvbmBPvBXdRuLXOELz0YXQIDC8U5Vn/Z p9TLWCXHDeIkv9jMspqGVrsh6ZAZflPmbSh+0Buo8JVPN3NtIEsSbcNt5fO4pYKDvwm0BaYhbAo+N oNRfxee9fN9eH5HZGZktQTD2xofG2NZkmjD02X0R0ddOsfVe32xN+q0mOP5NTLyXNDy/F9gYSQgQ6 a6T7FZrz/gQpO3gePE4DR+RzB3Q5ElwqokanAq8dbu2GoF4JKzdy2n24Yyu3ivAljHZfXKQHFYvVQ fygr48vQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1syn3r-0000000BkI0-1JPh; Thu, 10 Oct 2024 06:54:11 +0000 Date: Wed, 9 Oct 2024 23:54:11 -0700 From: Christoph Hellwig To: Mike Rapoport Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v5 1/8] mm: vmalloc: group declarations depending on CONFIG_MMU together Message-ID: References: <20241009180816.83591-1-rppt@kernel.org> <20241009180816.83591-2-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241009180816.83591-2-rppt@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: ttqorb6sw3uxbddgrh6y8dk366st3ge8 X-Rspamd-Queue-Id: 97B7F20008 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1728543278-454707 X-HE-Meta: U2FsdGVkX184Pq6p7ZeshpuyLzft5+kT+x0plhB/qi1pkJccMpmpvCD8VHrQyhF+7p0OlUw0CvLTqui7rn4KyZB00B4eZTs9wDc2FZslwei3L47A+p36tuykrcVvwqnUqsm4olBO61zTBdlqZ7Khmbq0qPtuSO+dUuWlPnEqqz/Z6PoR5NtfI2hf6NGOJCgxbc/gPQnNSjSEKlyap4nzgu0gJ7g7dpY3oub2NBPaePHDfvijs07CeH2irBLgAZNfFiPK+x6inm3/jfVg8Qm0mBDv+Rbhph0/YPC5YZ+4F31HCkyPLu10vkxnVzlQiiPp524ULzo3In1F8RnkbpdyiECeqizEzqCrulXTfuVl8K7oeECvRB02d+kRcYYTVfr+Su7ccKpHriF/KFM3SLcHu8o0juPDvIyVdpX200TPoANBvYcGBqhkYAPpLRmD/g4j4zNPCis/PssLFhOOVP8tK1aip3VoLpYOGcBCjad2mabFGxnvMc6ZRwrVjjYWol67RawpvRE5wXN54ZjT+hdBZJwwF81PKGLMMun4hX9U4aPSnlFnB5kT/a1ERQwRUYP+UYwQqP+XuN0u4WDhq5mNh9F6PSuMYaRNaI1JQrQM7FwbWp/YmOfNG1zIMFdOxgOy1VWab4YWfz6t1xSRCS0pD/hmELnI7qI6/cksj+vnUeRvxhccmO2EjEr0WLoUTG9HAxrFNS3yxbN1aMR9FZ+dLig3QAUR9UzCPqd8sVfsJ24x3RJxWC21TGDLdM18nWqXwNHUlni8FhYe/cNyW4ccqm4nNChwhtbjJS81O1Yq5HWg9DGZYeWGZk0+pZEWetfJBUyr5RsQ+kHYJ/smT5Y6Wv4zHZC3sF5GfSfwNV5IWQbEio0xHON9uxLjCW5nG3e0XBNr5b59M7HIbdAuHnB3WZZo+8tM/C0fe0XdBSwcBnvFon7tPvkwi5P9ePXY0i8iBKeB5szA+0jUkSoeBbk DRNOaNVc aSMsMRjD0VEwDSvMiImx2bZJMviGJxm9dCJwF/cXnqKA5B7XfR7e0E/+B1YSOoAe17G9JUPCHOJvWxxhy2tYcVTcnrFnXu7h9KrRiUANWu2j6cBGCkwlvmdywRWuAt5wZaotkPekSJIPstMaWt7nvC9LGKPowl5Y8HQ3RMNvODb3LfDyQniE57atH2PNb/mZY44LrJK9VDIKBI21dJHfNyezcOGMqiw3MkizhdmAAPCKFra8UcMaqUC6LyZOd0EU9gQcpwJK6zNp9cK+Wr61lH0bpbbIKtO5gM1K6qcvbjZAuUjg0qv7vAQkEe3gQZAvEWBlRbe8FgTUzeO1pw2Azhn/b1BNedrQ47iaBdhqsoBwObJ+Y2Zh1lIyE3w1rDWICLbs5+AV8ScDxWmHtycu/a2Ve9yCvMyqFF2U9kBpoJbGueqdljknkafud2xuzgMnFdYcDPr5+fpp5YGNtjNx4T5c8N6O8NQjCO0Yj6z4E8PY4S8Wt8aOK+EVOB4JbAY/3lyJX92jXlXLmpcLdjHsEz1n7Pg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 09, 2024 at 09:08:09PM +0300, Mike Rapoport wrote: > +/* for /proc/kcore */ > +extern long vread_iter(struct iov_iter *iter, const char *addr, size_t count); > + > +/* > + * Internals. Don't use.. > + */ > +extern __init void vm_area_add_early(struct vm_struct *vm); > +extern __init void vm_area_register_early(struct vm_struct *vm, size_t align); Please drop the externs while you're at it. (one more down below) Otherwise looks good: Reviewed-by: Christoph Hellwig