From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 559DFD2A52C for ; Wed, 16 Oct 2024 15:38:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C35B16B0082; Wed, 16 Oct 2024 11:38:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE55C6B0083; Wed, 16 Oct 2024 11:38:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AAD056B0088; Wed, 16 Oct 2024 11:38:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8BE0F6B0082 for ; Wed, 16 Oct 2024 11:38:01 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 02A1F1C28D3 for ; Wed, 16 Oct 2024 15:37:49 +0000 (UTC) X-FDA: 82679870868.26.4010346 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 000C5A001F for ; Wed, 16 Oct 2024 15:37:52 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PZWWOk03; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729093005; a=rsa-sha256; cv=none; b=kjgaotlE6RoJ2eIOmLysvmnNuwvT5MN7Teta+kTDjdq0htNXPZwj2bANBMJp8C6bR4n3se R5LaiWyPOQdyO1vPji4/OpEIRTDrHsb9VDM3HyOKShPL+z88RpxegBUojznmM8Z4GM86sY upZMIkWxhgRCOiwzXcy5kIUjo86GxTo= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PZWWOk03; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729093005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NE/daF3JwSlAOHoHFySuoCdtdh/nK5By8Ql8VqAMJdQ=; b=A5OZ+e94L2AupAbGZn+c0y5kon8nMLqtA5bn+USdMKeZXpQCV788L19DX5FVICUV0/xE59 eRxQx+arKmA7/eVlSCwLxIVuriSFAQ5W1GkI0O4eHm40/xSKjpWuFwM5D68Hjbky1NPRjX rAgb3qVzXyPupn38LQOwRWL6EFZ5JNA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NE/daF3JwSlAOHoHFySuoCdtdh/nK5By8Ql8VqAMJdQ=; b=PZWWOk03YymV9i8fSPmYETeYdU mePBbxPtqyNy51/xnqtP2chxnEgKVphBP4GiWmdJhyZm4/96KluzISKDb/RHLQ4v/H6g8qgHNhrhA ijYkWh+Ozk1U9gkf0R1NtfA6ExnLFD/1K3SZu3kB9QpyrINgYZw0gH1pAGbPvnY5yuHmnhuli4IkY 9CvcF+m6hI9aDdn29XxtoQAMcv/HuYT6Sql8ptWPpNzdVBc4TV6Rbt6iLfvMdQFdAI2p/Xh4lQwcI 28zM0hU8h1B4zWySnLRW/7PA/yMTemsXk8pIYFrc4+kV+C6tMEdP7QWgkdrY+aOr7ovVcKp1GNZGO HJS5YXxw==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t165w-00000008Jej-1xLm; Wed, 16 Oct 2024 15:37:52 +0000 Date: Wed, 16 Oct 2024 16:37:52 +0100 From: Matthew Wilcox To: Baolin Wang Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm: shmem: improve the tmpfs large folio read performance Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 9sq9fj8gysw9kemgkab6cso6xezpqkwp X-Rspamd-Queue-Id: 000C5A001F X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729093072-468344 X-HE-Meta: U2FsdGVkX1+GqKeHou8rcg+4uIEw6AQU6nMZyESfuKVmhhibu2XL1hW/27ayYf/I8Z09KIPadpDmah1e80hb+q3Qht1lXoxiNjMMrGtJH/RMIbqUJELDsBeHfhe09uVVah8mlrcVhryW96JvhL+L9zOSw0I8wjm1+Nl1reNMq7sUeX46NtttY7cslH1kaSEVpPEebvWFTGuiVW50CYlKTfEeLVyLuxnvTB7LZKCUhHKxlk64szjDJhstrHVh4v9XZVz4lPdY1SL9IGIaSvrA/C+/iNwFkJdo9zFdR01DVNtqm2m1mvQ+glKegsOrD5rdsMNA0FmpElo9q9YSQuDUkyUIUDD7izFot85s6p6JsfeDlGnMW1AoGdumVtSbmEcixWkETPw97XXghnGdAolCcODB7y4gzFfVTijIafSwIIjyu37+GFA+7WWBEalQs4q+BcXaMEhVR0wF15zd7Rto27lw6vFfvhNc7WyTO3m3UPVLBaorFZxi+AHxFjHOLgb+6gChJHs2TeMyVfUiVwblSjay6SSICe0zSsWy7fd/R+oMoTc59Q+JIt7ekENBuK2Ee3gezoSe7H/P7bd0mirgqTWjEzWSsmduD6kEG6SaCQ5iQFE/j6Mf1e7dIYKABiw/SDhvt5IpDWtHuh4kj0kvgCwgKKZw/6r9okcAzSvD3UzLtHgoOz/x//PtmAAdWn7c7AoKRT/X6HR0NmKxlx2PhFgOWIsVkeVys+EpFV4NfoPbvXcIfu2FjTCMmD7R8tlLvugtw5Vqe+XAB1MHfjAVADuyumU//Jd1uchjWD7njcNqx76rZJo4j8eha34YjvI70MzoanBrotiVh1A4gfXcC21P2BRrLTtFgAoHDsbbz/3MqfqbbNo7gVG8KrS0rQA5TlVbp7JR3vYBU3XGi7RaY+1a7YQNXVuzJhcqJpQ5usX404SMlKKi+OHTTYZ2JoY4yRmOVxWJSwm3nLxY2zA Po6E3tEM 9tLfgu1C77P5R73g/tnq07ZYNbz+t6aHwy/JsanbfAHFpNo/rHtr+natPTfG7mW0N9CvyhHnuKIowky4rKpTxC22UakWtbqyPP9m1kTjqEtUCG+dYGrjCGBhjDrjQZscG1kdqMNW/nCF3MA3OwMkvcPpTnVPI1EVEhZOAOptDJDdFu6WkmcMV7zI9GTDdf1ZaunWPBqc92Tp6NisgWcRSnD1+4rcsN5wwVmEB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 16, 2024 at 06:09:30PM +0800, Baolin Wang wrote: > @@ -3128,8 +3127,9 @@ static ssize_t shmem_file_read_iter(struct kiocb *iocb, struct iov_iter *to) > if (folio) { > folio_unlock(folio); > > - page = folio_file_page(folio, index); > - if (PageHWPoison(page)) { > + if (folio_test_hwpoison(folio) || > + (folio_test_large(folio) && > + folio_test_has_hwpoisoned(folio))) { Hm, so if we have hwpoison set on one page in a folio, we now can't read bytes from any page in the folio? That seems like we've made a bad situation worse.