From: Matthew Wilcox <willy@infradead.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: shmem: improve the tmpfs large folio read performance
Date: Wed, 16 Oct 2024 16:37:52 +0100 [thread overview]
Message-ID: <Zw_d0EVAJkpNJEbA@casper.infradead.org> (raw)
In-Reply-To: <df801bca5026c4b06cb843b9366fba21f0d45981.1729072803.git.baolin.wang@linux.alibaba.com>
On Wed, Oct 16, 2024 at 06:09:30PM +0800, Baolin Wang wrote:
> @@ -3128,8 +3127,9 @@ static ssize_t shmem_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
> if (folio) {
> folio_unlock(folio);
>
> - page = folio_file_page(folio, index);
> - if (PageHWPoison(page)) {
> + if (folio_test_hwpoison(folio) ||
> + (folio_test_large(folio) &&
> + folio_test_has_hwpoisoned(folio))) {
Hm, so if we have hwpoison set on one page in a folio, we now can't read
bytes from any page in the folio? That seems like we've made a bad
situation worse.
next prev parent reply other threads:[~2024-10-16 15:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 10:09 [PATCH 0/2] Improve " Baolin Wang
2024-10-16 10:09 ` [PATCH 1/2] mm: shmem: update iocb->ki_pos directly to simplify tmpfs read logic Baolin Wang
2024-10-16 12:34 ` Kefeng Wang
2024-10-17 2:45 ` Baolin Wang
2024-10-16 10:09 ` [PATCH 2/2] mm: shmem: improve the tmpfs large folio read performance Baolin Wang
2024-10-16 12:36 ` Kefeng Wang
2024-10-17 2:46 ` Baolin Wang
2024-10-16 15:37 ` Matthew Wilcox [this message]
2024-10-16 17:33 ` Yang Shi
2024-10-17 3:25 ` Baolin Wang
2024-10-17 16:48 ` Yang Shi
2024-10-18 1:45 ` Baolin Wang
2024-10-16 11:47 ` [PATCH 0/2] Improve " Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw_d0EVAJkpNJEbA@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox