From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D698D2A520 for ; Wed, 16 Oct 2024 14:41:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 090FD6B007B; Wed, 16 Oct 2024 10:41:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 019D96B0083; Wed, 16 Oct 2024 10:41:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DADE16B0089; Wed, 16 Oct 2024 10:41:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B5D096B007B for ; Wed, 16 Oct 2024 10:41:13 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3871C140306 for ; Wed, 16 Oct 2024 14:41:03 +0000 (UTC) X-FDA: 82679727774.30.19D0644 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf27.hostedemail.com (Postfix) with ESMTP id C94BC40010 for ; Wed, 16 Oct 2024 14:41:02 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="U9/dQOV8"; spf=pass (imf27.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729089624; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xNOEBHIW89c1j/jhsHn9BJm63iz+XQaKnsI8oRx93vU=; b=B/xXu6vbX4VEfXiJRxw3+fOHu0EBNb3gyxkdtm2cWmsXeUbDTgGk5U1xMngsFVASAP+taR w0b306JugAlU+sWYqyCDinCz3zYlpxBOlCpsu1McNs4Hedzotr8+HosjapiPJarsgtqdG9 VuaBjzZDEy0E6Ap+S5elGjTT+dYm+QY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="U9/dQOV8"; spf=pass (imf27.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729089624; a=rsa-sha256; cv=none; b=FO9/VBMH4FGyHSvWpiT4McVXxE44VX/JLZjTdsVZrC1siRHB6BExXM7NWepLNEveYkq/BN k8D2hAVjmQAKTanVdNVphltQYArm+CVtdAQlny7GmnXMZyjQeb1PgZx1/xsKM3tdhZEzeG Y69YiaUGXct/gkcQ15SBTJt5tLpxR2o= Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2fb5638dd57so31652421fa.0 for ; Wed, 16 Oct 2024 07:41:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729089669; x=1729694469; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=xNOEBHIW89c1j/jhsHn9BJm63iz+XQaKnsI8oRx93vU=; b=U9/dQOV8JKpvly9ubnPP9dljaT/WGYjqm6FNwiTR+MIGH8iRhfnAtdTEmDMaOQaJhm F2T99/QMrXJFYUsRhrn0m6XMB55eyZpPmLvka6/ZQtyWHeI24hJQ56KwM+RqSJXJj+eS gAjAOPbDXxpDfFDurZUcupaBMar6B4noIu6Ieyiqy2qZhVuukRto9itpE7lJs4VgcVCi r+NGmAOq2zLoUAPAt7ZDhY7ImEvsn7960rda2Sj6aB/2HZlUtU2ML8/zpghdjUvMw009 0Kij1SwBYdJ+ye7qMSYIZEYftG5xGFy99L9dAycsx4qgnPgfcf01S9EbIkrdyyxmMqQP QWiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729089669; x=1729694469; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xNOEBHIW89c1j/jhsHn9BJm63iz+XQaKnsI8oRx93vU=; b=NNxZ/I1RByx7j9beklxtq44A7gZVqdmLX6ixT/0GtDXENC8zHFKfacewYCEhvNkae9 svek3JlGzyQueQQ+zPdeWE3mLbjLzoBwOIYEjfSSLj8Wc9KcJWPZ8byNoxxziDwdulJU C7FPxGgTu2i8TUuCzQW68vIQ0Wo+mKNk36Wo8RMXthy2bes7/88Yx/ct7duU0dlT8lsN JQZOhKlZteVmgtN91zgG97drvkTTsLSddLw0wgFAj3gECHNEAwYXHYCgeZwKohFr6VEX oeEsgrI8PFr/BY8Gjox8Rmayi8zBG4MGy32zvhTiL5a7coyUDPZ61OAgWk6bnu53hsUb tq8A== X-Forwarded-Encrypted: i=1; AJvYcCWVOVnhSp2osO/rwP2aX+FHOq4vsTKmOxgTfMZTvhgN99hVpTwDnfqk6t5PihQCrhx1URVjL+7MfQ==@kvack.org X-Gm-Message-State: AOJu0YyYqueMOTE18vqT6P7XA3uZwPNshCvWF7IJdMH60hYOjjRQ7Mez TFs6epVLLtwOBl0eFcC9CNhHvYCPmM55T9fOb3/0D5tjEdkhpH2U X-Google-Smtp-Source: AGHT+IEQ2b77do+Ei5H+uRLYrEtNQq0NK3oK0wCc+2cFtuWRuK/aQBOOdJJvL1LeKTNOBzUMcJr/yQ== X-Received: by 2002:a05:651c:1989:b0:2fb:6181:8ca1 with SMTP id 38308e7fff4ca-2fb61b37a76mr33036831fa.6.1729089669341; Wed, 16 Oct 2024 07:41:09 -0700 (PDT) Received: from pc636 (host-95-203-1-67.mobileonline.telia.com. [95.203.1.67]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2fb5d1d0244sm4327361fa.139.2024.10.16.07.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2024 07:41:08 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 16 Oct 2024 16:41:03 +0200 To: Mike Rapoport Cc: Andrew Morton , Luis Chamberlain , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Suren Baghdasaryan , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org, Christoph Hellwig Subject: Re: [PATCH v6 1/8] mm: vmalloc: group declarations depending on CONFIG_MMU together Message-ID: References: <20241016122424.1655560-1-rppt@kernel.org> <20241016122424.1655560-2-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241016122424.1655560-2-rppt@kernel.org> X-Rspam-User: X-Stat-Signature: 48xt6cw4wb771k39hmwoq18jo6u4ia6m X-Rspamd-Queue-Id: C94BC40010 X-Rspamd-Server: rspam11 X-HE-Tag: 1729089662-575614 X-HE-Meta: U2FsdGVkX186ceXJMWoEVFz5Q00jjTX+Cz6WGeiHuOWl1XrVoVRDJv37Kqg5U2VmXyCvjh2lM1vyXB30of3d12LjLQWJM946tUd5R95Fynky43cGyJYDLxOjDhPYKXV8ozc+K9dDg9Sodt6CeeU+UPp0ImaO927AUix4XM51leiArj4Ka5C2WxCwfMKkxAv/e69jXM15Tisfg3Rb0tHPdw2hq/DeCr3bRrepOw7SsWtLBhGdhPX6lHKmbQ5Nmxz++3e7d+yFhVUe9AXZKatRstFPaQkb2uBQBz5RVy+ITJVkG5P7ncN5NxtMxJXqmShK2o7oPsFo24A6v1gDeHIJJvn0mNkH77NWm1mBX64hMPSLB/frMhQMNLzw1C8z+NBaRl24OeIttZYPKEhnZD1GBery2n+3yK0z5JG41OCzfueke4amnqSJl64zn2Sc+yhLaeXjNsgxFG/GFMX47IwakfG8JUCJdwZMlZLgkhcai/qqCrVmUPtScL2FeL2aclPP5gI7EJJjYe2ctA0woidX2TZHH/E+dwgZKbSsJZ57C3kLe5uCsyUwj08yPONbW7lsRXOf0+xy4TMsvP9SPhM9bXCKaeQP/OD5Fn8hAk89wKBtL3Xt/LbAODEpORCkn0XJDfd4rYYk76jIF3Bt9kaMnINEb/YcNNhmfEdhkNKqY+1DXdzcOm1S0bmwEWWnYZ6MhMCRjGxMkhq8Q5isr9RjiF8ym2MUg9SQ2r0TUZ2HE4ORb5dBNXJb2dRfJhFjJlIft4POhniUOGX1px7HKatJ0S4M2regd/cTssXpFvwYk7fTZ7jnffLNxUxJMwCSPl/J4eZeYkhbbTBzYgbtpysZ5FkVd2ImB42K+m0v8KgDSQDJlzvHSlyU5z2rtLvJyUBzuvXmNf4qsu6fs5sM/o/mm/SnWXf8N+D6NV6l34fZBoerrq6QtQs9iq7UuizW62y80j/XK1sOqUctd1zOvSr BXw2MBcY DSh/8MhejCieCq7oSAObiDR0DTTvDFX0hmctm97a3nWVAfZVBhhgV5CSZt5Xh4AQREZ+dR8LydeiLk4unMQCkKGfvFsihgZmVIUEfY8jJdNFO0Ajtfk2eIEZNy8AJh0UTKTglWhebI+5F6NB+kNnQbZgM2hmKz1pfWhT3H6psDP/DO1qF4Q/OKI95nskmsV1GkD65frtSweloNkfCnucU0CNsh2cBM0/Ra++egwT2MUUAadDFYZ6VtzEKuGiYHTXZDJljF8b2hG4Y5q1uWiD+iFGaiYfoldTeG09uY2vo3m6N/aMq4wB39QuXQBXWbucBM7kS8O4P+FovGbhJJClsDmYBZOIwlwlswyuquDCT6Ry55uS6hyqF6tyaHUzmBIUgBQI8u4Ov12LuGXWZlI/gjLFNnrXJrH10iB7Uroidw8z3njOrEF4gtrfvFef/k4V0hI0RWaJk7HrzLACB2eNjVFc8RqTvTZRWI3xUf1xcmdAYOwk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 16, 2024 at 03:24:17PM +0300, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > There are a couple of declarations that depend on CONFIG_MMU in > include/linux/vmalloc.h spread all over the file. > > Group them all together to improve code readability. > > No functional changes. > > Signed-off-by: Mike Rapoport (Microsoft) > Reviewed-by: Christoph Hellwig > --- > include/linux/vmalloc.h | 60 +++++++++++++++++------------------------ > 1 file changed, 24 insertions(+), 36 deletions(-) > > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index ad2ce7a6ab7a..27408f21e501 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -134,12 +134,6 @@ extern void vm_unmap_ram(const void *mem, unsigned int count); > extern void *vm_map_ram(struct page **pages, unsigned int count, int node); > extern void vm_unmap_aliases(void); > > -#ifdef CONFIG_MMU > -extern unsigned long vmalloc_nr_pages(void); > -#else > -static inline unsigned long vmalloc_nr_pages(void) { return 0; } > -#endif > - > extern void *vmalloc_noprof(unsigned long size) __alloc_size(1); > #define vmalloc(...) alloc_hooks(vmalloc_noprof(__VA_ARGS__)) > > @@ -266,12 +260,29 @@ static inline bool is_vm_area_hugepages(const void *addr) > #endif > } > > +/* for /proc/kcore */ > +long vread_iter(struct iov_iter *iter, const char *addr, size_t count); > + > +/* > + * Internals. Don't use.. > + */ > +__init void vm_area_add_early(struct vm_struct *vm); > +__init void vm_area_register_early(struct vm_struct *vm, size_t align); > + > +int register_vmap_purge_notifier(struct notifier_block *nb); > +int unregister_vmap_purge_notifier(struct notifier_block *nb); > + > #ifdef CONFIG_MMU > +#define VMALLOC_TOTAL (VMALLOC_END - VMALLOC_START) > + > +unsigned long vmalloc_nr_pages(void); > + > int vm_area_map_pages(struct vm_struct *area, unsigned long start, > unsigned long end, struct page **pages); > void vm_area_unmap_pages(struct vm_struct *area, unsigned long start, > unsigned long end); > void vunmap_range(unsigned long addr, unsigned long end); > + > static inline void set_vm_flush_reset_perms(void *addr) > { > struct vm_struct *vm = find_vm_area(addr); > @@ -279,24 +290,14 @@ static inline void set_vm_flush_reset_perms(void *addr) > if (vm) > vm->flags |= VM_FLUSH_RESET_PERMS; > } > +#else /* !CONFIG_MMU */ > +#define VMALLOC_TOTAL 0UL > > -#else > -static inline void set_vm_flush_reset_perms(void *addr) > -{ > -} > -#endif > - > -/* for /proc/kcore */ > -extern long vread_iter(struct iov_iter *iter, const char *addr, size_t count); > - > -/* > - * Internals. Don't use.. > - */ > -extern __init void vm_area_add_early(struct vm_struct *vm); > -extern __init void vm_area_register_early(struct vm_struct *vm, size_t align); > +static inline unsigned long vmalloc_nr_pages(void) { return 0; } > +static inline void set_vm_flush_reset_perms(void *addr) {} > +#endif /* CONFIG_MMU */ > > -#ifdef CONFIG_SMP > -# ifdef CONFIG_MMU > +#if defined(CONFIG_MMU) && defined(CONFIG_SMP) > struct vm_struct **pcpu_get_vm_areas(const unsigned long *offsets, > const size_t *sizes, int nr_vms, > size_t align); > @@ -311,22 +312,9 @@ pcpu_get_vm_areas(const unsigned long *offsets, > return NULL; > } > > -static inline void > -pcpu_free_vm_areas(struct vm_struct **vms, int nr_vms) > -{ > -} > -# endif > -#endif > - > -#ifdef CONFIG_MMU > -#define VMALLOC_TOTAL (VMALLOC_END - VMALLOC_START) > -#else > -#define VMALLOC_TOTAL 0UL > +static inline void pcpu_free_vm_areas(struct vm_struct **vms, int nr_vms) {} > #endif > > -int register_vmap_purge_notifier(struct notifier_block *nb); > -int unregister_vmap_purge_notifier(struct notifier_block *nb); > - > #if defined(CONFIG_MMU) && defined(CONFIG_PRINTK) > bool vmalloc_dump_obj(void *object); > #else > -- > 2.43.0 > Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki