From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1156FD2A537 for ; Wed, 16 Oct 2024 17:21:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85D7A6B0083; Wed, 16 Oct 2024 13:21:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E41D6B0088; Wed, 16 Oct 2024 13:21:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65D7C6B0089; Wed, 16 Oct 2024 13:21:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 461DE6B0083 for ; Wed, 16 Oct 2024 13:21:13 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B9BCB160935 for ; Wed, 16 Oct 2024 17:21:01 +0000 (UTC) X-FDA: 82680131058.04.B0B8F7F Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf12.hostedemail.com (Postfix) with ESMTP id C414740012 for ; Wed, 16 Oct 2024 17:21:06 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EJVkRqnl; spf=pass (imf12.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729099197; a=rsa-sha256; cv=none; b=I/GryRHBpu8sb1ecPPyWFtzCCpH7/biRPlJfebcI4MIj4qsuQn8ovLXhR4+8LE24NqV7c+ xZfL/UUHTOMpZuUqmfAH3jPXODXkGr66leR65DZdlW3f8s1kF7G7BU5U9TmKEmJHFNO+in ihssnXSWwxE3x3wVp2dxQ2b7d+S6W70= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EJVkRqnl; spf=pass (imf12.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729099197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1GP0B75uZXvlMdPMs8sxWFWqOcAn6bbZYSntM7zvNeg=; b=RjpQ0CGGkNOJf/cBzTBtzCml24ZBpD+eg4NQRv76wadyITOPbJ1BMZjHxwmwlkX30T/Ooc yyBvSBcBxx87p4fPQyYr6UESGSkNrqV4Do1FSsTU/xkkg4kHi8lfhpoJ1woMzM7SFnYzaN XmXxAASUp1KHnw3uWUM3MFdBkslN9nM= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-539e6c754bdso49142e87.2 for ; Wed, 16 Oct 2024 10:21:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729099269; x=1729704069; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=1GP0B75uZXvlMdPMs8sxWFWqOcAn6bbZYSntM7zvNeg=; b=EJVkRqnlhAhghXnVzLAUAv26mmorU6jdThoxEOW93TNWCtqxe4OrddwqF6YCLLVG0r sSaxxI/mJrsZYqaDVVdHXQ4LwTPoOwuZBUoR9XNruH9ZPL5gef2pR8XkBskZ6GF+N/9r Wz1CYVI3P8xG/ckX9sL0HLZUbOK0DinZISt5c/e3g8VpUFxMQ5XZCV7wRxT0QWDvm3vV zdCFTQWMML7EmpFwJ88qP6Y/xbnq5SXcG1bVBlkMp26aIT9CoqY8Yr5spsN+3nh/s+Ue xqkOzaukXzE7Ley1j58qUORhiyWyiiQlvgxdfV6U3oxIPs2UA0IVsW/Z4Cm4DzaJb6Al Z7nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729099269; x=1729704069; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1GP0B75uZXvlMdPMs8sxWFWqOcAn6bbZYSntM7zvNeg=; b=Wi8I8RlvhygRvBr59txbijlL6BZq9PFG0dxhI+Ap0umHzcPJ8pnjaKqAitwV+7KR+u LoENTB0hSd7DV7WnqIqoO00Nj11hZZD1KTP/PECm33fj8FZcUP5Vnt0VOzvnOl4cp8m/ BmO90zMLjOhWgN9vOQj/d/xCWLaYdnyZokxeJ2DLQtqNOtm1hfRI2ar0/xueCq0gfmXI kB6QgRcqdliCl4CNZ+mHuH2BRoHxwJWb9V563jOX0HLOu0c0kYTC9kIysRt0tFiV0QGN +EWqkcrfrDs/PxT+tImqwDUZKT70jVx9NyIFP7wmmXj4EsXd5pCZ3OWnFicuBCvxvQqR NDMA== X-Forwarded-Encrypted: i=1; AJvYcCWjwN/igO2Oy1gF9NHBSUsQKi/hHUNQwTdZoPajuQNQ5FEQGcKkk5trMJeFbX7cRYzuX0XDP0yb0A==@kvack.org X-Gm-Message-State: AOJu0YzO686X4FH61trYKKUCoXNmdwlYQQJTdtcJtVd8/a7UX5QpoWmb Wm1Rn2Heh9Z9XEhruOE5gFiNFYVJp0Y8GK0THBsnIpCbw1PgESxD X-Google-Smtp-Source: AGHT+IE3BOIzolDg/ircoXlrXALD+U8X6mjirKNd/VoSdJ8ZQKv3Aj0k5T5yFcByNzOByKxATFiOdw== X-Received: by 2002:a05:6512:402a:b0:539:f619:b458 with SMTP id 2adb3069b0e04-539f619b4cbmr6540423e87.22.1729099268652; Wed, 16 Oct 2024 10:21:08 -0700 (PDT) Received: from pc636 (host-95-203-1-67.mobileonline.telia.com. [95.203.1.67]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-539fffa8a5fsm512819e87.26.2024.10.16.10.21.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2024 10:21:08 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 16 Oct 2024 19:21:02 +0200 To: Mike Rapoport Cc: Andrew Morton , Luis Chamberlain , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Suren Baghdasaryan , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org, Christoph Hellwig Subject: Re: [PATCH v6 2/8] mm: vmalloc: don't account for number of nodes for HUGE_VMAP allocations Message-ID: References: <20241016122424.1655560-1-rppt@kernel.org> <20241016122424.1655560-3-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241016122424.1655560-3-rppt@kernel.org> X-Stat-Signature: es4gzbhs11sip1f516dg9ak4brs4tjwo X-Rspamd-Queue-Id: C414740012 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729099266-644703 X-HE-Meta: U2FsdGVkX19LgwKLVfNcDsnoDi9iKzPs4Vdj/vZc9d+Uh+FXSuslMoJL8ovcKbE9yv/1QfpCPBWERgAIGHoX7UbMYlOceAm3A35/qdJLjU/dt3ZQbkaYyWZGh3ZmkTq5EM+UmMphevZkM5K167r21qlDLR1PZONeuDKUOSx3BIv6wmqPu/a+FrgvcjYatISqEpljgibN2OBupp1H5H50I0btYsKi32yYFSniR1OtYNFUY+yTWW4ZE3Wv00uxjJSnzhADLe7qbf4wGyNfh56RmESuXspEOSuyc3XC+uXz2GD7+1dFIuP8ZGK1DRVbvJM6i4C3K/kryZP6JEtldYDdJ653w8dgao89MB4rqoa+KcwPpru08/8on3hAh/EqWc3GJUZGKqTW5YiJfqQBydc3bBNDCqMfDT388o15VlHSDr+aw9wL4x9ZjJNxM3uICz4kyQuntOVZAX2KdgEnfDRoMiqhxsOkP2jF6xr7TwBpLJs3M+DS+fbCNW8/Ei2QE0E/t0rqeFjJERDOj/sJK1efMJBkN3AZVyqz04p80kRVrGlw5NiyYNIuMlUAM6SA5p3kWInCJlV+d6+G+OfWMuI2IN3ewZXeNn97lBd8ldWQ7lNS+neII6nT9gNKX+4nXgayl2yy+QR1OM9lVoeuCXiBarA2Z249AGqPb1SbNeec0T7dsaplhwuu+2+PZQ6qKWCUb7C19t4E+RJvYrw5lTGN44MZbjGI9FallMs+KNzPgGj0+ao2j6lw3skiYmZGMZHyZeLU1ND1V/KZi6RK95zwy3Oo9Umh10ECeuQ5qsQ+xZcLZKnK7l8xn6cO2fuAnzmjyWxrBxt0P5k/FO+WvDIwno+kAeHSV4X/N/lknXDjrNuIsCBwbWKf1LXRBSzkAFEyzKliTJDOLJCtt0HAmykEYhS6nJr0YXBCo18BJLUX6B+Y/uKx70DNVa1nT7egmuZDrbti9H+Qqp75HXL6Wzh JR3HnbyZ uH5aUY2mEBY5nnoL4i73NyQ2coY164mtnb/etId45oaGRVtS5REcmflBweFQgSwEws5RQ1OI04adTd2kUMYSbObbgs6MXjbzHLWBg/4eI7s2HW1UvAE3kUm20FmTFwIpJSNQYZNvbFCGorib0tu6b8Xum3HSd0zuW6xWHHFIgmhqpk0NCHh0BSUPnsfpsThOFZBEws5Gp2XPGU3ZYfIyWa8rcuh7ITGNKnb0APGhBMhczom3FMhhhhLpJCeHIQnQvrbtRUYapWx/0UFX+LAA3a26nrXM5nhZrKznYIgK4p5LIih8qjMQ4UMTgdCCghiTb210lK8P/pzEBQCpbVkl+B2dl+eC37hR1LppKTSTqtCCtKLpxamCrY3BySws6owfgSDXwEGGHnUaFz2YrqwaiVhQvcdqBqPVCcqqn3M1qg1lfnky1dGSRJUqYKAA9DqALD8uv8k5QCBCWCB+rFekam7viQY7s3OaEus/wf8oilZv6yPA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 16, 2024 at 03:24:18PM +0300, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > vmalloc allocations with VM_ALLOW_HUGE_VMAP that do not explicitly > specify node ID will use huge pages only if size_per_node is larger than > a huge page. > Still the actual allocated memory is not distributed between nodes and > there is no advantage in such approach. > On the contrary, BPF allocates SZ_2M * num_possible_nodes() for each > new bpf_prog_pack, while it could do with a single huge page per pack. > > Don't account for number of nodes for VM_ALLOW_HUGE_VMAP with > NUMA_NO_NODE and use huge pages whenever the requested allocation size > is larger than a huge page. > > Signed-off-by: Mike Rapoport (Microsoft) > Reviewed-by: Christoph Hellwig > --- > mm/vmalloc.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 634162271c00..86b2344d7461 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3763,8 +3763,6 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, > } > > if (vmap_allow_huge && (vm_flags & VM_ALLOW_HUGE_VMAP)) { > - unsigned long size_per_node; > - > /* > * Try huge pages. Only try for PAGE_KERNEL allocations, > * others like modules don't yet expect huge pages in > @@ -3772,13 +3770,10 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align, > * supporting them. > */ > > - size_per_node = size; > - if (node == NUMA_NO_NODE) > - size_per_node /= num_online_nodes(); > - if (arch_vmap_pmd_supported(prot) && size_per_node >= PMD_SIZE) > + if (arch_vmap_pmd_supported(prot) && size >= PMD_SIZE) > shift = PMD_SHIFT; > else > - shift = arch_vmap_pte_supported_shift(size_per_node); > + shift = arch_vmap_pte_supported_shift(size); > > align = max(real_align, 1UL << shift); > size = ALIGN(real_size, 1UL << shift); > Looking at this place, i see that an overwriting a "size" approach seems as something that is a bit hard to follow. Below we have following code: ... again: area = __get_vm_area_node(real_size, align, shift, VM_ALLOC | VM_UNINITIALIZED | vm_flags, start, end, node, gfp_mask, caller); ... where we pass a "real_size", whereas there is only one place in the __vmalloc_node_range_noprof() function where a "size" is used. It is in the end of function: ... size = PAGE_ALIGN(size); if (!(vm_flags & VM_DEFER_KMEMLEAK)) kmemleak_vmalloc(area, size, gfp_mask); return area->addr; As fro this patch: Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki