From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D40BCF0453 for ; Wed, 9 Oct 2024 11:11:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C5D86B00AF; Wed, 9 Oct 2024 07:11:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0760A6B00B1; Wed, 9 Oct 2024 07:11:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E80426B00CF; Wed, 9 Oct 2024 07:11:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CA0086B00AF for ; Wed, 9 Oct 2024 07:11:39 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5B8D3140725 for ; Wed, 9 Oct 2024 11:11:37 +0000 (UTC) X-FDA: 82653798318.18.6D85F0A Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf24.hostedemail.com (Postfix) with ESMTP id A872B180003 for ; Wed, 9 Oct 2024 11:11:37 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Mz7RtfQh; spf=pass (imf24.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728472162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hb272+xXjz3b37mEd9a64YzYwJuYXJt/U9LW2D1HyrM=; b=SkqJPJYlvlGeaMpbuXZG5w6YaZ5v3L20r8zR+XDgXB3pn2JnLAsN0iy8O1LMgXw8GN7t2c Aj2FReKiTpCk610y7Ruq4BMYKihM3hLIxAev5xb5uY7F5cqVV4Cbw4Sxzhcw66vt5Og8Ia om1O160sY6CFnLooA6gb1Fi+3t1EFVE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728472162; a=rsa-sha256; cv=none; b=W7YUMC+DQaDrbRyd691i3BftxYelBrewh5b+SCX/gyG0gJPuxWM2a7Z8u8911iVUKyc2eX BUSj4ZKkokYdNLhFFgiKwMGMWYuNa6Ha3QNDT+Rt97auhLzZRgp1THDr3AMuGFHGy3POOg 2us9OUSZTkyCzjf4Z0pmoXHcqLJZ1rU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Mz7RtfQh; spf=pass (imf24.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7AA9AA43DC2; Wed, 9 Oct 2024 11:11:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9AD7C4CEC5; Wed, 9 Oct 2024 11:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728472295; bh=e3rviv3TJdVjm4yn7ziTk9KSuLclDXQUchWzo7AyiA4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mz7RtfQhCZ0uNCUFMWKtrHAFeascQPu/ebICZ3tR6PzNzrHFcc/TnETf+OJkJge90 ZR7BDjTr/iiEplJZ/McnERDIbJoo4Ruuko8yzXydymmHZercGjMUXR86WYDdDQJwhN TIfk2Qog/C8fAdxxpVjiYALqqIduKNgy3iaiEe9KNN0SWuIast05sUg34l4uHjyfCn xXgrJNWDslnX8A3zp1HtNtRwrw3gHZjBDPwqOjvfkIBTkKfvKyla22qr1n5qra8it0 9Vmmpa2HsBpKn4+LhSFP4gryYnJ0bcZMuKDcHnX9tTYsHSPZplMSMCHVO1DIZeMxqN C2HFPzUeHbo7w== Date: Wed, 9 Oct 2024 12:11:32 +0100 From: Mark Brown To: Deepak Gupta Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Christian Brauner , Peter Zijlstra , Oleg Nesterov , Eric Biederman , Kees Cook , Jonathan Corbet , Shuah Khan , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, alistair.francis@wdc.com, richard.henderson@linaro.org, jim.shu@sifive.com, andybnac@gmail.com, kito.cheng@sifive.com, charlie@rivosinc.com, atishp@rivosinc.com, evan@rivosinc.com, cleger@rivosinc.com, alexghiti@rivosinc.com, samitolvanen@google.com, rick.p.edgecombe@intel.com Subject: Re: [PATCH v6 02/33] mm: helper `is_shadow_stack_vma` to check shadow stack vma Message-ID: References: <20241008-v5_user_cfi_series-v6-0-60d9fe073f37@rivosinc.com> <20241008-v5_user_cfi_series-v6-2-60d9fe073f37@rivosinc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="RiYacTSmJWPXVleE" Content-Disposition: inline In-Reply-To: <20241008-v5_user_cfi_series-v6-2-60d9fe073f37@rivosinc.com> X-Cookie: Editing is a rewording activity. X-Rspamd-Queue-Id: A872B180003 X-Stat-Signature: dzobi7fg3qyqrdcouhox5qyyn4594t18 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728472297-906316 X-HE-Meta: U2FsdGVkX1+GGlWaRe21Zp04RB/CcvGrVnuopZ4Xjfx+KjFfD0M/zs/xRpWKkuTuxLAzg2BKKJziqmKhFfuo8Z6d5Y3Vdwbds3Th7dLcgYEZXrI2hp9r9dmzg+m2LxKuWfXn7HBfffZJoU5gFU/mfcqhYF6c5ucpbRnA207+oAC59Hw70y+67YD64UUFHGAV/pZ8UeolUexs2PgB/UssFU3RU1SocIVG+GyZIdPKB477se82NMip3TfIww7TWOflGFKl+hD2bEWAgFXrYzYu3ljzbyEprOjAFh/ixsbGZljQbD0k0DTpjxKnZuqVIXn47jAuvX2ijZDVj5ssK26tTqZuuuvvnKD+66Zu4TSYscT4wv9qACy5kUZieOIbHiSTq65JoPyrHuoKOVG9WHcZmjxfQoT+9tIfsLO7orEtQaOSG7etzHOvq2hsB549x7TblippNP0bTn3dTfAnWQ0x5uKC5c1nWuKUGBWTe5f8UKo9FvYsUIKiapJ1NkxFn1ndieYQf8CIMecCjlKga3vdRX/NNugae1824XB8bbI9ES1NmDHmepL29Hzg6OlgqCGd9WPGejsRInL18S27l4AaNpvlDOeWpy2KB3Y9nIRxsjurcv5NZOhGsS3zXxWUOo0MxOfbMMPz9DBqRGZy2VCV6bfAGW+fyuaH5CKJW09Tr1t8cjrEHGZM0CClJIZKeRbAFGQ6emGORJjohfUifdYFuwly4zyC8VfNsSvcpvHxqIFDI4PWtwIs2M9RRPk501aPo21UNlT9whYCOdIEBR8jN9a+vSiQIADoD8mI56Xs9U4lL/K0yww31a97J4tyF7gGIGND9HCNuApuwUJIAWYLwbUBjJ4DsheSARsUIcwQnXXn+8DF0kqXenvIxZWGoVxfhpc3srj01PyVSZG7syHAjyLBMrqvXJLomwLkMd5+zsz4zgBtz5927BU6ZiSfEXsLlFSRpQro8u/8qS0DWu1 k0fhqzEw GxpK9u21oAgybC9YH8JitnHUUWeka5yUIfckaezaLzrVEwkIZ2f6EbHokWyvGr+vPgF1+PRRsdiDHc5cu6C0s2JPRjkGDb0kD6c7IrVpDPIcjuO5rEFiKjS66PdvCbtOsmDig1nwo2uiOLixQwepiJEr03MjTbaV/dfOX4Ke32JgKeE5gHQgCPRyWsXVDBTk2hnV1G2B7pBjmTUtGBB5hIG/49ELipAkzUAZUgRvgt6VRgh2bDNGl6Fu0dkdZhJG/B8LS9uYRinkoN184wnvIl5a5ACJM0FwBcH4B/Uqve2Ww77C6dtb9AInc5j6T3PuJbfiFdqCmyKuiEv3EqhC9yFk7OxHQy6CFqBvnOPSrF7EHuGxlrC/AXCh+LtwPSATtZ0PCAN0qu8JZLarqsNpnFA4sHxK/3VxaTcd9aJ+FO9b1fXH8P3JcMEMZixui9zfrLR5HE7RzK2b+3QbLPyNK6ACJ7W93wuHmleU6lKXHflbExPX9hl2Sr5e/OA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --RiYacTSmJWPXVleE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 08, 2024 at 03:36:44PM -0700, Deepak Gupta wrote: > VM_SHADOW_STACK (alias to VM_HIGH_ARCH_5) is used to encode shadow stack > VMA on three architectures (x86 shadow stack, arm GCS and RISC-V shadow > stack). In case architecture doesn't implement shadow stack, it's VM_NONE > Introducing a helper `is_shadow_stack_vma` to determine shadow stack vma > or not. Not that it makes any difference but the arm64 eneded up defining VM_SHADOW_STACK to VM_HIGH_ARCH_6. > Signed-off-by: Deepak Gupta > --- > mm/gup.c | 2 +- > mm/vma.h | 10 +++++++--- > 2 files changed, 8 insertions(+), 4 deletions(-) There's another test of VM_SHADOW_STACK in mainline now, added by my change df7e1286b1dc3d6c ("mm: care about shadow stack guard gap when getting an unmapped area") - sorry, I should've remembered this change =66rom your series and pulled it into mine. > @@ -387,7 +392,6 @@ static inline bool is_data_mapping(vm_flags_t flags) > return (flags & (VM_WRITE | VM_SHARED | VM_STACK)) =3D=3D VM_WRIT= E; > } >=20 > - > static inline void vma_iter_config(struct vma_iterator *vmi, > unsigned long index, unsigned long last) Unrelated whitespace change. --RiYacTSmJWPXVleE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmcGZOMACgkQJNaLcl1U h9Dh9Qf/V2pf5NwELa5AFo32pS+UvPU+55Sn73YaN7CJwHb51fe8tNSKG9c3Gq8e E/N5zPxVN7izgYi2vXXf1GVM/Hm9oZUxNyU4BrkNeRLh7ofy0CsGwspy7Xp+k4LH mUZX01pPjiQ71euc4oxfaUpZT85PVe/Tj1pYyNSulKwk2My4BSuW+eHt+kD4v9uC TSSp4NrtEi8xN29WICLiOfJQ/GZnusdljjbOEDauW3H02lVyqsi9vr5nCUlViEqu A60ZAzYJ9XrQQEJXK6n0FL2ebd7wJH0RvYRKMCNrFBpLRUs7kiFCcczFV8QfnPTN B9GbsQB+3EaHLl6oGV2gv6QyQgmoCw== =uBsi -----END PGP SIGNATURE----- --RiYacTSmJWPXVleE--