From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B35BCCF0449 for ; Wed, 9 Oct 2024 10:25:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E1F36B00CF; Wed, 9 Oct 2024 06:25:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 390C16B00D1; Wed, 9 Oct 2024 06:25:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20B826B00D3; Wed, 9 Oct 2024 06:25:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F20626B00CF for ; Wed, 9 Oct 2024 06:25:37 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A6FA6120A63 for ; Wed, 9 Oct 2024 10:25:35 +0000 (UTC) X-FDA: 82653682314.16.42CFF89 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf18.hostedemail.com (Postfix) with ESMTP id EDE291C0014 for ; Wed, 9 Oct 2024 10:25:35 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="CU/Syyph"; spf=pass (imf18.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728469355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GJwjCb3BKvhkQGQOhXfL217QXhQud2QDJQRJIHJBpks=; b=ZXhH3dsQlHdBq62s+JBrCzHAeO1Di/UQeg/oXRmnjN8EIU1riWeLcQ/sNRFX0yl38rSkh1 whDPILi23L/o1atY2frXBTxW570iv/ckR8WRXAh3rtx7AoocQFqJRK9J9bcin7iyymCv+C 4XikkC8rS8fn09tvPa9DC2R6/N5jxO4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="CU/Syyph"; spf=pass (imf18.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728469355; a=rsa-sha256; cv=none; b=4KjR3hhK9KUhrlba25mRb33ZBwzbuYhU2lmalf0EdaWv3e2nPV9P/L/6PYRPk5eNOuYBWy bcnI68Hsjn3YJ9fztlpTDijlFv42qi906EsmX3hKssln7Ltsua/aqs37tPxnfDq21oMnPU kDhMyVeL5BLZj7sFOsViuX72cdxJqbo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 75288A43CF2; Wed, 9 Oct 2024 10:25:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39F86C4CEC5; Wed, 9 Oct 2024 10:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728469534; bh=E98w9taq8sn2oCFo6PyCyTLfRrjriLoSIyE58uTuJiw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CU/SyyphBFW7CION5UzN5ZaM2s9B2KaWUYjQIE24jNpQiaaNBcPZ/JBx43vZR9RIm dKAuev96gZiqv3cQzmnlNpHZGs9yUnbcbXXoet9w9Wkw11upiEbCgMxXNsdL4ezFdY +p5Tmy9zeIo8mmLnp1544+X/5q23ssqCYC9uPdMTUlybp9F8xH4e8D5xzIK9/AHeT4 VM8+SYp7oWGh1v48rq/tPnXUE9W2Y0QAcFjQlkkDsy7TNbdxWPifO6On6S6nNdb6x/ +Q0hlFwhivhYuLDaOGJFcmJB/380AQV7gmfUOo5/8+ukhcjeDEpd9KT8HTxCDfwmeH x2vMMvQe1JdeA== Date: Wed, 9 Oct 2024 11:25:31 +0100 From: Mark Brown To: "Edgecombe, Rick P" Cc: "corbet@lwn.net" , "robh@kernel.org" , "lorenzo.stoakes@oracle.com" , "dave.hansen@linux.intel.com" , "debug@rivosinc.com" , "vbabka@suse.cz" , "brauner@kernel.org" , "akpm@linux-foundation.org" , "palmer@dabbelt.com" , "mingo@redhat.com" , "paul.walmsley@sifive.com" , "Liam.Howlett@oracle.com" , "tglx@linutronix.de" , "aou@eecs.berkeley.edu" , "oleg@redhat.com" , "krzk+dt@kernel.org" , "conor@kernel.org" , "ebiederm@xmission.com" , "hpa@zytor.com" , "peterz@infradead.org" , "arnd@arndb.de" , "bp@alien8.de" , "kees@kernel.org" , "x86@kernel.org" , "shuah@kernel.org" , "jim.shu@sifive.com" , "alistair.francis@wdc.com" , "cleger@rivosinc.com" , "kito.cheng@sifive.com" , "linux-kernel@vger.kernel.org" , "samitolvanen@google.com" , "evan@rivosinc.com" , "linux-mm@kvack.org" , "linux-arch@vger.kernel.org" , "atishp@rivosinc.com" , "andybnac@gmail.com" , "devicetree@vger.kernel.org" , "charlie@rivosinc.com" , "linux-doc@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "richard.henderson@linaro.org" , "linux-riscv@lists.infradead.org" , "alexghiti@rivosinc.com" Subject: Re: [PATCH v6 16/33] riscv/shstk: If needed allocate a new shadow stack on clone Message-ID: References: <20241008-v5_user_cfi_series-v6-0-60d9fe073f37@rivosinc.com> <20241008-v5_user_cfi_series-v6-16-60d9fe073f37@rivosinc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pV5KnxhmLMXWkQIN" Content-Disposition: inline In-Reply-To: X-Cookie: Editing is a rewording activity. X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EDE291C0014 X-Stat-Signature: hhww86hboeck1tayyo88fg6mj1erbc86 X-Rspam-User: X-HE-Tag: 1728469535-49039 X-HE-Meta: U2FsdGVkX1/NlhnFKLvNg1PN8CTi0TT7T/+uwssYjF7rrCJkBRQKYKRqzvSe2d9W7BxAyUUMAJoWnSGKfJx75xgWkUIMLdbXnOek6EoZLBYO1THbitmIafynMMGoBz0rJpexgWtPP+qzLgT2CHJzMd0ENVNuJbxs5ViEXp0vZ4VHADNUIiSosrfI124xJ7FSrUp6+jZXzRXFgrLyXJO4tH8oouL70unBr/vF2Mn50H+hzF0RviwQm12j4NDVJPJbFe58U3zKMWll473YZTi915vHfZwcQ4vDUUhknxjD2FrsFNmzni3dlmMTW8GwLnPnIbFEhzy1cV52pDUar1JSpWf7g2RfSPvaLiKzDnhR2SecGKMQ1rGecfls0wr+OcoehsQznX0L6dQkd/2H9nJ7L+uHFTQisH5b0jNvtN7cPXiSgwIP/LvMjkEjvXAvgdMxhad0HlXzLXPhf+Z2hN92Iz21ARZYYsfGVs/4cMFxPUWMxSXwmEv6J1PCKshCK/GJ/k+DolxTVQCYo+P2/M6VtcRiYihxxhZaVHBDPGFvOFLKMk2dLXR9ID7OQjgmFMNcbtV5J3bn/8kMnyZGklKL4Wy8OOuWkx8qfnhw9qF8E+uCvkB1Gb09nCnWV6ExvCQ72oqghIIbX2WUVl9ttLReDtqzkk7PMKjlWYsiww5H1LIj33LG+Iowmy1KS/WFmoKe2Je7l0XUPonpzM7zhNyTSlH1kaxCyd/nx6Z/xb+xFC6KOpupXZj6H/EuBXHxUPMbkljWAudybhKAqT0ZQy2JLLL2jAzENKAdVJ5VbdpYPPBGTHUO+FzRNO9+gKmIdFQsqQH6BwFAzkubI794kKXr67NJsTVihFOUngFczlyoQGTI6qcCBV5ea60Yl4MxVMLN/p5kzqd6Suw6fZLDEJghHxnZusIBf8a0cYTYQ03n5nmjViltXmNLutCsqdyu2HhtZ/n3b7CGADrJxspde/c 046JHAvl NGnzeENInZGPWFlt8cvkBCEHZ5wCvKy6B85/DcGfYncJUvt/bVWrH2KeQSY3gQCMQjSGDTS+SFmheaeH89o090vt2f+iMKVyi8ONenLd7w0vnmnxqmVXdnuOCk/V1SfR6xK6Z4XLGl3/2faJHVvErOMzSfBRQbNt0j18w4fJ5ZR94PxXVQbE4R6SRoWbUQyvdW78LNFJu1unzhNOxbDCj5QWvDrUATJwjRGmKeNJc5D1iee+rs5OogGqPrUvTbblZLri3t4DFWWpsJrPuHhRMtqX3hHLPfpPM+7MKiJXHE7l7WaUI+fgVRUMB0w22mEqA/4zeCLeUXrvwi18rGyq84laCMt6JM4he49SW+D9u+PE0gu/6b9Pdj2quGD1+q4pEHigYOCZhmsw03xcTdcwMxhFGSvoz+BBAtRJ+CROj5A7cfH4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --pV5KnxhmLMXWkQIN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 08, 2024 at 10:55:29PM +0000, Edgecombe, Rick P wrote: > A lot of this patch and the previous one is similar to x86's and arm's. It great > that we can have consistency around this behavior. > There might be enough consistency to refactor some of the arch code into a > kernel/shstk.c. > Should we try? I think so - I think we discussed it before. I was thinking of looking at it once the clone3() stuff settles down, I don't want to trigger any unneeded refectorings there and cause further delays. --pV5KnxhmLMXWkQIN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmcGWhUACgkQJNaLcl1U h9CV8Qf+Ph9QxNDXCUSDZQA7lOMJTS+c3a+WdGbveXt6JMb2hP4Udd4ELfDvQVsP 2vwWUtByxmDax2qjADTJn56IYnJp+1yB9YBfBuwEGHGP67KgKDpcUHieu4xPemue 2pid1MtBjTUsviljsva6rAoewc+MO3Z5AAICoplF1wXYwW8JWpgKpALzehjsUnOG xGgEXqiS5ycjWc0ikmHyeOQRK13/4EVaiJr+pklcIbhhggLbnNIB7jvKTKnBr/ds fkXQZeW9aA6kQUAetPKjlkvwxOhyxix4xDR3tCncJjA/emX+9fze/UwLrBDs75JO eMHp4p8ZUDqVuxPu6ZNF8wGk8VJChA== =EDL3 -----END PGP SIGNATURE----- --pV5KnxhmLMXWkQIN--