From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C7A3CEFC30 for ; Tue, 8 Oct 2024 17:01:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C50F6B008C; Tue, 8 Oct 2024 13:01:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 674DD6B0092; Tue, 8 Oct 2024 13:01:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53BF56B0093; Tue, 8 Oct 2024 13:01:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 35A396B008C for ; Tue, 8 Oct 2024 13:01:36 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 739D540837 for ; Tue, 8 Oct 2024 17:01:34 +0000 (UTC) X-FDA: 82651051350.18.F398454 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf05.hostedemail.com (Postfix) with ESMTP id E5953100008 for ; Tue, 8 Oct 2024 17:01:32 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YMoNM7FO; spf=none (imf05.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 198.175.65.21) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728406757; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/L4lKypby7JgElOq+zb/nr0fh/ErgIy5ghHvvKtsNI0=; b=RBW2XmoeDNai8K2EYCM7q7NRCsNWlZM+drVxdtG/RF2iYEbz1QRBajD3O0kzw0hWSuzgLk sOpngNCHZlOwgH74MX7AMeJhXrzYbcp1zFdskPobCk7TwJxq5S6rcn3a1msxgRzzJC+qf9 uDvxyyC0MljlXzQcDmOnUtw5ymNmf3U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728406757; a=rsa-sha256; cv=none; b=JycLkn3uILcnnpLhGG1DSO/wkFjY6u4Lgt2maZhhuSlRt7bK7twEXp6zd+NqTbK98eeFWj nNdV6qMl/7ABEIH9rlYFSiAB0751krXHFk43w875OHnxa2kkUpNSoPUTx0Ag5k74AQ1yiL 5xl4JdVBmLz+1B3HPPMGuCV7QZa8D38= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YMoNM7FO; spf=none (imf05.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 198.175.65.21) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728406893; x=1759942893; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7yDX3p5l4AOgfdAig7iHKghNGgGyy6V+GbZVWH6Nah0=; b=YMoNM7FOlxEaXdBtUUqASgLHO5a8YSsmHoBL8edilTCtwdc1+5xuEAZZ ossg22n7zyZw9t0ZC/bj+4Gi1yLcj+V4psTCIFs3uLPx/l0iLSSrhxNMI RB7gOKDMNmouqv2z0sjOrn7OtL5/SNj4Fq8kz6VRT4FPWw04hgfkF/3VM lKtJdvdDWCZMTstrDni3HS5G8EZCaH/+8CxRGctrAhRe+F84PQFxVZ62v IFyo7SLGMDazvXjaZKx+JSkb+SnXNSZKly7rvhILzlEQ5NDLSUx4cp5KV TCBaPp3NX2gTXqunlbUBvWE6iM1WIxW1Yag+bI8UDkNAFWXNg1Och9Btf Q==; X-CSE-ConnectionGUID: hzGl3JecQ3ylL7YteMHpjw== X-CSE-MsgGUID: 4tmLJzZLTSi17n7zZu7nRQ== X-IronPort-AV: E=McAfee;i="6700,10204,11219"; a="27574517" X-IronPort-AV: E=Sophos;i="6.11,187,1725346800"; d="scan'208";a="27574517" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2024 10:01:31 -0700 X-CSE-ConnectionGUID: otqcIQWJTfm9wfBUFR+WKA== X-CSE-MsgGUID: OIYtR1NlR0SJCumSBlYHUw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,187,1725346800"; d="scan'208";a="99244245" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa002.fm.intel.com with ESMTP; 08 Oct 2024 10:01:27 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id D7F8220F; Tue, 08 Oct 2024 20:01:25 +0300 (EEST) Date: Tue, 8 Oct 2024 20:01:25 +0300 From: Andy Shevchenko To: "Huang, Ying" Cc: Dan Williams , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, David Hildenbrand , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Alistair Popple , Bjorn Helgaas , Baoquan He , Philip Li Subject: Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory Message-ID: References: <20240819023413.1109779-1-ying.huang@intel.com> <874j6vc10j.fsf@yhuang6-desk2.ccr.corp.intel.com> <66d8f41cb3e6_3975294f9@dwillia2-xfh.jf.intel.com.notmuch> <87v7z91teq.fsf@yhuang6-desk2.ccr.corp.intel.com> <871q0rnw6n.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871q0rnw6n.fsf@yhuang6-desk2.ccr.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Stat-Signature: domdc9hpodp3g1psi9w7dwgotwnawzsh X-Rspamd-Queue-Id: E5953100008 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1728406892-533034 X-HE-Meta: U2FsdGVkX19iwgXZt070vxI9K2cyWP2l9f6Pi3GFmpJJ1Z8QI+ND7tbyMG84YoEb1NxDIFQDUNBRi19aCjkb3nPdIoMzKp2HQ5YGwB5XZ2TFtARUkzAzx0sR31zSw3Z/QIyJkQVsSTkKnWinmm86HIXWcrZU28h7I4UeIR8dHN7SGXOIKWjQJ8ir4vUc6bV6Q7GdTGVM0van117J7/XHVb6V1YgpJkSdjGsWG7TkV+VWFX5pK1Yug6x2PA/j+BZuMXPYy6Mf+j/QN4lphQj70YdmKqAtxtdeAx+8VrRG3WuCzGmFXUEKdadrUsjaBUezgwpjFozwQs3kvKsG/Xwv5kYfZXjZDjAoCrJO0ECaDyNZ7t0pb2dgrxnng1pOpfpWXxZ1XIaMiCqzUyzvZitWAPy43qVCacgaglq8Wxr5O8Fh7JKpXAdQtNSXDo11Ae2noc8fGSde+3V3lTHmn8IAf73w91t+fP5IjL6ZVW70HmdX00VcD/jE9rprHlDbLKEbT3EXPZ1v5RtSjEra+viDJLLD7fVuAlFhIicqLOAeVcFnWzd2hAeJuH7uwsym5ldA7Zw1j1O/qojtjM8IQWpEw8t4UoF19wonrRGq31SjSuBqrxKPjhDkggKSK0PaYYppULAGWfDBjeWuA+z71W0JMPooa74K7R3S8gKDEFyLH3WeAvDRPMYTnzdZsG8zmZS5qSq6Rx6NVC5yEri4TtkSNPvybG4hNfzLWDq1so6mznj6luAzh3Ik+HFaN4lOXr1Cf71My5baYQCuCxKy7SWHFS/JmvrGmgZBXGaO+isSvKuYyAO34YQS0DVtsDJAereUHnHWpqHSLDS5M28z9xRsN8HgIo6r+KazqVIftj5vVaHSU7T+5tXHeT9/ZWx20aSXjubB4xonoxWhnomRNSrRBFTEuETvXMpNGnnW/8oP+/klQpZl7z+STlw9RG0MgxAk9k1nZuW3LdFgOnZ4vyw n1hmiUr/ yMj1I27VkS92+xWI6AlwacRo9U3a7htEjgH4qSCKizHfP4GsmIO/RNYC65tRCNoisOee2ffTzPHQxGmYQjgECnOYjVsgh3WWNZ8D4VgwfVp1RtqG6lTIViBYsAM78q5UoxSW422WP4VJmpA0jC0EbBnml8L8hxufZTE4ZxdG5rt1CRAjRj5nxXAJGyrfdNAIyArOs6xi4aFjSup41j7Wp+xZEdweMsy+lqGg8Jn9bOZxLHxNIc7nqpSysSSyc6SEv30nIK4nfbMEB6eOtDk4eWJMARcU+d6ZAu9F7iGQPty89kd+iDwYoetPpJ8SKbCvCdbIBEx9hBmfpBvI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 08, 2024 at 10:52:00AM +0800, Huang, Ying wrote: > Andy Shevchenko writes: > > On Fri, Sep 06, 2024 at 09:07:41AM +0800, Huang, Ying wrote: > >> Andy Shevchenko writes: > >> > On Wed, Sep 04, 2024 at 04:58:20PM -0700, Dan Williams wrote: > >> >> Huang, Ying wrote: > >> >> > Andy Shevchenko writes: [..] > >> >> > > You may move Cc list after '---', so it won't unnecessarily pollute the commit > >> >> > > message. > >> >> > > >> >> > Emm... It appears that it's a common practice to include "Cc" in the > >> >> > commit log. > >> >> > >> >> Yes, just ignore this feedback, it goes against common practice. Cc list > >> >> as is looks sane to me. > >> > > >> > It seems nobody can give technical arguments why it's better than just keeping > >> > them outside of the commit message. Mantra "common practice" nowadays is > >> > questionable. > >> > >> Cc list is used by 0day test robot to notify relevant developers and > >> maintainers in addition to the author when reporting regressions. That > >> is helpful information. > > > > I'm not objecting Cc email tags, I'm objecting having them in the commit messages! > > Can you explain, how useful they are when they are placed as part of commit message > > bodies? > > The result of regression bisection is the first bad commit. Where we > use the Cc list in commit message to help find out whom we should send > the report email to. We have all tags and MAINTAINERS database. How do you know if those who are in the Cc list are really interested in receiving this? What make me sure is to have Author of the culprit commit, relevant mailing list and maintainers, also reviewers and testers, if any. All this information is available without Cc list. But if you *really* want it, you should follow the Link tag (for the new commits, for the past ~2+ years) and harvest it there. And actually I use that Link to reply to the thread directly. So, again, the Cc list in the commit message is a historical burden that consumes a lot of time and energy and should be gone in the future. -- With Best Regards, Andy Shevchenko