From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0CDACEF173 for ; Tue, 8 Oct 2024 13:12:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28E546B0093; Tue, 8 Oct 2024 09:12:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C9D76B0095; Tue, 8 Oct 2024 09:12:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01A796B0096; Tue, 8 Oct 2024 09:12:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D7B026B0093 for ; Tue, 8 Oct 2024 09:12:05 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6FBCD80D49 for ; Tue, 8 Oct 2024 13:12:04 +0000 (UTC) X-FDA: 82650473010.03.F0874BD Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf03.hostedemail.com (Postfix) with ESMTP id 1CAA72001E for ; Tue, 8 Oct 2024 13:12:02 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Qxwz9B3A; spf=pass (imf03.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.222.174 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728392989; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KMYkHMwdVkbSLMxGZAZds8bTSvf1VBR7G7Hyvo2bDKo=; b=xRhqNS8z/NTdOZVlYTYBPwki87kULFkpW6y9xT067nxj/jkBVDzFwCln8k0Yt5c6pLEyjZ UFKAebT5RdV7K2NftMQ+st3EMZCljnIEiQ+7HotN2rKNiPJqXY6ha6H2MHilwbb3SoWK3c ERdtwyXdWABplJkJwUsjSqtLJWKbVSM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728392989; a=rsa-sha256; cv=none; b=2xbDtqNEt5OV7bz3s1C8hLSrGts6Rlij6wSBx2W1UCZl+4KroaO3c+BoELbr2sO1IuUWLz a4/QQqlUAFBNDq97b4xwWyd38xonEzV+GoXjy58+mqykLluVoTMaZAlVU/UYrNAvHr+I3m 2J7JQfVl9v3bnfMsFjae6xiR0aNXa6g= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Qxwz9B3A; spf=pass (imf03.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.222.174 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7a9aa913442so513695185a.1 for ; Tue, 08 Oct 2024 06:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728393122; x=1728997922; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=KMYkHMwdVkbSLMxGZAZds8bTSvf1VBR7G7Hyvo2bDKo=; b=Qxwz9B3A0XFEnXB6mdqmGQC1/32CFe3sLl5Nqoe0d8Phopuis+I60E+zcGctjg69pu d3nGlCiTb7vS1grOoE6kWGQE7VlhVrGti9DCdv/Ahvf6FGnBmXBfk0yVK8ixD05xPXQo qBG9CStVNB35BNZN5osdpqxNsiwT7EdoY0CknyWuSLhokJ61RU1wgxfH4g7bnAlD/qsO PwPQuYjW11D2sA7WabnQJux+C6feZk/z13J7QYfr38cJEnVzcjIGW1xdwee/h2bOTjub iVDFkBOS6HvGCZTr6w2aU3o18pBr6W3GSJNtKnVhD30xowMMgX9G0V3PhiUFTGrJZCZ1 rQVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728393122; x=1728997922; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KMYkHMwdVkbSLMxGZAZds8bTSvf1VBR7G7Hyvo2bDKo=; b=YoTNF3WNJqNdkq0j2aQNdft7hE2+e/z4LMR2RuOA8Tf07Tv2TsNr497gsYypgRQ5KJ 9MWPmitdjP506TVYwbHqFRXBuUUVvAy8o6R25AcwaJA6reg9dxzQJgTuwkDIFzA2JMNB J5L/mwh65/7jbK+9dk/d5PPnGgxz2FuS1cfco9G1a+wNWU+UjBKTxsimgzyeFD89klPE 6KW2qQbmbjMmxMVZiMZfRLOLXs3mn9i0qZYvUcDld/TVT+dClde0pmM+g+RUR/l7Abik x4xyP6fUZQbxxy63QTLQi/Efi2oOEp4TrfWRhn6uP6mWDmIaSzv8DCZvxlGtgJs8g6z4 B3vw== X-Forwarded-Encrypted: i=1; AJvYcCWZd47iPtQDKEM1I+Ce4PeAC6GvyROzWwTg7mAwQ00K/oCMZWyo8lSRhd+v+XZcaKWUpQ7QK1frHA==@kvack.org X-Gm-Message-State: AOJu0YwpZkmB557NCOqw3vfDhqm0hKBWDgi1nPYPok6SrjOarNw/GhHC RHUGmcvjnBMdqGO4yFaYX2J2ZINP0BcqY7ufdcCMDo1jympDwS7c X-Google-Smtp-Source: AGHT+IGsWTvqPZueDUbUsaCDXQY0K9BJDQnEBOl7ormRevhhHgRvlWLX1J+0XIrR/GM5eBOE1MGz0A== X-Received: by 2002:a05:620a:394e:b0:7ac:de4d:9129 with SMTP id af79cd13be357-7ae6f44cd21mr2452591985a.31.1728393121978; Tue, 08 Oct 2024 06:12:01 -0700 (PDT) Received: from fauth-a1-smtp.messagingengine.com (fauth-a1-smtp.messagingengine.com. [103.168.172.200]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ae75760e8dsm351608585a.108.2024.10.08.06.12.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 06:12:01 -0700 (PDT) Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfauth.phl.internal (Postfix) with ESMTP id 028621200068; Tue, 8 Oct 2024 09:12:01 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Tue, 08 Oct 2024 09:12:01 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdefuddgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvden ucfhrhhomhepuehoqhhunhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrihhlrd gtohhmqeenucggtffrrghtthgvrhhnpeehudfgudffffetuedtvdehueevledvhfelleei vedtgeeuhfegueevieduffeivdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegsohhquhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhi thihqdeiledvgeehtdeigedqudejjeekheehhedvqdgsohhquhhnrdhfvghngheppehgmh grihhlrdgtohhmsehfihigmhgvrdhnrghmvgdpnhgspghrtghpthhtohepvdehpdhmohgu vgepshhmthhpohhuthdprhgtphhtthhopegurghkrheskhgvrhhnvghlrdhorhhgpdhrtg hpthhtohepohhjvggurgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheprghlvgigrdhg rgihnhhorhesghhmrghilhdrtghomhdprhgtphhtthhopeifvggushhonhgrfhesghhmrg hilhdrtghomhdprhgtphhtthhopehgrghrhiesghgrrhihghhuohdrnhgvthdprhgtphht thhopegsjhhorhhnfegpghhhsehprhhothhonhhmrghilhdrtghomhdprhgtphhtthhope gsvghnnhhordhlohhsshhinhesphhrohhtohhnrdhmvgdprhgtphhtthhopegrrdhhihhn uggsohhrghesshgrmhhsuhhnghdrtghomhdprhgtphhtthhopegrlhhitggvrhihhhhlse hgohhoghhlvgdrtghomh X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Oct 2024 09:12:00 -0400 (EDT) Date: Tue, 8 Oct 2024 06:10:39 -0700 From: Boqun Feng To: Danilo Krummrich Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v9 07/29] rust: alloc: add module `allocator_test` Message-ID: References: <20241004154149.93856-1-dakr@kernel.org> <20241004154149.93856-8-dakr@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241004154149.93856-8-dakr@kernel.org> X-Rspamd-Queue-Id: 1CAA72001E X-Stat-Signature: 38mhx8juxz7beq6zxu5ue1cp5k4zqc7f X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728393122-480619 X-HE-Meta: U2FsdGVkX19X4/lMT6s7fde6MlURpr8F/W8daBD0C7gNo+LcBi2dhKAXlnRbHaLHk4tYKZIv23zuzAObqruRJP1dhpwX5ltQZ/4g0pXAw2thkSxk4PmJwG1ok8csvF3azSm7SdlsjRPLZkoYRztm9wK5b2S5j0TAIoS8wq5WaFyALN50rzX8/jKeF8TrCF2UZ64KFJisxtiVNOB29J1IIe3coSNLwszjvkJKfk48Uv/hVpguURKlY8nN6uny/Tpv5hoctdImE74XwzyU9P6UURIB005UDhjUZesY3tB2XD+MUn3LgAyeYzTA/aQBM+Q90DRu2HOLiiJMuQQdWC7dZxVc5dAGWdPdzLFShc/46yjH8916R0ldxmymNyaZouCSjM9flEpu0uCDgZe52ULqyvV5DnUT82mzatDlIIkXW2Kymhzvb9Xz6SufV2zNiai7sZ0XaVUOtaJX5JuYiOxq9Dm4KjN27DF7tL1HlQYd7Ku/TI8jCla1MzuSl3C6KFfxTS+eHb6kdOIUGK9ajIfIrC515Cg0/I1auLhxzEcorbp3yXF4tqNk5iormNCwi0WvNfa+3jq/KGPil7hCi8WdQAbNHTsDWgldXctpGbWONhEjjWYuvb9IdPQK14BoDLiRqkcDcDJEZhYksLmmcvztuOCrnNrAm3ysLBLwIBNsaZO+HXVM7FZKWC91Fbsqtmda1VU4KlcC7BITAEqAbDfV4V8zpD8JdJkLjqKprfrSyg/CuFAKNMJeQn0Ig2Vjj8Ka49E1sjrVdHSWW+1xH9MX+Ta9M0Aq6Jz6NT4NaW7a7H1NGOumC3qAxlGJzrPPaItyHBmcNvFHti49zsmS3nlmmcpdesQQ1JOA3R8fYShVb4re1LZijCW8CqfChmWxnJoITS5zEBxETyEnhFTuVZoIfP/7mPCmlprzndVsC1KqXYbuigkrnK7bLrfprdpvD82k8m9Hu6/CwMCIhdlnxxo AWQchehm vW+PIYD4Bxf/D6vJ0C8n4g1h5S3a1V+SqGWunXSBaJoNhI+0EmKKT2E5Y59iNftjG8aoDlUmIz9YiHcI6jVUQU2IrRK4b5p9c+kBBsGOSdmj78StuoKNCQQCHd8n7lAL+K/XJ1f0Sj1I+WoKF0t1fkA5n75u/8jTrNA4JJgMN6DpMCjs/oZi3cSW3Db6iCC7IpO6HiF5pYciH810WkSKxpflnA+FR1hP35ZTxIBas17HPKhTwGL5zDsmumZdKo0Dgv+ofGyPHLjXyKSBk56GFv+BiHQzvcSH1uT7fQJHv1AJKhatV9CVHK+zoBWg19KfY4CHGygw/sPJl/dWKMgCC6tin6C1qAIksgj47CNA9VbtoDgfQr1FMJ34uUidwFLMuH0/Eh3Sx3uZXBsyezLtoDw03JBQKuEIHNKV4Gm8wdHzfhOfGuqXItNKHLBdI5zZPP+j5dL0Ginfyh0KpdEutXNHTEB91a0V2gQNENsb0ZzvblA3LDSlO436hmz9M2cXWgVysFE9+TO4JlYku71rBBGJWWkmVtfIo8/lHlDaWWCeLsL5kprhYMnNVboyhKM5Lh9y+Sjt3vsQfuRcuR9KVcBLMM5N/7vJRUsaY3t9MBLS+FEh0ITn7vs7DBWnzvNLqylvh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 04, 2024 at 05:41:11PM +0200, Danilo Krummrich wrote: > `Allocator`s, such as `Kmalloc`, will be used by e.g. `Box` and `Vec` in > subsequent patches, and hence this dependency propagates throughout the > whole kernel. > > Add the `allocator_test` module that provides an empty implementation > for all `Allocator`s in the kernel, such that we don't break the > `rusttest` make target in subsequent patches. > > Reviewed-by: Alice Ryhl > Reviewed-by: Benno Lossin > Reviewed-by: Gary Guo > Signed-off-by: Danilo Krummrich > --- > rust/kernel/alloc.rs | 9 +++++++-- > rust/kernel/alloc/allocator_test.rs | 19 +++++++++++++++++++ > 2 files changed, 26 insertions(+), 2 deletions(-) > create mode 100644 rust/kernel/alloc/allocator_test.rs > > diff --git a/rust/kernel/alloc.rs b/rust/kernel/alloc.rs > index 91b2a26faf3d..f8ddc8d96da9 100644 > --- a/rust/kernel/alloc.rs > +++ b/rust/kernel/alloc.rs > @@ -2,12 +2,17 @@ > > //! Extensions to the [`alloc`] crate. > > -#[cfg(not(test))] > -#[cfg(not(testlib))] > +#[cfg(not(any(test, testlib)))] > pub mod allocator; > pub mod box_ext; > pub mod vec_ext; > > +#[cfg(any(test, testlib))] > +pub mod allocator_test; > + > +#[cfg(any(test, testlib))] > +pub use self::allocator_test as allocator; > + > /// Indicates an allocation error. > #[derive(Copy, Clone, PartialEq, Eq, Debug)] > pub struct AllocError; > diff --git a/rust/kernel/alloc/allocator_test.rs b/rust/kernel/alloc/allocator_test.rs > new file mode 100644 > index 000000000000..4785efc474a7 > --- /dev/null > +++ b/rust/kernel/alloc/allocator_test.rs > @@ -0,0 +1,19 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +#![allow(missing_docs)] > + > +use super::{AllocError, Allocator, Flags}; > +use core::alloc::Layout; > +use core::ptr::NonNull; > + > +pub struct Kmalloc; > + > +unsafe impl Allocator for Kmalloc { > + unsafe fn realloc( > + _ptr: Option>, > + _layout: Layout, The `old_layout` parameter is missing here. Regards, Boqun > + _flags: Flags, > + ) -> Result, AllocError> { > + panic!(); > + } > +} > -- > 2.46.1 >