From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A35B2CFB45F for ; Mon, 7 Oct 2024 20:13:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC34B6B0082; Mon, 7 Oct 2024 16:13:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D732D6B0083; Mon, 7 Oct 2024 16:13:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3ACD6B0085; Mon, 7 Oct 2024 16:13:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A93C66B0082 for ; Mon, 7 Oct 2024 16:13:48 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2583E1C2D76 for ; Mon, 7 Oct 2024 20:13:48 +0000 (UTC) X-FDA: 82647906936.30.7ED9345 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf27.hostedemail.com (Postfix) with ESMTP id 4D82E4000E for ; Mon, 7 Oct 2024 20:13:46 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QntNEnRQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of vvvvvv@google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=vvvvvv@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728331917; a=rsa-sha256; cv=none; b=QAV8T5UnzD5MAOt4ANt5fkMSWFFvS4PIUE8PcLNib81h8/dkwtHmX/Nzpo06PuuONEY+MP 29RhoSaUkxdFB6++yeEYwqadl3CThd9VwIfTjcv9VlqJvWNRMFNBkVcDCdNM4kGGuxbMJm CaZTl/UQtBxJxbVCxlvlJ6wyKqELVhA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QntNEnRQ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of vvvvvv@google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=vvvvvv@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728331917; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yx0pt4scDmNk1EWAFeHFSniKZ7EUYcMTiEUSd4YB+1U=; b=sD2tjIa6hHoFfMwfVOGEZIWHm0psNkeFRJFCyJmQ5lkSUg2nDk3MNPODLTqytw7CK5fQGN P+nikLe7X06Y8jVSnyyCxWV54oFZWMW1I44li3c3PK1WycRx53WwRUGRIV4qDfcCc9pno3 /WjhvIcMVmC+NKnMAHSFSaznV+p7M0o= Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-42cbbb1727eso49264525e9.2 for ; Mon, 07 Oct 2024 13:13:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728332025; x=1728936825; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Yx0pt4scDmNk1EWAFeHFSniKZ7EUYcMTiEUSd4YB+1U=; b=QntNEnRQjkRFhvTwppQsup8K+2/W4erFi5jV5Zdi5duSpmkoC7V9VBqERtFfe9mR9k e3qN71GYPn9NoywRGoWx+aLjEOZjeLMv+RUpjXr8KwjJUujWMJCTHI86lAQ2y4WLLCC1 XwjBzDiCtvqjESiEYC1pIn9YUwMyCUwdT6rCLkO+un/vx01QpxHDwkaaf8ijw1LBhxT8 Dr5uTGsR590e4bhCVzic9WbCg3JrdJcoCI/6G2qClAMthYk6SL9Lw1zlg3/eAdeCWbWf rDpXvFhCVJvQVouPxI6GY3Vx0xF9nJI+yNhNzG8hv2DuBuoTafWsYXewiiycMB+o66xR w1Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728332025; x=1728936825; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Yx0pt4scDmNk1EWAFeHFSniKZ7EUYcMTiEUSd4YB+1U=; b=q3TG9eMLb3y7+PWRkmCJL3JAvoyOqw+SfiA0owMNSjFNeAkXRE4LdYU67AtH8WGTeW y2Uj+GuRFAYc6+1k++6w7x9o8RGcJ2CJtSbPVg86ETxrrzGiVw7x1RMGQT4axJkpHKxm Zw+JrZvhbxSmVvk5Cx+qpKe2AUvDNHYPj2z6BpLHcSlKmzIRHai+c1MvDEJDXxjsU+yK fzxWlP/bxDMkTaYfa0kbonedhmjwnpa+3jdeSOc2jyLRumnmDKdibbK21HQDRgzVUGxJ kSA4C3GbwbWPZRZsjLZ+PrHRmlPOksBisjACNcagJxYmqlZOyNAbXGytZI0sOfCs8pJd 0VgA== X-Forwarded-Encrypted: i=1; AJvYcCVjpP2B9pd+mPr0c1KU3q5PZlZij4uQgKm35i+Vj6e9pHI4vsH8+QqEoT9medhygr3PUluNXrxFkQ==@kvack.org X-Gm-Message-State: AOJu0Yy8Gm+e4u35KMquxFrhycrqELrUymXEb/9TwQ+CE1emovBkvnn/ iTm0C31BTGm0aqN9mx3Lu4hRMrVzR6EpysLryx8eVbN23sg79CYt7gHlvhXXd7z4ub2PkY7qA8k rVOmY X-Google-Smtp-Source: AGHT+IECSBYGWYElrGQ9/PLjCv/QGgIvTaH6gZjMVFJX3HJR0CsTFxRRdwcOmmbwk/i2hOLei1z4+w== X-Received: by 2002:a05:600c:1907:b0:428:e866:3933 with SMTP id 5b1f17b1804b1-42f85ae9d2bmr109959455e9.22.1728332024426; Mon, 07 Oct 2024 13:13:44 -0700 (PDT) Received: from localhost (110.121.148.146.bc.googleusercontent.com. [146.148.121.110]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f86b43f2dsm103724915e9.31.2024.10.07.13.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 13:13:44 -0700 (PDT) Date: Mon, 7 Oct 2024 20:13:41 +0000 From: Aleksei Vetrov To: Shivamurthy Shastri Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, vbabka@suse.cz, willy@infradead.org, hannes@cmpxchg.org, anna-maria@linutronix.de, tglx@linutronix.de, nathan@kernel.org Subject: Re: [PATCH] mm/vmstat: Fix -Wenum-enum-conversion warning in vmstat.h Message-ID: References: <20240621111604.25330-1-shivamurthy.shastri@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240621111604.25330-1-shivamurthy.shastri@linutronix.de> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4D82E4000E X-Stat-Signature: 89n8rcmb5mhrk4xf67ty67r4nh6tu51e X-Rspam-User: X-HE-Tag: 1728332026-408731 X-HE-Meta: U2FsdGVkX187IS0K1eKM8XdOwb28aDbADjZ8SniSYqJMS7s/mxvvoL90LarqGx72g7UbR7dNirRBJ08fM7TXKcTRoF06V6YEuWBjr3ab7mtH0OuUCbhF6TgP0yalUkVsINOPhoyio8pxbxnrBll7qitpSrhgqcC9Ufp/k4hjf5EDzCWdFNEBAQmTaxc2ehW0kr1xjVBsLUHiHxYu1wv8l/I126FFakKT0ugolwMu/Q0LIoI++FHwlEHBaPX/Y6Ac8oQqQdKMyuQLPuGVhMZasAH2vsbgBHSTqLtQh3PKnHVgAAqyI2lK9g0hPIstOLNYoT6E9Y+suDu0eLyWJkrKtCJ7XAk3EKbnhTt5FLmlcubAwf7etR2jtYwhmSyNM2drWlWIcWwAFi9H6xWL1fqmSklDDKDbkS8USbgpPSEMttX4vDrcPqg2FJx+606F8wq7llZ/8AH1O0JL75x4YiMnA0f/BoHQokeXXjTrUiE8bvpdguTeujk5Ar6q+EhVJt0CSg4tLwFyxeutkFj7DutuzdaylIqaI15kAQKUjW2qRAL0Y1SJzUIZO9UCjNXQp5/NKGb6w6XWrGanyWaiFNK/n/kyKwm9cG9lGx6wCnspI9Mc2wMfhxNQ6CRNMKkrHcInEtVAh214rC8atmQu8ysiNNcEYAyN5BjgeUD0/XiTXRfgUVLa+YmrODwUdW8adpQhihANlhc3tui0nuQPL4BqY+BrO+iDUgnNj9pJFdoGaWm1ciB1rS6o/amj7a+4Mw5AUKQP0jHEGL3g+th+MR5anAP25R61FwQafHptIIf1gQ4NntqEJyG/M8o6wZbtfPFCQsYI9082zGwnq1LYivx4MOid+LVvH1UbzoCfrTNHafjAgz1fZpYwxUXw9Byl9+vCrNxbKRAW0RTJZlqFy8GfrZ+bUTSkhgB4QKuYsXQnFL9SQkVUpAiioZb+sgHcQ2wPbYhWtJXX63AqEIA/TgF 0woXM0dR XsPexRI7ou9dcg0TVIwJxljQYE2xKgSOXuasCsVOCHFP6zMs6sP6VGpl8FyssQks+mI6qk0L6uE9DKvJEA9v8CS8ZzlpewtILUK/lx/d8Xh0RhR0/hagKKe39lwJ3UYzTsxM6U+5TuAInh3XTKzdxFwSFc+3zPs3lsYNteIRhKibOsV/Pz/JQ/fI33S6z4vi/ah7t+tAiIfsqn5HjPjEfWCooMgLsdf7AgIFFiSs1VENDAvULy89W+vM7t7WxsJWJ3RSQih09+zW59G1Hae0WRw0SLvo6PQhfbTS1N1V1YO7eczREdSicA/7JApbAXvVg2q+iMpn5dyK2jgOiFQvnjAe1ZXOp3inUdz+EqKpdAjzW+YLcYkxa+mxK+rPs4aVLSqyk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Shivamurthy, On Fri, Jun 21, 2024 at 01:16:04PM +0200, Shivamurthy Shastri wrote: > A W=1 build with -Wenum-enum-conversion enabled, results in the > following build warning due to an arithmetic operation between different > enumeration types 'enum node_stat_item' and 'enum lru_list': > > include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] > 514 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" > | ~~~~~~~~~~~ ^ ~~~ > > Address this by casting lru to the proper type. > > Signed-off-by: Shivamurthy Shastri > Reviewed-by: Anna-Maria Behnsen > --- > include/linux/vmstat.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h > index 735eae6e272c..72ecd46fd0c4 100644 > --- a/include/linux/vmstat.h > +++ b/include/linux/vmstat.h > @@ -511,7 +511,7 @@ static inline const char *node_stat_name(enum node_stat_item item) > > static inline const char *lru_list_name(enum lru_list lru) > { > - return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" > + return node_stat_name(NR_LRU_BASE + (enum node_stat_item)lru) + 3; // skip "nr_" > } > > static inline const char *writeback_stat_name(enum writeback_stat_item item) > -- > 2.34.1 > We have encountered the same problem after trying to update Clang to the latest version and this is a blocker because we use W=1 to compile the kernel. Do you plan to address review comments about casting to int instead of enum node_stat_item? Or I can submit another patch myself that addresses it.