From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D18BCFB441 for ; Mon, 7 Oct 2024 14:20:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A988C6B0088; Mon, 7 Oct 2024 10:20:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A49666B0089; Mon, 7 Oct 2024 10:20:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 910706B008A; Mon, 7 Oct 2024 10:20:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 750D56B0088 for ; Mon, 7 Oct 2024 10:20:53 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2178BA177E for ; Mon, 7 Oct 2024 14:20:53 +0000 (UTC) X-FDA: 82647017586.12.61A5C97 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by imf17.hostedemail.com (Postfix) with ESMTP id 2E76040014 for ; Mon, 7 Oct 2024 14:20:49 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ibwKW68N; spf=none (imf17.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.9) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728310782; a=rsa-sha256; cv=none; b=7D2Qlc0ATZaXoLKl3RIY60YQvNumcdddnl+dTVivK/6gH7mOemELaTHYsekdXq59rDDk+i Dw0+eaQkb/d7dtSIKP9RAkmuN2vOFth2lIdjp2Dhg65+xsaOqXVmI/bs1PxHsydN/dl8Xb JLvIxAt9EYzacCFyG8jjrMKBjwYBB2U= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ibwKW68N; spf=none (imf17.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.9) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728310782; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h8yklupX2vAWaj1m9Kz8usp/ely4FvG5CT+p+MDvxKs=; b=Kybyvb1n1whXyTneuCSSE86xXP7ycPBzvuqQqOgNdebydVCWbhmbSN/L2EsOJeLLUrU2Tf l7sTBnpV1L8bFpae69ep9hkUdobBp/xVT54S6xT6uSNubrRb0Ue8wv7zUakUbnKItObgPf 8J/el5sKh8I3SJhKnN+9v3SqozzzlJU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728310851; x=1759846851; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=zpVx4NcO+FvNMmwInSSBP2llHiiEZi7422EEP8tONds=; b=ibwKW68NQg7WA4T9O4SMkEgjg0GmUYvlRh0FYApZPcRcGPRAZBvFcVV2 UNrN5lzIpRDC8tuncaLL5gyxKyEnVngA8bZPHrsEUKwF5J/b2YCfgfC9R X+kdA7OM3BbKL0Cn+wuOFFxNJ9aPTZMm55iV5ItT5pbcot4O8piH6tO3a mTbRqojrgMX4DKYaGcfyXQlHbLgZybQzHVOcllM4Um+YWJNnUmY5n9Q1Q FJjOjZrQnTOwm5TsK5+k/MjHX55nsQd/QRZWk574hmunpPvnKZoZlt196 BDfQqUxX+oz/3eMID4RqMVxNH6H5n64xpC7xqcPkC2bBw8x1HTZ5FNXO9 w==; X-CSE-ConnectionGUID: ROT+3b3gSZK3PpWv3bpRFw== X-CSE-MsgGUID: 7un1EDRBQXS+Q5yPUhwKKA== X-IronPort-AV: E=McAfee;i="6700,10204,11218"; a="38118648" X-IronPort-AV: E=Sophos;i="6.11,184,1725346800"; d="scan'208";a="38118648" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2024 07:16:37 -0700 X-CSE-ConnectionGUID: tMxxieRtTOu1eIukJFqVAQ== X-CSE-MsgGUID: EPQots9qQ7SVdTQRLByrJg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,184,1725346800"; d="scan'208";a="79479075" Received: from smile.fi.intel.com ([10.237.72.154]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2024 07:16:33 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sxoXG-00000000Ewb-18FR; Mon, 07 Oct 2024 17:16:30 +0300 Date: Mon, 7 Oct 2024 17:16:30 +0300 From: Andy Shevchenko To: Dan Williams Cc: "Huang, Ying" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, David Hildenbrand , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Alistair Popple , Bjorn Helgaas , Baoquan He Subject: Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory Message-ID: References: <20240819023413.1109779-1-ying.huang@intel.com> <874j6vc10j.fsf@yhuang6-desk2.ccr.corp.intel.com> <66d8f41cb3e6_3975294f9@dwillia2-xfh.jf.intel.com.notmuch> <66da24827b2a9_22a2294b3@dwillia2-xfh.jf.intel.com.notmuch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66da24827b2a9_22a2294b3@dwillia2-xfh.jf.intel.com.notmuch> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Stat-Signature: azm4xgw9dbhnp7xcp1sbkns3hn1uftjn X-Rspamd-Queue-Id: 2E76040014 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1728310849-605386 X-HE-Meta: U2FsdGVkX1+TOHzbL4Wy1JWc3l7Y2hOBqtn/qeOT/vIkHOtWbUirxEuZszRNKiuBRZWsXy8SIvW8T5DjL7QcMlxvfjhuDWT3bLipKjVURTKoS9hfcusjGV78kuNgJlhLdDYfCliJ976tgcuh4XSGzzB90WTxyBfFUPCnsaVO2q8mVLE++H3cfbzPMZ9adCZX8VsxaZV5aGxg2ulNOwSXWxP45mvc8tJ+Mn0kbgJyOy7UnCBf28Kpci9DkfvZWHFBciCpp+2zGv3qcrm2W+AJc+Xv69tl3ASUxA7GgmLQK6uZD55RlYO4JLcML4cyKHlstf4m5RiK9mexH/lAskCZr7yYDcBLf+YdZ1RNw7XrODxmHnJIhKLvEV39SidoZzg6DJrpfM82bPhvh8jdIQi2wQ/84fNDmQQS2EslMB3l+Nre/3omg/PoQjWxdhhQqBxBAGTspoA2f3AHIweswbr19kU9QUMCDyP5tCFNTz9g0fRwmkh4ENIFI+mVhAKPdhFpMenwzyyjnx53DOj4GyxnHTUxGBsjk5il8YE6wXPEw/RKyePSmjiXBakBQ3B3pLSWf2aR5I8oXsuLES5gU4gSKn7qG1+dfWhzi5YmC+kQCoCzbu+Xpyi03hTvf7IrSQsRRuTREpRt6xieEHIkp472YNZSSRNHM6SOK2U9rzQYWSG3nM1+CcoNHA4W0EgJ88+GexTB6dqF3eZsXT2tf/dqzaA2P/WkjPCqkRGkS6Gy8+upTgeZWm6AqeR8sBhoSpq7zOfXcQktPATtBX6NHW2pfSvW3tNr/YLgubOiXEzb6NTTGNysG1igQtyRyFlbl8DTzLPXMjiuK/+EUbf78xQ57DcmqtuxCWEZ/0O6P8rOM0sycvePOi0C0CsotC/Eirh/YMY6KB1kJPtwUp8JMiErjuAcctrUeUXPFB5lQ1zg9jAOc4wXPbUObQD1f5PFKbeV+sxHS+ErYPjateCmi20 2GTmcQeb MypcPf4V19SXqw+2QxWIpkz8mrJ8m1uoqNyxCl3HK3DqIgVyLNFnrek9zJciZs0mR5CC1sPcfcCR3Yp/WdoidTHryGrjtHyrMgiPImmksYK1aaln/pNAWWT8o/XS4s0IiNogo08poHJyK1eXzFiUqP1syCp8Z/Wwr8SO4kbj5TuCibW4Dzw2U3qxNrHqoiccMjQqJ6lKiPVaaIwpacGDMJvh43Jkx5/VauwSWg/zJ5iphFIphdJM4YrvEwZzn0b3ooXT4f5YSYljBwJlyGwYvepTiiWOuC0CnjYeRowaj8zzWYBM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 05, 2024 at 02:37:06PM -0700, Dan Williams wrote: > Andy Shevchenko wrote: > > On Wed, Sep 04, 2024 at 04:58:20PM -0700, Dan Williams wrote: > > > Huang, Ying wrote: > > > > Andy Shevchenko writes: [..] > > > > > You may move Cc list after '---', so it won't unnecessarily pollute the commit > > > > > message. > > > > > > > > Emm... It appears that it's a common practice to include "Cc" in the > > > > commit log. > > > > > > Yes, just ignore this feedback, it goes against common practice. Cc list > > > as is looks sane to me. > > > > It seems nobody can give technical arguments why it's better than just keeping > > them outside of the commit message. Mantra "common practice" nowadays is > > questionable. > > Yes, question asked and answered. Not to your satisfaction, but the > people that have engaged to date have been cold to the idea. It's just matter if we care or not (about the environment, about performance in reviewing the code, about people who might use small screens or smartphones for reading the changes, et cetera). Even status quo should be questioned from time to time. > Historically, reaching into other kernel developers workflows to > instantiate a new preference is a high risk low reward endeavor, please > moderate your advocacy accordingly. Yeah, I got it... -- With Best Regards, Andy Shevchenko