From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B2A2CFB441 for ; Mon, 7 Oct 2024 14:13:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCAE26B007B; Mon, 7 Oct 2024 10:13:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7ABE6B0082; Mon, 7 Oct 2024 10:13:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1BF76B0085; Mon, 7 Oct 2024 10:13:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7A1B76B007B for ; Mon, 7 Oct 2024 10:13:04 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 34082A0336 for ; Mon, 7 Oct 2024 14:13:04 +0000 (UTC) X-FDA: 82646997888.15.306B741 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by imf07.hostedemail.com (Postfix) with ESMTP id 1732B4001A for ; Mon, 7 Oct 2024 14:12:59 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FQvvdvn9; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf07.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.14) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728310282; a=rsa-sha256; cv=none; b=iFpLZyg8k580BwrD23YLVPMICCrzwmYU8ubNOCgYreHLyEszezLU6i7d3la8xAlSEE7G23 M3pa4P9aMqeRMay9u4Tp1P8pXT6A9NnsBobLnAclJn6SlkdkThtwjW3HQUz1unPIB/k6QL ejqsrChI9WBYvIKYxkWyc+Agnv+X83o= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=FQvvdvn9; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf07.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.14) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728310282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q3NVEodyef4XZD3bcNZC0jo6QgWVmAsb15xsHFer1L8=; b=MeV7vmhEIYCOXRBH45TVzsN5oWbztCVndcEKqC09va3ZmkrQi4ijmR00fdQdXismZoNC9r zjjxc4YYd+qgKtc7qmJiq5ktV2OOTwOgldaTAnob0WSonxTSt1akp49FAnXdRqH2qm9ye6 U13KRSgbEtPYLstkg0Pu01De3XhvwaM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728310380; x=1759846380; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bAcQDD+8QQ8WCDszEzop3lIKjgTMQY4AjD6eofNySgk=; b=FQvvdvn97XWj8ZaBQQfl3VrCu02+sru8E3jh5nyW4itV44a6+5PsgINd L0lBWpVIzUMBWFwkJ/uEiM/wVuqq0LwBZhkKBwAjyxS27I76sXj+Rivcb Jw7yzWw98fav8PwAZaFedQvWZF5Vvm6qUI25bSfuMrwDlpBXhEddSUSHD fTf/jH9sBLOGdHEnrBUC7BJSREXkyaudTOTyf4ahNqNM3OOO+PXUcuUcz afBUN7ALWAB8FnMUStGbe9YV+vHK5N2t6JqltJ/wLBK6QIgHIiAw5nRIK KlrFL+h+HB/2dD4R6gv80RsFgy/vAzi0yUrTmPq+ootJYiB5cRl3I6Mbw g==; X-CSE-ConnectionGUID: 4op5VcPtSqS4mrdBEBwKFg== X-CSE-MsgGUID: N2l3WwxLRd6ilQiyCLAL1w== X-IronPort-AV: E=McAfee;i="6700,10204,11218"; a="27629743" X-IronPort-AV: E=Sophos;i="6.11,184,1725346800"; d="scan'208";a="27629743" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2024 07:12:58 -0700 X-CSE-ConnectionGUID: uCD1Sb3ASam3hRd5L6XWYQ== X-CSE-MsgGUID: OhhnmWqtRYqYbudghm2VCw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,184,1725346800"; d="scan'208";a="75844023" Received: from smile.fi.intel.com ([10.237.72.154]) by fmviesa010.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2024 07:12:54 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sxoTj-00000000Esa-0jwK; Mon, 07 Oct 2024 17:12:51 +0300 Date: Mon, 7 Oct 2024 17:12:50 +0300 From: Andy Shevchenko To: "Huang, Ying" Cc: Dan Williams , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, David Hildenbrand , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Alistair Popple , Bjorn Helgaas , Baoquan He , Philip Li Subject: Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory Message-ID: References: <20240819023413.1109779-1-ying.huang@intel.com> <874j6vc10j.fsf@yhuang6-desk2.ccr.corp.intel.com> <66d8f41cb3e6_3975294f9@dwillia2-xfh.jf.intel.com.notmuch> <87v7z91teq.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87v7z91teq.fsf@yhuang6-desk2.ccr.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Queue-Id: 1732B4001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ua51qrynsgys4hant1rwf8s9widgkzw8 X-HE-Tag: 1728310379-362894 X-HE-Meta: U2FsdGVkX18EaGW2d/Hk/lVyq1vPJJQdNIhs6JrzwNlRczaL0biSkHbU4BHzpcVZX2M9dBJVvsPV+IzOCYF3ol8F0Sl8LQf90CDNZZUN1coeU1HRanfLAXvHlujaYZKUxFgUIx0wz400a+RSL2w5PWnKR+1iYZjGEXhvDXMl9TPXpa92T7H2p5VdiL+ZouarExLdNFCZSNRwsk8wl70ssYYQxgT1vPsRQ/nLnufBV2BPjk48tYERrFph7qhbhMqrk9QDk00ea7OGDKnkBAjsGDMn37JyAsPFi2Poi7mjaK/mefLnGo4TkoT9mu/A4WooSuaUx3UFLV54RXHfJoVMDvev2YUMHzr8JVyNafXF/TSZVVnOQbOodmmSfzJtiuX3LsyNUz/KsrQlGtfU0LMuVwCi9N84/3AbKWChk42nIYLb5apLdK5XsZlUS+dUqVkGZ2zOBiLZLtHfNDrn4U7R6kgPCQuiPpi+/U11FDDlYqW14czGda2uCWGBB1f767zCn8VY2gvl9+NtsYzlCWkPOnEz4cAC9dAaYYNVrEqg0DvHFWXZlW/0qDpy5e8wn+Mu2o+Rku8fBxLRWPP25JJ2yxhBJ8uLDPVjJPGLstz80K5qqfZNFj3eH2PMGz/RumXcie7b50gox0QHM5y05BmdhPB9gNHw1t/HwXlfT5tBcHS/xQimA+yV5ujnvKDDGKHQ7B91JuFMt/HPSrpPrBwZuDfjAxxeLAxVoBj12nWzuP/Tb+v3aVkjat6KbwNtrGiphnB9ApGHTfrKFUWlCx+cp3gnpXsbW0e/rA2aEIsFomPvYpMuuRZ4al4+Xm+KvHhM8Jd7AGQqi9Yrg8X0ZApMdWkn9uYOK5gWssLngMlRB/+mpQYsllLWKRqBVCvCu9Q7rf7L/D1/hLS+b2kNUcy/vnGvCV9bnBl0U85K6pukvkF8lijmKo21YKCN6wtB5FXnD7N2zcCCs918bnspN2n wK58hbzb pUPi2f0okubPd0RMM9gyS0w25xEGnIkE2VsA+OPXKmOixN7eLENpoLULCi6dT0x3eioAIbkSrv2fWxnQC+vpKgqOrgmGxB8O36w7HwxAivyyFNVlwRm6/Xt6kaBbrgKxFie/uVU0/KxDL36nb+sS+dZRbti/BTx4L85/CNp2dNIq5jd1WQO6PaKvLNsa38xMaGt45GPIp9u9itbdI7SzQ0vhBA1H22lPelhgVyjxweYFz9qA5U7Tf20NPGJQEHs9jJgHhTSzkm2d0aO5nAX4ZV0DHuztrSrRSXz1ZCsCLPjJKTkM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Sep 06, 2024 at 09:07:41AM +0800, Huang, Ying wrote: > Andy Shevchenko writes: > > On Wed, Sep 04, 2024 at 04:58:20PM -0700, Dan Williams wrote: > >> Huang, Ying wrote: > >> > Andy Shevchenko writes: [..] > >> > > You may move Cc list after '---', so it won't unnecessarily pollute the commit > >> > > message. > >> > > >> > Emm... It appears that it's a common practice to include "Cc" in the > >> > commit log. > >> > >> Yes, just ignore this feedback, it goes against common practice. Cc list > >> as is looks sane to me. > > > > It seems nobody can give technical arguments why it's better than just keeping > > them outside of the commit message. Mantra "common practice" nowadays is > > questionable. > > Cc list is used by 0day test robot to notify relevant developers and > maintainers in addition to the author when reporting regressions. That > is helpful information. I'm not objecting Cc email tags, I'm objecting having them in the commit messages! Can you explain, how useful they are when they are placed as part of commit message bodies? -- With Best Regards, Andy Shevchenko