From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29404CFB440 for ; Mon, 7 Oct 2024 06:22:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF5266B0102; Mon, 7 Oct 2024 02:22:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA6076B0103; Mon, 7 Oct 2024 02:22:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 993A46B0104; Mon, 7 Oct 2024 02:22:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7158C6B0102 for ; Mon, 7 Oct 2024 02:22:16 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2C839A09D4 for ; Mon, 7 Oct 2024 06:22:16 +0000 (UTC) X-FDA: 82645811472.13.B5D2640 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id 197118000E for ; Mon, 7 Oct 2024 06:22:13 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=VbF5A3Jz; dmarc=none; spf=none (imf02.hostedemail.com: domain of BATV+648787c9b6ecc8725e49+7715+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+648787c9b6ecc8725e49+7715+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728281987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bgk+pgWE2jzGVBKPUQmz0/Xlcerm+872WRQL7Nno+5U=; b=0mUCxW7TFvOZ94b0SJ3xv2yHRrG7OEGCOmxlgcY17MgaLAWx/wSB9Y95ID6vcm1JdiFHEp D2fGDya70VPDLdwwM2PNyT3xcnGBcf4bFiXZU500bSJEvGRDnGPQLl3Pc+9k425QBDNHoQ SmCvRdkUhH/8Y2tZ4kYSLzuJlZs+ddM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728281987; a=rsa-sha256; cv=none; b=z7/b7DanKlG4P1jbP/aWk3yWZUZE+GgXJ7fOpyxvYm5GjrFZkuXBz4mFUA48IRJwFSoZZv 751BZgUI6C7cLCHxrPqSfLO2rzs37BBON+F+iYRp0pP4TpnK0xeAvLvUXyORVrwf+mKVuI YDlkFwublCQAc082caKWkdKfyzxJZVY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=VbF5A3Jz; dmarc=none; spf=none (imf02.hostedemail.com: domain of BATV+648787c9b6ecc8725e49+7715+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+648787c9b6ecc8725e49+7715+infradead.org+hch@bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bgk+pgWE2jzGVBKPUQmz0/Xlcerm+872WRQL7Nno+5U=; b=VbF5A3JzfMrRqDDmRp30kH5cZ+ hAGQzy+E4iiiGyKEN6kxXd09RLoZYAU6vc4eHiiwoFAavwlDSFX7pSy78KPw/7qke5/lZ0v42BUnQ hd3A735hh2kRpvOE0KsDvIpvXscnByqvCrw9e3wtL3D/3Qw9GAWYGmsCufOFsMavX9kSEstKarQsG 26GN96ODVvEztQRW6S4MUI8U3xgoJVdC1OhIdmCSW4BiOqq1VMHgU0qGnkl7EWycQtDOAWNaSHSCX 8F304ptq5eWi/bHDj7NHC5KJT/Dam4pzJp1MmKrFdg3bxQ914ce+2RWhnUUmXmBI/kyQjdNf2i76Z RMlCxsxA==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1sxh8F-00000001PHa-12lh; Mon, 07 Oct 2024 06:22:11 +0000 Date: Sun, 6 Oct 2024 23:22:11 -0700 From: Christoph Hellwig To: Vladimir Kondratiev Cc: Christoph Hellwig , Alexandre Ghiti , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH v1] riscv: make ZONE_DMA32 optional Message-ID: References: <20240827113611.537302-1-vladimir.kondratiev@mobileye.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 197118000E X-Stat-Signature: 91wxfqpbje7fmcb1bc1ipdbhgsgk6oi4 X-Rspam-User: X-HE-Tag: 1728282133-452142 X-HE-Meta: U2FsdGVkX1+UfgekbDuRDZZvJBmzqPxQ6w0ykFWRZSnpPFojfj+jcqTwgshNV9Mj6S/8H5vhf+QDw7PgAZwz9A/JEm8Wo/FEyGWH3raY4Gn9e/+FKH/4zHuGqelIDWKBOtjU10R7SYHx1bE43Z2MEz5jrNZO4rNZxNtRp4kkjlf1r6o77/Sm0p/oCUNTQxcTCP7uaG0MGigUhp7W/1clitHsBN7Uvy46z7lHDQHSz38miUBkZ9SXYMDBACyJkRaeFoR20OtOvAUetyGRsxkmKWBA9RpdIblfxQDOO2eIF8wZrYQ+v2PTnx+5XtLntBs459iyyQqmyjCPolYEoQzxht8IGGN4GSEzglRITdztSa2Ot+F8a/mIyqc+5YwR1vCywNYDsWrRtgnsMXJUFoE+HJZkWl4fu2JHzb42URINNKYVB+w40l7TdK6gbqWodiI/db9kfqgo01buJ4HZsnZh+9R+dkC/GlmbupflG1qsr0ZpDfNVyS2eOThDPKa21ALLXNFS71tUyQichWWe9BKmKKaVTSO57MiG2PkMclTYrYxMIE1ZvzlvTYjM7SAvsCb2rabSgB0fRRQE4jkAhIAFm7ocSf1FyyXcikSZwnHsXxA4gadx1I4HzuOPjqfC5SS7kkOlV0/hkyUMYQtr7o3wvgd7TygtvLiDtrE1/uy25+RELjR0p3JJUJEnuEiujmhgorLdrOEAjRBScUpRWs7i4u8T09FqlaBISLasrERhbGqjAt5oaFv+IwnUtfVjOmbhVgDMdb0tz/lepiLkpC0iC0+i3OQivllkQhhAQ4CMAnoqKUHSrsSgMDxtIMPv1Oyk+KTBgxVHSiomxYvWn8QQeH+PsjtQaInM1xIfJItvU4LRBMOCLO+ly3XjF4+GqB58WsiG2tO/7lfA/X/TihsFQBiLFpKWQVHQ3lkTk2+iCtaUAfkYZnq1F80ySV0AhIW2tg5Zngcvfi1gXCGmIw/ zaDIn0Xm pcz7tg4TgvAlUwDCJuU8SVss4piHM4whRZ5xVpiOgjwGy+z21xATyPf5/ESG1/ZjKfCfwmBGEHeMLg2Zq8iWe/k3hmRieKcHwzQ4q8jBWq5f6b16xd9xZtLCj+bRjThfKvgpWIhS85JlY1m9A3AcMJJhS3pJknBJ/gqECdUbXm4ZAYzScF9etNE9rB09Nq7Dxk7X8D1OqI0Sa82rSyK91UdYFgnuNVgFgGa6ZVrtLvRNIASASVuXjUrxhpHITMgAyM4qMs9Y4rtX6fsWDJpobTIF5iAG8sNgi1jUkX7BHNr/U76SRVHYmA82VHjjzGvyAHhJPKScoMNejvcw5E9s2W8drNlrAs0MJhKmO1Gob9XyJSPw+b3uUoP8xFOc7rfVMsod0ZVLpe+X1wY6mkgeEwaOns3QZc+k3CDHHrSWvHV8J0FLkG+eYWVHqvEF9yC5CVaPG+ir0duLJPRNo4CaPepUaS82BCXT3BxtP1bW7i8FrId+6qusdHOoZIqYlBf2HYv50yYn4Bf6sxuXSF1gw2xoh0IWuWMEmHMRaXAV/4tfY48bnQbSj0fOWHIoiTqIDv+dt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 07, 2024 at 06:17:14AM +0000, Vladimir Kondratiev wrote: > >Well, this doesn't get any more true by just irgnoring the previous > >discussion and just reposting :( > > Sorry, this wasn't the intention. Perhaps I messed with the message-id, I see my "patch v1" in one mail thread together with the previous discussion, but not in the other thread. > > Anyway, I think making ZONE_DMA32 selection depend on NONPORTABLE answers the concern > that was raised It doesn't at all. For one not having ZONE_DMA32 is going to break a lot of things. Drivers do expect 32-bit addressable memory. And because SOC designers know this there usually is a way to provide it, e.g. by doing window translations between cpu physical and bus physical address. Please go back to your data sheet or talk to the designers. And if there really is not way to provide this, the right way is just to stop the runtime allocation that triggered you to do this if ZONE_DMA32 is empty, not to add a non-portable option.