From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1740CF8862 for ; Sat, 5 Oct 2024 12:20:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB4266B0367; Sat, 5 Oct 2024 08:20:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D645E6B0368; Sat, 5 Oct 2024 08:20:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2B706B0369; Sat, 5 Oct 2024 08:20:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A2C176B0367 for ; Sat, 5 Oct 2024 08:20:32 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 05E1E1A011A for ; Sat, 5 Oct 2024 12:20:32 +0000 (UTC) X-FDA: 82639456704.09.F3EB1FC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id EB7B8C000B for ; Sat, 5 Oct 2024 12:20:28 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QBePC9QY; dmarc=none; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728130732; a=rsa-sha256; cv=none; b=WfoEWzSGDGLTylfmn5z+Gw26hCMcZyTKKh6/CgyJps+dJFJo5MlWeVuQQ66nXVVPQ+tJ2N zo5nKTh7FAXqdpS4dVhXXPZHbm3f3u/8EVyy96zlrE/AIBPi7BoU+DfkbGCPiNAw4ogq1+ FwVg6g39Btv3QuW4Qdq3CjFD16NbaRU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QBePC9QY; dmarc=none; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728130732; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AoUgjCaBzG4huna+s3tBLuhd6kKJ5UXOoXAelkoDBms=; b=pZFXudJ6lJ+zhqQaaM5UcyLRY1p9s60DuvaOGUZCTaq7tjEj/5VacePdCLtl05Aj/I+Cpf 9X01Dyso8Jzba1u7lX6ZhVxF1r1UDZbN3fLxYpxLgUwHDoc845VIDO/XbrtW1MzRVF2/hn /IuPJMBfrIMnF+473e0wsqTBzYEsbzU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AoUgjCaBzG4huna+s3tBLuhd6kKJ5UXOoXAelkoDBms=; b=QBePC9QYVG2AImvIIiYZWM2p9W x+Rkv4hJJ/bTrBoBGYjmdYZNyHWLJL+jytcmcnp9wuxS9CwKTkFsRr9fbW8n13Sjo2CwV5tTLbuLH SnIupliB8LKGRqnjwAB/thxfIb6JrjcyGpplJrQ67v1o80wjWfpeSV0/KM53lAVO+hD15Ym71kdSd k+2Ib6y0wSdZB9/u8dGvOtkXKmqlsr0skKeY/1PG048h7KAnr2cUzWAP89C7/UA3unmDsiXsri4l/ kMXUbI8qfjK3RuSQ4iYmdm9qIxGaK5gDqpMHErqW4WWAp9dvJFrvB0UB72N9h+2BzOT4zVI6H4U6O bbS6kx2w==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1sx3lm-0000000CpCi-3XFY; Sat, 05 Oct 2024 12:20:23 +0000 Date: Sat, 5 Oct 2024 13:20:22 +0100 From: Matthew Wilcox To: kernel test robot Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: Re: arch/x86/mm/pat/memtype.c:128:39: error: use of undeclared identifier 'PG_arch_2'; did you mean 'PG_arch_1'? Message-ID: References: <202410051828.Pb7a79Gu-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202410051828.Pb7a79Gu-lkp@intel.com> X-Rspamd-Queue-Id: EB7B8C000B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ojmagjmp5e54odrefrugz1o3yq4jaih1 X-HE-Tag: 1728130828-553072 X-HE-Meta: U2FsdGVkX1+x6WRqnwdyB6NnwpUBVTA1yyfOqaNd/725hxWkB1KfVZhzMZk+RNOxm5jl00Bnk3GZGvxyjM0mNm+Jpl6AJtOnFf5gwTo3FEmQxpj/znw0UkiLmXukAnWLWzslEZk9scp24DmLJ/RFO93M2z3Bf4jok1o648PxT4rQIDWdrKejtmWvsYJyjdB7PutQRfQVhb8uLlZH/4numZsM2yO/kbzZV/YHyZNDPIQbWgcHKL2iGy5/nAfynrcgHfQ2iD+DsUaZJt2YQiWS8WUSAgnNDcWIeX4CR8glTncbUtGeK59rjSBTONKDd/idXMYOPxc+m4dxg8Nf6DG9pNcxnP3AEP0/vXnosq2RIZmw/ihR4J/e1qehUABoAItDu42T+5/7ymzZPNzjjmwGjWl2L4YAxtF2a4+CAT9l6pHmQTA3BeimhppvdrXwpPJyNOAnbbuz9JUqqHf3EAJiqqV58WTvGM0MHSkScxDkO2IHbv7iReiye43tHXj+ZCPyKIeXhTT/MWgw4QdkfvudLwdZ89qpf9Zp1grpnKsZo/orUlPH3W7b37hqeb9c4jxFrMCOxBS+KzrQoG/eeDh0hKSXrcpzvRqBtouCFVuKK6NdTkhNERGycVsawXvKNdNOKJ1YCb7uISm5Ie7EySXg9QYmpgcut1jqFHMevtkSbKfqMOx+gvjzYFKfBn/QuJPeZnliLBv5CiwpB+4Tby7Z4fCCIHHR2fSOosDWV046QXQIhruBTBsVBqQ2oFJ7Xy82eRSDtJkXPs8ZpjqbZXr/PWXNkA+d0c5Az2C22843hMU2SA0oUxQzfcZmf1xegMGIriYq3KjAFweT8kQi2clnT97vVBdeP1QhgnWQiubuChkHspDm7dfjVo4P1+8zPViDObA7wdfZRuL5YsMHKVXQBved7ATNlSID+oZA8L6z5JQPHtJ8soR4Fxw8bYLqpn7WKpySK2npKDBWd0U5Yq8 tKHpeQAe F7pcMMJPjlwV6pCKyT12ZCdVFWU/1t3QoA22P72oypGRABQBAdVt8+0BdIL6D0cR74p9Sd2VsixgKM67osZIXXsolTYg49n9z24Ox0Jz4EPRHr3Y7tQ88s1KmZX8KspjPX+0GphbenjN58kWd6eBzfOI5GY7YA20/hrW0wrvy/ZvvQNdDTuS7DfRKAJAFxaL7IcJ1rejHvmNbS9zE6Frccxmc920EtcFb99ippebLbyZ4qvWRPwCT2MqKgc33UQsk6mFt7mrhcR8pwUiLdzdrvLFCSQCX7TKAg1R6bAiiTi5oJlFhZh2PbSJ9EqUBe0apIkI/4m5qJ0VXDSQwiYv3R4ixL6Q+7oW5QOyWL335qThp8ekb3ydXyxMGO2jX+ysohHmNg0lJRZfPTzQpZFSd7QAXZ3yH5OT/gutkunlCSWBTHvVRxHkSH/qMHJJSulwuQ6M1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Oct 05, 2024 at 06:11:14PM +0800, kernel test robot wrote: > commit: 7a87225ae2c6c317c7b80cf599e5cf0eee699196 x86: remove PG_uncached > date: 4 weeks ago > config: x86_64-randconfig-003-20241002 (https://download.01.org/0day-ci/archive/20241005/202410051828.Pb7a79Gu-lkp@intel.com/config) Hum, works for me with both gcc and clang-17, but that shouldn't make a difference here. The config has ARCH_USES_PG_ARCH_2 selected. > compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241005/202410051828.Pb7a79Gu-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202410051828.Pb7a79Gu-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > >> arch/x86/mm/pat/memtype.c:128:39: error: use of undeclared identifier 'PG_arch_2'; did you mean 'PG_arch_1'? > 128 | unsigned long pg_flags = pg->flags & _PGMT_MASK; > | ^ > arch/x86/mm/pat/memtype.c:123:29: note: expanded from macro '_PGMT_MASK' > 123 | #define _PGMT_MASK (1UL << PG_arch_2 | 1UL << PG_arch_1) > | ^ > include/linux/page-flags.h:106:2: note: 'PG_arch_1' declared here > 106 | PG_arch_1, > | ^ > arch/x86/mm/pat/memtype.c:134:23: error: use of undeclared identifier 'PG_arch_2'; did you mean 'PG_arch_1'? > 134 | else if (pg_flags == _PGMT_UC_MINUS) > | ^ > arch/x86/mm/pat/memtype.c:121:33: note: expanded from macro '_PGMT_UC_MINUS' > 121 | #define _PGMT_UC_MINUS (1UL << PG_arch_2) > | ^ > include/linux/page-flags.h:106:2: note: 'PG_arch_1' declared here > 106 | PG_arch_1, > | ^ > arch/x86/mm/pat/memtype.c:152:19: error: use of undeclared identifier 'PG_arch_2'; did you mean 'PG_arch_1'? > 152 | memtype_flags = _PGMT_UC_MINUS; > | ^ > arch/x86/mm/pat/memtype.c:121:33: note: expanded from macro '_PGMT_UC_MINUS' > 121 | #define _PGMT_UC_MINUS (1UL << PG_arch_2) > | ^ > include/linux/page-flags.h:106:2: note: 'PG_arch_1' declared here > 106 | PG_arch_1, > | ^ > arch/x86/mm/pat/memtype.c:155:19: error: use of undeclared identifier 'PG_arch_2'; did you mean 'PG_arch_1'? > 155 | memtype_flags = _PGMT_WT; > | ^ > arch/x86/mm/pat/memtype.c:122:27: note: expanded from macro '_PGMT_WT' > 122 | #define _PGMT_WT (1UL << PG_arch_2 | 1UL << PG_arch_1) > | ^ > include/linux/page-flags.h:106:2: note: 'PG_arch_1' declared here > 106 | PG_arch_1, > | ^ > arch/x86/mm/pat/memtype.c:165:28: error: use of undeclared identifier 'PG_arch_2'; did you mean 'PG_arch_1'? > 165 | new_flags = (old_flags & _PGMT_CLEAR_MASK) | memtype_flags; > | ^ > arch/x86/mm/pat/memtype.c:124:28: note: expanded from macro '_PGMT_CLEAR_MASK' > 124 | #define _PGMT_CLEAR_MASK (~_PGMT_MASK) > | ^ > arch/x86/mm/pat/memtype.c:123:29: note: expanded from macro '_PGMT_MASK' > 123 | #define _PGMT_MASK (1UL << PG_arch_2 | 1UL << PG_arch_1) > | ^ > include/linux/page-flags.h:106:2: note: 'PG_arch_1' declared here > 106 | PG_arch_1, > | ^ > 5 errors generated. > > > vim +128 arch/x86/mm/pat/memtype.c > > 0dbcae884779fd arch/x86/mm/pat.c Thomas Gleixner 2014-11-16 125 > 0dbcae884779fd arch/x86/mm/pat.c Thomas Gleixner 2014-11-16 126 static inline enum page_cache_mode get_page_memtype(struct page *pg) > 0dbcae884779fd arch/x86/mm/pat.c Thomas Gleixner 2014-11-16 127 { > 0dbcae884779fd arch/x86/mm/pat.c Thomas Gleixner 2014-11-16 @128 unsigned long pg_flags = pg->flags & _PGMT_MASK; > 0dbcae884779fd arch/x86/mm/pat.c Thomas Gleixner 2014-11-16 129 > 35a5a10411d87e arch/x86/mm/pat.c Toshi Kani 2015-06-04 130 if (pg_flags == _PGMT_WB) > 35a5a10411d87e arch/x86/mm/pat.c Toshi Kani 2015-06-04 131 return _PAGE_CACHE_MODE_WB; > 0dbcae884779fd arch/x86/mm/pat.c Thomas Gleixner 2014-11-16 132 else if (pg_flags == _PGMT_WC) > 0dbcae884779fd arch/x86/mm/pat.c Thomas Gleixner 2014-11-16 133 return _PAGE_CACHE_MODE_WC; > 0dbcae884779fd arch/x86/mm/pat.c Thomas Gleixner 2014-11-16 134 else if (pg_flags == _PGMT_UC_MINUS) > 0dbcae884779fd arch/x86/mm/pat.c Thomas Gleixner 2014-11-16 135 return _PAGE_CACHE_MODE_UC_MINUS; > 0dbcae884779fd arch/x86/mm/pat.c Thomas Gleixner 2014-11-16 136 else > 35a5a10411d87e arch/x86/mm/pat.c Toshi Kani 2015-06-04 137 return _PAGE_CACHE_MODE_WT; > 0dbcae884779fd arch/x86/mm/pat.c Thomas Gleixner 2014-11-16 138 } > 0dbcae884779fd arch/x86/mm/pat.c Thomas Gleixner 2014-11-16 139 > > :::::: The code at line 128 was first introduced by commit > :::::: 0dbcae884779fdf7e2239a97ac7488877f0693d9 x86: mm: Move PAT only functions to mm/pat.c > > :::::: TO: Thomas Gleixner > :::::: CC: Thomas Gleixner > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki