From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C214CF885F for ; Fri, 4 Oct 2024 21:58:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B398F6B0136; Fri, 4 Oct 2024 17:58:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE93A6B0138; Fri, 4 Oct 2024 17:58:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B2156B013B; Fri, 4 Oct 2024 17:58:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7B8F36B0136 for ; Fri, 4 Oct 2024 17:58:16 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1159040201 for ; Fri, 4 Oct 2024 21:58:16 +0000 (UTC) X-FDA: 82637283792.09.BA58D1B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 54DA5A0006 for ; Fri, 4 Oct 2024 21:58:14 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bLV3swEQ; spf=pass (imf25.hostedemail.com: domain of namhyung@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=namhyung@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728078963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XH09H83ipStvdPQfuu7VOTLe/wANuHXB+4qmJAHWeUw=; b=750cRqIgJ4B9krWokr5rsKLjil2XRnQ5XMF8Kt1ck6U1mgWcLvkUTXqWOEI04wkU0EMwCa j6BaxqdNK47D3jsZf1lslEd6acQ2FclB8Whgn5L9XQ7kSQwGvF8VBNIB62C+Uhql7fvxfj uUA5l9K5W9pREHy/SW9hjTjUL1dHAso= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728078963; a=rsa-sha256; cv=none; b=k3dOw0eRuOpB8MAqZ8WYOpRWUssKi2gCwcejj0BgQy1TPiSCPLBsBnSepBHqHWJQkEVTBF 2mO6U7xvsrHOoRvnS/GpONEy8ZNiVqDXRpDiOkVYDGphnpZjfXjkxNhsOv7rxHA8DoQfy3 81f9CZzo04MlhXJ4YSTlVUuMuE0ddHQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bLV3swEQ; spf=pass (imf25.hostedemail.com: domain of namhyung@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=namhyung@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 439805C5BD9; Fri, 4 Oct 2024 21:58:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 385AEC4CECC; Fri, 4 Oct 2024 21:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728079093; bh=uyBiC8TMq18uQv1PsbbayjsAVacLQRvcD/6Q3GJE+3s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bLV3swEQutk8gH54bI5uf7RM60RwpRAzvkRhfqCAw8SBzoFmt0umcKAvykcvTNy/o u3MB+NEg814mDllNTaPnwcfAYPLtFrVAbdq8oQd2FW7g5m0EF9utJrvaxYo4sLq4oJ +m/VAjTFrd+eO4uK8j7dreYC3rHEuToZYdyIq8O02Sy8k4iYLLzA/K2dAXVAwICn7D dIQt3KRpUhLCp0HXPv/C3OogsWVOneTgtPSNl1upretN16eHjIzgADCz5ely62q0QO RHb/0ShPlj7Yeo0T4JDHSXjTj7mFRCfclevgPJhcy/qPqZr88IrDeIxMl1BYSwwnJj QCUyEovsc1xzw== Date: Fri, 4 Oct 2024 14:58:10 -0700 From: Namhyung Kim To: Song Liu Cc: Roman Gushchin , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , LKML , bpf@vger.kernel.org, Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, Arnaldo Carvalho de Melo , Kees Cook Subject: Re: [PATCH v4 bpf-next 2/3] mm/bpf: Add bpf_get_kmem_cache() kfunc Message-ID: References: <20241002180956.1781008-1-namhyung@kernel.org> <20241002180956.1781008-3-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: u47xx6fwhhdc6fgu7jq8o3woufd9xdf9 X-Rspamd-Queue-Id: 54DA5A0006 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1728079094-572376 X-HE-Meta: U2FsdGVkX19LImw9vnM7NpsGwQlYPvJSlUVAvfTG0nyiQs0vf/oRRI+meRnajGA0Vd5qTaWBnZlxkr3+CkYwFc4NuswwTun3fLchDkmAoHDAxcyhfx6C8d6RmKtq7le3xblUPW7VAWyWIV3Dt1VcZevluehYVhMyaumDVnrppBzmqpMQ4BeOjqjhN4DBAtxqJnyFFBvmiuDHJ8VlAXOGOy9P3Oy928VvIzi5yGsBfLIJJXYJvH17EfIMlTbm9EyuRAMsw8B6DwUtIp/52YT4QSdjOO2mvJyqneWh6ybI0vHd4QAIqcJrSE0+sEntyqq/St3GOxdYkND5PcoOV17nsS0CNNiNmVBWyRoZ0oCV03uL/OXOiECvT7uO0vfRGWO1Nx/3JVknoagQjqhWhMK0CIOgj+HVs/G9qdxHc/DA6RhdBBigawe1HsFn+Te+Zem5HC8KRFJS9q7aykbFWs5RNe+ijJMl/GwOgqo90uJ1dO4sVEg8OnDILg2sdr1JgblPS3FszPqd/k+vfzFtHx534w/QzBpYN86+uZGgdBrt7/qW7pcY2YyyKgG2ftYLB387xF2a3ySAQxSQthZkiBC94TjXVraawAHGoa6rj1n4DZLpJDg4W1Mu8/BXb5enOwCAbGd43V9EubrVGaFlYd9DUHGDA2Kdbttcq2bwHICnUUAmza54l5S1nKMw40hyloF9OGxrAt1cY9DvsKQJ6h770sN3Aotjp6fVfEYi1uKTzAY/zh+8V5ycBruQQuUG+XlnSjPPr3A+L5mVCU9LFu77GsKJ34yTJvwASEKxnzk+sdyOfIL166hTxVkZYRSvlFwneBIMRKjTkz87vDNWsWteKyUA0K5RApDgOQcMpG+JP6Kr6I24nFMArOaG81doib1RAYklXVUv9hwPAxo7B/4NTpf3VqX0AOm4GvOZM7LUGw/Oe6Cw95Ppr0FiEdvomhUfaYZmFUgg6s3+HFd6Y+W CnbsaE5v paQARGoarmFbhdGuqXkLpQYnKL13xzzBkB1gk/aIe6MttxK1zXzEzTv9KkBMZITaky0iuclUWkXN3EIVQiUwK8KTJTwu3tYGlB4yE7Dh8qZe5unMzBA1q8iLTJPtZvzZ+8Rn9OEa3TZkibTAQKyyieyjnpJ3T29LE6wGwkICsbpGkbfCxV23BIZos5tobCqmv2b5DavDuz8em4H7ZmhLOFmD1Od0oNJH0OrACYbuuOIo8sm602qF//txYED+UIgLmpeqmx7VkhTELus7Tr/WL+CSDooVmN9FhvKmADTrtGn2vqm4YgdtZrrP9G8tMsN8mE3q6U2LaSnfUUEmF4HQ2c5uTipJA00LZDKxblhIrVkgMSCuw19vYgO6RdZyhIts7evT0VnluOgVfZ5dcQ+xRjVik4NGhzrEKLD/zST/XMIWZOFdscHLP89vGVKLRVWlqXEaw0FQisQqwf5w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 04, 2024 at 02:36:30PM -0700, Song Liu wrote: > On Fri, Oct 4, 2024 at 2:25 PM Roman Gushchin wrote: > > > > On Fri, Oct 04, 2024 at 01:10:58PM -0700, Song Liu wrote: > > > On Wed, Oct 2, 2024 at 11:10 AM Namhyung Kim wrote: > > > > > > > > The bpf_get_kmem_cache() is to get a slab cache information from a > > > > virtual address like virt_to_cache(). If the address is a pointer > > > > to a slab object, it'd return a valid kmem_cache pointer, otherwise > > > > NULL is returned. > > > > > > > > It doesn't grab a reference count of the kmem_cache so the caller is > > > > responsible to manage the access. The intended use case for now is to > > > > symbolize locks in slab objects from the lock contention tracepoints. > > > > > > > > Suggested-by: Vlastimil Babka > > > > Acked-by: Roman Gushchin (mm/*) > > > > Acked-by: Vlastimil Babka #mm/slab > > > > Signed-off-by: Namhyung Kim > > > > --- > > > > kernel/bpf/helpers.c | 1 + > > > > mm/slab_common.c | 19 +++++++++++++++++++ > > > > 2 files changed, 20 insertions(+) > > > > > > > > diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c > > > > index 4053f279ed4cc7ab..3709fb14288105c6 100644 > > > > --- a/kernel/bpf/helpers.c > > > > +++ b/kernel/bpf/helpers.c > > > > @@ -3090,6 +3090,7 @@ BTF_ID_FLAGS(func, bpf_iter_bits_new, KF_ITER_NEW) > > > > BTF_ID_FLAGS(func, bpf_iter_bits_next, KF_ITER_NEXT | KF_RET_NULL) > > > > BTF_ID_FLAGS(func, bpf_iter_bits_destroy, KF_ITER_DESTROY) > > > > BTF_ID_FLAGS(func, bpf_copy_from_user_str, KF_SLEEPABLE) > > > > +BTF_ID_FLAGS(func, bpf_get_kmem_cache, KF_RET_NULL) > > > > BTF_KFUNCS_END(common_btf_ids) > > > > > > > > static const struct btf_kfunc_id_set common_kfunc_set = { > > > > diff --git a/mm/slab_common.c b/mm/slab_common.c > > > > index 7443244656150325..5484e1cd812f698e 100644 > > > > --- a/mm/slab_common.c > > > > +++ b/mm/slab_common.c > > > > @@ -1322,6 +1322,25 @@ size_t ksize(const void *objp) > > > > } > > > > EXPORT_SYMBOL(ksize); > > > > > > > > +#ifdef CONFIG_BPF_SYSCALL > > > > +#include > > > > + > > > > +__bpf_kfunc_start_defs(); > > > > + > > > > +__bpf_kfunc struct kmem_cache *bpf_get_kmem_cache(u64 addr) > > > > +{ > > > > + struct slab *slab; > > > > + > > > > + if (!virt_addr_valid(addr)) > > > > + return NULL; > > > > + > > > > + slab = virt_to_slab((void *)(long)addr); > > > > + return slab ? slab->slab_cache : NULL; > > > > +} > > > > > > Do we need to hold a refcount to the slab_cache? Given > > > we make this kfunc available everywhere, including > > > sleepable contexts, I think it is necessary. > > > > It's a really good question. > > > > If the callee somehow owns the slab object, as in the example > > provided in the series (current task), it's not necessarily. > > > > If a user can pass a random address, you're right, we need to > > grab the slab_cache's refcnt. But then we also can't guarantee > > that the object still belongs to the same slab_cache, the > > function becomes racy by the definition. > > To be safe, we can limit the kfunc to sleepable context only. Then > we can lock slab_mutex for virt_to_slab, and hold a refcount > to slab_cache. We will need a KF_RELEASE kfunc to release > the refcount later. Then it needs to call kmem_cache_destroy() for release which contains rcu_barrier. :( > > IIUC, this limitation (sleepable context only) shouldn't be a problem > for perf use case? No, it would be called from the lock contention path including spinlocks. :( Can we limit it to non-sleepable ctx and not to pass arbtrary address somehow (or not to save the result pointer)? Thanks, Namhyung