From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5444CCF885B for ; Fri, 4 Oct 2024 21:37:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7A916B01A7; Fri, 4 Oct 2024 17:37:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D03CD6B01B1; Fri, 4 Oct 2024 17:37:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B062F6B01A7; Fri, 4 Oct 2024 17:37:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 89AF26B01A2 for ; Fri, 4 Oct 2024 17:37:55 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 167C41C74D2 for ; Fri, 4 Oct 2024 21:37:55 +0000 (UTC) X-FDA: 82637232510.20.970E6AE Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf19.hostedemail.com (Postfix) with ESMTP id 7DB1D1A0002 for ; Fri, 4 Oct 2024 21:37:53 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sMv0f0gv; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of namhyung@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=namhyung@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728077832; a=rsa-sha256; cv=none; b=YqtxV5M3r9Wd811MZ8796XVNxNIl0v/kHf3apKeVyQPSE7sFhcj5oR7HqVnaraCo9073Ht rkpTx0IAGUvWKcvs92oU/e47HxwTzBL6DMiC74htxIjkr7jGFtKSrW/XPsIEWWfO8TOUUt hF7ZIZ/jFftjucFKH4uZ+7zjwKCdE8g= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sMv0f0gv; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of namhyung@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=namhyung@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728077832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3qAdEj4zRvW6/dBTuHxM7h0tUtvGthwY8YDy2fpohBQ=; b=AnHoazS9eD4NmdKKlxVJKF+rBq8G2DK6iklio61z36VxY0Fj/waZFw7XNxOGhS4p3ADf1c /yWzNJAWEZ/Q1cZ4vHio3/nS5cC/gXF3N7o5uCwUCC40MeL6Ddu4AcQbmRbffSetWoxWlJ +rGWPsqDGLdVQeYI2oaseY5uS+6DXrA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 69DDCA41A70; Fri, 4 Oct 2024 21:37:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9B1DC4CEC6; Fri, 4 Oct 2024 21:37:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728077872; bh=uI51PM2JAvMx0e80REFOC0KFBkahpgGyS8qZnr+qSDo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sMv0f0gvdQfc6M4qtQBPEKUHyIEbj1Ud6IouO+vTfHOJP+nyt/oraBHLdCLVS1GRK 26RiTZnyedWV2n7jlKDeKGRrrWKIwHw9f0KWTGpYmiEHUSgZWaYk5E/EX2eQCCF3p1 pikveRcfVe6Coi89DV+lznTKT5/hand3Fk3aa8ayAV59G6/K7z2NM7YTrqVnTtJoN3 DTv0LAYG5zixINz0foPJvaUfAmHTHy48eToMUPx2AG16ZAoDBLqhwtSz36B5kjFwt0 kUomy5v/tEdydhJdzjTTtiwPR0hX7mHWC3zy5ZBd4d4BjlkscJEw7UK+poMeYSpkob IBk95lK65lgiQ== Date: Fri, 4 Oct 2024 14:37:50 -0700 From: Namhyung Kim To: Song Liu Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , LKML , bpf@vger.kernel.org, Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, Arnaldo Carvalho de Melo , Kees Cook Subject: Re: [PATCH v4 bpf-next 1/3] bpf: Add kmem_cache iterator Message-ID: References: <20241002180956.1781008-1-namhyung@kernel.org> <20241002180956.1781008-2-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 7DB1D1A0002 X-Rspamd-Server: rspam01 X-Stat-Signature: izbo3bgtsopsm6tc9rw185q6cbqx7ozw X-HE-Tag: 1728077873-605660 X-HE-Meta: U2FsdGVkX18nCzNtsBMdE31H8fkaT8pPH8bGkrg8FE7oZ6D9D+jx1anGrDHSqsBqhc78mJk9yL5Bpk7HA8g84/D3arvcdP8oyJEezo+Qa+sjT7E1ol7d5lbELdMOPuW+yzyyIJ37wb5NESr4B9ycj4if3RUPVvukeZEIa8ZbwQQfigC8WJ7/H/IdUWUsiCoof0VVSQOBt5joaKNXVjnrezKkWdlb630U2Q6lN7LBbdUMaD6JpHnRhUZjmIAZlZ/E7Ky/XNbJ2zW1tPFsUOYfhn33YgPAEbcUf5ECLHgJZc3smfBGL8tKVLJE3RYOO63E9NTDUXFdiKD9i3N7h6REV1EI08nXI+9+E0L5z5abEjF8nvOiXQI0UAucY+8QmUQaCdLQ7TEzn41IOMpGw8AoaP3hmJXe33wpidRIekh/MvzSFpSgoUCFUArR33mTkzZFql8RVh8y6EVANvLPiflRgPiWGi7/5C7xVYn4z/bj9FMRoBpKnbrgeTbOchAY+Vk06m8LCDfA6jL+pwQ5Thge7+JljALL702DPXK4KE1BWtQbQZyGTOSd0N6PVXRbdNBopumRL3DFzYk5ZfaaGa1uV+eHeqcbDaBnAwEsQ8N11syh5hJuleBaoY4+EMljUrVO3zhZQYrZmQ7F5o+S3CvtXXiJoq2u9nwfUxmPJmD7+rFpVcp2ImtmSAfBKWiXQne+IapOUgpitLGyraIZYFuDHuziCtcxPof1G0aDBeHEhc8oXrT6J18GPGCXrvti6UNOsdVuk0n8lJalv0/4ki0tybjpou2iIYeWfyaNAI5tcRuw8Yriu48sC8geHvIKrR4d1sCPoZ/qUefUAY3LkNLLGtmCxa0irYMGxQiABYKPWBXVJxUzi1gstVrwA2kWXfoxKMxl5Q+6r9GouVz3eAx4NA6T09bsC4/m0EbfSJxxWAoehMX9bNtd4i7BpaD6Iu0wuP41b1A6CN/ahzVviQQ S8WYgKA9 rYe6dOmEp+IfLoeTbH8jGt1He+XfQRMBuLZHkDL0vrYTWcmgS04VqFSpB8VKUnQPKj4H2+CYUUCM85f6xwfupd2//dIYZBR37+uwIoeOLmIk6OcrAK8QuBZeP5YPUhfbvi+R3oWbXOdXs/9WRUK2N8TeeNFp2+QYiThNV2rdvYblFRtp7DLh5RaF/oOz1C6EDuO++aBEldXyeICAbUIiUeHVqgOgT+yaIkM6iMhylSOZL+/eIOr1fgchN0c6vO2V0XsDSRDqaRyaoaoHG0vmLkaOp56/rgEHyRh0gttEe9frj5Mh7PeBB/SgV6AhIFrcgbjP2xFOXBkZZo+J9to1Xy8YZMLcqmEGKKzsHcAS6TCc8OR3AstDMszRliW21pUaRhb1G41DHXCRJOhpyEyVkkIo0itpS7YnX3LWDk+tbCHx3COdmUDU54yQmDqQEk6da7O6/bgN0TNubfbo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Song, On Fri, Oct 04, 2024 at 01:33:19PM -0700, Song Liu wrote: > On Wed, Oct 2, 2024 at 11:09 AM Namhyung Kim wrote: > > > [...] > > + > > + mutex_lock(&slab_mutex); > > + > > + /* > > + * Find an entry at the given position in the slab_caches list instead > > Nit: style of multi-line comment: "/* Find ...". Ok, will update. > > > + * of keeping a reference (of the last visited entry, if any) out of > > + * slab_mutex. It might miss something if one is deleted in the middle > > + * while it releases the lock. But it should be rare and there's not > > + * much we can do about it. > > + */ > > + list_for_each_entry(s, &slab_caches, list) { > > + if (cnt == *pos) { > > + /* > > + * Make sure this entry remains in the list by getting > > + * a new reference count. Note that boot_cache entries > > + * have a negative refcount, so don't touch them. > > + */ > > + if (s->refcount > 0) > > + s->refcount++; > > + found = true; > > + break; > > + } > > + cnt++; > > + } > > + mutex_unlock(&slab_mutex); > > + > > + if (!found) > > + return NULL; > > + > > + ++*pos; > > + return s; > > +} > > + > > +static void kmem_cache_iter_seq_stop(struct seq_file *seq, void *v) > > +{ > > + struct bpf_iter_meta meta; > > + struct bpf_iter__kmem_cache ctx = { > > + .meta = &meta, > > + .s = v, > > + }; > > + struct bpf_prog *prog; > > + bool destroy = false; > > + > > + meta.seq = seq; > > + prog = bpf_iter_get_info(&meta, true); > > + if (prog) > > + bpf_iter_run_prog(prog, &ctx); > > + > > + if (ctx.s == NULL) > > + return; > > + > > + mutex_lock(&slab_mutex); > > + > > + /* Skip kmem_cache_destroy() for active entries */ > > + if (ctx.s->refcount > 1) > > + ctx.s->refcount--; > > + else if (ctx.s->refcount == 1) > > + destroy = true; > > + > > + mutex_unlock(&slab_mutex); > > + > > + if (destroy) > > + kmem_cache_destroy(ctx.s); > > +} > > + > > +static void *kmem_cache_iter_seq_next(struct seq_file *seq, void *v, loff_t *pos) > > +{ > > + struct kmem_cache *s = v; > > + struct kmem_cache *next = NULL; > > + bool destroy = false; > > + > > + ++*pos; > > + > > + mutex_lock(&slab_mutex); > > + > > + if (list_last_entry(&slab_caches, struct kmem_cache, list) != s) { > > + next = list_next_entry(s, list); > > + if (next->refcount > 0) > > + next->refcount++; > > What if next->refcount <=0? Shall we find next of next? The slab_mutex should protect refcount == 0 case so it won't see that. The negative refcount means it's a boot_cache and we shouldn't touch the refcount. Thanks, Namhyung > > > + } > > + > > + /* Skip kmem_cache_destroy() for active entries */ > > + if (s->refcount > 1) > > + s->refcount--; > > + else if (s->refcount == 1) > > + destroy = true; > > + > > + mutex_unlock(&slab_mutex); > > + > > + if (destroy) > > + kmem_cache_destroy(s); > > + > > + return next; > > +} > [...]