From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09E66D1AD21 for ; Wed, 16 Oct 2024 08:03:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F6966B0083; Wed, 16 Oct 2024 04:03:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A7196B0088; Wed, 16 Oct 2024 04:03:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 693366B0089; Wed, 16 Oct 2024 04:03:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3CB776B0083 for ; Wed, 16 Oct 2024 04:03:37 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8959B81B59 for ; Wed, 16 Oct 2024 08:03:28 +0000 (UTC) X-FDA: 82678725822.24.2935D79 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP id 9DBC0140015 for ; Wed, 16 Oct 2024 08:03:28 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=IjHv7E37; dmarc=none; spf=none (imf26.hostedemail.com: domain of BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729065656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cCY7fIIdD9vzLcDjnHfpOMFMIQtReCFg/F86NN2j8Pg=; b=3//fxqlaxxwZ62AhMVty3ua9rtRV97HmUeoJ+Dwnc3WkpXoCQFPN0l1IJ5IYveDuD9bfKF wzQVHus5C7RqA5B4vj4ewqjg3/Go2v4afb5m+tDKsOXopUIqTiBOXOHjTMPiaFXengSSFC MT7LbUZLo9kt6KoijYNKNMzV4YVwpoE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729065656; a=rsa-sha256; cv=none; b=VO84g+kmP/7hq2FA5x76cYdSUqORlQT3hs+fIFS7cYNtxhgsp+vSJEreBLme+iCKy0wcDI qtkMt6WnQY7lkN3AuqoLIJIIOdKSf9+mK33bDP4dxwXIV+D/AS5Q7IDgBYWrXVQPJsDnJW NxJayv9Hk+fId4UeOr0iU1yR8kwSG3k= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=IjHv7E37; dmarc=none; spf=none (imf26.hostedemail.com: domain of BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cCY7fIIdD9vzLcDjnHfpOMFMIQtReCFg/F86NN2j8Pg=; b=IjHv7E37m/fgFFaRVelx/XvCgx TqBYcC6nZKkJytqtM3wjX5j35H/1sU2/1o8Gha8Pn6MPyEDOCZsl4/vaO0/jcGCS8VrAeuXiCJgWM oI9tV7bTH/Us0f7Hjqq7u8sTEdz4gEbr34C/tu5RflD9YlMeyXCOogKARGUTzkHWGShB0RgNZnLes G2uTpffmr/S8bXiY6utyF5AdRJ/vwflxp9MIPXTJNIeYlDJlik5/k4hsUTpe4TYvdEuEScynz2LUb +hCyZXMXQp4yn6H0Y2i1gyWGvMWIv//tHFciVLy+kYZHDUFGRcQxjzbARIwUHtMM4zJs1bB0bSL+k ImvMvxsg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t0z0H-0000000Aw9l-0FTJ; Wed, 16 Oct 2024 08:03:33 +0000 Date: Wed, 16 Oct 2024 01:03:33 -0700 From: Christoph Hellwig To: lizhe.67@bytedance.com Cc: hch@infradead.org, akpm@linux-foundation.org, boqun.feng@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, longman@redhat.com, mingo@redhat.com, peterz@infradead.org, will@kernel.org Subject: Re: [RFC 1/2] rwsem: introduce upgrade_read interface Message-ID: References: <20241016080057.43997-1-lizhe.67@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241016080057.43997-1-lizhe.67@bytedance.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9DBC0140015 X-Stat-Signature: m1q9uj46khk5sy9goh5tacwfbqupckuf X-Rspam-User: X-HE-Tag: 1729065808-894104 X-HE-Meta: U2FsdGVkX19AncXeGOVZmTm44dpurplg9zk82AAnZC0ppEaaUcOE4B2Q+iu/DI85gEcFQXfK+oDixTRxmXJssWGALZ0V9YJMHn8j7mIkgJcyZB8wWvuYtKRztxUAz+WkCNJaLebgYgBOuVvKs70Mnjqv9bPH92RRS7DwCVQ4NygOEUtgaXCceeroOtng1vDFV7zHtV5RWt4gWcpKrGyI/xGSgrQ+MJXP6D/F7MuvvgqSL7bz8TpSWOjYcVhlKXFl9ivVaAfuQ3zQhI3tPDM7MTBynA5Y52rvaOHujMpNc8XNbOFrLfab8rJ8oePM6PjQbNhVWOtQaD70A/ef5D+NIrxjGNBdwo1zAyvSxwb25F7dLVBxVIr90h+P7TMuPBWd06++VhX31ko0GeXatZ34DdYKx0o2B1v+CuyLO+DxgyARxRvr3XcH3BFAkvvlHClkhAKCo4KtZ6zMtB7wrKw5hwQCGqSBqYm7oboH3fdDX45ugFS8OeneLtKxfpLM60NVVVOlyJOoHsVbHl8irsp0kvgCPHZmimyeMwwWKHQecq5JKpCB4mG/hdi8+y5nrzTc4HRcUYswdbx4x7qCzwpo/YARnwX+gEH5hgk2faaGdmo7Q0o3gZRjLa4ZN8CepsZ2Tfp7F/YQe8ZTgtqFe99ysDT1WPr+0dFEuMaVjYn5DUnT0sFXdwiF2UqyL7hTQ6Kv5M50t8rFYsLUxfUutTly4jyB53KZbtQ/rINTH6TtKVJHgLtsh3AGr2MVbWpCsal2B8l835UqCqOKgtEV1CkxL97i6A0PGrLveq3hP/2XG4op8jwkRQ9kdkiMdhrlvnhKEnxcnd9U72sNLNcl4uTvooiuBifYdEK9k0lBlfKEs7tMLqSHfNI92jRAmmMx0c81HPQ8ar2lTT4uEnvOBkSt4tiQsVFGAyDjt2lx3zRVs516zSoS2J45VAOaLn3/sm5S5xg7tAgCqhjFayHU1gD MxdqZ8BY A8wpWOZcOLaaO0SB0MV3IMLtiOI3dqXZEODZPWyY7VfjTeu6P1lQDCduztEyp40oAKzN+TCKLXJX6gai5MFwliuYL20ly7d6KFt8Knw58AbXqjAQ51qnp+ZybLenxe372Oyvzrbx8eJ9mV+2WQb+v5NJA7ooUb/YVGRC0STLnJiIO6w/AyV4IlYpaErlIjhk6tcSf/7ku/O59X5/rI5seJk84Vfqmv7vJ6d4VqtsI0ekX07AAyp+Oa6NalE5UxQZ+ogoxzFcWDtX2rVCeDUz3fYapXqdQi/5Cc+KtgsNS//Np316F6dueJT48GycqX43SvjOO9nzvbZYZJm6SLf4Vyzrw1VSVBhRtUcfrLh+WL6Zq6e/p2PoX4ePcT05uznxFaBK50AZv9tyrI9APv31VADtc3ha/nBUzD0wO74LH5cQ/ZinqrlV+tlIX/OgeO77xrOzdHzNhnjw98wYdHvCKUMn3d6uhfprm2vKxjiVAM3/Pe7Jt+YlvGspTbbRdF76XPbbSfQ7L4bXg9FddkBhUe6DJb9oG9PW2ZtbrP2Qu0OxszJmuNkXe0kiVtdda1nLj6gxgNBsdsxAeX8bxQhNkFlapZRlH2oFsqaneY9w9tIST/gtsMQ7buJXxhA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 16, 2024 at 04:00:57PM +0800, lizhe.67@bytedance.com wrote: > OK I know what you mean. It is indeed OK to remove "extern", but all function > declarations in the rwsem.h have the "extern" prefix. I think it would be > better to keep it consistent. They are pointless and should never be added.