From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16A15D2069D for ; Wed, 16 Oct 2024 04:56:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 881086B0083; Wed, 16 Oct 2024 00:56:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 858946B0088; Wed, 16 Oct 2024 00:56:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7479D6B0089; Wed, 16 Oct 2024 00:56:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4DE826B0083 for ; Wed, 16 Oct 2024 00:56:58 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1404CACD57 for ; Wed, 16 Oct 2024 04:56:39 +0000 (UTC) X-FDA: 82678255380.19.6E197B7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP id 46C9D140008 for ; Wed, 16 Oct 2024 04:56:50 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=BIn4zwsg; spf=none (imf26.hostedemail.com: domain of BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729054543; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aVmIGSz20klS9BwIwrqXLAa+YKrvR1eU4YmQC013FKY=; b=SErZesJ54QfQmLheBj+1Lpe2v2r2DGikNse0spxwanTFoQAVxlXvV8Me4QmBzLMHcWSWHU xbr+UZuCkVPHVwHizrTIeZPhNSoGUr3YNcwXDq0KvikIM5RK5hffzJ9BQxn7TgSmwCYGvL cEjjVQeZz2Ycb0LB5cfZdeqcv1NS2XQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=BIn4zwsg; spf=none (imf26.hostedemail.com: domain of BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729054543; a=rsa-sha256; cv=none; b=nLBNKEsfAN6cUnX8AaqBfbi05quDJcJ6013cOkX7PDTrd5E/OmIdlYcptlyR8Q/Zif1ZHw y81+/ApynUdchvaPby8ZPczgOBlg81d9iLm3pxoSbC6V0SraopPwzOwkYyeQkv/tJ5X/vZ dYZ/xt3HUmgIUuiZenXrTPJULz4ckNs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aVmIGSz20klS9BwIwrqXLAa+YKrvR1eU4YmQC013FKY=; b=BIn4zwsgqexoDCuwPI98ylZZ1s AXIF288+7kSjgvl6Xi9cYsX10ZNj+lSxG11jn7YKHWh+P5Ag0EBk6QAuHlGyo8DrXK9Msv8TtclYA CHky/h7XFBXZuGZklLFNKXhuz5KFoWXf8XxB+F4kgnRRGH4W1+9oQbFKjtK0KYXChIomh+r+On55i ELMeqGMu+uBBsN6PU6zuExJLgLRKhvEmQ9oHpw2FvJLX1m6MdCXged+KqkmKZbFwJPdR6uIjsBUKF xtL0gJsrYoRuJAi9cI6nSAAnsg4eVMCOdDPF2yZg1PpYAalumDkMUUGoIOsIxGvbvES+IEIb+nQeQ 3v1VtPyg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t0w5b-0000000AWro-0Mzz; Wed, 16 Oct 2024 04:56:51 +0000 Date: Tue, 15 Oct 2024 21:56:51 -0700 From: Christoph Hellwig To: lizhe.67@bytedance.com Cc: peterz@infradead.org, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC 1/2] rwsem: introduce upgrade_read interface Message-ID: References: <20241016043600.35139-1-lizhe.67@bytedance.com> <20241016043600.35139-2-lizhe.67@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241016043600.35139-2-lizhe.67@bytedance.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 46C9D140008 X-Stat-Signature: wrdgpzg8rzkryrkhpesj9dkdjtmiwmt7 X-HE-Tag: 1729054610-438454 X-HE-Meta: U2FsdGVkX1+jaJInpfBXpYSvSlR/5EahD+lJxkbK3HbZDthg8TNUXoNriDKY59o3jl5RO90EaBjGLz+CHJ6kxbyc07EpiTIHeb7YMwXzraAs8vJ1PCCASW5wLMPlw7865WWfrime5YwCzsgJ6veE7lsFZvigWxeYH1AUB9bGr032i0eiw/QXg/0spkOYc3rMZ1465HL4ilOvTkSmGW+TKBn15/OixIVb3t+R5wdBZVrLt6eAAYCf1/dK3nShPO/DF+PoHHnqxKTbXG4fbTRW4uy+l9oSdjcWB1bH+KTiiIrVFgfNad23hhzhRg7JioS9SGrh6FeK4g7ae3zPsD9IUtkJDXEDuOI8RyxDWO2Udi68iKcyji4ojW3Ed2QjHev7h85jNfDcpi+uust3KmtypTg3X09zHcWW36ksk4LedFZ/WVDBVxbz5gJ1m4sXoBN9lRv/WrB186fQUQ6BDgKtp/7QLeBCH6REcSsFXoccm2l1DoonIWGPbDMZPc2hyMhJbXaXrBq135NrXQ/3ENKWJOgpkkxBTVvblHBVPD0owSFCJ3BVWgRHfNf9OpXZo6ti8hrRS1nHY5uApPJAakuEaTgXnDKzg5lAEKe4N+XTQk7zBHqEoVDArvhacieFXAZ1Zt/a5kjrDKJZAjyRzgrwSNebPjocn7IiJpVE5TGiYM3/rzfavh5pmKaHRAY88NVZBXUbEZ+7W3TCm2vx0MhRJhwsRRJQbZgXvE9folx0+IG4MjIUkvQhh9qEzC3jKhmmRp5Y7e62xfKcNpPDzkNskat/ldLJ5oIlb9dHhV8+UnmZlDnSEWpstolRFjcLxNG2UC2BJWHSai3Z/MoRg2/CASp8JkRUjtL0dZqFgTct4xwLicJ6fhOhNKMjIAERqGFvUqsEx2V87y60lSH8AajCM3uXmuXVpLEZPBcD6+qrWlK0aRKgytwsXcOlaO/pcnKUbqtqLlzzvTnNy1clUzn +Kwpfma2 ldB3RnciXDukeWzvsTTYsKfuxpnFFNkHmAos3gCp3+mwf8NA8lM1HMRB3QO/sz1k6IbRwgrbOKL5DjeYY+jma3dIDpHdebS0SWxPuN2zFQYvXFbIxVAqNUxy8GjJazJumeH8axJJOXZlQybIbGjCARYC23mb7ARlFhE82yJvDn7KCkerY2+6y/B0WgCbhwuhzsHS4j4DYhmg371hguTs5ViImBOMB/0PViqcwUrjZk0RFnLR31xzmyi6/S6lJyjnUwnZK3F31Cx6An3vsMF3WkUBUTA2z/l6P/xnv4G66RovM+4IyAP2/ItaHrkPQ5tS2m3mH364ty8waZF1WHidJGRQv+RbXSbpYjwhKMPRgYnqCx+qpmQXLzU4tEczX8J8c7gTap+PlqMgzhZzMYosKJluJXUApX+TXuCBzgCrJm7yjtdm02bMzJgC9XXgD6kaq99I9xPCCNhUegWLVQVrmqHJX9AiSi1VO/moIIkN5qV7vwjcb2OegmENfIEYurz/COtg8ta0WA4vlmr5u+6OhjFz3CLa9Bf8aUSFHxaBCQfTgUYVB4pQqK1oXupO1uZ+SUsBHm21NddJPinY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 16, 2024 at 12:35:59PM +0800, lizhe.67@bytedance.com wrote: > From: Li Zhe > > Introduce a new rwsem interface upgrade_read(). We can call it It's obviously a try_upgrade_read, right? > +extern int upgrade_read(struct rw_semaphore *sem); No need for the extern. Also please make any new advanced funtionality like this an EXPORT_SYMBO_GPL. That is if you actually had a modular user, the current one is built-in. (although we could use this in XFS if it lands).