From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78066D1AD24 for ; Wed, 16 Oct 2024 08:16:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D5AF6B0083; Wed, 16 Oct 2024 04:16:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 084D36B0082; Wed, 16 Oct 2024 04:16:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB5916B0083; Wed, 16 Oct 2024 04:16:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C5BFB6B007B for ; Wed, 16 Oct 2024 04:16:00 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2B238AAA49 for ; Wed, 16 Oct 2024 08:15:41 +0000 (UTC) X-FDA: 82678757196.29.A7CDC92 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 0938E8000E for ; Wed, 16 Oct 2024 08:15:42 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oqR5qsdi; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729066526; a=rsa-sha256; cv=none; b=OvrqxRsUCjzOoX5Z4UHBoZ90IFiYcdjmIytDS37E+6mrwDAL7qkvJlXTveWaB0eLuhI1bS gWxUonjmH3Ybn/XEHIuLeU7+dq2cj0pv0xN2tV6ZFcWxp6a5WJWKilHGwRq+CRNlIFgjzS ZxGmnsqflaDGhmwH1iMJ4KkmqKnKRFc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oqR5qsdi; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729066526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0YZhX2A4xvf5d52QLl8gFzJ+PUPYDVSpo+8ILsM3Apo=; b=qirw2ZgLpudZMZ8sM36+JGcproMZ5YScpnri8XAFP38To8yxvbhWVhfKWJPAlCTNDFBNZd J/TgFd+s/47hjwYTCLploWhPYZJGNhkUqy6ZyjzF/IbaKwVn2E0WPQO1EAYLEgVALGpOXk GVTpQcWlDJX7rHCGaFJPtSsMER+lTII= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 83B3F5C5D9D; Wed, 16 Oct 2024 08:15:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B789EC4CECE; Wed, 16 Oct 2024 08:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729066557; bh=paOfskxnn7huquWUaZ1z3Ki63NJ44tEyCzZcQM3Eqsk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oqR5qsdiN7DIXQ1uMZ2eyas6EtLCo3X6jIjqexMT8BSRUy1XXhOXyfZcTSG3RKp7g OEfLbQO6KkfWnF+6qpR0k7oPiSw0TGLA1HBs/qH9WvhgkBp+LH7TRhtgkZUbSEZ5as c0xbLCpAVblXpFTlmYqoQDg6gyjwPf2VCQIlm1uMJSC/jUWlXrn7rlb/CpcOjhUNEJ Yvh3xrA739UxCYNkgt5fKt4Qu06DhXJg8IPDR4203yI4Ipuu9FnpvaRPCGbus0zNTu 6ApGrPDperlLMvdjPZ0rGqeZ1Ct4y88CSLBxF48jwr2SoUgPLD7mBIIOjtKNm9hK4d PjRUNZB+3Tv3Q== Date: Wed, 16 Oct 2024 11:12:18 +0300 From: Mike Rapoport To: Nobuhiro Iwamatsu Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, yuji2.ishikawa@toshiba.co.jp Subject: Re: [PATCH RFC] mm: numa_clear_kernel_node_hotplug: Add NUMA_NO_NODE check for node id Message-ID: References: <1729057030-4625-1-git-send-email-nobuhiro1.iwamatsu@toshiba.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1729057030-4625-1-git-send-email-nobuhiro1.iwamatsu@toshiba.co.jp> X-Rspam-User: X-Stat-Signature: 589q66xoropfifz8odw4tp6rha9jric7 X-Rspamd-Queue-Id: 0938E8000E X-Rspamd-Server: rspam02 X-HE-Tag: 1729066542-911974 X-HE-Meta: U2FsdGVkX1+XvbLziG59qYykwR9Lt2okZUIBKk5eCcQ1kYtQ4L9dyQullIrpTX8RAG0W0/maC36mqSBifJsCJHBYE5lEcXcd2Ksp1b2J8/xgH1hzT0Feg/vzDSVLdy7ikGMhuKPMSetF5wO9CiknKjOZmu7vu7awKK5FcsEFc4mc/tXYRaF400bqUOhDcKGZEM9UFLtIgS0wquZvTJKvaJQLAMy6so9fpm9OVHwTgDCIQCk8sppLNlpsiHKlTinHq2xLq/EyQblBy0IVHKxnJs55IZkf3MAm/dzSWHyfSe3572FhghgewjNuai02VgHVlSPMtfMQ3GeNiRlvwlQnuQ9Ma+eC5dOl+cuHh4dLb2Nat8zeaEG3SfPtEJwiMrFzhKev0/yJ97O7nTM7Jf+zC5L3zESENn8SmikDEgJrZ53ut5lpWB27nflLKNRWidH4AKq5p1PnWtGbW6EYB9zcR0AkL4UmeOnDZF3ZwNiHPR50vbFB8f1MA9jFdPlA/Z6F/9q7ZaVyNQ7yO1HaKtz2/4UKoVHIGtFLhcN+YvwEZffnSkanv59apUE7h+xPTUm1/XsIXTuErtv5dpYfSdh5a02aqijAvBoGw+dZkNTxcX0r53cdro7MYDFSV92YCjjaSy4Faos+21Y14hTz6byhgdWNYvpdw5lgGNlGthG1AEYobaFj6Hpd/OW1OMxaRLbeLZ53f6iBTbVHvJX21ISMOcSVWN35uNxwnubFlEuecn0qGcgTRiDkXe7n2bNxFdUSV3KxUPkZA8Jj4Z1nhVbwgAcgRyho9vJOuur4g3o8hsJDBeXu/C6tI9q8IspvBJo/v7aNQ2QnqO5h4MZBzY+Ri11n+Vx3cL+OGtmy3iLJ4yIMC+EqULqjuYD1o52rJot/vfN3G3byE7BlIDlgiXppB4gRArHTTBFeh+vtC0T5yHdzBSfo418UQZOgA66L+5WdWoR8hJW5mSVoCLp8YOZ 0P/JCI1d mbo+xwtldFi1Jo//2dzxLjHbco3+Wzu4Udkf2MKFjR0ojP4a6WzDkHK4bTfMGYgTFjAGlAjYnW8glohH0l3aRWC/nE0n4ZijxdTcgm0Ro9dyfJ6ax76dPCRhTh02KuJculvd0ALct6tQL+M3Y18nmi+oro7lQocjhT9/VPfc5yPDxfCCDjsjOvizsOAWekElUiJFBhNSUnw+O69NbGW5kgIWMnUhUiq0eM5Z+ywiBwQk1KyF2khR9VPN5okCDZ3hzUq4+FR5yUrza3VIjppFZdGbu3QZmVS9G+Fd9nh5WZswrIXOWiKTVGmlyrPXmvxPkQFXioKmDlblH6KKZsjX6Jata2YU3jNDjOK7XjxAiNmqZ7cs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 16, 2024 at 02:37:10PM +0900, Nobuhiro Iwamatsu wrote: > The acquired memory blocks for reserved may include blocks outside of > memory management. In this case, the nid variable is set to NUMA_NO_NODE > (-1), so an error occurs in node_set(). > This adds a check to numa_clear_kernel_node_hotplug that skips node_set > when nid is set to NUMA_NO_NODE. > > Fixes: 87482708210f ("mm: introduce numa_memblks") > Suggested-by: Yuji Ishikawa > Signed-off-by: Nobuhiro Iwamatsu > Cc: Mike Rapoport (Microsoft) > --- > mm/numa_memblks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c > index be52b93a9c58..b982f9260872 100644 > --- a/mm/numa_memblks.c > +++ b/mm/numa_memblks.c > @@ -349,7 +349,7 @@ static void __init numa_clear_kernel_node_hotplug(void) > for_each_reserved_mem_region(mb_region) { > int nid = memblock_get_region_node(mb_region); > > - if (nid != MAX_NUMNODES) > + if (nid != NUMA_NO_NODE && nid != MAX_NUMNODES) We have numa_valid_node() check for this, please use that. Otherwise Reviewed-by: Mike Rapoport (Microsoft) > node_set(nid, reserved_nodemask); > } > > -- > 2.45.2 > > -- Sincerely yours, Mike.