From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13022D1D896 for ; Tue, 15 Oct 2024 18:33:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 717F86B008A; Tue, 15 Oct 2024 14:33:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A0416B008C; Tue, 15 Oct 2024 14:33:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F3456B0092; Tue, 15 Oct 2024 14:33:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2E7026B008A for ; Tue, 15 Oct 2024 14:33:54 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D642216186A for ; Tue, 15 Oct 2024 18:33:43 +0000 (UTC) X-FDA: 82676685210.07.1E2FADE Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by imf01.hostedemail.com (Postfix) with ESMTP id 3B01A40013 for ; Tue, 15 Oct 2024 18:33:45 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NKMInNAY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729017199; a=rsa-sha256; cv=none; b=CsYFa58QZ8DY6Y+DLcno/iGMoxe9/RV6icw4j0LW8D+MF+Lqbewp5RB6HiSz1ocpvfLSdP 4Pn7gbE2fiGhQIcZ4EiaIehzAGi9yb5WNXFq3D/a6K83V33TJq0lqbXo0TjX17+r5NFttg yHeCZsk/Oq+oICUdiVmjhrcpozWTAYY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NKMInNAY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.45 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729017199; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QwdSz4+8Ky45UzwFORY+UYW0E7DBFtoy97+eh38bxws=; b=q06ckhCKfzSUb3DVl+DquVzcBwCQhgpCQKolNNTunEFJJcdfj4C/Ks3aHY+ZR53w8Diksz /CHRmO32bMUhV32HBdt0J39J+QkqZ4RoVa4J1JX5vDpx4ymdZvLKr3CIeRUJvdKpZ4X5K6 vLCFCubeZx8/FaY7BwtesX5/auRJ8kw= Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6cbe3e99680so28257726d6.3 for ; Tue, 15 Oct 2024 11:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729017231; x=1729622031; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=QwdSz4+8Ky45UzwFORY+UYW0E7DBFtoy97+eh38bxws=; b=NKMInNAYElF0rstvoOw1nRQBnhs8vK0wi7fm89/o+5yLHrRUq/xXcJL1lCbhSWJ6im u+6NDLYecQw69W8bqG2C9B+6sMrUwBup92SURPD6iQD25hfPNBqCXxvAbWXfPKarpdhu GZRFPuIzjOQojcgZSV7bzRgwATv/maSyDlj8jJ9YJpV5ks+xJGVyVJviNB/wKqoTPYdq k4c2Qk8k9+gk7OMvWHO1LiJmFr7W0onQTI8W8brxvgdXGx86Kp4ssgnM05kXNEv7OMws ZDUHXEPAziIwcS6wcYZuU7u2PtFikTIcvRc1jljFkaJpE7gLrtTNbgJtl98z6KqfuJXH a7mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729017231; x=1729622031; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QwdSz4+8Ky45UzwFORY+UYW0E7DBFtoy97+eh38bxws=; b=bV85rFhD3E2E89H/TtGGMfRPYe/wIW4a36dr6VdwLIMgFJaSiAX094vgT2j2/WFeAP IQrv1Ei30/PY1R7NXf7cEN1obYKbUoaW5YJaYIepIpr6AriUikdHPT/3W9CVoMNoZ+Ac qq8EwhMrFqZyg2qOnwH0XhWieqDoAe1+CpMamNnLdp98hJmzVNnr9qEOqf92+9v8mCBV heEugbqnsy2Rd32Mznb/66WrI003lfPsBOD0AeHLJcMMnlQmCArMhUE2hXMyFYP4HMZW ps9tdba1susP/A3uapgsxH9FMH8azCbLHUwFyIgvGwQijkdh1Uuph8tz8bREHtcAolyp FAZA== X-Forwarded-Encrypted: i=1; AJvYcCXOwM8ClpkdhUwKXh9NWqpfuy+Z74QGI4CIzY7RNyFaU6sa1qNKOl3u/nYWwFOMLfMikHdSqjHHLg==@kvack.org X-Gm-Message-State: AOJu0YyiKYe/+3GpSpSdS+8madt7ujhPFdYBNjH77QOi7gLRbAF3xeKx bg/8ytMIMZanMrFwfjOT9HD4TZEbLU1nUrJr3QHzOs+Qx3AkE7xn X-Google-Smtp-Source: AGHT+IG47YfMpMWRfsK29ywOrKJ5I3JyLV5j7fESJj4JpLi+jJSQPwF7cEuVqLMekZBMWwKKEWVaZA== X-Received: by 2002:ad4:4506:0:b0:6cc:2c7c:92e2 with SMTP id 6a1803df08f44-6cc2c7c9343mr4741956d6.18.1729017230808; Tue, 15 Oct 2024 11:33:50 -0700 (PDT) Received: from fauth-a2-smtp.messagingengine.com (fauth-a2-smtp.messagingengine.com. [103.168.172.201]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cc22959a23sm9535806d6.94.2024.10.15.11.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 11:33:50 -0700 (PDT) Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfauth.phl.internal (Postfix) with ESMTP id 0E08C1200043; Tue, 15 Oct 2024 14:33:50 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Tue, 15 Oct 2024 14:33:50 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdegjedguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddv necuhfhrohhmpeeuohhquhhnucfhvghnghcuoegsohhquhhnrdhfvghnghesghhmrghilh drtghomheqnecuggftrfgrthhtvghrnhephedugfduffffteeutddvheeuveelvdfhleel ieevtdeguefhgeeuveeiudffiedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepsghoqhhunhdomhgvshhmthhprghuthhhphgvrhhsohhnrghl ihhthidqieelvdeghedtieegqddujeejkeehheehvddqsghoqhhunhdrfhgvnhhgpeepgh hmrghilhdrtghomhesfhhigihmvgdrnhgrmhgvpdhnsggprhgtphhtthhopedugedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtoheprghlihgtvghrhihhlhesghhoohhglhgvrd gtohhmpdhrtghpthhtohepohhjvggurgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtohep rghkphhmsehlihhnuhigqdhfohhunhgurghtihhonhdrohhrghdprhgtphhtthhopeifih hllhihsehinhhfrhgruggvrggurdhorhhgpdhrtghpthhtoheprghlvgigrdhgrgihnhho rhesghhmrghilhdrtghomhdprhgtphhtthhopehgrghrhiesghgrrhihghhuohdrnhgvth dprhgtphhtthhopegsjhhorhhnfegpghhhsehprhhothhonhhmrghilhdrtghomhdprhgt phhtthhopegsvghnnhhordhlohhsshhinhesphhrohhtohhnrdhmvgdprhgtphhtthhope grrdhhihhnuggsohhrgheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Oct 2024 14:33:49 -0400 (EDT) Date: Tue, 15 Oct 2024 11:33:29 -0700 From: Boqun Feng To: Alice Ryhl Cc: Miguel Ojeda , Andrew Morton , "Matthew Wilcox (Oracle)" , Alex Gaynor , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Trevor Gross , linux-mm@kvack.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rust: page: add Rust version of PAGE_ALIGN Message-ID: References: <20241015-page-align-v1-1-68fbd8b6d10c@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241015-page-align-v1-1-68fbd8b6d10c@google.com> X-Rspam-User: X-Stat-Signature: xw4d6c4b8aymy75omthb1muh4xsbjt57 X-Rspamd-Queue-Id: 3B01A40013 X-Rspamd-Server: rspam02 X-HE-Tag: 1729017225-352704 X-HE-Meta: U2FsdGVkX185MqkW0BAYfFA05k0N+tNUVwePqpB64zQfj736WdJe0ZQokhi8fyuPYYGnp8h68mh5CdUuQWINpvfSI8m5LDJYAw9hvV20HD16LVWa3wJAGF6UpC6oOV6uyGQe925TaRRydLdcxWvVjt0hl0k2cwrdNtoTxuU1T9c1mqYI7/faGUWi1bB2nSMjHMJ03bsl3rjN7HAb2v0MjXWR2iw8RAkjvYhMSGmZYjp3AvwXbcjteuaty5RKpW8KpmmzhNP0jHdw+hF4owK44SsaXiHxAWm6qeq66mp0t45DdJJAq5rycYK0vgXwIR9uSnJL69QPhtwQvv39ZkW9ehL1N2s6yDeTnPu3gl02yQv2mdoo2zTxD1hiy9O1Z5coAMudApDqZMHugk5U98rXjvvLDS2j5L8hzDXVrQkZnW7PVzH6AsD7hea6FIHUV1Pp+TdYZX9ThCcy19Iq3DvZIebXLAGwsy58QbCNHieZjd/zEGIAuxVSkqpgB64EHbeQMHwfwqSoOaRriDwGGjy2TDvxXfsf0map2+Zm4T2vc6E5eJmr7Q5JEBXRp0kvSVsCqe3XE1TWvX+LOqx/EvFc6uChpm8YJMwNKsBtf/E8Oxky/L69X+8Yx6BpyFltYSHZK2RBiPedCeVEWkwpxVIt+qvsM6lmOibYWNt/Jhai2ndfAZEEhYoGO9U1zRDHmaJv3Loa9kjqBgNP0+rb3oCbNFT/g4NPhUSQObB91Li+Vy97nBnKg0ZYElNUd1dxcyC3mJD7DQ0EaIOtGt0c6lF347GPe43hSqTg3h/D1SelW/UXoISE4q8sFjTUwN8FuK5z054iP5uj7Sw9VcNUVZ8CtJUkdZM/Gzmu+6C+F1lCKDfA8hcVSncP0xqkfZx5twYO8ZG+L+foDk4YFo1JvqyeN+fv0Z0QbO15IFo0k2GSXALk3bK0ig4N+/xKYel04z+XGbZYWfyFM5NCy4PAmmp 2GSqYxJR agepJKBhFAbKR6IAWd0vYkxj1QH4AfebPe1A9vmoWblocZF9rS5eYRnBCR/6SV6X74Ee4hwNdbQFAxQDW8RQogGgD8JAY/OyzBVztU5df4IAq0gcY0L7SAa+slL+MrA/8FSc+EtSw3nApcHgKB4maH/PHfejd3ScXkndoNnkcdLqDaUbSg9FYjxLJ3++j4BJ4HLZ3hLnIBozgyUNi5N1nrs9FNzp//R0mJ2+kWXk0YSGp7tILQ0F+pna7GdH6YPGKYCYshPKK/w0d7QLyVT0JhUtxggJL0EL4EeZz2xUmYwK1QLNXkFmlP6S69gIfLjTvABAiEs3IURQiQeadSQeKfDgxBubNRcPmjEjhDCh6loCfsdQA7NwRdUJTFM65iJVDTCj3clyXOLbYDlZ6cMz0ZvwrOw2UcjSST6OsPhoFSNSnb6CXQtusW2w1wyFiRD6pJ0/DobYUmgmE0UQTZxKT3mT7FZWzMeJmJWgr/4ytB/YNYxU0TWR/Abil6dnF9fyk9JxoK8LSAqj4VLBRxRfNi0DVSm2TdNRRz2OTOaZ2yQQ4EsI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 15, 2024 at 02:28:28PM +0000, Alice Ryhl wrote: > This is a useful for helper for working with indices into buffers that > consist of several pages. I forgot to include it when I added PAGE_SIZE > and PAGE_MASK for the same purpose in commit fc6e66f4696b ("rust: add > abstraction for `struct page`"). > > Signed-off-by: Alice Ryhl > --- > rust/kernel/page.rs | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/rust/kernel/page.rs b/rust/kernel/page.rs > index 208a006d587c..90846e3fe829 100644 > --- a/rust/kernel/page.rs > +++ b/rust/kernel/page.rs > @@ -20,6 +20,11 @@ > /// A bitmask that gives the page containing a given address. > pub const PAGE_MASK: usize = !(PAGE_SIZE - 1); > > +/// Round up the given number to a multiple of `PAGE_SIZE`. > +pub fn page_align(addr: usize) -> usize { Make it a `const` function? For example, there is a VMBUS_RING_SIZE() macro in C that calculates a const number for a vmbus ringbuffer size, so it will be useful. > + (addr + (PAGE_SIZE - 1)) & PAGE_MASK I guess overflows are unexpected, i.e. the users should not pass a `addr` that `> usize::MAX - PAGE_SIZE + 1`? Regards, Boqun > +} > + > /// A pointer to a page that owns the page allocation. > /// > /// # Invariants > > --- > base-commit: 8d8f785ceb21b9a0de11e05b811cc52d6fa79318 > change-id: 20241015-page-align-7e5fa4c751be > > Best regards, > -- > Alice Ryhl >