From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACBA9D18157 for ; Mon, 14 Oct 2024 23:22:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A4316B0082; Mon, 14 Oct 2024 19:22:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22F8F6B0083; Mon, 14 Oct 2024 19:22:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F5016B0085; Mon, 14 Oct 2024 19:22:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E3BAE6B0082 for ; Mon, 14 Oct 2024 19:22:16 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 201B8AB1F2 for ; Mon, 14 Oct 2024 23:22:00 +0000 (UTC) X-FDA: 82673783262.25.54D98FF Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) by imf02.hostedemail.com (Postfix) with ESMTP id CF48180014 for ; Mon, 14 Oct 2024 23:22:01 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=4lajm9We; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of 3pKcNZwYKCGkZLHUQJNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--seanjc.bounces.google.com designates 209.85.215.201 as permitted sender) smtp.mailfrom=3pKcNZwYKCGkZLHUQJNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728948103; a=rsa-sha256; cv=none; b=Lgt7tInlJiJjy3imBilg6k1b2Nu1FC3XOhwt/12iaoWr0pHRkyAZv9BFKeVCydgHwD2EIk F/Yd2ZQwKVVMvP2prw3HQ8lN+iNUQYzYtWJI6fpVK2FEJOizS2LB8JZiDHV1lvJZ96hI6L 4M7qs9Gbdt11E+f8RZwehsR5bzDXbsY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=4lajm9We; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of 3pKcNZwYKCGkZLHUQJNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--seanjc.bounces.google.com designates 209.85.215.201 as permitted sender) smtp.mailfrom=3pKcNZwYKCGkZLHUQJNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728948103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VAu7m51SVxmU1exE3wy3lzahRBBLAty9XHzwNKyTXnk=; b=xreoz+10x225LCyIYwmyho/UjfIuSlsv5qI9tpSg5/OYOVCKH0ZwKbz2/HgrmDqtaYWujs KG8f7DChI4BtPZgB+PvD8JG8mHcf0FkDHT+nTHXoMBaQwUuLRLxyeCwtDHoj/uitCUeFMC 5E+vybSAUtW9Vx8VKeHXtj3RP9sV1gQ= Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-7e6e98892e1so5245374a12.0 for ; Mon, 14 Oct 2024 16:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728948133; x=1729552933; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=VAu7m51SVxmU1exE3wy3lzahRBBLAty9XHzwNKyTXnk=; b=4lajm9WertEZ6YQ8yniW841GKhbTcfH+PJOsyH99vF4AyEChfZyFvGr7prDXpZg7yK dzMXVkW79RodatzSTtO3ghAvBfHPeKy3hdpo8kHuvYacEDGj3dE/zcUI/gw7I59klPqc +Ld73NgBHLqSGzG4bj4R0BMzrsm3T3Kck/EEDbhLn2OAP+fbpagh2+3mnpkVhHJ3zhri /2PJB4stk7q1Em3uj00XqR16UV2tttosFavMLD115TCj4Nz9ylZyDFC8od3Qlub9CNQ8 hQVHIgolmXyHyF4hOPSlRYf9Bo3rKpYYW+ui2UNJ8UCs6sjzdxlYOpJWfzFMUwyn4txA c4HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728948133; x=1729552933; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VAu7m51SVxmU1exE3wy3lzahRBBLAty9XHzwNKyTXnk=; b=HCtxYEPbd3fcYI/6ppKiS/oh5ogehV9J80LfbtKVGcUQi0jBlPJFqfsBy0SS40XjqV c3RlxDHrkOcPiI4f3Z8Qxw8Dmt6HmTEy48fm0G7v430QVf19PyoNiIta/9Ka2E9e2qO6 nb+WsI8KSHOoJHd9eHouDfJcRPBLM7/hwD/pbNi9/sIBunXZ7VhJqr+3C7qME/isVxsE FGGRCOGO3vFcKtgYdaiCDfS8CryQ+lH6aHGqipi6VV8FFov4PpsaJCKR8YeYT+jz0gKq 7EDzfNI4simxKPW3Bthb/OSUvFrY6moj5Z9HiLR/IJcKi22oSFOFuebfa1o/y8u0WiwM MueQ== X-Forwarded-Encrypted: i=1; AJvYcCVdQ5W4Q4PxDm+RaAbEa9Wd/+9qqq1LeKwH82JwcQf0PeiyDO6Bb6DgCS9FzpM5vQMFvqB6Bkjk4g==@kvack.org X-Gm-Message-State: AOJu0Yzm71r5+2BinkjJF+OI2AH4RcBFz3ZY18qCM4dp2BhqTOGRxYSn gzVNPuUz3IwcPPJj46Zz5zEn4x7aRWg2+cAa+7AeiAN+SIBHkf5MPCLQPVb+awxUKL7K77an5lD Tjg== X-Google-Smtp-Source: AGHT+IEKOSgRz9DiX0LTECtalJA9o5kHyI4bzVItB0t5QtRGcyAmOXJ+lxLiO/PhBoXndkle9dQfPQy7mvE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a63:c25:0:b0:694:4311:6eb4 with SMTP id 41be03b00d2f7-7ea5358e4e2mr17001a12.8.1728948132929; Mon, 14 Oct 2024 16:22:12 -0700 (PDT) Date: Mon, 14 Oct 2024 16:22:11 -0700 In-Reply-To: <20240926013506.860253-1-jthoughton@google.com> Mime-Version: 1.0 References: <20240926013506.860253-1-jthoughton@google.com> Message-ID: Subject: Re: [PATCH v7 00/18] mm: multi-gen LRU: Walk secondary MMU page tables while aging From: Sean Christopherson To: James Houghton Cc: Paolo Bonzini , Andrew Morton , David Matlack , David Rientjes , Jason Gunthorpe , Jonathan Corbet , Marc Zyngier , Oliver Upton , Wei Xu , Yu Zhao , Axel Rasmussen , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Stat-Signature: 5z8zeituwwzt5jkpr3tfrgij56etdgtj X-Rspamd-Queue-Id: CF48180014 X-Rspamd-Server: rspam02 X-HE-Tag: 1728948121-170273 X-HE-Meta: U2FsdGVkX18y+MWZ+XddHQQtj7Gj996h63dWKxmAfTdboc9XQ+v9nVs7rl8YaAAEGi4f74TY6vmiEm7qORWVbdfVeRjTRN72NPwPf/vivNcZ4QRNtLCGJu20RsAebNjtjw/GAm2xnO9pef3FHwj0h5VvneFaNoGfRGGvrP8rWaZEL09yWY5ybI5CggIw5gKXBqPdVZEb8tjzWC4VUXwcZ/k50NYeSwe00mpMidEWuFa4nPspe90eda2nRkX6EGmRUsXKW4BrJ5N2kaeAPrcL3uzPs95Mg3oRoXjVcZFBTDZoZMMt2nBq4W0VPsy2d4cqgiaFktrxScTqIvSFCw6uUe1k6d45dKhPkM34IkyS7S/lXch4LS9p25RK9XvLuj9j7qzG/zV+ANaZTJUGHEnlO77xTDrD0BnhLbFUNyooaD//4IMPqhPwuHJH18MKvcTeFFF+65YaJYCTrMUvpG2phlBLpXdoOnvZOjhJzna/2sWVFQkeBgu94LQ5vFSuU9PCV9ZT9CWiMxLz615Zr1eb/ENJPPbUSJo75NWCrMiQZ8CywiuPSe0l7I0JR0U64lAvHquigideDXNtNWs/Oz/C/UZPi/MEtuqL6BSCeFm56pyruO9LnhncBUg0t8zp0KAPHk/vyoctiR4FD5MWKXDDI2Wa5BoDMjxZppEYl3g9iuhyJWh+YyVUUl16iw4hWNSjUdhL99qGqDguJgMZCq3RxOpGs9eavG3kNuVoGVAJI3bGNQBzyNV9YRPqjDSkNKGJT8OZsHLqKk62u9hYbF0KmIIhqZrjVllHM50LSTRJr3Kr0V5vxrwW+wufn6fcd7fd1DgivJ+8nxyk0doVT75DXJjixvlh/386CsaSAofUk12HKQqYTzrffGu0GQk4bDScu5xXxSEwWbaYRn1Gz4sxL2cMG8ThgjcfhnssB/qJRtcdttdCCimdwD83kFBMLu0jdOA47S1w6V11CSL8CKr eLdUwD/A fmMloW4xptVoGuGPMNMsahx19FvqTX56yS3e8QutDw3wv/Qf0+4MH+JQ8Kzxk6UHPopmwTaYy+K80+cxdIm2GCSuIiCovtFRTJISUnDcm6mm6Fzz/eMJljm12nwV/PdRggXt16oSQLPSQMvTPomMZ0rwcG9LCdNjASviAqow3pkLlpCAkgH+BKZLiMJjrWRUR4R06SBXWwcUdD0Rnoroc/87yz1fpIm01w5+Dq8fS+WIg3r4nJfzGr4b9NDML0xoHWS0tBjaUX6JouEt2lgFoInws8vsps2loW7O38pf6SskmgqAHF4htIyTvyGfouZwMtZcpy/pcAu2nWoMZLjlnqByrT5lrtUWmy+K/0c/qD0i7qHmh2eNj9HLauuyDyD6X8Sw4JyCLj9OCqCvF5NZSflh6eMO+auEJXLnz1tHVLY6FkwdfS68+8gzXFdV7eBWXfG650Q0O+tjecSAxGXoLv2yify7Jod4/UX5r0aA/db033R1Cz0X7/nidecUMWIWpLy78Kd6yTCw/WaO9d6koEy9ZdH1E8uXLvFU8VS4mO9bbXnG4Up0WXUi+v0eHprhs6/sXGB1AvZJzI9PzDNvszetcMQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 26, 2024, James Houghton wrote: > This patchset makes it possible for MGLRU to consult secondary MMUs > while doing aging, not just during eviction. This allows for more > accurate reclaim decisions, which is especially important for proactive > reclaim. ... > James Houghton (14): > KVM: Remove kvm_handle_hva_range helper functions > KVM: Add lockless memslot walk to KVM > KVM: x86/mmu: Factor out spte atomic bit clearing routine > KVM: x86/mmu: Relax locking for kvm_test_age_gfn and kvm_age_gfn > KVM: x86/mmu: Rearrange kvm_{test_,}age_gfn > KVM: x86/mmu: Only check gfn age in shadow MMU if > indirect_shadow_pages > 0 > mm: Add missing mmu_notifier_clear_young for !MMU_NOTIFIER > mm: Add has_fast_aging to struct mmu_notifier > mm: Add fast_only bool to test_young and clear_young MMU notifiers Per offline discussions, there's a non-zero chance that fast_only won't be needed, because it may be preferable to incorporate secondary MMUs into MGLRU, even if they don't support "fast" aging. What's the status on that front? Even if the status is "TBD", it'd be very helpful to let others know, so that they don't spend time reviewing code that might be completely thrown away. > KVM: Pass fast_only to kvm_{test_,}age_gfn > KVM: x86/mmu: Locklessly harvest access information from shadow MMU > KVM: x86/mmu: Enable has_fast_aging > mm: multi-gen LRU: Have secondary MMUs participate in aging > KVM: selftests: Add multi-gen LRU aging to access_tracking_perf_test > > Sean Christopherson (4): > KVM: x86/mmu: Refactor low level rmap helpers to prep for walking w/o > mmu_lock > KVM: x86/mmu: Add infrastructure to allow walking rmaps outside of > mmu_lock > KVM: x86/mmu: Add support for lockless walks of rmap SPTEs > KVM: x86/mmu: Support rmap walks without holding mmu_lock when aging > gfns