From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B64CD1812A for ; Mon, 14 Oct 2024 15:48:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E31B6B0092; Mon, 14 Oct 2024 11:48:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 992936B0093; Mon, 14 Oct 2024 11:48:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 833736B0095; Mon, 14 Oct 2024 11:48:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E7F886B0092 for ; Mon, 14 Oct 2024 11:48:06 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 153CBAC066 for ; Mon, 14 Oct 2024 15:47:51 +0000 (UTC) X-FDA: 82672638846.16.2DD13D0 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf02.hostedemail.com (Postfix) with ESMTP id 0A57A80012 for ; Mon, 14 Oct 2024 15:47:52 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gUQHaFJn; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728920744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UN9DOZReEVJo/OcC/HXd2C7OMvf7IGr1OAx2EsccCPE=; b=FfoUObFY3KHzPmqlPMFV8pDd5Z15qvOFXsedqsYQqmcTmmEEH3JXsTNqbgbqj7in/M7IYJ IB0fJXnDgASsU4MU4CasIdyRu+IZCZW5NxisRJjkaCH9EaxIHj/ni8Ed5FNUlqzPCTiFZk uR4SuG8JdZpE2plHItUBrf956sS8pMY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728920744; a=rsa-sha256; cv=none; b=0qJgHS8oFJEtciM6wnnboBoKMrPK5LuWJFMyrzSq7spO500zoGB0SkWoaCB2IzeborDlet acsEas/cznzfep9EytjuRvIMbEZ+h38okHIknikRn1vBhR+ON4zm/q7MUrh6Qt+2IzQDJN jBbBIe0+rW7IdFLej9+ALslVi1PqDE8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gUQHaFJn; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3F10FA424E8; Mon, 14 Oct 2024 15:47:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 419EEC4CEC3; Mon, 14 Oct 2024 15:47:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728920883; bh=GzsUoUiNhKTK3YdZrXtW8NdzWqv5iw1PoH3sAqDorsw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gUQHaFJnfl8GocRbvMKCm2pNSv4Zu1bSbud4/N4HypWJBIeqQYnzf2PpU6r14SWJz kW0SPc8Te5lh8jX/vrd/yPGkY4O9IPCtqas2cbjJAxkHccC9gToBtC15aJ3e0yU5Mf 7p43gdpyB7n8IetfqbLFmpJewplOl7Y2MyvxbGm8nFwIoeIgoVrvwH+ApvH9UPOZCm Wgz45tCNiMdnSTaVNdfJa5iX3UL/V7PMDulmRjuyBtyIKNN2lIHxkmyQsSvfraLxVA K7q9QhV55XUcVhUJRx96J38FC/HiNvETBOo8/ffBfDu2wnnu8YIG0lolI/vpmRonFb TP90mzUwaH44w== Date: Mon, 14 Oct 2024 18:44:14 +0300 From: Mike Rapoport To: Dave Hansen Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christophe Leroy , Christoph Hellwig , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , linux-kernel@vger.kernel.org Subject: Re: [linux-next:master] [x86/module] 6661cae1aa: WARNING:at_arch/x86/mm/pat/set_memory.c:#__cpa_process_fault Message-ID: References: <202410111408.8fe6f604-lkp@intel.com> <73d5a6ed-da3c-448e-8cf8-6abb59cb2c36@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 0A57A80012 X-Stat-Signature: uboauwdu5tdtdikw3s1qifq6hkgyxs1k X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728920872-81213 X-HE-Meta: U2FsdGVkX18Nnc6DMX9sth2SD2gORHbj48uPx84GZY+63+cquRJ40CwGwV4WRqqo7wigzGosdNhv5K0Ra/+C4EpdIdyUyXt/noHAWMpXe7ySDx4pDkyghoSx1HG8qs7n5IvYTpumAp9C2IeDCHxOf5Z5e/qefhGTvxICe9PkDexSc0Uof9/7c8TlUVkhoYwkK5a1HVa/IJH7gN6nvtTy2I53C8u2bHUJ9EQu87f0zpOy9RoRHs7GapDd/Ps7dgQYFCVtzQf6YXi0sR0LgePCUqLIKuf/1SksYx6mfm8AdSy5ySXi0gEf3LbBH+9Xs8iuj4QPiTFkD/WmjlvbbM1oAV0+6NXQUtpl3rreLRt6O1dbtuH5gfZ2MdkrDI/BZwlwYgJrRd4+4lO/OoS77Lk1qWZ95t/1ym/MB3v1k50yX2M58VOkogfeYOXnGc5mu6EwSltxZoAoGtGNuf1xYrc5OyRo203d7Z6v7BpP/qG7qHhJz80nGb9ZMnKR+UoD3MhajjmjNeBnHsOL711b/OBgB6kSVqI9j2+6JewWC3l5mMXDf6wBkQMtnGl+5wwhoQO8lEIw+neHlhT+2Dy2cT42z2dzlxxzO/F0gnY2KW1THdgOPqBL+JqpEhCStg5lU3Sf3+BdkQySxBHqyKulUeRy8E//me1SCx5yXrXTcs4a3d7cM1dtOJZpaEHtVBnxgkfylC7bnKDXEGVIqC6if71SXxdbMHVdSTBYA6G3fLAn4VFS2+hJ6t5uNMa6h/BLyG8O2ivENmRkQqnipE7fxaY6PoNggEQrIjv5EqQLQkCi83cuaMazHbqp5SYm1QFIQJo7i/eOysa+ZaVyUeH2lknuWFIm6X8HpyEOPCM/7m3Oi33CWDEkVT8YEPFWlqQbPAdWZEIJ+CnSJwDmfZtmJFqxehR22EQpzkQBc7YA9uH43kmJHLxQKC4IcOyBqOeIrlw3PNGkMyksabsXlY92+o0 7PanAe2K Dva1KzOSZ7Lv9/W+T78L66YZ+XgAuGyi4Skm/nyunwztudvmkaBQE0Ujz18lWEivDBPsMqtQOqO6M9WQte+JsW4r1Ap1ca1BJXJiybZqDxzfFHWgJ0xZFToA9NsR3Abl+S17DtYXhMB5m6HfGDCmWxuM07z0VLnSveF3wws1Bqx9n57TaxaTDHfiaPGna2CJ0CHZXkNTGTDEMWB31lkzduI96LNVrKBKwS4kFXbmKPcWhj+O7q2Mx3xUWNMc1VfpYg+pc6TY5E1bQ6HM8wMVZ/U0VQsX0i50+EUv33U/0cIauStGrCdg1CQ4U5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 08:27:36AM -0700, Dave Hansen wrote: > On 10/13/24 01:17, Mike Rapoport wrote: > > On Fri, Oct 11, 2024 at 09:30:33AM -0700, Dave Hansen wrote: > >> On 10/11/24 08:40, Mike Rapoport wrote: > >>> On Fri, Oct 11, 2024 at 07:00:01AM -0700, Dave Hansen wrote: > >>>> On 10/11/24 06:08, Mike Rapoport wrote: > >>>>> This patch disables ROX caches on 32-bit, it should fix the issue. > >>>> While I'm not going to shed a tear for 32-bit, what's the actual > >>>> compatibility issue with 32-bit? > >>> From the stack trace it looks like execmem tries to update the direct map > >>> for highmem memory, and cpa is not happy about it. > >> > >> First of all, if it's a highmem problem, shouldn't the check be for > >> CONFIG_HIGHMEM and not on 32-bit vs. 64-bit? We do have non-highmem > >> 32-bit configs. > > > > 32 bit also does not have ARCH_HUGE_VMALLOC and execmem cache will be > > anyway populated with 4k pages, so I don't see why it would be useful on 32 > > bit all. > > It's not really about making it _available_ to 32-bit, but making sure > that we're actually doing the check against the right feature and in the > right way. > > To me, it seems like execmem itself should be excluding all HIGHMEM=y > builds or _maybe_ all 32-bit builds because execmem has the built-in > assumption that vmalloc memory is in the direct map. I presume you mean execmem cache here, as execmem in general should work everywhere. After discussion with Christoph about how to define execmem_fill_trapping_insns(), I'm going to add a Kconfig opt-in option that will guard the entire execmem cache implementation and have it selected by x86_64. -- Sincerely yours, Mike.