From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FFD2D1AD51 for ; Wed, 16 Oct 2024 12:21:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6985E6B007B; Wed, 16 Oct 2024 08:21:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 647C16B0082; Wed, 16 Oct 2024 08:21:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 536B56B0083; Wed, 16 Oct 2024 08:21:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 352766B007B for ; Wed, 16 Oct 2024 08:21:09 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F1BDA120130 for ; Wed, 16 Oct 2024 12:20:59 +0000 (UTC) X-FDA: 82679374722.27.C4A93D4 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id B37E340018 for ; Wed, 16 Oct 2024 12:21:02 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=UcS+SPbO; spf=none (imf12.hostedemail.com: domain of BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729081123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nicdyFTZX9ieCZYp6ZmfHdLzBRvz0j9w4YIafplZsjI=; b=qewGfFHPbnHI38tabzYeJFdWrgq1QEDUXIfYXQ2YyejzGf+ZSOu9w8RH5bMYw8jtqIPJFK aYQ5XN/wpbQYqz8mfROHN5ULev/2LWiOwQhqvYcPsLKi1DbI5mmZs+dU1EkfPpEMjPlK3g THaDkCY4NxGmQBFpU89T2UUYc7lnLWw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729081123; a=rsa-sha256; cv=none; b=JGGDJTkhy/bzR7q/prUAX+qT8NiUaLWaU+yrbSpCrIpeFvpQ0eUxXyASUT7IVqXCm/Ox5O caTJbFjgstjjEOYR+tQjogIR2cBtN0OEE3cr54H5R4VvC0VhbPswBD+EgUqFIuWKWZ+LDq RUZNpZunuaNT0aNxxEpG/FhifjXxccU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=UcS+SPbO; spf=none (imf12.hostedemail.com: domain of BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+6680796fe0e0bc9bbc38+7724+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nicdyFTZX9ieCZYp6ZmfHdLzBRvz0j9w4YIafplZsjI=; b=UcS+SPbOrwzSnT08ot3hY/CSeL pZqWiTKxdylFrPmkWX4QHs3BoBsWdVjdAnEHBKXUSivgHMfq4NUx8z4yCgNXOdBDfA4EbUunyq1TH gzXJKE5fuRS/XSEO/+MFweEuqt/0uJ3bzL8zjia95AlhcpWPiR4CBVhbIoB5zHcht8mQ+6JQMAb0L kO0Wd0hR1vtQFH4qhweyGDtP5sEI+Z2lTkbfgc/RIJNVesy9DwTbtMQNNv35kL6stWzybL7ouCHN2 n5cTl6PVTjSnNHXkXoRhrrqakP+a7bTPu19O/hc1dsUqK2EmNWNF9w6+8Qd2EkbyB7Ac2ZldSSGlA e3T3EY1Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t131Q-0000000BiEc-3hrM; Wed, 16 Oct 2024 12:21:00 +0000 Date: Wed, 16 Oct 2024 05:21:00 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , lizhe.67@bytedance.com, peterz@infradead.org, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC 1/2] rwsem: introduce upgrade_read interface Message-ID: References: <20241016043600.35139-1-lizhe.67@bytedance.com> <20241016043600.35139-2-lizhe.67@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B37E340018 X-Stat-Signature: kcea711atsq1u4azeqrhtxu5got9w173 X-HE-Tag: 1729081262-752584 X-HE-Meta: U2FsdGVkX18Lnco8D86FqN19pyCqhRDi54qoaE24f+NC1o7UuQsiPGPvs17aFNHXOlGBo187Tgq8AlkfRaqkZNQVsLo2qSSGl2BQ7aa6bYrS8zHQJTDWZSx8FPfstqWlF+rKxN0cofelDw1PX/sYwgBIcvxVu3YcIXVEol4i+tOjYL4FYFqaahdF0UWGmLiNLyaRU3/bweTdlzYHib4lgNwAMlRYzTGKxpDJfeulHEcfK7jckepsMySUpQP4BFUH1LQSj7O5E6vMsaB+l/plVzFN6bps9L4WhPDMkjWglDX0wBkRAPzjHLHuEpc3j5Cn8Z48ecCTAjxaZV8o3tbVR4h50TSS0mw+T3VZ8BsnYtcS4b/V9Iz7bRrDp29XOgyejIis29vUkk/ng8HCLLeKTXVkX827oQtZTWfdANu0/ttx7SgBIDkDgdsbi4fEX5DTAdedFPJgNcP2UE6JNtZAdEvA4NV/IFx4KKk5CQ5w3Za+0el+322Ep7b9Y4+/Oh3PMDG2W+E3E5AFnNpCEzQZe32fxu3p7rVLxKDwOD5UK99KwtMzVQtspJcHzyqMNaCHV1IHK7GT7LzwI8e6fE/mWsicJ+aSNO9lw9XoRNTFcFr8Ww8gaOzNKABuvWEPjgeFEaGNhaxwSR5QuKcx6NZmviJrijvC1B6OkN8OMLV9bYLHThcWfFD7WliR1gDx5+lcSmdP3WqmJsc5HPiEmpo+MX4I8tU01c41YAtcSS6l4LVD0woFQD5/zdcTxGvWAnnKAwHG1h47gUPrl5EjVSw8snZJJigtZUikBmauvCugAoUanys8h1Ifv+ezM+4WKxyyOfVUqF61E1QAFY7WFjMCbYp1OoioaJK2AWNy6h0KM06o0cXb6thHL9v2gcXGDepJJpWWv55w2oQ66kstijDfoLKGFzBznWC7uorTHhoiG8E9/5qJsqSWOf3U74htzLIv+GWJB5ovXyPgA4f6Q9X 7+Ajr7nf Lt8F6Zmo/2aDSXtblJveADOi2Nv305spUlZ2qLGixvc1F+G9gGfooVuAmW30eslaexCGUJjsJipyLZ/8XaKSf6FkxdHhKCOJT3wFK490nAkEb8ylSg/cVUPjBxCH37SQgMZwvW87hqX6m6QTitDR52h4f7zen8QB//bCZWlL5oT/1fXQN2Ihh5LHN4qXPzwMfvPMlLZOBRC52p7HzGev7FFXx7CJzqiAqsJUdiNZsLDDMZDs/K/J081tsSPwzOnifospGFMMTi0A11uNX39Z8K/m1BM+eFN6juLj9ASblVqF14/Fy5YaSnDR0zIfRr1OAyVbLCWYa/6uW6Ciu7LfNcv5nwxeBWyhn6SUq7VzQdNZqPezmfFjAzqaC91KgnBCDvt0IWb/7qPBTyzp8/sZiixptQUrBGh3bSJMkPKtrkEfjIWC3OvJfD7lq4/DNoPm+Y0CU0yahr7BnCPHvZFVw5uuRcGOXLIXZQWZN+UlQUHezbXB4oS5mDcMsgNKRPv9DUnoRTTCqwwnhv1474KP5F3r1Rwgh9EQfgXGDYjyQdFVbJbR+NH8aEf71lAyTyYRYSIED8WSzymVv3udunnCNlA1+d77bfCFLzYLS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 16, 2024 at 12:51:23PM +0100, Matthew Wilcox wrote: > > It's obviously a try_upgrade_read, right? > > Well, that's confusing. "try" usually means "don't sleep", and this > sleeps. Maybe it shouldn't sleep; ie we make this fail if there's any > other reader? It'll succeed less often, but it'll be easier to > understand. To me try primarily implies that it can fail and the return value needs to be checked. But I guess it has different implications to different people.