From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 223BECF3189 for ; Tue, 1 Oct 2024 23:13:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5F28680042; Tue, 1 Oct 2024 19:13:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E90668002B; Tue, 1 Oct 2024 19:13:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83B4D680042; Tue, 1 Oct 2024 19:13:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 636D268002B for ; Tue, 1 Oct 2024 19:13:22 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2259CA1504 for ; Tue, 1 Oct 2024 23:13:22 +0000 (UTC) X-FDA: 82626586644.14.5E4966D Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf05.hostedemail.com (Postfix) with ESMTP id 0FA8A100003 for ; Tue, 1 Oct 2024 23:13:19 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=vpz66vEI; spf=pass (imf05.hostedemail.com: domain of debug@rivosinc.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727824335; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vF28sAx//tve6z0mOEzHepFQAlUB74FiXmJYm/deJzs=; b=C5p00+S9JqLFm5BDwkusS1nSFVEEasvj8E0y9HvOXNp0Dt/aTaPVmiWmFl0o7/TKfpCdxY DKSKlGjUdOcvLyxEGDYG8EFqzjxAFfthMFpl86MGPZkiVbDHaAWKCfN7ijrSuSMJdJ0Fqe zHX/EMyiQ8ITFuqTL4ugXaPbHs0XBSA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=vpz66vEI; spf=pass (imf05.hostedemail.com: domain of debug@rivosinc.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727824335; a=rsa-sha256; cv=none; b=hiBIYx7MsdbMFMWKIfydwrf4RV/PGHCnpKhTzG3A9yhzSMUtwgnwxrh/3vkplyaZzg/KJK feg8nB8+Xhy0EX6DQJfXuM5HmVOCzqkAxogGh/b6xl9vI9qbTZkaFDPQtREqkmiMkStYoG rIEd2So+43X1BzCoV8IzUCk/hCW0afA= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-20b8be13cb1so28459005ad.1 for ; Tue, 01 Oct 2024 16:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1727824399; x=1728429199; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vF28sAx//tve6z0mOEzHepFQAlUB74FiXmJYm/deJzs=; b=vpz66vEIgYML9qFOk03MVsQKXeCcxqbPkRG7vLSK04IrXqwIIlypoQNe1+pOHUsrLg yg0J+U4B9wLQXNq1fB3kwXXyE7kIeC/3WZ8CRE8dqbFQLa7/0lHf3NOYcjPkN9Af+bkC /Px/zu/2PhREaTyWsT65pj++uEb0jalq1atw1x9XgqyWMyF+bMzZiwCmRhhUbiPu/abo V9XNiR+A8CkQk/20EgJYZqDrp2q32zewJLoox+aNDxRv/0DLm0Wlz6uL0nVeemQvHoPq wfeS3Y0pDKXdh52bUl+GbJWlaF3FHGkPPCe4jjT09fk2CDRPHLK/Z7hxI02vsg2HXnXP 2oxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727824399; x=1728429199; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vF28sAx//tve6z0mOEzHepFQAlUB74FiXmJYm/deJzs=; b=hNyi45o1fIJxtlHYyoatxhHZngZCSsb19xMijHBMXM6BIBqEo1sySebFvNBoKCRSqW R5TP4XAeC36fjQqeFAjX+axPxlt9e/L4kMJ4h7oWmo8nNuMKkcafzfh0zJHa62Ucs6A4 m8fXY3+DTsFuarJkDcoEcFjnBaTSMzoXCETnX2YnNEGllTv864Dwrj6U9XCXU6KRU+LZ fjxJuxDt5JhzSR5yN19ymO4vy/rva8ufa0T1P6AmCuMMPTthegCwSgaahEwkce54VQ4w j6LJm/RG9Ve+VoU/mYtaLEKucN6K3NpqyoyIr4wc+7mbQxYq5r3bMPGZTFWuOWLRVzwK dXMQ== X-Forwarded-Encrypted: i=1; AJvYcCVZzoOWILHmFlmqC0+08hsAp4tUg3MIah5wKyIJz4A6bUq60hXJ/nrraAU9suAiuDgTwCWKN6i/HQ==@kvack.org X-Gm-Message-State: AOJu0YwxCjP2CtMjnPBRgvPHtcHGWecF79dTKm+ruwzVw+ziz10LcA3Z N8QP7hA/U+QCq8Gc9Y5ai8uxjJFzCImAD9FnyUyt4FbuMI+bdGGO9GrLIfPkwZM= X-Google-Smtp-Source: AGHT+IEIrzHYfjGFMSAlwPPGGJUrbwH3BDEgMMmzhiHFcldc7QLYwSfdGVw09IGHWqEtu37pmMpU7g== X-Received: by 2002:a17:903:41c4:b0:20b:a431:8f17 with SMTP id d9443c01a7336-20bc5a887b7mr17332045ad.58.1727824398654; Tue, 01 Oct 2024 16:13:18 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20b37e37225sm74521465ad.197.2024.10.01.16.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 16:13:18 -0700 (PDT) Date: Tue, 1 Oct 2024 16:13:15 -0700 From: Deepak Gupta To: Mark Brown Cc: Catalin Marinas , Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Shuah Khan , "Rick P. Edgecombe" , Ard Biesheuvel , Szabolcs Nagy , Kees Cook , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Florian Weimer , Christian Brauner , Thiago Jung Bauermann , Ross Burton , David Spickett , Yury Khrustalev , Wilco Dijkstra , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v13 04/40] prctl: arch-agnostic prctl for shadow stack Message-ID: References: <20241001-arm64-gcs-v13-0-222b78d87eee@kernel.org> <20241001-arm64-gcs-v13-4-222b78d87eee@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20241001-arm64-gcs-v13-4-222b78d87eee@kernel.org> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 0FA8A100003 X-Stat-Signature: ryhnjoc1p6honndfhk7muprb5qo5bkq1 X-HE-Tag: 1727824399-481087 X-HE-Meta: U2FsdGVkX1/yJz2W5xEZeyPk5K0Nud4LIiovZ5KNO/pSkN5CnBxtf7OcGU+BuF06XF+0gYrso9WaOx1h8wqWOgPve6QbaMHeyR4OXDM9CLgWAS9xZXxbbuWF4GbREW6rtv0u5miCFhkT9DKROSFnbaQRPDpXW41nRT2+omqpF80CE2N5tVGJm/sTtdsJtIhoCLkQnaUaYXTL68gDZNFAKGdF/ayCbvn1nqQZQCDTG9lqrC+8nZdfWdFz47NolSJL3mdWVQ0DeSmDTDDYoibxgsz1hk1luv4Jsv9UyQHaoWrpCtcOWXrnVYw1NlYRmuofXx+g/ScdqwbLXZApiKKHkBpHK2AXMHGco5cLe3AYmiW9Cc9Hcl4NW5B8rvJkAWUky4uXdeihRCAdikvb72a/JGC6RL12+wjPoWYWKi7MCKe2h1x8lULuYl9NuhvrSfXArg7Ue5V9FzU8lqz7i2nSG3NPJWp2N4yBXMqPawETwMlYi8+yXhweYe5SWc2ZdRndmUWUjDH2NKruGMUROqX2+3vBVWaRwmmaP4asi1vaMxorSb2YxUzGSWhG+tmUv7hPaRuS8gRsI7fqt/Tq3/evI15yP8QuTDEb3kRvi/nBm1MYgYYGSWyLrhVYZkhFHuv4AshcRqDvskMdH9C6ExW/KlOt9/AyJ38ibqxY4Rf2WWA0OC6G425nuuECzEO4OwJ5n8zT987wEdtkHui5BSEz4rLQ7yd2O4iUu03MHNId9S5q+vTGrb9ORNrYsbqUlLRiC6R6LMPZ9YW2N+sei3OTPgT/Fi9CjhI6eOWtuDeFToh6JY6KA8FGIDLDq+RTBD/0ACeyikvN/KycftPreCsiEiM3TcuRW3aRPg/hA8Cuk3z8+oSQQSZtZL6bNErRb0KS17ivk3WCHmGZoTzVa2S7l5/vmLN3Qp2nlOcCZz2Nl0V1fHjh3B59Yw/zsBgOKujJM36OfLSGDnsKSgT/HSN geNev6vL yy9LSzbkF3kFKUkmAw0iU2RfN35euNztWaAqGqJovnwj+FR1g1RMwXEWaekeids4KH5tIZUgOdZ58EDQH0vBOvaxC84+3i2EWllOxozFzTgjlPbMR3iP9MCSDalBfZwejCBzIjJtYkA5Ah9A+tVTClShFyH/h1Us4YpE6rpvf1f2WoCGhk4HEYN3f5yDxic8XizZwovDhJIAC3QpRQDmTSvPq4kL02+omsj7MZZMvMH0O7NnYJQzhYqQwAjDIBTOvIQmOEDWNMw/qv2K2FIXmEOFqM2U3STtl2WHOfbmZGxhxo/DPQNk4GgfVh266QCL5G/tE34ivXqIikBc9WIESd+MxtY8e2vIqSH3El3AllzFEZcWIlG5tNRjRIoJiC006gGvmP1EO4senxCAOfEs3fHqtPHn2LQgSDQ6SqeaCsj7nlgdXEeVg6pX11/PLv+y4fetx3qIvR2VdKJGguEvX6kxG4LyEvYugonoBj+S4OFXt9knK9NYP4HvomP14YA74wTYV5OLc41iDqAT2/4wU1qrhXhhRTGvh7hZB/nsriDu+5cXpMVZqFOL+zi97vc4STtX0TJhCR9jKrUnItCmN77EpIDKcj7AccwDWbX7UztIctpHCaVboQWr2VvPX3qmh+U4t X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 01, 2024 at 11:58:43PM +0100, Mark Brown wrote: >Three architectures (x86, aarch64, riscv) have announced support for >shadow stacks with fairly similar functionality. While x86 is using >arch_prctl() to control the functionality neither arm64 nor riscv uses >that interface so this patch adds arch-agnostic prctl() support to >get and set status of shadow stacks and lock the current configuation to >prevent further changes, with support for turning on and off individual >subfeatures so applications can limit their exposure to features that >they do not need. The features are: > > - PR_SHADOW_STACK_ENABLE: Tracking and enforcement of shadow stacks, > including allocation of a shadow stack if one is not already > allocated. > - PR_SHADOW_STACK_WRITE: Writes to specific addresses in the shadow > stack. > - PR_SHADOW_STACK_PUSH: Push additional values onto the shadow stack. > >These features are expected to be inherited by new threads and cleared >on exec(), unknown features should be rejected for enable but accepted >for locking (in order to allow for future proofing). > >This is based on a patch originally written by Deepak Gupta but modified >fairly heavily, support for indirect landing pads is removed, additional >modes added and the locking interface reworked. The set status prctl() >is also reworked to just set flags, if setting/reading the shadow stack >pointer is required this could be a separate prctl. > >Reviewed-by: Thiago Jung Bauermann >Reviewed-by: Catalin Marinas >Acked-by: Yury Khrustalev >Signed-off-by: Mark Brown >--- > include/linux/mm.h | 4 ++++ > include/uapi/linux/prctl.h | 22 ++++++++++++++++++++++ > kernel/sys.c | 30 ++++++++++++++++++++++++++++++ > 3 files changed, 56 insertions(+) Reviewed-by: Deepak Gupta >